Commit Graph

4992 Commits

Author SHA1 Message Date
Todd Kennedy daf869cf60 Use an Account object to create a mail sender
Instead of boiling the account down to an unusable URI, just pass along
the Account object.

Change-Id: Ida408912de29734c8f4ed9cdf09a4d633dd03002
2011-04-20 11:14:02 -07:00
Todd Kennedy 031527a03e Merge "Use Account instead of URI to create transports" 2011-04-20 09:16:28 -07:00
Todd Kennedy a50fc99b0c Use Account instead of URI to create transports
There's no need to create a URI just to rip in appart again. Additionally, to
support additional changes (i.e. to use Mailbox instead of Folder in the
MessageController), we need to store the actual Account.

NOTE -- This change only affects IMAP and POP3. SMTP will come in a follow-on CL

Change-Id: I400036a17271c99272fd9c603547dcd713b50b9d
2011-04-20 08:31:24 -07:00
Ben Komalo 8f84cae3c3 Merge "Re-work the layout computation for MessageListItem" 2011-04-19 12:19:42 -07:00
Ben Komalo 8b2109f047 Re-work the layout computation for MessageListItem
This now uses an XML layout that gets inflated and computed after a
layout pass. The drawing simply uses the coordinates stored after the
layout.

This makes it a lot easier to maintain the different views and allows us
to simply provide different XML files for different modes/views, isntead
of trying to hand tweak Java layout code.

Some TODOs - clean up the "paints" and optimize the layout/drawing
computation

Change-Id: I784919f726bd4d80aba8744a8f047fcfe79ad93a
2011-04-19 11:53:30 -07:00
Todd Kennedy ba7652cda0 Make ImapFolder a top-level class
No code changes; just moving the class

Change-Id: I4e4544d99d52dde85b96c99ef45da3a96e7d3d48
2011-04-19 09:31:43 -07:00
Ben Komalo 058eb3984f Merge "Fixup auto advance policy handling." 2011-04-18 10:46:21 -07:00
Ben Komalo 36990d46cf Fixup auto advance policy handling.
The phone code has gone stale and ignored auto advance policies - this
fixes it, though that code is likely to get merged anyways.

Makes it so that auto-advancing to the end of the list pops back out to
the message list

Bug: 4302999
Change-Id: I609747c0a19672b8aa56d2c0ab57533823899e47
2011-04-18 09:48:58 -07:00
Eric Fischer c61d9b4ff2 am c23f695d: (-s ours) am ce5828ed: am 11574724: (-s ours) Import revised translations. DO NOT MERGE
* commit 'c23f695de53aadbb3dc58987d632dab3647febed':
  Import revised translations.  DO NOT MERGE
2011-04-18 03:28:47 -07:00
Eric Fischer c23f695de5 am ce5828ed: am 11574724: (-s ours) Import revised translations. DO NOT MERGE
* commit 'ce5828ed38212df654352ae8532dcad42d172de3':
  Import revised translations.  DO NOT MERGE
2011-04-18 03:18:16 -07:00
Ben Komalo 238f837844 Merge "Kill old message_list_item." 2011-04-16 18:36:24 -07:00
Ben Komalo 1fdfdc51a1 Kill old message_list_item.
E-mail uses a custom view now and this XML layout has bitrotted.

Change-Id: I8e358d941bb56174cd4f8fcb74a106107363e557
2011-04-15 15:15:26 -07:00
Eric Fischer b99d44c112 Merge "Import revised translations." 2011-04-15 15:00:39 -07:00
Eric Fischer deb6d39394 Import revised translations.
Change-Id: I84bb8da3f1e442b68124a500fa513b0cb1048912
2011-04-15 14:40:03 -07:00
Todd Kennedy cfbf1eb66d Clean up drag-and-drop
Basic refactoring of the drag-and-drop logic to make it a bit cleaner

Change-Id: I0e59074710be00bd285f637e92f554c8ee47fabf
2011-04-15 14:33:25 -07:00
Eric Fischer ce5828ed38 am 11574724: (-s ours) Import revised translations. DO NOT MERGE
* commit '11574724466d0a363b9cd8a99aa4e2f6841aa4a2':
  Import revised translations.  DO NOT MERGE
2011-04-15 12:44:30 -07:00
Todd Kennedy 49786fbe2a Remove extra padding from expanded icon
Change-Id: I1e351dc0978a5e2d576a7c0c84625d66b3ebbbbc
2011-04-15 09:20:02 -07:00
Todd Kennedy d1b1404d76 Merge "Implement drag-n-drop with nested folders" 2011-04-15 08:57:26 -07:00
Todd Kennedy 6c3cd4e247 Implement drag-n-drop with nested folders
We can now drill down into nested folders during drag-n-drop. Simply hover over
a collapsed folder for 750ms and it will auto-expand.

Change-Id: Ia9b42dd87e19c2ebdf8675c761cb1453bb26d158
2011-04-14 16:23:20 -07:00
Ben Komalo 8a05da7c8c Remove uneeded layer of parcelling.
ListStateSaver did nothing more than hold a Parcelable, and was a
Parcelable itself. The abstraction may have been useful at some point,
but that time seems to have passed.

Change-Id: I2f1f45828782ab44aa8935aa50b825e07845a2a5
2011-04-14 15:30:54 -07:00
Makoto Onuki edeca22ac3 Merge "Make two pane layout (more or less) useable on phone" 2011-04-14 14:26:04 -07:00
Makoto Onuki b32704dae5 Make two pane layout (more or less) useable on phone
Now the two pane activity survives longer on the phone, as opposed to
crash immediately.
(It still crashes when you open the message view.)

I'd like to submit this because:
- It'll make my experiment easier
- It wouldn't do any harm to the tablet UI.

Change-Id: Id716a42c63026cf09b30ff6a63e0e58311aa53ed
2011-04-14 14:25:05 -07:00
Eric Fischer 1157472446 Import revised translations. DO NOT MERGE
Change-Id: Ie71335ec0b6f8b728afdd5834b242406e816c22f
2011-04-14 14:02:55 -07:00
Ben Komalo 28b3fec5c1 Include guava in Email.
- adds a compile time dependency to the guava library
- changes to use @VisibleForTesting in places to ensure it works

Change-Id: I2c5c4f9861234fec3613da011185e5c11f228466
2011-04-14 13:49:01 -07:00
Todd Kennedy 8faa4e9cfa Merge "Fix layout of chip in combined view" 2011-04-14 10:25:12 -07:00
Todd Kennedy 9eb697c657 Fix layout of chip in combined view
the chip was part of the sub-layout when it should not have been.

Change-Id: Ie3a547bdf6d6ae4a3b458eaf4c30b57463b8ec34
2011-04-14 10:19:13 -07:00
Todd Kennedy 7219fccc42 Always display subfolder icon in the same view
We were handling the subfolder icon strangely. Sometimes it was shown in the
folder_icon view and sometimes in the folder_expanded_icon view. Now the
folder_icon view is used exclusively for system folders (such as inbox, etc...)
and folder_expanded_icon is always used for the expanded/collapsed icon.

Change-Id: Ifff9a44cc792497a469c2408337dafd431f6dfc3
2011-04-14 10:12:18 -07:00
Ben Komalo 5b84c8d9d0 Merge "Apply auto-advance policy when doing a batch op." 2011-04-13 18:04:25 -07:00
Ben Komalo 52618afa81 Apply auto-advance policy when doing a batch op.
Batch operations that occur when the current message selection is
contained within the affected messages will now force the selection to
advance according to the auto advance policy to the next unselected
conversation.

Bug: 3409809
Bug: 3405864
Change-Id: Ibe75f32b9263ef6f3fb2314a07e63980f437f988
2011-04-13 18:03:48 -07:00
Ben Komalo 2071bde957 Merge "Minor fix to error dialog formatting." 2011-04-13 16:13:54 -07:00
Ben Komalo 5a2d7da136 Minor fix to error dialog formatting.
Bug: 3515558
Change-Id: Id4d88379dc68c114338fdd2d4d437a2defb94ba4
2011-04-13 16:07:50 -07:00
Todd Kennedy a8ba5e76dc Merge "only allow navigating to mailboxes w/ children" 2011-04-13 14:56:16 -07:00
Todd Kennedy f7036b7379 only allow navigating to mailboxes w/ children
If a mailbox doesn't have any sub-mailboxes, only allow selecting them to view
any contained messages. Do not update the mailbox list.

Change-Id: I6f469bf20a57dc440885402084c21ff184f13dff
2011-04-13 14:35:03 -07:00
Ben Komalo ead17de8f2 Merge "Remove a layer of public methods that weren't used" 2011-04-13 13:07:47 -07:00
Ben Komalo 6336a5231e Remove a layer of public methods that weren't used
Change-Id: Iba88634db2a687ce72f6875e0b499f79c219ca8f
2011-04-13 13:03:23 -07:00
Marc Blank 4bf590d400 Merge "Create constant for unknown sync window (0, i.e. uninitialized)" 2011-04-13 11:54:28 -07:00
Ben Komalo 1d1b7a070a Merge "Add signature when starting from external intents." 2011-04-13 10:22:51 -07:00
Todd Kennedy ce99dd8cd1 Add comment to package-private members & methods
Change-Id: I9bb641d44253635f8dacc5dfecde55eac8d72c59
2011-04-13 09:52:42 -07:00
Ben Komalo 0fb68c8f0c Add signature when starting from external intents.
Also update some of the tests.

Bug: 3122070
Change-Id: Ia0e4620f54279dc53ca1c4484fec6508c411b418
2011-04-12 18:10:05 -07:00
Todd Kennedy 2b82c3f0a3 Add columns to cursor to allow for proper layout
The layout requires different indentation. Although the exact layout may
change, we will likely always need to differentiate between the different
mailbox types.

Change-Id: Ia2ff84b552873f92fa45563b2dc0868c29bec3e3
2011-04-12 15:09:51 -07:00
Todd Kennedy 57dc03acec Merge "Add current nested folder to list" 2011-04-12 15:08:00 -07:00
Marc Blank 38eb3b3a94 Create constant for unknown sync window (0, i.e. uninitialized)
Change-Id: I85410162893e76748f293f48fd12571eeaf4b620
2011-04-12 14:19:58 -07:00
Makoto Onuki 0efbee2bd0 Merge "Fix bug that prevents from accepting 2 invites in a row." 2011-04-12 13:56:59 -07:00
Makoto Onuki 5dceaa5b5e Fix bug that prevents from accepting 2 invites in a row.
mPreviousMeetingResponse is tied to the current response state, so it
should be reset too when we clear the response checkboxes.

Bug 4132763

Change-Id: If816706f47f8500441330882fb4f372b31465ff5
2011-04-12 11:08:16 -07:00
Todd Kennedy 7f139f14b9 Add current nested folder to list
When selecting a nested folder, the currently selected folder should be listed
along with "All Folders" and sub-folders

Change-Id: I7c6f726a0355a13d3e7b59aa4707bd92473283b4
2011-04-12 09:47:56 -07:00
Ben Komalo 7dc1e86d91 Less aggressive selection change in msg content.
All focus changes to the message body content was pushing the selection
to the end, which is wrong if state restoration happens, and is just
non-standard behavior if the user explicitly taps on a particular spot
on the text view. Make this slightly less aggressive.

Misc other changes in compose view.

Bug: 3076256
Change-Id: I9edb9c3c4edb5ddec12207f4136f3ca73cabf89d
2011-04-12 09:23:40 -07:00
Ben Komalo 2577842269 Misc fixes and dead code removal.
Change-Id: I48b2fa5f7bf619197d882c71e8b174d31d130e26
2011-04-11 14:01:01 -07:00
Marc Blank cd5da3c445 Remember to clear query in MessagesAdapter if we're not searching
Change-Id: I3b16f080c66f6ce025e41a7c459aa3cb94dbecd0
2011-04-08 14:01:35 -07:00
Marc Blank 18d3b3de1e Merge "Improve temporary mailbox settings UI" 2011-04-07 20:04:18 -07:00
Marc Blank f047c7cfd1 Improve temporary mailbox settings UI
* Start dialogs with current setting selected
* Add Cancel/OK buttons

Change-Id: Ia3d28eec558a8af8d3826b70cb313b68a5efc533
2011-04-07 20:03:23 -07:00