Commit Graph

3726 Commits

Author SHA1 Message Date
Andy Stadler
9ce244b2e3 Hide vibrate notification option on no-vibrate devices
* Check for existence of vibrator, hide option if appropriate
* Notifications with vibration are still OK, they are just ignored
* Minor cleanups & renaming

Bug: 2988758
Change-Id: Ia1fd259f57d33a75a54cf1016f66a1c072aba579
2010-11-04 21:13:45 -07:00
Marc Blank
bad09c18d9 Correct drag & drop mechanics; implement multiple selection
* This CL brings drag&drop move in line with the current document
  describing its functionality in the Email app

Bug: 3135124

TODO: Assets and proper creation of the drag thumbnail based on
  those assets
TODO: Review long-press behavior re: press on subject vs sender

Change-Id: I6e1ee1a1f055feb041a0338f2f5c775a88620595
2010-11-04 17:13:55 -07:00
Makoto Onuki
138abe82e6 Make "Send all messages" a menu option
- Now it's a menu command rather than a button.
- Also string changed from "Send outgoing messages".

Bug 3166218

Change-Id: I82f6188365f9f6bc5a6d40fb23d774eebe181445
2010-11-04 16:53:18 -07:00
Makoto Onuki
bf678771b7 UI change: MassageCompose
Basic changes for the new UI.  At this point we don't know what the new phone
UI will look like, so I didn't bother trying to preserve the old behavior on
the phone UI.  The changes will affect both the phone UI and the tablet UI.

- Send, Save Draft, and Discard are now action bar commands.
- Add CC/BCC and Add Attachment are now regular buttons.
- Activity title changed to "Compose"
- Some string changes per new wireframe

Further changes (actual layout changes for the latest wireframe) should be made
only for the xlarge layout.

Change-Id: I68c9c37dfdca6736b1e35053e7f196800fcfce2e
2010-11-04 15:22:25 -07:00
Marc Blank
c81bef6720 Drag & Drop "move to folder"
* Drag & Drop "move to folder" preliminary implementation
* Use "drag handle" button to initiate drag
* Use the message list item itself as the drag thumbnail for
  one item; "Move N messages" for multiple (not implemented)
* Disable MailboxList update during drag
* Use ListView itself as drag/drop target

Bug: 3138004
Change-Id: I9243e4f583cf91caa1b9dd04fd64d52e8b28fa30
2010-11-04 08:45:24 -07:00
Makoto Onuki
e4f8111001 Merge "Fix & clean up intent handling" 2010-11-03 16:53:02 -07:00
Marc Blank
5ade775c8f Merge "Send sync start/finish callbacks in pairs" 2010-11-03 16:01:10 -07:00
Andrew Stadler
997a022c9b Enable zooming in MessageView
Bug: 2282390
Change-Id: Ie5be3c4adb8cc3bef5ccf4fccbfefe8a40872b17
2010-11-03 15:31:08 -07:00
Marc Blank
12b398fac3 Send sync start/finish callbacks in pairs
Bug: 3143544
Change-Id: Ifb8c3c4c12e32df6a7d058446a0279c26048e0f3
2010-11-03 11:18:07 -07:00
Andy Stadler
ba4e72a947 Cleanup various IMAP/POP manual account setup defaults
These defaults affect manual setup only.  There should be no changes
observed in automatic setup, and no changes observed in EAS setup.

* user $email instead of $user as default login
* guess "imap." or "pop3." for server name
* propagate the incoming server name to the outgoing server name, and
  replace "imap.", "pop3." or "pop." with "smtp."

Also, fixed a couple of leftover places where we were trimming
passwords (and should not be, since some people insist on having
spaces in their passwords.)

Bug: 2978634
Change-Id: I9b0e345aa9550b5e1cc29aaa22109f03da61af20
2010-11-03 09:31:45 -07:00
Makoto Onuki
7126e5ae53 Fix & clean up intent handling
- Make sure an account shortcut really opens the account by
  adding the FLAG_ACTIVITY_CLEAR_TOP flag to shortcuts

  * Shortcuts have to be re-created for this fix to take effect.

- Remove Welcome.createOpenCombinedInbox/OutboxIntent, which don't work
  with the new combined view.

  * createOpenCombinedInboxIntent() is not used already
  * createOpenCombinedOutboxIntent() is used, but is not final UI, so
    removing it is okay.

- Fix MessageListXL.actionOpenMailbox -- now it really uses the passed
  mailbox ID.

Bug 3144066

Change-Id: I2ee3f84c62a135351c10266c7ca6d5178c3a0ca2
2010-11-02 18:18:43 -07:00
Andrew Stadler
c50f912676 Inhibit "send" when user is a monkey.
While monkey is active, any clicks on "send" will be mapped to "save".
Drafts will pile up, but nothing will get out.

Bug: 2799956
Change-Id: I300d50001b43c8b61062143f9a0ac914aa2deaca
2010-11-02 16:14:19 -07:00
Andrew Stadler
ba0b1bbc8d Implement text zoom for Message View
* Add preference for default text size
* Move saveSettings logic into onPreferenceChange handler
* Per user tests, default setting is large (not "normal") for XL devices.
* Use setting in MessageView's WebView

TODO: Investigate zooming header (to/from/subject/etc) as well.

Bug: 2282390
Change-Id: If32ed3626244b046941a461f974b3dbdb535f592
2010-11-02 14:58:24 -07:00
Marc Blank
278cb8e3d5 Merge "Support EAS in providers.xml files" 2010-11-01 21:14:46 -07:00
Makoto Onuki
3aca79fbec Switch to the Theme.Holo.Light.Extended theme.
Change-Id: Ib620285c6445f7b7500217cfb354ed1de280d861
2010-11-01 17:19:38 -07:00
Andrew Stadler
cd09545b87 Provide runtime switch for GL acceleration
* new checkbox in debug fragment
* saved value in prefs so it's sticky
* each Activity calls a helper to enable/disable per that flag

Change-Id: I1af1ae9f401bc746cc97da00dfb0e06407b79d46
2010-11-01 16:16:27 -07:00
Makoto Onuki
da0d12ca36 Merge "Add null check to investigate an NPE in restoreMessageWithId." 2010-11-01 15:40:26 -07:00
Makoto Onuki
d281726706 Add null check to investigate an NPE in restoreMessageWithId.
We're getting an NPE in restoreMessageWithId(EmailContent.java:670)
called from MessageFileViewFragment.openMessageSync().

However, there're only two things that can be null in this line,
context and context.getContentResolver(), and either one really
can't be null.  Add explicit null checks to investigate what's going
on.

Bug 3134403

Change-Id: I463b039b6afeda32729f7e6a93edfdb9abf12093
2010-11-01 15:29:11 -07:00
Marc Blank
26e01b4ad2 Merge "Delay appearance of "stop" button when loading attachments" 2010-11-01 14:02:01 -07:00
Marc Blank
fdc41d4ffc Delay appearance of "stop" button when loading attachments
Bug: 3082804
Change-Id: Ib8b0fcec36a7303b2094bd0e49645d11aa2ff2db
2010-11-01 13:48:53 -07:00
Makoto Onuki
bbe25adfc8 Fix crashes related to readParcelable
We need to pass the actual class loader.  Passing null makes it use
the boot class loader, which can't find our classes.

Bug 3073304

Change-Id: I1c72c1d352cfc0a730aba1d83eb048a8cfa95b67
2010-11-01 13:47:53 -07:00
Makoto Onuki
730cc6724a Add "Combined view".
- Don't show combined mailboxes with regular mailboxes in the mailbox list.
- Add "Combined view" to the account selector instead.
- "Combined view" has all the combined mailboxes and accounts.
- Renambed these combined boxes.  (e.g. "Combined inbox" -> "Inbox")
- Regular account view still has "Starred" mailbox, but it's actually
  "combined" and not per-account.
- Re-order special mailboxes per latest wireframe.

Bug 3138004

Change-Id: I4c5860c6774b10c55ba0ca599373e51105432cf8
2010-11-01 11:51:51 -07:00
Makoto Onuki
7c09f04810 Merge "Turn on ActionBar on the 1-pane message list" 2010-11-01 10:56:46 -07:00
Brad Fitzpatrick
f0ce3ea911 Merge "SharedPreferences commit -> apply" 2010-11-01 10:32:09 -07:00
Brad Fitzpatrick
bd29c30903 SharedPreferences commit -> apply
Change-Id: Icdca00268a8b5ea274c91366867172ee7e3841d4
2010-11-01 08:51:26 -07:00
Marc Blank
4afdd19e20 Support EAS in providers.xml files
Bug: 2962123

Change-Id: I661c52afcf36e337e29bb10fd878196a3b0147ae
2010-10-29 19:03:44 -07:00
Marc Blank
a7fbf44511 Merge "Harden AttachmentDownloadService" 2010-10-29 16:29:13 -07:00
Andrew Stadler
be2e345af9 am 418eb07a: (-s ours) am 7d7ffaf6: am 9031e67b: (-s ours) Fix remote wipe with mobile sync server DO NOT MERGE
* commit '418eb07a87695e19fd10298a801f2c7a9f5e1083':
  Fix remote wipe with mobile sync server DO NOT MERGE
2010-10-29 16:25:36 -07:00
Andrew Stadler
97722dab78 am bf567c81: (-s ours) am aae1f83a: am 89a799c8: (-s ours) DO NOT MERGE: Don\'t disable account box if sync freq -> "Never"
* commit 'bf567c81c11c9677ab7412a7c7890812ae2c4204':
  DO NOT MERGE: Don't disable account box if sync freq -> "Never"
2010-10-29 16:23:43 -07:00
Andrew Stadler
418eb07a87 am 7d7ffaf6: am 9031e67b: (-s ours) Fix remote wipe with mobile sync server DO NOT MERGE
* commit '7d7ffaf6a36e1ddc6c91ed3dbf499c271b79965f':
  Fix remote wipe with mobile sync server DO NOT MERGE
2010-10-29 16:23:35 -07:00
Andrew Stadler
7d7ffaf6a3 am 9031e67b: (-s ours) Fix remote wipe with mobile sync server DO NOT MERGE
* commit '9031e67b7e2ec00033a45155ff644fccb33e6bc7':
  Fix remote wipe with mobile sync server DO NOT MERGE
2010-10-29 16:22:11 -07:00
Andrew Stadler
bf567c81c1 am aae1f83a: am 89a799c8: (-s ours) DO NOT MERGE: Don\'t disable account box if sync freq -> "Never"
* commit 'aae1f83ad10aef8ac6379c10ee88c34268a33817':
  DO NOT MERGE: Don't disable account box if sync freq -> "Never"
2010-10-29 16:21:39 -07:00
Andrew Stadler
aae1f83ad1 am 89a799c8: (-s ours) DO NOT MERGE: Don\'t disable account box if sync freq -> "Never"
* commit '89a799c8d4e9b44c2cf5ba6e72f17e1bb652c42b':
  DO NOT MERGE: Don't disable account box if sync freq -> "Never"
2010-10-29 16:19:14 -07:00
Andrew Stadler
9031e67b7e Fix remote wipe with mobile sync server DO NOT MERGE
* It appears as if our running multiple sync threads can confuse the
  mobile sync server during a remote wipe (the server expects the next
  client response to be an acknowledgment, whereas it might well be
  a command or response from a different thread)
* To avoid this, we first put the account on security hold and then
  shut down all other sync threads for the account
* After this, we send the acknowledgment and the remote wipe proceeds
  normally.
* NOTE: It's possible that, due to the vagaries of multithreaded
  operation, one of the other syncing threads could still send a non-
  acknowledgment response to the server before our provisioning thread
  gets a chance to send its acknowledgment.  However, since the other
  syncing threads will terminate (and not restart, because of the hold),
  the provision/remote wipe/ack sequence will work on the subsequent
  attempt

Bug: 2844888
Backport From: Ib4ffbbc67b681e69176b6c1d5515fa80c7d1e121
Backport From: Ie9e944bd39f331c2ddc0f0ba303a3d5684f6f033

Change-Id: Ie57f13a5ca2149961a48b99afaebb812f1cbc88e
2010-10-29 16:18:44 -07:00
Andrew Stadler
eae2a6806b am b7a7931d: (-s ours) am 90e22765: am 3ddfdb8e: (-s ours) Merge "Give email its own version# scheme. DO NOT MERGE" into froyo
* commit 'b7a7931db02bed498147e47df940361e177213f3':
  Give email its own version# scheme.  DO NOT MERGE
2010-10-29 16:18:33 -07:00
Andrew Stadler
89a799c8d4 DO NOT MERGE: Don't disable account box if sync freq -> "Never"
Original Change-Id: Iec214b0fed093ff39dc70d5d821577bcf15f00ed
Bug: 2905667

Change-Id: Iee182596d8c217d6bd78371fcf6fdc4dbfcd04a4
2010-10-29 16:16:40 -07:00
Andrew Stadler
77e005f62f am 53881237: (-s ours) am ac6e846c: am bafd3d87: (-s ours) Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
* commit '53881237b2ed37df133c4e11d173b5f703e2aa30':
  Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
2010-10-29 16:16:31 -07:00
Andrew Stadler
b7a7931db0 am 90e22765: am 3ddfdb8e: (-s ours) Merge "Give email its own version# scheme. DO NOT MERGE" into froyo
* commit '90e227650c58407176ea0cab7e315ebb294a3bf7':
  Give email its own version# scheme.  DO NOT MERGE
2010-10-29 16:16:23 -07:00
Andrew Stadler
53881237b2 am ac6e846c: am bafd3d87: (-s ours) Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
* commit 'ac6e846c10464b48deb85f320dc8f9b02e76d3a6':
  Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
2010-10-29 16:14:29 -07:00
Andrew Stadler
90e227650c am 3ddfdb8e: (-s ours) Merge "Give email its own version# scheme. DO NOT MERGE" into froyo
* commit '3ddfdb8e075f57184954a2000e71f70922ab7bd9':
  Give email its own version# scheme.  DO NOT MERGE
2010-10-29 16:14:11 -07:00
Andrew Stadler
ac6e846c10 am bafd3d87: (-s ours) Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
* commit 'bafd3d871530335ef47b7b33b984b6bff0df91fa':
  Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
2010-10-29 16:12:19 -07:00
Andrew Stadler
3ddfdb8e07 Merge "Give email its own version# scheme. DO NOT MERGE" into froyo 2010-10-29 16:11:12 -07:00
Andrew Stadler
7ecf6d5ca8 Give email its own version# scheme. DO NOT MERGE
Backport From: I258ffcf47d243417edadad44714f74247c78b366

Change-Id: I66dcce11bfaa5bec6d2936aafeb4fde43eafb2c0
2010-10-29 14:17:49 -07:00
Andrew Stadler
bafd3d8715 Increase EAS command timeout from 20 to 30 seconds DO NOT MERGE
Original Change-Id: Ic58fea147d179ffd18f28a8ce5d290a1b37302ce
Bug: 3027271

Change-Id: I86cd297f3273b20bd21fcca534eb58b39f904965
2010-10-29 14:07:50 -07:00
Andrew Stadler
34e6205d44 Simplify setupSyncReportsLocked
* Remove three unneeded DB lookups
* Eliminate race condition that could cause NPE
* Remove protocol field from report, it wasn't needed (we already
  set the sync interval to -1 which has the same effect.)

Note, the problems were introduced unintentionally, due to the merged
result of three different CL's:
 I168b3db49bf422b33d05f25cfff1c7be15150c2b
 I74a3dae21d9ec16f9903bdf2a1c28092ae89cc50
 I53e935f8bf08e0bda6e2cd483229a6377ed39d74

Bug: 3139451
Change-Id: Iadbed267f88808aeace0a2f011e4acf79074af70
2010-10-29 11:38:28 -07:00
Marc Blank
828ad13c15 Merge "Ensure that finishBroadcast is called in broadcastCallbacks" 2010-10-29 08:03:32 -07:00
Marc Blank
b961c78ff4 Harden AttachmentDownloadService
* It's possible that endDownload will be called for a request
  that has been dequeued.
* Harden endDownload against this eventuality, so that we clean
  up properly without throwing exceptions

Bug: 3142618
Change-Id: If61136ed1ea972248fc5f9388beaaf84754f9931
2010-10-28 17:21:28 -07:00
Marc Blank
4f1480369c Ensure that finishBroadcast is called in broadcastCallbacks
* An unexpected (runtime) exception during a callback left the
  broadcast unfinished, leading to a fatal exception
* Ensure that we always call finishBroadcast()
* Catch RuntimeException in a broadcast call, so that other calls
  can be executed
* Addresses one of two issues in the referenced bug

Bug: 3142618
Change-Id: I77166bf927560681a2b189906cd687a6e3585223
2010-10-28 17:00:35 -07:00
Eric Fischer
02f5a84ee3 Import revised translations.
Change-Id: I21bfef5a27492a444b6f4cbe16e5e07b6fddd51b
2010-10-28 14:09:13 -07:00
Eric Fischer
07f06fd9ad Merge "Fix string formatting mistake that put "new" outside its <item /> block." 2010-10-28 10:09:42 -07:00