Commit Graph

6195 Commits

Author SHA1 Message Date
Ben Komalo b7d137bfb6 Refresh account list in settings.
Since account deletion is async, the deleted account still shows up for
a split second. We can do something smarter about this later, but not
for ICS, and not worth it for such a rare event

Bug: 5116203
Change-Id: I82cced09b7a098e4a1a960f2d8ad75c1979b0649
2011-08-30 16:25:42 -07:00
Ben Komalo f97ec4d1e8 Hide search icon in search mode.
This is a kludge - the real solution is to use the proper action modes
in the framework. That's too large to do this late.

Bug: 5232787
Change-Id: I76b68b250c384bdabf51e8831f833afd65c0c73b
2011-08-30 14:57:21 -07:00
Ben Komalo 8466f79a06 Asset drop.
- this syncs up the UX repo with the developer repo so that the assets
now match. We should be able to do wholesale drops/diffs from now on.
- lots of changes to widget so that it is (mostly) up to spec now, and
matches the preview

Bug: 5225385
Bug: 5205578
Bug: 4320895
Change-Id: I8ccbadcfc17cdb406599497edc91165809f55d68
2011-08-30 12:57:38 -07:00
Marc Blank 3170153d16 Merge "Throw RuntimeExceptions when PolicyService calls fail" 2011-08-29 16:21:42 -07:00
Marc Blank c28fdfeaad Throw RuntimeExceptions when PolicyService calls fail
* Rather than returning false, which can cause unexpected
  results, e.g. locking out an account until reboot
* Partial fix for the referenced bug (there might be other
  causes)

Bug: 5221119
Change-Id: I5b47093a3411deb6995624887197297323db0d2d
2011-08-29 16:18:50 -07:00
Marc Blank b946263f45 Merge "Password history changes do NOT require user intervention" 2011-08-29 16:09:51 -07:00
Mindy Pereira 149e3ed9bd Merge "fix height of compose view fields" 2011-08-29 09:38:49 -07:00
Mindy Pereira cc02d435b2 fix height of compose view fields
fixes bug:5223556 heights of compose view text fields are too tall on phone/ tablet

Change-Id: I1bbf570a66a424cffcabcae6cfdc2b6ca05be4b7
2011-08-29 08:45:47 -07:00
Marc Blank e86d8af163 Password history changes do NOT require user intervention
* A change in history requirement is not intended to force a new
  password immediately; we just tell the DPM what the new
  requirement is...
* This is one cause of the below-referenced bug

Bug: 5221119
Change-Id: I890b42d4eab4fbd9d34665fbea138f179d5d3215
2011-08-28 16:34:28 -07:00
Marc Blank 9bcdd58a09 Merge "Be careful before setting account's delete policy" 2011-08-26 18:43:34 -07:00
Nick Pelly 1f1ead8d76 Merge "Update for NDEF push API change." 2011-08-26 17:31:57 -07:00
Marc Blank 81a5ba47c6 Be careful before setting account's delete policy
* We were using the getSelectedItem() from the deletion spinner to
  set the account's deletion policy, even if that spinner was
  invisible (which it would be for IMAP).
* The result of this is indeterminate; sigh
* The fix is to make sure the spinner is visible before using its
  value

Bug: 5216422
Change-Id: I7e44b5e8127f5277693f7e962899e8642be55239
2011-08-26 17:14:08 -07:00
Eric Fischer ad0431962a Import revised translations.
Change-Id: I5075133c45e2a393ea2f3429a3282b50b54530f9
2011-08-26 14:55:31 -07:00
Nick Pelly ccb247cf2d Update for NDEF push API change.
Change-Id: I2a51c8c39cd23f90bc35133b2f50b01a82fe1ce4
2011-08-26 10:34:06 -07:00
Ben Komalo 1eb80b23fb New waiting for sync layout.
Bug: 5161231
Change-Id: I7b547982c923067e32154b38f61eea0a3be10553
2011-08-25 12:53:38 -07:00
Ben Komalo b8dd117002 Remove needless clearView()
- this is leftover from a time where we re-used a single WebView for
multiple messages. The current architecture does not rely on that, so
the clearView() is actually not useful. Worse - it's causing issues
because the operation in the WebView is asynchronous, so a clearView and
a load of the content in quick succession causes a race condition,
causing items not to load

Bug: 5205296
Change-Id: I5ee6697bdf53a033ba1c7f21170820259bf830d1
2011-08-24 18:30:20 -07:00
Marc Blank d80e7565dd Merge "Restore return statement erroneously deleted earlier" 2011-08-24 17:26:59 -07:00
Marc Blank 185fd5b3b8 Restore return statement erroneously deleted earlier
* Screwed up in I1f6e31bfd2e7c32bdd7886e54b02fd4640a96e6f

Bug: 5205488
Bug: 5203883
Change-Id: I619135bd5dd8359b4b0573316482356a9b517865
2011-08-24 17:14:07 -07:00
Ben Komalo 5a0dd9a292 Merge "Update asset for "always show" checkmark" 2011-08-24 13:38:41 -07:00
Ben Komalo 781fa387b0 Update asset for "always show" checkmark
Bug: 5184494
Change-Id: I6bae14002d1bfaf661da95ca2b96a0af03a449cc
2011-08-24 12:42:29 -07:00
Ben Komalo 3c97a91b37 Swap read/unread state icons.
Bug: 5204621
Change-Id: I928601135cec72496d69526343dcccd80904fea5
2011-08-24 12:32:23 -07:00
Ben Komalo 32bed4bb8e Fix unit tests.
- make attachment download service injectable
- fix assertions for account manager account checks
- update message compose ID's so they're consistent on tablet/phone

Bug: 5198343
Change-Id: I9976f5b9e5590dd61fb0a62937d3f9203fefe236
2011-08-24 10:24:42 -07:00
Ben Komalo 44cbb82756 New icon drop.
- minor changes to some icons (can't see a difference in some of the
cases?), larger changes to others (e.g. mark unread)
- xhdpi assets for a bunch that were missing

Change-Id: Id71d22aa50440cf6c83e4244bb807e3d237949c6
2011-08-23 10:37:16 -07:00
Ben Komalo b1a4f9d562 Merge "Slight reordering and add settings to compose menu" 2011-08-22 15:44:58 -07:00
Ben Komalo d7f5d0f976 Merge "CAB item reorderings for phone/tablet" 2011-08-22 15:26:04 -07:00
Ben Komalo 4520d35e7c Slight reordering and add settings to compose menu
Bug: 5189476
Change-Id: I91fc0a718859fb55c79157236268dd6976ac0427
2011-08-22 15:21:14 -07:00
Ben Komalo 297f2c67a8 CAB item reorderings for phone/tablet
Bug: 5191624
Change-Id: I3ad3d86d12bb9b27eedca91b2e9d8008e4e04c0c
2011-08-22 15:08:12 -07:00
Ben Komalo c341ddfe94 Reorder menu buttons for tablet
Bug: 5124234
Change-Id: I345f16707c8824f7d8de56c2e94299942dfdf802
2011-08-22 15:05:33 -07:00
Ben Komalo c2b829eb1a Merge "New list background assets" 2011-08-22 14:13:26 -07:00
Eric Fischer 77e43a50aa Merge "Import revised translations." 2011-08-22 12:10:01 -07:00
Eric Fischer 7a78838e94 Import revised translations.
Change-Id: I6b9b20ae1daa034ce072ce1456894861c82e37fd
2011-08-22 11:14:16 -07:00
Marc Blank ebbbbc45ce Merge "Fix dont-allow-camera in Email DPM" 2011-08-22 09:36:27 -07:00
Marc Blank ce582527bb Fix dont-allow-camera in Email DPM
* We weren't checking for it in determining whether our policies
  were active; because of this, we never actually SET the policy
  in the DPM

Bug: 5193399
Change-Id: I276901be21be681f66891f5374ec58cf1ea7b4be
2011-08-21 21:06:54 -07:00
Marc Blank 1aba472486 Remove unneeded logging from EmailProvider
Change-Id: I229c3044566b6067efb7a8a06c10f41dbea3ad5a
2011-08-19 16:56:29 -07:00
Ben Komalo e8df7f6e63 New list background assets
Bug: 5160570
Bug: 5179058
Change-Id: I91834210adb21f7d4a2def4da13f007114f57348
2011-08-19 16:38:09 -07:00
Mindy Pereira bea643e699 Merge "Update attachment ui to look like Gmail attachment ui; fix from padding." 2011-08-19 15:45:11 -07:00
Marc Blank 828bf89535 Merge "Make sure reconcileAccounts in AccountService is synchronous" 2011-08-19 15:40:00 -07:00
Mindy Pereira 89dd731a90 Update attachment ui to look like Gmail attachment ui; fix from padding.
Fixes Bug:5184434 Compose view doesn't match pixel perfects
Change-Id: I7217eb4a63beedfd0bc00dffe9e0f29a5af6214c
2011-08-19 15:36:23 -07:00
Marc Blank 8b755f600c Make sure reconcileAccounts in AccountService is synchronous
* This is important so that callers can know that reconciliation
  is complete.

Bug: 5189766
Change-Id: I4fbbaa6506042f975e7ad4e828fe8399c4d4a366
2011-08-19 15:27:00 -07:00
Mindy Pereira 7b41b374cc Style Email compose to look like gmail compose.
Change-Id: I8e1f0e9c4bbbbcd2463473da190bff88f2748905
2011-08-19 11:42:09 -07:00
Mindy Pereira 5b5a9b3f9e Fix alignment of to/cc/bcc fields.
Part of bug:5162602 Alignment of elements in compose screen seems off (master/tot/prime

Change-Id: Ica741328c687b68c8995a1e9fde4d6bb566407ba
2011-08-18 16:17:29 -07:00
Mindy Pereira 475a56fd0a Merge "Change the fonts / sizes of the chips labels to match the rest of the compose activity." 2011-08-18 15:58:37 -07:00
Ben Komalo a3e8adac95 Merge "Add in missing return statement" 2011-08-18 13:12:26 -07:00
Marc Blank 28a48b6001 Merge "Support IMAP search in UTF-8, in addition to US-ASCII" 2011-08-18 13:02:48 -07:00
Ben Komalo d766e72450 Add in missing return statement
This caused an unintended fallthrough

Bug: 5183930
Change-Id: Iff2100be13a242bfc576c1cb737d8777f4b8065a
2011-08-18 12:15:37 -07:00
Ben Komalo 2ae341bfa1 Fix messagelistitem logic.
We had two separate "height" values in XML that weren't consistent - one
was used for the coordinates and one was used for the actual item i nthe
adapter. This made things off slightly when the values didn't match
(i.e. on tablet wide mode).

Also fixed an issue with paperclip icon not aligning with date on wide
mode

Bug: 5184169
Change-Id: I1d80bb9c685fdd8216fcaef26bf6ad715eb74c4c
2011-08-18 12:09:39 -07:00
Ben Komalo 899e481fd1 Fix up action bar items.
- vertically centers mailboxes
- fixes subject lines from extending beyond 2 lines and getting cut off

Bug: 5183775
Change-Id: I8f6367edeafdfcf361cafa7e542f4028e955f7f1
2011-08-18 10:51:02 -07:00
Ben Komalo f13fee5d78 Drop in notification for multiple new mails
Bug: 5058000
Change-Id: Ic852004f8f154943742cf40ccfb6063a736d4cae
2011-08-17 17:10:06 -07:00
Mindy Pereira d52ff88e89 Change the fonts / sizes of the chips labels to match the rest of the compose activity.
part of Bug:5162602 Alignment of elements in compose screen seems off (master/tot/prime)

Change-Id: Ie2125df9888198448d1503edc4cccf3537db016c
2011-08-17 16:52:01 -07:00
Marc Blank 20bf1f632f Support IMAP search in UTF-8, in addition to US-ASCII
* The existing IMAP search code is well-known to be primitive and
  largely broken.  In particular, it fails with any non-ASCII
  character and with a variety of symbols (e.g. quotes, slashes,
  etc.)  Basically, it's an accident waiting to happen, returning
  empty data sets even when the query might reasonably be expected
  (or known) to return valid data.
* The current CL uses the IMAP literal string format to represent
  the query text; this string can be sent either in ascii or in
  UTF-8, and since it is sent as an octet (byte) count followed by
  8-bit data, it also solves any quoting issues that might come
  up.  So, we kill two birds with one stone.
* The bug in question was punted to a subsequent MR; however, I
  think it would be a mistake to ship the code without this
  CL, which has been tested against the three common IMAP servers
  that we aim to support.

Bug: 4690713
Change-Id: Iaa542bfc56737871f3cbc9c83f0e768415a7f2b6
2011-08-17 16:17:04 -07:00