Remove needless clearView()

- this is leftover from a time where we re-used a single WebView for
multiple messages. The current architecture does not rely on that, so
the clearView() is actually not useful. Worse - it's causing issues
because the operation in the WebView is asynchronous, so a clearView and
a load of the content in quick succession causes a race condition,
causing items not to load

Bug: 5205296
Change-Id: I5ee6697bdf53a033ba1c7f21170820259bf830d1
This commit is contained in:
Ben Komalo 2011-08-24 18:24:00 -07:00
parent d80e7565dd
commit b8dd117002

View File

@ -494,6 +494,8 @@ public abstract class MessageViewFragmentBase extends Fragment implements View.O
makeVisible(mLoadingProgress, !showContent && showProgressWhenHidden);
}
// TODO: clean this up - most of this is not needed since the WebView and Fragment is not
// reused for multiple messages.
protected void resetView() {
showContent(false, false);
updateTabs(0);
@ -501,7 +503,6 @@ public abstract class MessageViewFragmentBase extends Fragment implements View.O
if (mMessageContentView != null) {
blockNetworkLoads(true);
mMessageContentView.scrollTo(0, 0);
mMessageContentView.clearView();
// Dynamic configuration of WebView
final WebSettings settings = mMessageContentView.getSettings();