Commit Graph

5862 Commits

Author SHA1 Message Date
Eric Fischer
d15a3fbf57 Merge "Import revised translations." 2011-07-07 11:34:38 -07:00
Eric Fischer
321286fedf Import revised translations.
Change-Id: I95a7e35ac39e85b2d007f9a8dda712fb3038ebba
2011-07-07 11:32:35 -07:00
Ben Komalo
7891106a7d Write reply/forward flags on Controller.sendMessage
- also fix some mixups with the actual icon states

Bug: 4947145
Change-Id: Iec1bbfc46ac956a6bf050e4fb162b94ea3c6b316
2011-07-06 18:10:16 -04:00
Ben Komalo
33d6307d4b Prevent wasteful calls to invalidateOptionsMenu
The app is spending a lot of time in startup inflating XML. I suspect a
lot of it is due to the refreshActionBar() calls.

On a normal startup with NO refresh, the action bar was rebuilt 6 times.
If a refresh happens, the refresh callbacks get called in rapid
succession (20+ successive calls is not uncommon), which seemed really
wasteful.

Change-Id: I05feb56ba7fafb109d820328f591526945ca0a5f
2011-07-06 11:19:40 -04:00
Ben Komalo
d8ab562d0d Reduce startup time via Welcome.
In the common case, we don't need the "waiting for sync..." message, so
avoid inflation in those cases and just inflate on demand.

Also do a quick drive-by fix for the error message being pushed in way
too much on phones

Change-Id: Ie7a8472194659a52069d1ee21e0a0cb9b6fc91ba
2011-07-06 11:14:04 -04:00
Jon Starling
ea11bfd6fc SmtpSender: Send EHLO that adheres to RFC2821
Adhere to RFC2821 Sec. 4.1.3 Address Literals should be enclosed by brackets and
prefixed with 'IPv6:' if the sender is an IPv6 host

Original author: Jon Starling

Bug: 4207470
Change-Id: Id327930001188186713e38d1ce8ecc1dad8cfbc0
2011-07-05 12:50:34 -07:00
Ben Komalo
e76962b1b9 Revert "Enable SD card encryption policy when emulated"
This is a manual cherry-pick of c379ebe372
This reverts commit 7fd14be804

The introduction of proper SD cards breaks the invariant that "external"
storage can be encrypted. Unfortunately, this means that accounts with
that policy bit set will have to be removed for now.

Accounts with the security policy set will be forced to go through
security provisioning on the next sync, using the regular mechanisms of
showing a notification with "Security update required", and then having
it fail. :(

Bug: 4466311
Change-Id: I68119b14f8d198779c2073296e228bc6772136ee
2011-07-04 16:16:07 -07:00
Ben Komalo
0268581de2 Merge "Be explicit about disabling drag n drop in search" 2011-07-04 15:59:00 -07:00
Ben Komalo
b8dc7beca2 Merge "Quick fixes to unread count" 2011-07-04 07:38:48 -07:00
Makoto Onuki
96e084e67a Merge "Work around for bug 4674712" 2011-07-01 16:39:46 -07:00
Ben Komalo
1b4b6cf560 Be explicit about disabling drag n drop in search
It was accidentally happening because search doesn't show the mailbox
list, but explicit > implicit.

Change-Id: Ifb8354dbb366f4c8328bef31d4e251166ae6876a
2011-07-01 16:36:44 -07:00
Ben Komalo
ec9e903ce2 Merge "Fix some stale TODO's" 2011-07-01 16:36:35 -07:00
Ben Komalo
fdd99f5486 Merge "Remove some stale stopships and TODO's" 2011-07-01 16:36:29 -07:00
Makoto Onuki
8b72c7eb8d Work around for bug 4674712
Seems like we're getting onItemClick() on header rows, which are
supposed to be disabled.

Change-Id: I03b108c508f46368cc420049eed67438af7a7735
2011-07-01 16:30:33 -07:00
Ben Komalo
130bf263da Remove some stale stopships and TODO's
Change-Id: I3221b3c35c5ffb464756f9de288bf36f560cf8fb
2011-07-01 16:29:21 -07:00
Ben Komalo
4abf58237a Fix some stale TODO's
- also bail search mode if we can't find an account. it probably doesn't
matter _that_ much since the UIController will also bail, but just in
case...

Change-Id: I0b601186362e048de83b53617e529bbada1e8db5
2011-07-01 16:21:31 -07:00
Jorge Lugo
7d243000d4 Merge "Added "replied to" and "forwarded" icons in message list" 2011-07-01 15:05:25 -07:00
Jorge Lugo
e2f6f18396 Added "replied to" and "forwarded" icons in message list
When a message has been replied to or forwarded by the user in
Exchange or IMAP, it now displays the appropriate symbol in the
message list view. (Right now it's just a test image based on the
reply/forward/replyall images until the assets come in.)

Bug: 4313491
Change-Id: I525e55179d62b6ab08df37cb9bfe9fdd9fefb908
2011-07-01 14:43:17 -07:00
Makoto Onuki
6a712721b1 Merge "Fix all NoSuchMethodErrors" 2011-07-01 12:48:02 -07:00
Makoto Onuki
745b33b8ff Fix all NoSuchMethodErrors
Change-Id: I05adf2b99c819d6aa2d3b52c52a8c655d9307337
2011-07-01 12:44:27 -07:00
Makoto Onuki
7107d8e821 Merge "Use parallel executor" 2011-07-01 11:19:04 -07:00
Makoto Onuki
bc2eaadde9 Use parallel executor
We should eventually replace all with EmailAsyncTask, but it's the safest thing
we can do now to avoid regression.

Change-Id: I78bfc4fb2be1dcfadeb7f90092ec7adb35c1d393
2011-07-01 11:04:11 -07:00
Makoto Onuki
1600adab97 Merge "Fix bug 4978035 Precondition failure: Not combined mailbox" 2011-07-01 10:19:46 -07:00
Makoto Onuki
a6212c88e0 Fix bug 4978035 Precondition failure: Not combined mailbox
Also added test.

(For some reason the message count doesn't get set properly on tests...
I'll investigate it when I get around to it...)

Change-Id: I83f3b6f2079da06b2d4973419d2296e6492de1d3
2011-07-01 10:18:13 -07:00
Makoto Onuki
45bfb10464 Merge "Fix bug 4901592 Do not drill-in to inbox by default" 2011-07-01 10:06:55 -07:00
Marc Blank
983fd116b1 Merge "Delete orphaned mailboxes/messages/policies at provider startup" 2011-07-01 09:22:11 -07:00
Marc Blank
2bdf7ee0f0 Delete orphaned mailboxes/messages/policies at provider startup
Bug: 4972132

Change-Id: Icc756a9e28b77de052261903089b040d229e7b5d
2011-07-01 09:21:09 -07:00
Mindy Pereira
11370c69b0 Merge "Turn on chips for email on tablet." 2011-07-01 07:45:40 -07:00
Jorge Lugo
c01db92acf Merge "Widget logo opens up mailbox" 2011-06-30 20:46:22 -07:00
Mindy Pereira
2a2e47d51b Turn on chips for email on tablet.
Change-Id: I3958b0f32b8d335a3f5905f4d3b188324284da43
2011-06-30 19:43:42 -07:00
Makoto Onuki
9630e31bac Fix bug 4901592 Do not drill-in to inbox by default
If the initial mailbox has child mailboxes, we should show the drilled-in
view by default, EXCEPT if the initial mailbox is inbox, in which case
we want to show the root view.

(And we drill-in if the user taps Inbox.)

Bug 4901592

Change-Id: Idc1462030cf8d971dd4dcbba647ac3a64cab6819
2011-06-30 18:00:11 -07:00
Ben Komalo
ad359c8fdf Quick fixes to unread count
Makes it consistent in the header and dropdown

Change-Id: Iec97678fa8704c6c4cf8c8eb129c94321f34949b
2011-06-30 16:26:02 -07:00
Ben Komalo
6fc2585327 Fix account settings crash.
The check settings fragment could potentially take a while to finish,
and may finish after the activity has shut down. Ensure that the
callbacks don't go through if that happens (usually means the user
backed out before it finished)
Bug: 4689161

Change-Id: Ie8e052f03a8f8f2884c0fe1e334a91c02444f96c
2011-06-30 15:38:34 -07:00
Jorge Lugo
1f59271769 Widget logo opens up mailbox
Pressing the email widget's logo will open up the account's inbox.
Also, composing a new email open the compose window for that
account instead of an arbitrary account as before.

Bug: 3366819
Change-Id: I03c0d6973f5428b2044e755f41fcc6f4da225afa
2011-06-30 15:16:47 -07:00
Ben Komalo
09e7fffb2a Merge "Fix b/4905749 using workaround" 2011-06-30 11:56:05 -07:00
Ben Komalo
85cfc9c0bd Fix b/4905749 using workaround
We suspect the underlying bug is b/4981556 but it is a framework issue
which needs time to fix. Some fragment state is not restored properly
when going through orientation change, so navigation shortly after that
will always crash.

Change-Id: Id6b8714c2aeac5f6bf09e82aea5459bb19d0054d
2011-06-30 11:47:39 -07:00
Makoto Onuki
3aa7fd74f8 Fix bug 4978032 Can't get out of "starred" mailbox
Even with CL the account spinner on the starred mailbox looks still a bit
weird because the spinner turns into the combined mode even if you select
the starred mailbox from a normail account's mailbox list, but at least
you'll be able to get out of the starred mailbox.

Change-Id: I26a256be39f070acece67f4a308a8525a6be1d3b
2011-06-30 09:46:15 -07:00
Ben Komalo
698aa92e6f Fix actionbar for message view
- shows the title of the message in the action bar (visuals not final -
need to extend the width and hide the account name)
- ensures that tapping up/back from a message view from a search result
list doesn't exit search
- ensures that tapping "app up" from a collapsible tablet view doesn't
exist the search unless the left pane is uncollapsed

Change-Id: I2b21a430d12148cf72237060c05312c7a23e2b3b
2011-06-29 19:46:58 -07:00
Makoto Onuki
8de5bda815 Close cursor properly.
Also, don't issue separate query()s for each recent mailbox.

Bug 4977956

Change-Id: I3ccd437a7efd5c3599c4a1952ba091a7b3b815bf
2011-06-29 19:21:14 -07:00
Makoto Onuki
5fbc5025f0 Merge "Remove opener IDs from message view fragment." 2011-06-29 17:58:37 -07:00
Marc Blank
6da2b981da Merge "Oops; fix NPE" 2011-06-29 17:54:53 -07:00
Marc Blank
569785b4f9 Oops; fix NPE
Bug: 4977755

Change-Id: I117eb3a061628ee572f37123631c3da301b5e50b
2011-06-29 17:50:23 -07:00
Makoto Onuki
918860b8e0 Remove opener IDs from message view fragment.
There are needed for the back navigation when a message
is opened from a deep link, but now that we always have a list context
they're not necessary.

Change-Id: Iba2d0b2f31f4539f6e872970b514574347e248c5
2011-06-29 17:32:45 -07:00
Makoto Onuki
87fce70d0f Merge "Newer/older + auto-advance for one-pane" 2011-06-29 17:31:32 -07:00
Makoto Onuki
22d1a794cd Newer/older + auto-advance for one-pane
- Moved MessageOrderManager code from 2-pabe to the base class.
- Most of the code is shared between 1-pane and 2-pane.

- Also fixed the bug where we re-created MessageOrderManager every time
the user taps newer/older, which was the reson the newer/older button
temporarily got disabled when you tapped them.
Before this CL we stopped MOM in uninstallMessageViewFragment, but now that
we don't reuse fragments this means we stops MOM when we remove the current
message view, and re-created a new one when a new message view is created.
Now we stop MOM when the right pane gets hidden (2pane) or when showing
the mailbox/message list (1pane).

- Also removed a now unused callback onMessageShown() from MessageViewFragment.
We used to update MOM on this event, but now we do this in
installMessageViweFramgment().

Bug 4575586

Change-Id: Idc4aba184f318e0c086afc29dcbe42364e2b51b3
2011-06-29 17:29:29 -07:00
Marc Blank
17f7ffae4c Merge "More Store cleanup" 2011-06-29 16:43:01 -07:00
Makoto Onuki
4b39d7ccff Fix for "Unknown uri: .../mailbox/-4
It was caused by the fact that we show the combined starred mailbox
on each account's mailbox list.

Beacuse of this, when you open the starred mailbox on non-combined view,
we pass a normal account ID + the combined starred mailbox ID to the
AccountsLoader, which then thinks that because the account ID is not
ACCOUNT_ID_COMBINED_VIEW the mailbox ID must be of a regular mailbox,
issues a query to get mailbox info, and crashes because the mailbox
is virtual.

- Also fixed the issue that we don't show message count on the account
spinner for combined mailboxes.

bug 4971181

Change-Id: Iaa13b362505b8babc7f7ea8a03ddf5494736dc2d
2011-06-29 16:30:43 -07:00
Ben Komalo
3dbab0e26d Allow widget to be resized to 2x2
This way it doesn't have to take the entire phone screen
Bug: 4902471

Change-Id: I5c7b957d895d3abb7d3f5b7c502b7e8e886755b4
2011-06-29 16:18:01 -07:00
Marc Blank
0b8e04c84d More Store cleanup
Change-Id: I8f542175b4468c7a320322a57bfdaf19a7320165
2011-06-29 15:22:05 -07:00
Marc Blank
aa46bc3919 Merge "Remove redundant and unused constants" 2011-06-29 14:48:08 -07:00