Commit Graph

3785 Commits

Author SHA1 Message Date
Marc Blank
c31d9cd4eb Merge "Initial rewrite of MessageListItem for XL" 2010-11-17 15:11:16 -08:00
Marc Blank
937ea4fc87 Initial rewrite of MessageListItem for XL
* Drawing all done by MessageListItem, based on view width
* Completely functional, layout tweaks required

TODO: Consider caching drawing values for performance

Bug: 3137994

Change-Id: Ie3de79357bfe976b2fcebdedb71dea011252b445
2010-11-17 12:23:03 -08:00
Eric Fischer
12b350a46f Merge "Import revised translations." 2010-11-17 12:11:37 -08:00
Eric Fischer
09871f179b Import revised translations.
Change-Id: I733f1dbd88809e72f80d60d7d85fba783f598dcb
2010-11-17 11:39:44 -08:00
Marc Blank
349055aad4 Allow ProviderTests to work with ContentCache
Bug: 3204331
Change-Id: I5399345c2b759fb34d3dc7c694eb0eef8d7de493
2010-11-17 10:19:30 -08:00
Marc Blank
8afdca0bac Merge "Minor cleanups for ContentCache" 2010-11-17 09:16:47 -08:00
Andy Stadler
2199c7ddf5 Minor cleanups for ContentCache
* Change CounterMap to not extend HashMap
* Renamed remove() to subtract()
* Comment out a failing test
* Add a flag that prevents any objects from being cached

Change-Id: I74754133b505178e8b0166390f69509f006a3da2
2010-11-16 22:49:04 -08:00
Makoto Onuki
878a9da420 Merge "Three pane behavior changes" 2010-11-16 17:19:33 -08:00
Makoto Onuki
d2289c2f19 Three pane behavior changes
- Now pressing back on the message view on portrait expands the message
  list.  Pressing back again closes the message view and navigates
  to the mailbox list + message list view.
- Fixed the bug where the app icon on the action bar will lose the back arrow
  on screen rotation.
- Code clean up.

Bug 3137919
Bug 3198987

Change-Id: Ia452f90ebe5599a2a8de905f4dabec6bd3ceb4a2
2010-11-16 17:18:46 -08:00
Andy Stadler
e6c6587b04 Create XL layouts for incoming, outgoing, exchange
* Create XL fragments (will be shared w/settings)
* Create XL landscape activities
* Create XL portrait activities
* Placeholders left for integration with settings - remove in settings CL
* Quick fixes (non shipping) for phone UX
* Update existing portait next/prev buttons per new wireframes

Bug: 3188940
Change-Id: Ied6e7fd1e968fd6db57607a68dabf7e00ba78ee6
2010-11-16 16:40:34 -08:00
Makoto Onuki
15f46cc715 XL layout for message compose
The layout is not final, but it's closer to the wireframe.
- All dimensions and colors are not final.  I just made them up.
- The "+cc/bcc" and "add attachment" buttons are in the wrong position.

I'll wait for the pixel perfect before addressing them.

Bug 3138037

Change-Id: I72fc7557c28e72df08a3751c3c93acfb35749d68
2010-11-16 11:28:58 -08:00
Marc Blank
28214840dc Merge "EmailProvider content caching" 2010-11-16 11:18:00 -08:00
Marc Blank
fab77f147f EmailProvider content caching
* In this CL, we cache individual rows, based on the CONTENT_PROJECTION
  defined for the most common queries (Account, HostAuth, Mailbox, and
  Message)
* Queries on individual rows (most often Class.restoreClassById()) will
  look to the cache first, rather than querying the database
* Queries on smaller projections will build MatrixCursor's from cached
  data
* Write-through caching updates the cache with changed columns
* Experiments with live data indicate that > 95% of queries that are
  cacheable (single row, no selection) can be retrieved from the cache,
  thereby saving a great deal of disk access.
* Timing experiments show that cache hits are > 40x faster than cache
  misses
* Unit tests for the various classes exist, with more coming

TODO
----
* More unit tests

Change-Id: I386a948a2f4cc02b6548d07d9b2fefd1e018a262
2010-11-16 08:58:05 -08:00
Andy Stadler
7fd78d8d61 Create XL layouts for AccountSetupOptions
* Landscape and portrait layouts
* Quick fixes to phone UX (not shippable)
* Added some CHAR_LIMIT values

Bug: 3188940
Change-Id: I093d5a6dcde2da96c173b5878900114802aead3e
2010-11-15 18:37:56 -08:00
Marc Blank
01f8be9952 Merge "Accept complex characters policy regardless of password mode" 2010-11-15 15:01:13 -08:00
Makoto Onuki
e446bb8b45 Merge "Switch from Theme.Holo.Light.Extended to Theme.Holo.Light" 2010-11-15 12:54:03 -08:00
Andy Stadler
17adb23fb4 Preliminary XL version of Account Names screen
* Add new account names layouts for XL devices
* Placeholder UX for phones

Bug: 3188940
Change-Id: I8c9d0793b004af5f5b66070fd18ecb46fc6f1612
2010-11-15 12:08:37 -08:00
Makoto Onuki
65b1eef31b Message view code change
- Show sender email address
- Show BCC for sent messages
- Don't show the default quick contact badge frame.
  (change QuickContact to ImageView)

Bug 1501239
Bug 3138021

Change-Id: I0e8d91ad3a6a3a021c8aff0945a1ce11d13b2728
2010-11-15 12:03:36 -08:00
Makoto Onuki
b43c991e5f Switch from Theme.Holo.Light.Extended to Theme.Holo.Light
Change-Id: I91a43412a87a5444042141c9d6917e1ff200fe7a
2010-11-15 12:01:45 -08:00
Makoto Onuki
17670b1194 Merge "Small code change on MessageCompose" 2010-11-15 11:03:21 -08:00
Andy Stadler
27c70e3322 Preliminary XL version of Account Type screen
* Add new account type layout for XL devices

Bug: 3188940
Change-Id: I12ebe60075971fa14c7c55be65dccc0b7602f566
2010-11-14 21:37:41 -08:00
Andy Stadler
7988164ddf First pass of XL account setup
* AccountSetupBasics now has an XL version
* This is from prelim wireframes
* Final colors, text size, and positioning all TBD
* Fixed a StrictMode violation (counting #accounts in onCreate)
* Lightweight (non-shippable) fixes for functional phone UX

Bug: 3188940
Change-Id: Idf6cb514208eba07eaa20b20abfd5fcc3dae1751
2010-11-14 21:16:49 -08:00
Marc Blank
ac05d5e179 Accept complex characters policy regardless of password mode
* We were rejecting complex characters policy if the mode was
  none or simple, but this case is already handled in the
  constructor for PolicySet

Bug: 3192973
Change-Id: I060b17401c58498d1597c9322be588020deca69c
2010-11-13 14:32:57 -08:00
Makoto Onuki
4977ce62f0 Small code change on MessageCompose
Change how we show/hide CC/BCC.  The new way will work for the tab UI too,
where we show the labels to these fields as well.

Also hide the "+Cc/Bcc" button when they're visible.

Bug 3138037
Bug 3192841

Change-Id: Ic78b3200c418430c8eade3ca1238b0d0f1ee4731
2010-11-12 16:19:26 -08:00
Makoto Onuki
949138d482 Merge "Fix NPE on the phone UI" 2010-11-12 16:08:28 -08:00
Makoto Onuki
05565d4e83 Fix NPE on the phone UI
It still has a problem that no menu options show up on the activity,
but it's at least useable.

Bug 3192277

Change-Id: Ia891557020c863bfa53d45b7465d012aa411d67f
2010-11-12 14:25:37 -08:00
Makoto Onuki
9e34bb73f7 Action bar: Use the app icon as back.
Bug 3137891

Change-Id: I3d8e10f7a3a7880518127c4ed582bc2b7c96c8d6
2010-11-11 17:03:06 -08:00
Makoto Onuki
6926cf85ef Merge "Fix "Parcel@406cd448: Unmarshalling unknown type code..."" 2010-11-11 17:02:52 -08:00
Makoto Onuki
5f91dd12d8 Fix "Parcel@406cd448: Unmarshalling unknown type code..."
It was a mismatch between onSaveInstanceState and onRestoreInstanceState.

Bug 3158588

Change-Id: I36ff6ee8a666ff418f3cf0da50477f9347040322
2010-11-11 17:00:28 -08:00
Marc Blank
ec79508146 Revert "Reuse mailbox cursor unless boxes have changed"
This reverts commit 6c3fa18356.
2010-11-11 10:55:37 -08:00
Marc Blank
cb2b974899 Merge "Fix provisioning error with min complex characters" 2010-11-10 17:55:57 -08:00
Marc Blank
313532ab06 Fix provisioning error with min complex characters
Change-Id: I411cc97460561edee2269119225a41630a2d8444
2010-11-10 17:45:44 -08:00
Makoto Onuki
2ac1eaf8c3 Account selector rework.
- Show email address
- Show inbox unread message count

Initially I thought of using a join to get accounts with their unread
counts with one query, but there were enough subtle issues that I gave up
on the idea.

Instead it uses a MatrixCursor to build a completely new cursor,
based on a regular accounts cursor.

Change-Id: I09e8762f131cc2bd3637e1a3d302088a3b5b2479
2010-11-10 17:41:29 -08:00
Makoto Onuki
fd8ee7bc50 Show confirmation dialog before discarding drafts.
1. This CL implements the most common case, which is pressing the discard
  button on MessageCompose.

2. This CL doesn't change the discard on message list, which is much trickier.
   (We need to check the message type of all messages in the selection,
   as selection can contain any number of any kind of messges in "All Starred")

Bug 3072556

Change-Id: Ib270cae726f8fd5abf7e0e7dfc34ce97019d5301
2010-11-10 14:13:05 -08:00
Makoto Onuki
77303a483b Merge "New message view command layout" 2010-11-10 14:09:38 -08:00
Makoto Onuki
931ca67a1f New message view command layout
UI Changes:
- "Move", "Delete" and "Mark as unread" became action bar commands.
- The message view bottom panel now only has "newer" and "older" buttons,
  with  the current position in the message list.  (shown as POS of TOTAL)
- The buttom panel is now shown only on portrait

Non UI changes
- MessageOrderManager now keeps track of the current cursor position
  as well as the total message count.

- Fixed the "move_action" string, which was wrongly marked as non-translatable.

Bug 3169454

Change-Id: I599543f9e11000a4ee283d31fbd407b2ab53ac44
2010-11-10 11:08:14 -08:00
Eric Fischer
47b53f9c6a Merge "Import revised translations." 2010-11-10 10:26:54 -08:00
Makoto Onuki
6f3d167cfa Don't show non-incoming message in notification.
Filter out non-incoming messages using a subquery.
(because the message table doen't have the mailbox type.)

I was initially thinking of adding a new content URL for
the message table joined with the mailbox table, but it turned out
to be a bit of pain, so ended up using a subquery.
(one of the problems was that both tables had the "_id" field.)

Bug 3177220

Change-Id: I276efb70db1589835f3ddb8c7da4773e72d8691b
2010-11-10 10:22:41 -08:00
Eric Fischer
40ce4e6f9e Import revised translations.
Change-Id: Id4f425eb8a5b3b0dbf6b6825be9b20352bf3a634
2010-11-09 17:40:23 -08:00
Makoto Onuki
d12e56d321 Fix auto-refresh of mailbox list
sEnableUpdate should default to true.

Bug 3180421

Change-Id: I1145846d96bba9e962f598e785daf7ce7ad2404b
2010-11-09 15:27:55 -08:00
Makoto Onuki
b70772daa5 Merge "Code change for new mailbox list layout" 2010-11-09 13:47:08 -08:00
Marc Blank
4ac5286eb9 Merge "Don't allow d&d move from boxes that don't support it" 2010-11-09 13:22:25 -08:00
Marc Blank
e857ff50ec Don't allow d&d move from boxes that don't support it
Bug: 3177021
Change-Id: Ib5cfcef05794d6f83884d97f2096f3d4f6b3295c
2010-11-09 12:21:34 -08:00
Makoto Onuki
9c39deef4e Code change for new mailbox list layout
- Don't show a folder icon for regular mailboxes
- Change the count look
- Don't show counts for Sent/Trash.

Bug 3137965
Bug 3073147

Change-Id: I8fc0af8fc2d51968605fe4b570e5704453092ac7
2010-11-08 18:16:23 -08:00
Makoto Onuki
44904aee53 Merge "Don't call dismiss() in onLoadFinished()." 2010-11-08 15:34:17 -08:00
Makoto Onuki
8197d84734 Don't call dismiss() in onLoadFinished().
It's prohibited.  Instead use a Handler to delay-call it.

Bug 3173317

Change-Id: Ic5ef245a65b3a4eeebabcebd6323b9a7921f34d5
2010-11-08 14:27:13 -08:00
Marc Blank
ad222dc6bb Remove heartbeat logging in ExchangeService
Change-Id: I76be32340811a6a64fb404964d424d881b4db7c5
2010-11-08 13:05:38 -08:00
Marc Blank
6c3fa18356 Reuse mailbox cursor unless boxes have changed
Change-Id: Ic91b1d7bd72e9faf04d3448c1e194663db2c889a
2010-11-08 12:51:55 -08:00
Marc Blank
dc8f1afeb6 Merge "Prevent unnecessary database queries in ExchangeService" 2010-11-05 20:36:19 -07:00
Marc Blank
79ff660aa2 Prevent unnecessary database queries in ExchangeService
Change-Id: Idc3cbc272bd96598b7c7a5de644786bddf1ce03e
2010-11-05 20:35:14 -07:00