We haven't gotten all dimensions yet, but this is what I inferred from
the latest redlines.
Also fixed a margin above the message area on message view.
(Keep the margin even if there's no tabs.)
Bug 3138021
Change-Id: Iafff578f499737674ec10206b75566377cf2383b
Remove the concept of scroll speeds. According to Mark, multiple scroll speeds
is a "nice to have" feature and not a "must have". Besides, this did not work
(there was only ever one scroll speed), and, when fixed, the top scroll speed
was way too fast to be usable.
bug 3335062
Change-Id: I160bec2ca5de0b26da81ed31dfb96fc86e543988
Still waiting for a few missing assets, but it's done other than that.
The divider change is already merged; new layouts all use the framework style.
It's basically all layout changes, except for:
- Now the recepient address line has "Show details", which shows a dialog with
all to/cc/bcc addresses with the timestamp.
- Now invite response buttons are checkboxes.
(But the basic behavior doesn't change -- once you check a response,
the message will be gone, so you can't change the response later.)
Copied message_header_bg from gmail manuall. It'll look silly without it.
Bug 3138021
Bug 3307021
Change-Id: I6f7eb91d6104c3143a5c58b0c4c6c19929cea477
The framework defines ?android:attr/dividerHorizontal. Instead of defining our
own divider by specifying some arbitrary RGB colour, utilize the framework's
divider.
bug 3335145
Change-Id: I64dd30a5a73b0884f82f6a2b9fbbd88c6782e0db
* Dimensions, Colors, Paddings, Text styles, etc.
* Update AccountSetupBasics, AccountSetupAccountType,
AccountSetupOptions, and AccountSetupNames
* Extracted shared layouts in AccountSetupOptions & AccountSetupNames
* Leave behind STOPSHIP entries for:
- button positioning (primarily vertical)
- colors of text & dividers
* Will do incoming, outgoing, exchange in a separate CL (because they
are shared with settings)
Bug: 3335093
Bug: 3188940
Change-Id: Idf727e3b2b6a0293d6d41bf29f1c0c48d746ab7c
* Stop running syncs
* Delete all EmailProvider data except the account itself (with
cleared sync key) and the account mailbox (necessary for syncing
to sync after security hold is lifted
Bug: 3245779
Bug: 3253952
Change-Id: Idc208ef5ed85808b085ebab9c26a428fb0451e34
* cleaned out old placeholders
* moved a bunch of unused strings into placeholders
* moved three strings into active status.
Bug: 3335092
Change-Id: Ibb0690f7cc9ddd1b8f7f337964faff6471be880c
Check value of ActivityManager.isRunningInTestHarness() before allowing force
account creation, instead of ActivityManager.isUserAMonkey().
Bug 3329873
Change-Id: I5028eef9caced2cacc9c187dfd746865939fdedd
If you do so, MessageCompose won't be able to restore an account, so it'll
use null account...
Bug 3324472
Change-Id: Ic0e615b31e21246e41f6f2c709a8422bef230040
Icons reported as unused by running the script "findUnusedAssets". This
script checks for any reference to a drawable in all XML and Java files.
Some _holo_light icons are removed as they are no longer in the designer
git and should not be used.
Change-Id: Ie42d13394d6d81d35fcb48f8f76c6abd4cb09ee4
Use the new icons where appropriate. This is not a complete change as there are
still some icons missing.
Change-Id: I51d1458749343ddfc6456dc2a9853b8bc2540e26
We discovered that AsyncTask.cancel() doesn't quite perform as expected;
In particular, if you call cancel() during a particularly slow background
worker, the result is discarded and onPostExecute() is never called. If
the result is an open cursor, then we "leak" by not closing it.
For AccountFolderList, which has a multi-step doInBackground():
1. Check for isCancelled() during the long doInBackground() which will
reduce the number of discarded cursors in the first place.
2. Check for isCancelled() at the end of the long doInBackground() and
if true, close the result cursors and return null.
3. In the existing isCancelled() code in onPostExecute(), close the
cursors.
For other AsyncTasks (with simpler configurations):
1. Check for isCancelled() at the end of doInBackground() and if true,
close the just-opened cursor and return null.
See also Change-Id: Ie63a3197af563baa8bb0fe6f1ef9423e281cbf4c
Bug: 3088870
Change-Id: I51b11bb5b23f209f8b61962500a063040484fd24
* Add simple sanity checks to scanned accounts, skip over if bad
* Fix existing unit tests and add new unit test for this change
* Also fixed minor bug in EmailContent that was never triggered in
production code (only discovered it via a unit test).
* Also fixed minor bug in an existing unit test
Bug: 2937595
Change-Id: Id60bbb5d8bd923db043d46891c7f89d7debb0a11
