Commit Graph

4010 Commits

Author SHA1 Message Date
Makoto Onuki
adbb6f8bc4 Log cursor/adapter class name and such when detecting a crash
Also log where the cursor was closed, if it is.

To investigate bug 3308465 and bug 3305706

Change-Id: I2b0fd9ea14757b6cf7597cd7162686d050d43fe9
2010-12-23 16:15:44 -08:00
Andy Stadler
2959a7e073 Fix ANRs from Email.setServicesEnabled()
* Create sync & async versions
* Rename all callsites so sync is very apparent
* Fix callsites appropriately
* Clean up interaction between reconciler and setServicesEnabled

Bug: 3133770
Bug: 3134677
Change-Id: Iefbc7814d9aa390baea6345e450e2a4768bf0a9a
2010-12-23 13:19:55 -08:00
Andy Stadler
6aec257fe7 Merge "Fix NPE when changing server settings w/security dialog" 2010-12-23 11:08:50 -08:00
Andy Stadler
c4c3a71f9f Merge "Async code for read/unread and starred" 2010-12-23 11:01:42 -08:00
Makoto Onuki
948bcad901 Merge "Use swapCursor(null) instead of changeCursor(null)" 2010-12-23 10:15:05 -08:00
Andy Stadler
3b1cccf234 Async code for read/unread and starred
* Move each worker into async (combining common code)
* Update unit tests to match
* Make the message->account->controller lookups more efficient

Bug: 3134653
Change-Id: Icc82998a5d8eb07c7ebc7edbd28cd9308378d866
2010-12-23 09:55:16 -08:00
Andy Stadler
d8f1d8f2ff Fix NPE when changing server settings w/security dialog
Bug: 3302453
Change-Id: I8adb5166598b72f9eb4a26bbe47afc756e764159
2010-12-22 19:01:08 -08:00
Andy Stadler
8d22e85e45 Reduce/eliminate DB access in server settings
* Create shared async worker to check for duplicate accounts
* Use it in AccountSetupIncomingFragment
* Use it in AccountSetupExchangeFragment
* Debounce proceed/next button because work is now async
* Also, upgrade leftover old-style code in AccountSetupOutgoingFragment

Bug: 3134666
Change-Id: I5c24a6546d1ab66aedc5c4ac826ddf4f1ff53446
2010-12-22 18:57:27 -08:00
Makoto Onuki
e0f28d7853 Use swapCursor(null) instead of changeCursor(null)
The later closes the old cursor while the former doesn't.
LoaderManager takes care of closing cursors, so no need to close
cursors by ourselves.

Change-Id: Ib652e6877dcfc1fea51ffc862254eaeed451cdfa
2010-12-22 17:35:44 -08:00
Andy Stadler
6ebaa90847 Reduce/eliminate UI thread access in MailService
* Make most calls to AccountBackupRestore return immediately w/o DB access
* Move most workers in MailService into async runnables
* Remove account restore / null check from ACTION_SEND_PENDING_EMAIL
* Strengthened unit test on Mailbox.findMailboxOfType() because after
  removing the account check (above), sendPendingMessages depends on
  findMailboxOfType() returning -1 on a missing account.
* Clean up a bunch of warnings (no longer use deprecated Config.LOGD)

Bug: 3133763  (and probably others)
Change-Id: Id39707bca7a8ebf5000f84d542013411ff0f422e
2010-12-22 16:34:48 -08:00
Andy Stadler
9f7e3982ad Reduce UI thread disk access in account settings
This change is in top-level settings for a given account:
* Call saveSettings async on UI changes, instead of synch at onDestroy()
* In loadSettings, get default account id async

Also sprinkled in some TODOs for future whack-a-mole fixes.

Bug: 3133639

Change-Id: I5216c78d28b35fe47e43b48ad0db3a3e57b25004
2010-12-22 13:55:42 -08:00
Marc Blank
84dfef9085 Merge "Put individual account inboxes in widget rotation" 2010-12-22 13:46:11 -08:00
Makoto Onuki
cb89e057ec Assets!
Change-Id: Ibde20ffb64049387fe025293f7d35b342352eb81
2010-12-22 13:16:44 -08:00
Makoto Onuki
22b33a5a4a Show stacktrace when failing to load message body
Change-Id: Ie6b2dda6fa32982e48e052f5f8fe2c699ebc8a01
2010-12-22 12:53:05 -08:00
Marc Blank
66b6b95646 Put individual account inboxes in widget rotation
Change-Id: If1fddc107d9934849bbf273a67dd1db9c2063d99
2010-12-22 12:49:15 -08:00
Makoto Onuki
ac0a11b25a Remove empty.html, which isn't used any more.
Change-Id: I2fa4b669d930cb48b9d03a799ebef7e88c9dfe09
2010-12-22 11:59:31 -08:00
Makoto Onuki
ab1674a2d6 Cosmetic changes to MessageView
- Don't show the progress icon unless loading from network
- Don't show the content until LoadAttachmentsTask finishes
- Disable the fade-in animation.  It causes some weird positioning issue
  with the GL accelerated webview.
- Use WebView.clearView() to clear its content.
- Use the "normal" layout mode, otherwise WebView won't use its entire
  width
- Don't hide the vertical scrollbar

Bug 3287729
Bug 3225068
Bug 3295761
Bug 3304396

Change-Id: Ic4b8baac99b71dc0da58021849ff7c1dbd6dbe55
2010-12-21 17:57:16 -08:00
Marc Blank
9c4458dcd7 Don't try to show thumbnail for unloaded attachments
Bug: 3292689
Change-Id: I7575cb891f0b46c4a8564b5d2c4907025d91c639
2010-12-21 12:37:40 -08:00
Dianne Hackborn
8b9f2a7284 Update to use new Loader callbacks.
Change-Id: Ib478c2f2314bbae4a380539e22892d85dd9a34b5
2010-12-20 23:14:01 -08:00
Marc Blank
d9b251d23b Properly return zero-count cursor from getMatrixCursor
Change-Id: I574528bf56b5a82ecbaab3d3501b26e7afb974ec
2010-12-20 13:58:11 -08:00
Dianne Hackborn
0698f4027f Update to new Loader APIs.
Change-Id: Ic228f7b785f0d902a0188cfe995006b73b8a3c8b
2010-12-20 12:23:13 -08:00
Marc Blank
0fd8ae8808 Pixel perfect Email widget
* Functionally correct and pixel perfect
* All current assets in place

Bug: 3292507
Bug: 3284201
Bug: 3135118
Bug: 3255036
Bug: 3252913

Change-Id: I8fa6752748c74b3a9789a3675da12f6c0c11975f
2010-12-20 11:55:01 -08:00
Marc Blank
13c615314f Fix broken asset (and build)
Change-Id: Ie03ca71dd44f91d43e86d7bc501284b9c1e15f8c
2010-12-17 17:03:03 -08:00
Makoto Onuki
e4355b8be9 Merge "Latest assets from designer git" 2010-12-17 14:30:19 -08:00
Makoto Onuki
22fb45817b Merge "Follow-up to the loader API change" 2010-12-17 13:46:23 -08:00
Makoto Onuki
992d606dd5 Latest assets from designer git
Change-Id: I8837b6ff31ff7af274904e274cdd3ce1e6e21b3e
2010-12-17 13:44:48 -08:00
Makoto Onuki
6a5a39c9e8 Merge "Make reply/forward/etc buttons selectable with keyboard" 2010-12-17 13:44:08 -08:00
Makoto Onuki
28d6e09575 Follow-up to the loader API change
This should fix the "attempt to re-open an already-closed object" exception
from SQLite.

(destroy()s don't have @Override becuase the base method is now depricated
and will be removed someday.)

Bug 3288666

Change-Id: I4780f6c8d89c7204b266608462c0833ad5af4e5f
2010-12-17 13:36:51 -08:00
Marc Blank
120674a05c Merge "Harden AttachmentDownloadService; fix storage calculation" 2010-12-17 12:00:14 -08:00
Marc Blank
edb05ca5ee Harden AttachmentDownloadService; fix storage calculation
Bug: 3292720
Bug: 3286634

Change-Id: I378aac369ee8317c0c41b1f021a3731b81bcb380
2010-12-17 11:28:18 -08:00
Marc Blank
1504ef5fd1 Merge "Remove unused debug flag" 2010-12-17 10:40:13 -08:00
Marc Blank
f3ced5b8a5 Merge "Remove unnecessary logging in Utility.attachmentExists" 2010-12-17 10:36:09 -08:00
Marc Blank
54250337a0 Remove unused debug flag
Change-Id: I88ef517a5b4860c30f1eb2a52f15d8f07c823797
2010-12-17 10:34:43 -08:00
Marc Blank
f995f680a8 Merge "Throw exception on illegal URI's in EmailProvider operations" 2010-12-17 10:21:44 -08:00
Makoto Onuki
73675b666f Merge "New assets from designer's git" 2010-12-17 09:53:08 -08:00
Marc Blank
d3fafabd0f Remove unnecessary logging in Utility.attachmentExists
Bug: 3292689
Change-Id: I937ef44b4576634fd870c759a13f3d27255112bd
2010-12-16 20:09:41 -08:00
Marc Blank
e6a22dff39 Throw exception on illegal URI's in EmailProvider operations
Change-Id: I6354c03e7cead81df3764b7d0bd1be0e90271664
2010-12-16 17:12:42 -08:00
Makoto Onuki
4aa8d1850d Make reply/forward/etc buttons selectable with keyboard
Reply, reply-all, forward, star, and the quick contact badge are now clickable
with the keyboard.

Bug 3292854

Change-Id: Ieeb9f50c9e63f251cafb23255dd3f923b2501849
2010-12-16 16:45:38 -08:00
Andy Stadler
5b393bfece Merge "Show attachment download progress/status properly" 2010-12-16 15:30:12 -08:00
Andy Stadler
6624909533 Show attachment download progress/status properly
Bug: 3291532
Change-Id: I3ceab8a67095190898273b9ccd5a1016218edcb2
2010-12-16 15:09:03 -08:00
Makoto Onuki
dd26e24dca New assets from designer's git
- Note the widget preview has moved from drawable/ to drawable-mdpi/.
- Also note not all mdpi assets have their conterpart in hdpi.
  Not sure if it's okay or not...

Change-Id: I087a800cdbb7ea1732df197827c1a0bfe8c4b809
2010-12-16 13:45:05 -08:00
Dianne Hackborn
80769cefb3 Prepare for some changes to LoaderManager/Loader.
Sorry it is a bit ugly, it is to allow this change to be
checked in prior to the first stage of the framework change
without breaking the build.

Change-Id: I1828579019ac0325d19c070a4c62cd79549e7d51
2010-12-16 13:20:39 -08:00
Makoto Onuki
303816534d Don't show app name on action bar
Need to hide the action bar title when showing account spinner.

Change-Id: Id85fa91f1b89fbd9d2a92bd2d175121176b8a2f0
2010-12-16 11:32:28 -08:00
Makoto Onuki
a9939ab165 Merge "Disable "upgrade accounts" for now." 2010-12-16 11:09:06 -08:00
Marc Blank
4970392341 Synchronize properly with ContentCache; document synchronization
Bug: 3291682
Change-Id: I69c4a3b2ee62a41e6488b63deeb975e510a3f554
2010-12-16 10:39:08 -08:00
Andy Stadler
fdfd466fe6 Update widget with slightly newer drawable
Change-Id: Iea4a1a3e0d8b2601d515c02d792636a416de3756
2010-12-15 22:07:55 -08:00
Andy Stadler
e6214d1f87 Merge "Restrict download/display to "attachment" and "inline"" 2010-12-15 18:06:59 -08:00
Andy Stadler
95701c2f2a Merge "Add widget preview" 2010-12-15 17:52:42 -08:00
Andy Stadler
d2fcefc567 Add widget preview
* Also bumped email version number to 3.0 because the version# may need
  to increment to force refresh of the preview tile.

Bug: 3277453
Change-Id: Ic556e49a4b531fcfdbf3c8f6a2537a34ee0f3c63
2010-12-15 17:49:07 -08:00
Makoto Onuki
b358da3344 Disable "upgrade accounts" for now.
This will not be necessary on tablet.

Bug 3122020

Change-Id: Ifff59a11ccf628fdb5b6d007a7a6591db10153ce
2010-12-15 16:22:04 -08:00