Commit Graph

6251 Commits

Author SHA1 Message Date
Ben Komalo
0cf23308ba Merge "Update headers in message view." 2011-08-10 13:30:02 -07:00
Ben Komalo
3f1a171f0b Prevent NPE when arg cache is not init
Bug: 5146630
Change-Id: I5d90f4c915f1cbb437be88849e179efd29a4b9a9
2011-08-10 10:27:12 -07:00
Ben Komalo
136dedbbd9 Update headers in message view.
- this uses the new gradient/drop shadows
- adds quick contact badge triangle thing
- also puts in contentDescriptions for the reply/all/forward/star
  actions that were lost
- also merges the headers in tablet and phone

Bug: 5144711
Change-Id: Ie2d14c26b7818aa4389731794a15be6c31f4981d
2011-08-10 10:24:24 -07:00
Ben Komalo
2468b54db5 Merge "Fix search styling." 2011-08-09 18:07:00 -07:00
Mindy Pereira
75c86362e0 Merge "Add single chip copy." 2011-08-09 17:32:43 -07:00
Jorge Lugo
0ce564962c Merge "Pre-populate contentDescription for MessageListItems" 2011-08-09 17:26:09 -07:00
Mindy Pereira
4693fecab2 Add single chip copy.
Fixes b/5143564 implement single chip copy

Change-Id: Ibcf058d7a1e8c18258a3117e9968d24a8723953f
2011-08-09 17:02:57 -07:00
Jorge Lugo
56593af65a Pre-populate contentDescription for MessageListItems
Always populate the contentDesription rather than only
when dispatchPopulateAccessibilityEvent() is called. Makes
life easier for testing.

Bug: 5129286
Change-Id: Ide897b81ff30708b9d637cebbf8eb63f06084a74
2011-08-09 16:56:21 -07:00
Ben Komalo
747c4d6f14 Merge "Small fixes to attachments UI" 2011-08-09 16:17:02 -07:00
Ben Komalo
06dee204a0 Small fixes to attachments UI
Bug: 5102245
Change-Id: I71ccce885c563454672e18aa62eac4ab3996146e
2011-08-09 15:07:57 -07:00
Jorge Lugo
757c73634d Merge "Allow pre-populating of content descriptions when testing" 2011-08-09 14:49:50 -07:00
Jorge Lugo
70a3f21041 Allow pre-populating of content descriptions when testing
Creates isTesting flag in MessageListItem. When set to true,
populates the contentDescription of each message on initialization
rather than on touch.

Bug: 5129286
Change-Id: Ia0df93bf7399859a750a3fa01e5429436b9daf16
2011-08-09 13:16:30 -07:00
Ben Komalo
03bc225d08 Show color chips in account spinner.
Bug: 5011742
Change-Id: I6aa3d24b83ee1378bf30fb8466a52c6787d27277
2011-08-09 11:27:47 -07:00
Ben Komalo
2c4a6855ba Make isInboxList check robust to combined views.
rookie mistake :(

Bug: 5141774
Change-Id: Iafc4907a4717143ccf8251a1fb452e1ff00aa5ff
2011-08-09 10:44:43 -07:00
Ben Komalo
e91ff527ed Update backstack model.
This makes "Inbox" the top level with the mailbox list one level under.
All "up"/"back" navigation is now identical and will take you upwards
towards the inbox before falling off to the launcher.

This uses a kludge and the "backstack" of the activity is not actually
represented now by the mPreviousFragment variable; it just uses tricker
in the onBackPressed()/shouldPopFromBackStack() calls to do the right
thing.

Bug: 5111629
Change-Id: Ide88efc78fe4f40d89b5ab83c480318e81902554
2011-08-08 17:38:21 -07:00
Ben Komalo
ed494cd6bb Fix search styling.
This eliminates the excessive padding on the left and makes the hint
text behave according to the new spec (since it uses the new action view
expanded mode).

A later CL will actually change the item to use the action view
facilities of the framework (so we don't have to manage our own custom
views).

Bug: 5109953
Change-Id: Ia3e4a1e64e65b3b8bb3e708b31636f4186acfd46
2011-08-08 17:16:47 -07:00
Ben Komalo
547cae3c8e Move reply/replyall/forward spinner to actionbar.
Bug: 5126487
Change-Id: I56cd8861d6d616d1c4590f06c6f949cd84e5a42b
2011-08-08 15:17:42 -07:00
Ben Komalo
3fdf92c977 Merge "Move IntentUtils to emailcommon." 2011-08-08 15:15:44 -07:00
Eric Fischer
c7355975f0 Merge "Import revised translations." 2011-08-08 15:06:23 -07:00
Jorge Lugo
cf8a36531f Remove done button from edit quick responses
Removes done button from edit quick resposnses fragment and
centers the "create new" button.

Bug: 5111173
Change-Id: Ia847725e5d3bdc67426f76dd386f2263befe4189
2011-08-08 14:56:47 -07:00
Ben Komalo
0e6a521747 Move IntentUtils to emailcommon.
This is needed so Exchange can fire up Email activities.
No change other than the move.

Bug: 5122497
Change-Id: I6ee3f61654745fafd444314ecf75eb8ae6bbd01d
2011-08-08 14:39:19 -07:00
Ben Komalo
507ac98f79 Merge "New attachment icons" 2011-08-08 11:31:20 -07:00
Ben Komalo
e9dad11e1a Merge "Avoid NPE when subject/snippet are null." 2011-08-08 11:30:38 -07:00
Ben Komalo
86ed3c07a8 Merge "Compose UI fixes" 2011-08-08 11:30:04 -07:00
Ben Komalo
6f326631db Merge "Misc style fixes." 2011-08-08 11:29:08 -07:00
Ben Komalo
03b08654e7 New attachment icons
- these were stolen from Gmail's new set. Had to resize a bit in gimp to
fit in redlines

Bug: 4320895
Change-Id: I4e3ad1718af012f2c4ec5a566cf477439bd0d6fa
2011-08-07 16:45:25 -07:00
Ben Komalo
dce6aafe4e Avoid NPE when subject/snippet are null.
There are cases when subject and snippet re null. If the MessageListItem
is not being recycled (i.e. it's the first time), this can be detected
as "no change from the previous state (of being empty)", which doesn't
initialize mText.

Bug: 5129307
Change-Id: I6df910fb365b7e8c1dd298f787d21fbb438830fd
2011-08-07 16:12:35 -07:00
Ben Komalo
03cb4a2135 Merge "Hide sync options and search icon when appropriate" 2011-08-07 15:44:30 -07:00
Ben Komalo
37a7469716 Hide sync options and search icon when appropriate
- hide sync options for mailboxes that aren't actually syncable
- hide search icon for any mailboxes that don't have any server
counterparts

Bug: 5086134
Change-Id: I60d5e5d1225a946464c5ea273c7d4b9299f433e5
2011-08-07 15:40:12 -07:00
Ben Komalo
b86da6b913 Compose UI fixes
- don't show error message if there are chips

Bug: 5126958
Change-Id: I65a22555260b00ded1df49668cde09b03d7f7d90
2011-08-07 15:37:01 -07:00
Ben Komalo
4e200e4bea Misc style fixes.
- split action bar should not happen on compose and settings

Bug: 5127008
Change-Id: I97f2ccac26522831db69216b69a858e382571f5e
2011-08-07 15:33:33 -07:00
Ben Komalo
5b4a214240 Merge "Fix SSL certificate selection for exchange." 2011-08-07 15:04:57 -07:00
Eric Fischer
0d0093eccf Import revised translations.
Change-Id: I065e0f028c31376a2473ad66cda4065fa357403f
2011-08-05 17:00:47 -07:00
Ben Komalo
c42f09c05d Merge "Make compose landscape(phone) go fullscreen" 2011-08-05 16:26:28 -07:00
Ben Komalo
994343b14b Fix SSL certificate selection for exchange.
- Since the Email and Exchange processes do not share UID, we need to
ensure the call to the KeyChain to request the certificate happens in
the Exchange process
- Misc UI fixes so it's not so ugly

Bug: 5117682
Change-Id: If80698850902e0178eb0998493b4cf4b89e2a15c
2011-08-05 11:28:52 -07:00
Ben Komalo
330b1273af Fix show pictures to not look broken.
- this still needs an asset for the "checkmark" button when showing
"always show pictures" prompt - using a checkbox on state as a
placeholder but it's probably not the best thing for it

Bug: 5037485
Change-Id: Iaa1d0f865bf0c01fde0b0cb37ea1c395345ed582
2011-08-05 10:02:30 -07:00
Marc Blank
a08f654a1a Merge "Catch case where provider reports returning null in error" 2011-08-05 09:56:35 -07:00
Marc Blank
577e604df0 Catch case where provider reports returning null in error
* Missed this one

Change-Id: I080bd3b910827336fcfde818564067db5b4ec3cc
2011-08-05 09:50:56 -07:00
Marc Blank
20b511ff68 Handle GB->ICS upgrade of POP3 accounts properly
* Heh.
* We were using the login from the HostAuth in creating the Account
  Manager account, but it should be the email address from the
  Account itself; in IMAP (and usually in POP3) these are the same
* But not for juno.com!
* Updated unit test coming in another CL (tests are broken in a
  strange way, and the bug is FAST-blocker)

Bug: 5110013
Change-Id: Id11799e8b30a0420804f00c2d2f265e44e39c4c0
2011-08-04 19:03:07 -07:00
Ben Komalo
0108aeb5b1 Make compose landscape(phone) go fullscreen
Bug: 5121640
Change-Id: Ib7cc74c2ee494b69c7674d60960df83d6f0d9845
2011-08-04 17:59:03 -07:00
Ben Komalo
6be8cceadd Update sync settings UI to specs
- minor text changes
- use light holo theme
- slight order changes

Bug: 5110452
Change-Id: Icf558ee495860dc97048765d3b8d09d31161dd32
2011-08-03 17:25:10 -07:00
Ben Komalo
876537bb25 Merge "Minor conversation header visual cleanups" 2011-08-03 17:23:55 -07:00
Ben Komalo
f6348449fa Minor conversation header visual cleanups
- fix header bg on tablets
- fix font color in header
- make subject text wrap on phones

Bug: 5110992
Change-Id: I8c58271788f11251906d71073e6e03033c74f38f
2011-08-03 15:45:16 -07:00
Marc Blank
8ba8c1648c Prevent leaking ServiceConnection when process/threads killed
Change-Id: Id5d85fbdd0d044a59cc61748432e3f714264bcd5
2011-08-03 15:40:16 -07:00
Marc Blank
4418596f9b Merge "More whack-a-mole in AttachmentDownloadService" 2011-08-03 14:55:26 -07:00
Marc Blank
c74874c4af Merge "Fix NPE in NfcHandler" 2011-08-03 14:54:46 -07:00
Marc Blank
433b0ed9fe More whack-a-mole in AttachmentDownloadService
Bug: 5115008
Change-Id: I6e5236e08331cfd6a9a11868d97bf5caaf68f6fe
2011-08-03 13:28:01 -07:00
Marc Blank
2208f5dce9 Fix NPE in NfcHandler
Bug: 5115848
Change-Id: I8e581aa77363bc1f33eb3267be5c924fba772aae
2011-08-03 12:56:47 -07:00
Ben Komalo
937fa30b0e Merge "Fix spinner style." 2011-08-03 12:36:38 -07:00
Ben Komalo
5497cae94c Fix issues with state restoration in messagelist
- immediate issue was the the mIsFirstLoad flag was on the Loader
instead of the list - since the Loader is retained on rotation, we
didn't the initial list setup after rotation leaving the list in an
infinite "loading" state
- second issue was that list scroll state was being handled poorly - it
was always saved and restored needlessly. However, if two subsequent
loads happened prior to a layout, saving the list state actually saved
bad values (the restored state only seems to take effect after layout)
- third issue was the footer mode was being handled poorly as well - it
was always updated, which required re-setting the adapter every time,
which reset the scroll position. This was why we were always trying to
save/restore scroll position.

Overall this should speed up the list loading and data updates in the
list by a bunch.

Bug: 5110000
Change-Id: Id2f6db928c095ae10ee55b40e7e9241d70e0bebe
2011-08-03 11:23:15 -07:00