We had two separate "height" values in XML that weren't consistent - one
was used for the coordinates and one was used for the actual item i nthe
adapter. This made things off slightly when the values didn't match
(i.e. on tablet wide mode).
Also fixed an issue with paperclip icon not aligning with date on wide
mode
Bug: 5184169
Change-Id: I1d80bb9c685fdd8216fcaef26bf6ad715eb74c4c
* The existing IMAP search code is well-known to be primitive and
largely broken. In particular, it fails with any non-ASCII
character and with a variety of symbols (e.g. quotes, slashes,
etc.) Basically, it's an accident waiting to happen, returning
empty data sets even when the query might reasonably be expected
(or known) to return valid data.
* The current CL uses the IMAP literal string format to represent
the query text; this string can be sent either in ascii or in
UTF-8, and since it is sent as an octet (byte) count followed by
8-bit data, it also solves any quoting issues that might come
up. So, we kill two birds with one stone.
* The bug in question was punted to a subsequent MR; however, I
think it would be a mistake to ship the code without this
CL, which has been tested against the three common IMAP servers
that we aim to support.
Bug: 4690713
Change-Id: Iaa542bfc56737871f3cbc9c83f0e768415a7f2b6
The MessageListFragment doesn't guarantee to return a non-null Mailbox -
it can be null for virtual mailboxes. We weren't checking this properly.
Bug: 5171577
Change-Id: I272f6a71633680d3424b049d730500fb5f04935e
* The previous text was confusing and potentially misleading.
* The new text is more standard (i.e. used by common clients)
Bug: 5011919
Change-Id: I645c7105ecb36cf58b6c78f6b5bc76f2a17858a3
Removal of the accounts header broke code that assumed the list of
accounts started at index 1. Change code so that it doesn't rely on that
assumption.
Bug: 5171557
Change-Id: Idde445cac914c4a742c54e291d808b991e612c5f
Also turned off extract mode for subject/ body as we already
did this in gmail at request of ux.
Fixes b/5161118 TO field drops all entry chips on rotation
Change-Id: Iada93bbf7ee457801340167aa1086b03b87b4268
- also removes the "Accounts" header as requested by UX
- also tightens up width on tablets a little.
Bug: 5160847
Change-Id: Ie8da1f9d2ec0e53421a435897fc9bb50991a20b6
- tweaked padding for 7" portrait tablets (required copying tablet
layout to two spots so that the 10" portrait tablets still work
normally)
- removed checkboxes on phones and toyed with fonts
Bug: 5165210
Bug: 5156282
Change-Id: Idd3a1c53dc32fefc14854b08a0a9eaebeb5d2f44
The "message saved as draft" toast is distracting when the user is going
to pick an attachment. Stop it from happening.
Bug: 5156507
Change-Id: I3c02ec9c0a17c9d5ea3d02377cfc6d6cd8870a49
- the "offline" icon isn't much use for a lot of our (non-gmail) users
anyways and it takes precious real estate in the header
Bug: 5147565
Change-Id: Iea3df0c1c3756ff749e50ce46a7437488dc169e7
- openMessageSync for EML files touches the provider since it copies
things into the Message table from temporary attachment data. Therefore,
acting on a reload of an EML message will trigger the observer, and do
the same thing.
- still unsure when or how this regressed, but I can't see the previous
behavior being correct regardless
Bug: 5150886
Change-Id: Icfcea7beb95b0fbb026184d6fdecc93c810569ef
This is immediately following some string deletions to avoid warnings in
the build about default translations not being available.
Change-Id: If985d02e42bed2a08901eca5d7b94b9f6fb8069a
* Caching Senders isn't a great idea; during validation, it causes
the bug referenced below. It's a small optimization anyway, so
we'll just get rid of the cache.
* Also, remove unused code
Bug: 5144603
Change-Id: I539284dfa6d457fffd5cb011b8e1db5881249636
