Commit Graph

5979 Commits

Author SHA1 Message Date
Ben Komalo
507ac98f79 Merge "New attachment icons" 2011-08-08 11:31:20 -07:00
Ben Komalo
e9dad11e1a Merge "Avoid NPE when subject/snippet are null." 2011-08-08 11:30:38 -07:00
Ben Komalo
86ed3c07a8 Merge "Compose UI fixes" 2011-08-08 11:30:04 -07:00
Ben Komalo
6f326631db Merge "Misc style fixes." 2011-08-08 11:29:08 -07:00
Ben Komalo
03b08654e7 New attachment icons
- these were stolen from Gmail's new set. Had to resize a bit in gimp to
fit in redlines

Bug: 4320895
Change-Id: I4e3ad1718af012f2c4ec5a566cf477439bd0d6fa
2011-08-07 16:45:25 -07:00
Ben Komalo
dce6aafe4e Avoid NPE when subject/snippet are null.
There are cases when subject and snippet re null. If the MessageListItem
is not being recycled (i.e. it's the first time), this can be detected
as "no change from the previous state (of being empty)", which doesn't
initialize mText.

Bug: 5129307
Change-Id: I6df910fb365b7e8c1dd298f787d21fbb438830fd
2011-08-07 16:12:35 -07:00
Ben Komalo
03cb4a2135 Merge "Hide sync options and search icon when appropriate" 2011-08-07 15:44:30 -07:00
Ben Komalo
37a7469716 Hide sync options and search icon when appropriate
- hide sync options for mailboxes that aren't actually syncable
- hide search icon for any mailboxes that don't have any server
counterparts

Bug: 5086134
Change-Id: I60d5e5d1225a946464c5ea273c7d4b9299f433e5
2011-08-07 15:40:12 -07:00
Ben Komalo
b86da6b913 Compose UI fixes
- don't show error message if there are chips

Bug: 5126958
Change-Id: I65a22555260b00ded1df49668cde09b03d7f7d90
2011-08-07 15:37:01 -07:00
Ben Komalo
4e200e4bea Misc style fixes.
- split action bar should not happen on compose and settings

Bug: 5127008
Change-Id: I97f2ccac26522831db69216b69a858e382571f5e
2011-08-07 15:33:33 -07:00
Ben Komalo
5b4a214240 Merge "Fix SSL certificate selection for exchange." 2011-08-07 15:04:57 -07:00
Ben Komalo
c42f09c05d Merge "Make compose landscape(phone) go fullscreen" 2011-08-05 16:26:28 -07:00
Ben Komalo
994343b14b Fix SSL certificate selection for exchange.
- Since the Email and Exchange processes do not share UID, we need to
ensure the call to the KeyChain to request the certificate happens in
the Exchange process
- Misc UI fixes so it's not so ugly

Bug: 5117682
Change-Id: If80698850902e0178eb0998493b4cf4b89e2a15c
2011-08-05 11:28:52 -07:00
Ben Komalo
330b1273af Fix show pictures to not look broken.
- this still needs an asset for the "checkmark" button when showing
"always show pictures" prompt - using a checkbox on state as a
placeholder but it's probably not the best thing for it

Bug: 5037485
Change-Id: Iaa1d0f865bf0c01fde0b0cb37ea1c395345ed582
2011-08-05 10:02:30 -07:00
Marc Blank
a08f654a1a Merge "Catch case where provider reports returning null in error" 2011-08-05 09:56:35 -07:00
Marc Blank
577e604df0 Catch case where provider reports returning null in error
* Missed this one

Change-Id: I080bd3b910827336fcfde818564067db5b4ec3cc
2011-08-05 09:50:56 -07:00
Marc Blank
20b511ff68 Handle GB->ICS upgrade of POP3 accounts properly
* Heh.
* We were using the login from the HostAuth in creating the Account
  Manager account, but it should be the email address from the
  Account itself; in IMAP (and usually in POP3) these are the same
* But not for juno.com!
* Updated unit test coming in another CL (tests are broken in a
  strange way, and the bug is FAST-blocker)

Bug: 5110013
Change-Id: Id11799e8b30a0420804f00c2d2f265e44e39c4c0
2011-08-04 19:03:07 -07:00
Ben Komalo
0108aeb5b1 Make compose landscape(phone) go fullscreen
Bug: 5121640
Change-Id: Ib7cc74c2ee494b69c7674d60960df83d6f0d9845
2011-08-04 17:59:03 -07:00
Ben Komalo
6be8cceadd Update sync settings UI to specs
- minor text changes
- use light holo theme
- slight order changes

Bug: 5110452
Change-Id: Icf558ee495860dc97048765d3b8d09d31161dd32
2011-08-03 17:25:10 -07:00
Ben Komalo
876537bb25 Merge "Minor conversation header visual cleanups" 2011-08-03 17:23:55 -07:00
Ben Komalo
f6348449fa Minor conversation header visual cleanups
- fix header bg on tablets
- fix font color in header
- make subject text wrap on phones

Bug: 5110992
Change-Id: I8c58271788f11251906d71073e6e03033c74f38f
2011-08-03 15:45:16 -07:00
Marc Blank
8ba8c1648c Prevent leaking ServiceConnection when process/threads killed
Change-Id: Id5d85fbdd0d044a59cc61748432e3f714264bcd5
2011-08-03 15:40:16 -07:00
Marc Blank
4418596f9b Merge "More whack-a-mole in AttachmentDownloadService" 2011-08-03 14:55:26 -07:00
Marc Blank
c74874c4af Merge "Fix NPE in NfcHandler" 2011-08-03 14:54:46 -07:00
Marc Blank
433b0ed9fe More whack-a-mole in AttachmentDownloadService
Bug: 5115008
Change-Id: I6e5236e08331cfd6a9a11868d97bf5caaf68f6fe
2011-08-03 13:28:01 -07:00
Marc Blank
2208f5dce9 Fix NPE in NfcHandler
Bug: 5115848
Change-Id: I8e581aa77363bc1f33eb3267be5c924fba772aae
2011-08-03 12:56:47 -07:00
Ben Komalo
937fa30b0e Merge "Fix spinner style." 2011-08-03 12:36:38 -07:00
Ben Komalo
5497cae94c Fix issues with state restoration in messagelist
- immediate issue was the the mIsFirstLoad flag was on the Loader
instead of the list - since the Loader is retained on rotation, we
didn't the initial list setup after rotation leaving the list in an
infinite "loading" state
- second issue was that list scroll state was being handled poorly - it
was always saved and restored needlessly. However, if two subsequent
loads happened prior to a layout, saving the list state actually saved
bad values (the restored state only seems to take effect after layout)
- third issue was the footer mode was being handled poorly as well - it
was always updated, which required re-setting the adapter every time,
which reset the scroll position. This was why we were always trying to
save/restore scroll position.

Overall this should speed up the list loading and data updates in the
list by a bunch.

Bug: 5110000
Change-Id: Id2f6db928c095ae10ee55b40e7e9241d70e0bebe
2011-08-03 11:23:15 -07:00
Ben Komalo
0a12a6636c Merge "Minor visual fixes in message list" 2011-08-03 10:40:36 -07:00
Ben Komalo
0632f52c3c Fix spinner style.
- use proper theme attribute instead of hardcoded style

Bug: 5115264
Change-Id: Ieb0be8093a0a99655877389353ede4ed8d921262
2011-08-03 10:38:31 -07:00
Adam Powell
72fb0c8b2f Follow framework API changes
Change-Id: Idda69badd6405fe6ddff1d3f4b8ea06332ac3360
2011-08-02 17:00:11 -07:00
Eric Fischer
6bf982abf7 Merge "Import revised translations." 2011-08-02 15:26:54 -07:00
Ben Komalo
2313f48bdc Minor visual fixes in message list
- changed activated font to white
- ensure activated bg is set even for wide (as it shows for a split
  second when you select a message right before the slide animation)
- attempt to make the animation not so abrupt

Bug: 5110992
Change-Id: Ie05e0a6a09afb97155b26d28672d4a2fb79cc563
2011-08-02 15:19:10 -07:00
Ben Komalo
263d0ec707 Fix account spinner width.
- make it take up different size on phones and tablets (also landscape
  phone/portrait phone)
- move unread count outside of the spinner area

Bug: 5108972
Bug: 5111250
Change-Id: I2c16bbb52ce53bbf1c8fe08fd78f1a4b4afd4ccf
2011-08-02 15:04:48 -07:00
Ben Komalo
171d7303c8 Merge "Update message list item redlines." 2011-08-02 14:15:54 -07:00
Ben Komalo
383279a1c5 Update message list item redlines.
- reduces number of "modes" to just two: normal and wide
- consolidate the normal/narrow modes for phone and tablet (as per spec)
  with the only diff on the tablet being side paddings
- fix issue with "white arrow" visual being shown in phone when tapping
  on a message
- make touch computations be resilient to padding values instead of
  assuming that the check/star icons are right at the left/right

Bug: 5103823

Change-Id: I23f967454f7744d9c59256625e302e54a353994a
2011-08-02 14:05:05 -07:00
Marc Blank
36aef9fb74 Add logging to v21->v22 upgrade; small cleanup
Change-Id: I6659998a3ad2490c923061aab5328469c3222e25
2011-08-02 11:51:21 -07:00
Eric Fischer
86b8260b13 Import revised translations.
Change-Id: If14c3c403c66f550b3e034b0f6e2630c584a7a51
2011-08-02 11:25:24 -07:00
Ben Komalo
c1312ff65f Merge "Save IMAP prefix." 2011-08-01 17:45:18 -07:00
Ben Komalo
bcd1339610 Merge "Minor changes to actionbar for message view" 2011-08-01 14:38:56 -07:00
Marc Blank
b6e2bd85a4 Merge "Make "security required" notification ongoing" 2011-08-01 14:20:11 -07:00
Ben Komalo
3baefc2da0 Minor changes to actionbar for message view
- hides the unread count and account name
- makes the subject two lines

Bug: 5103483
Change-Id: Ied537a0c7d8142ecebe49638a814010790433299
2011-08-01 13:58:35 -07:00
Ben Komalo
5125c06cef Save IMAP prefix.
Bug: 4517078
Change-Id: I4f4a1e490abc78088ec8ded4e4627e5da1ac3fd2
2011-08-01 12:56:55 -07:00
Mindy Pereira
b83ecdbb9f Merge "make shorter chips views for landscape where we are turning off extract mode." 2011-08-01 11:18:53 -07:00
Marc Blank
27a04fecfb Fix EmailProvider database upgrades
* Two of the upgrades (v21->v22 and v25->v26) need to be fixed so
  that they don't reference columns that might not exist.
* Oops

Bug: 4439595
Change-Id: I4a8c556be22bb85fb78807416cd1d6b81c6ef118
2011-07-29 21:53:44 -07:00
Ben Komalo
8bdfee9eec Merge "Update assets" 2011-07-29 10:24:38 -07:00
Ben Komalo
d9e8dcae2f Update assets
- updated checkboxes (new ones for sw600dp and phone)
  ones for phone)
- updated stars (new ones for sw600dp and phone)
- added existing cc/bcc icon to menu item
- updated reply/replyall/forward actions to dark themed items (renames
involved)
- update message list backgrounds (new ones for hdpi,xhdpi, renamed
  everything so that there is no message_ or conversation_
  suffixes, also added missing states for some of the selectors)

Change-Id: I1b4f49f206b846566870f5b430e3c6386e621a0c
2011-07-28 14:40:02 -07:00
Marc Blank
1f825aa538 Merge "Catch NPE in AttachmentDownloadService" 2011-07-28 14:22:44 -07:00
Marc Blank
d9b2a8f237 Make "security required" notification ongoing
* While investigating the referenced bug, it was discovered that
  canceling the "security required" notification (with "X", rather
  than the "cancel" option in the dialog) causes the notification
  to be unavailable until a reboot
* This puts the account needing a security update in the position
  of being unsyncable, and might explain the referenced bug (we
  have no confirmation of that step; on the other hand, the tester
  can't now reproduce the problem, so an unusual action like this
  is to be expected)
* The fix consists of making this particular notification "ongoing",
  which prevents the user from dismissing it; arguably, this should
  always have been the case anyway...
* Consider this fix for backport into LTE and MR2 branches

Bug: 5072343
Change-Id: Ia7419236cf9389380d1e079b1a9a6f425015c487
2011-07-28 13:59:16 -07:00
Marc Blank
0306da14e3 Correct recently added EmailProvider logging
Change-Id: Ica61b7bcbe455448a1a261c83defa840ab1abf3e
2011-07-27 21:57:06 -07:00