Commit Graph

4244 Commits

Author SHA1 Message Date
Marc Blank
2fabab32b9 Don't require sSyncLock for sync error map
* Use ConcurrentHashMap; check that this provides enough protection
  for all uses
* This resolves known deadlock issues in ExchangeService

Bug: 3371039

Change-Id: Ie4ccbe7cdfe8c3d4ec7a0f789409126c8c09f8c4
2011-01-21 18:14:04 -08:00
Todd Kennedy
f92dd2bf3e Don't display toast for background download failures
When downloading attachments in the background, do not display any errors
on the display.

NOTE: This is a partial fix for general background attachment downloading issues

bug 3373982

Change-Id: I874ed902bde293303e10308f38b992b2bb15b6aa
2011-01-21 15:17:29 -08:00
Makoto Onuki
d5c6717eeb Merge "Compose: Make sure to unhide CC if not empty for reply-all" into honeycomb 2011-01-21 13:50:00 -08:00
Marc Blank
0a7d214b27 Merge "Delete attachment if there's no corresponding message" into honeycomb 2011-01-21 11:10:09 -08:00
Makoto Onuki
3784b28aa6 Compose: Make sure to unhide CC if not empty for reply-all
Bug 3376821

Change-Id: Ieec04881843717fea55cec8efbf35757042c8d2a
2011-01-21 10:26:07 -08:00
Marc Blank
2ac1833943 Delete attachment if there's no corresponding message
Bug: 3372440
Change-Id: I5c3653c5f27e0aa7bab52ca0d979e14bb6bafc34
2011-01-20 20:32:56 -08:00
Makoto Onuki
7093746dd5 Don't modify content URI to non-email providers
The "?limit=" param is only supported by EmailProvider, so don't add
it to other URIs.

Doing so causes a permission error when opening an EML attachment on gmail,
because we're granted the permission only to the passed URI, but not to
the URI with the "?limit=" param.

Bug 3371630

Change-Id: I88fff88a7e48e5bc958124eedec3e592978a40c7
2011-01-20 16:28:36 -08:00
Makoto Onuki
092ff131af Merge "Expand Reply/Forward/etc buttons for easier tap" into honeycomb 2011-01-20 15:33:32 -08:00
Makoto Onuki
b6acba0e7b Expand Reply/Forward/etc buttons for easier tap
Bug 3372927

Change-Id: I9a6e01c43b4c534b5e6c5c697062313d610c44e6
2011-01-20 14:42:48 -08:00
Marc Blank
554ad34475 Merge "Respect email sync setting" into honeycomb 2011-01-20 14:38:48 -08:00
Marc Blank
6c9911e3fb Merge "Strip content of the "head" tag" into honeycomb 2011-01-20 14:38:26 -08:00
Marc Blank
9dc8ba5cad Strip content of the "head" tag
Bug: 3285281
Change-Id: I1183697ad09fbf8740e3529fecfa59cf6650b2f9
2011-01-20 14:31:09 -08:00
Roy West
41f3170c67 Merge "Remove erroneous extra space char." into honeycomb 2011-01-20 13:26:59 -08:00
Roy West
45939a77b8 Remove erroneous extra space char.
Change-Id: I2a4f107bc7f9ab4d407ddd6740faa2454f9c593f
2011-01-20 13:22:24 -08:00
Todd Kennedy
02ba344cf2 Only show messages from inbox for account & unread views
Use a sub-selection to limit the messages from the inbox. Also add a unit
test to ensure the selections are working correctly.

bug 3368613

Change-Id: Ia24ef6028ded27c69f982ecbc6b67f35f84d1b6d
2011-01-20 13:20:12 -08:00
Roy West
c8f6d57ca5 Change "status bar" to "System bar" for HC and future.
Change-Id: I8bc78dd5071e21cdaa67574994c27781437b2c27
2011-01-20 12:01:08 -08:00
Marc Blank
f24b1a6f3f Respect email sync setting
Bug: 3362586
Change-Id: I585abcec95a668d04d37886b98a6a0b66a0fae4e
2011-01-20 11:59:12 -08:00
Andy Stadler
75e508a794 Merge "Cleanup account name, user name, and summary" into honeycomb 2011-01-20 11:38:21 -08:00
Andy Stadler
373ccb1037 Cleanup account name, user name, and summary
* In AccountSetupNames:
  * Add "Field required" error tag to Names display
* In AccountSettings:
  * Improve IME behavior in text fields - auto-capitalization
  * Prevent empty username
  * Reset empty nickname back to default (email address)
  * Fix broken hint for signature
* Proper trimming in all fields

Bug: 3338435
Change-Id: I2720c4524303ada6dd228866756fc9c3aac173f3
2011-01-20 11:37:39 -08:00
Makoto Onuki
41e1c81b81 Merge "App icon on app drawer shouldn't restart the app" into honeycomb 2011-01-20 10:08:08 -08:00
Todd Kennedy
6bbc689efc Implement final drag & drop spec
Current specification calls for the following:
* Droppable targets: do nothing
* Not droppable targets: grey text (hex #999999)
* Hover over droppable: use label/folder list pressed state
* Hover over not droppable: do nothing
* Destructive targets: background (hex #f10000)

We need to copy the resource from the framework as there is no supported way to
fetch the pressed state drawable during runtime. Adam filed bug 3370043 so we
can specify a drag target state directly in the selector.

bug 3154986

Change-Id: Ifd5c24a3dc46b5a1c64a149904657dda297ed047
2011-01-20 08:41:24 -08:00
Marc Blank
c0a8b2cfb0 Merge "Implement checks before performing background attachment download" into honeycomb 2011-01-19 22:40:35 -08:00
Marc Blank
475c20d3a8 Implement checks before performing background attachment download
Bug: 3339007
Change-Id: I36a8359f3478c37b2ccd6a0cf0381569c592061a
2011-01-19 19:20:38 -08:00
Andy Stadler
b3412d7f5e Merge "Handle leading/trailing space in passwords" into honeycomb 2011-01-19 16:43:22 -08:00
Andy Stadler
858c282277 Handle leading/trailing space in passwords
* Allow, but provide warnings via EditText.setError()
* Remove one last instance of password trim()

Bug: 2981433
Change-Id: I406a4f8b8f27cc5ce90424a8cafe88a677e72f45
Signed-off-by: Andy Stadler <stadler@google.com>
2011-01-19 16:40:15 -08:00
Makoto Onuki
0c75f83f03 App icon on app drawer shouldn't restart the app
When launching Welcome and MessageListXL, make sure they start
as a "main" activity.  This fixes the reported bug.

Bug 3366537

Change-Id: I68facd739bd1dad8eeec52015b0720299d632e11
2011-01-19 16:37:19 -08:00
Todd Kennedy
a33c0c74cc Revert string name change
to prevent churn for the translators, revert the string name change

Change-Id: I22710d810a5f3602ccd53a9cb4d2f31edca572f1
2011-01-19 16:23:42 -08:00
Marc Blank
238b9f2826 Merge "Split out AttachmentInfo into its own top-level class" into honeycomb 2011-01-19 16:19:23 -08:00
Marc Blank
3a761c8038 Split out AttachmentInfo into its own top-level class
* Determine load state and allowability of view/save in constructor
* Extend AttachmentInfo in MessageViewFragmentBase to include views,
  buttons, etc. and to add extra requirements for view/save as
  needed (e.g. availabilty of external storage)

Change-Id: I2ce2b4e71fd784ef0329e391cc0e2d1639f8273c
2011-01-19 16:15:28 -08:00
Makoto Onuki
e539a1973e Merge "Dump widget state to bugreport" into honeycomb 2011-01-19 14:34:39 -08:00
Makoto Onuki
dc200a44a9 Dump widget state to bugreport
This might be helpful someday...

Change-Id: I5a9e0a2948c7ea9fa5c9a7da61d143c10dda7d9a
2011-01-19 14:22:01 -08:00
Makoto Onuki
4911af8879 Merge "Compose: Make the EditTexts easy to focus on" into honeycomb 2011-01-19 13:44:03 -08:00
Makoto Onuki
8ac207f298 Compose: Make the EditTexts easy to focus on
- Now tapping these To/Cc/Bcc/Subject labels moves the focus to
  the corresponding edittext.
- Tapping the bottom part of the screen moves the focus to the
  main EditText.
- Also use paddings instead of margins for the main EditText, to
  expand the hitarea.

Bug 3366831
Bug 3367100

Change-Id: I9b5d18dcc9d7802bfcbd0160befcb008c784d9f7
2011-01-19 13:36:21 -08:00
Andy Stadler
be6910e7a4 Merge "Properly handle unsupported encryption policy" into honeycomb 2011-01-19 12:01:56 -08:00
Andy Stadler
a0d080558f Properly handle unsupported encryption policy
* This fixes the case of:
  * a device that does *not* support device encryption
  * connecting to an account that *does* require device encryption
  * but also supports "non-provisioned devices" (making the encryption
    requirement optional.)
* Added unit test

Bug: 3367191
Change-Id: I894e68c4119a102dad02d2e0815fccdae1e87189
2011-01-19 11:40:48 -08:00
Todd Kennedy
3db3e4b795 widget combined inbox view only shows messages in inbox
instead of showing all messages (e.g. messages in drafts, etc...) the "combined
inbox" view now only messages in the inbox folder. This is now identical to
the "combined inbox" view available in the full email UI.

bug 3368613

Change-Id: I0080b56cd2718a3dce82b279277c63c4f43e86dc
2011-01-19 11:27:41 -08:00
Todd Kennedy
a5de96be71 Merge "Update widget colours / assets according to spec" into honeycomb 2011-01-19 11:03:18 -08:00
Marc Blank
0324017aa0 Fix another case of HTML leakage in snippets
* Add test for this case

Bug: 3285281
Change-Id: If45d33624ac5dbd16d28b45428be29e5a8c51046
2011-01-19 10:59:29 -08:00
Todd Kennedy
290fb65595 Update widget colours / assets according to spec
* Modified font colours for read/un-read emails
* Add chip colours when viewing mail from multiple accounts
* Add calendar icon if message has an invite attachment
* Update background of read/un-read emails

bug 3351761

Change-Id: Id59573d25a6988e9e869335f95778aad28b43912
2011-01-19 09:23:58 -08:00
Marc Blank
985155fddd Merge "Fix regression re: bad folder sync key" into honeycomb 2011-01-19 08:33:40 -08:00
Marc Blank
212a054804 Fix regression re: bad folder sync key
Bug: 3368400
Change-Id: I8bbba33ea0149b6c19a333dcd739208cec6c0475
2011-01-19 08:23:11 -08:00
Adam Cohen
1911a78271 Merge "Updating widget due to API changes." into honeycomb 2011-01-18 23:07:47 -08:00
Andy Stadler
98ea710d18 Add strings before string translation deadline
Bug: 3301398 Phone->Android device in device admin setup screen
Bug: 3296594 email widget doesn't have a "tap to configure"
Bug: 2981433 should not trim leading/trailing spaces from passwords
Bug: 3360873 Attachment pre-caching should be a per-account setting
Bug: 3362752 Malformed message can prevent sync (error while decoding)

Change-Id: Ibed653987ccd5e0e1bd4e195f044c5c1cc06368f
2011-01-18 18:41:24 -08:00
Marc Blank
7a69ac781b Merge "Don't report connection error when account isn't initialized" into honeycomb 2011-01-18 16:22:04 -08:00
Winson Chung
cb8a5544bf Updating widget due to API changes.
Change-Id: I8623c48e912330145cfd325c962574d322ccc6f0
2011-01-18 15:31:17 -08:00
Eric Fischer
6fe0e87b75 Import revised translations. DO NOT MERGE
Change-Id: Ic576d5a1733b93eca24940f38c0b458910f4cba9
2011-01-18 15:05:44 -08:00
Marc Blank
aeea97275d Don't report connection error when account isn't initialized
* We report uninitialized for updateFolderList when no mailboxes
  have been created

Bug: 3235788
Change-Id: I337cfeac83bf320e8078e5a837976414fdd93e0f
2011-01-18 14:19:19 -08:00
Makoto Onuki
3407d9683e Merge "Pixelperfect: message compose" into honeycomb 2011-01-18 11:09:02 -08:00
Makoto Onuki
f72f812f5b Merge "Use proper alert icons on dialogs" into honeycomb 2011-01-18 11:08:56 -08:00
Makoto Onuki
6b21662ba8 Merge "Remove STOPSHIPs regarding CloseTraceCursorWrapper" into honeycomb 2011-01-18 11:08:51 -08:00