Commit Graph

3753 Commits

Author SHA1 Message Date
Makoto Onuki
2ac1eaf8c3 Account selector rework.
- Show email address
- Show inbox unread message count

Initially I thought of using a join to get accounts with their unread
counts with one query, but there were enough subtle issues that I gave up
on the idea.

Instead it uses a MatrixCursor to build a completely new cursor,
based on a regular accounts cursor.

Change-Id: I09e8762f131cc2bd3637e1a3d302088a3b5b2479
2010-11-10 17:41:29 -08:00
Makoto Onuki
fd8ee7bc50 Show confirmation dialog before discarding drafts.
1. This CL implements the most common case, which is pressing the discard
  button on MessageCompose.

2. This CL doesn't change the discard on message list, which is much trickier.
   (We need to check the message type of all messages in the selection,
   as selection can contain any number of any kind of messges in "All Starred")

Bug 3072556

Change-Id: Ib270cae726f8fd5abf7e0e7dfc34ce97019d5301
2010-11-10 14:13:05 -08:00
Makoto Onuki
77303a483b Merge "New message view command layout" 2010-11-10 14:09:38 -08:00
Makoto Onuki
931ca67a1f New message view command layout
UI Changes:
- "Move", "Delete" and "Mark as unread" became action bar commands.
- The message view bottom panel now only has "newer" and "older" buttons,
  with  the current position in the message list.  (shown as POS of TOTAL)
- The buttom panel is now shown only on portrait

Non UI changes
- MessageOrderManager now keeps track of the current cursor position
  as well as the total message count.

- Fixed the "move_action" string, which was wrongly marked as non-translatable.

Bug 3169454

Change-Id: I599543f9e11000a4ee283d31fbd407b2ab53ac44
2010-11-10 11:08:14 -08:00
Eric Fischer
47b53f9c6a Merge "Import revised translations." 2010-11-10 10:26:54 -08:00
Makoto Onuki
6f3d167cfa Don't show non-incoming message in notification.
Filter out non-incoming messages using a subquery.
(because the message table doen't have the mailbox type.)

I was initially thinking of adding a new content URL for
the message table joined with the mailbox table, but it turned out
to be a bit of pain, so ended up using a subquery.
(one of the problems was that both tables had the "_id" field.)

Bug 3177220

Change-Id: I276efb70db1589835f3ddb8c7da4773e72d8691b
2010-11-10 10:22:41 -08:00
Eric Fischer
40ce4e6f9e Import revised translations.
Change-Id: Id4f425eb8a5b3b0dbf6b6825be9b20352bf3a634
2010-11-09 17:40:23 -08:00
Makoto Onuki
d12e56d321 Fix auto-refresh of mailbox list
sEnableUpdate should default to true.

Bug 3180421

Change-Id: I1145846d96bba9e962f598e785daf7ce7ad2404b
2010-11-09 15:27:55 -08:00
Makoto Onuki
b70772daa5 Merge "Code change for new mailbox list layout" 2010-11-09 13:47:08 -08:00
Marc Blank
4ac5286eb9 Merge "Don't allow d&d move from boxes that don't support it" 2010-11-09 13:22:25 -08:00
Marc Blank
e857ff50ec Don't allow d&d move from boxes that don't support it
Bug: 3177021
Change-Id: Ib5cfcef05794d6f83884d97f2096f3d4f6b3295c
2010-11-09 12:21:34 -08:00
Makoto Onuki
9c39deef4e Code change for new mailbox list layout
- Don't show a folder icon for regular mailboxes
- Change the count look
- Don't show counts for Sent/Trash.

Bug 3137965
Bug 3073147

Change-Id: I8fc0af8fc2d51968605fe4b570e5704453092ac7
2010-11-08 18:16:23 -08:00
Makoto Onuki
44904aee53 Merge "Don't call dismiss() in onLoadFinished()." 2010-11-08 15:34:17 -08:00
Makoto Onuki
8197d84734 Don't call dismiss() in onLoadFinished().
It's prohibited.  Instead use a Handler to delay-call it.

Bug 3173317

Change-Id: Ic5ef245a65b3a4eeebabcebd6323b9a7921f34d5
2010-11-08 14:27:13 -08:00
Marc Blank
ad222dc6bb Remove heartbeat logging in ExchangeService
Change-Id: I76be32340811a6a64fb404964d424d881b4db7c5
2010-11-08 13:05:38 -08:00
Marc Blank
6c3fa18356 Reuse mailbox cursor unless boxes have changed
Change-Id: Ic91b1d7bd72e9faf04d3448c1e194663db2c889a
2010-11-08 12:51:55 -08:00
Marc Blank
dc8f1afeb6 Merge "Prevent unnecessary database queries in ExchangeService" 2010-11-05 20:36:19 -07:00
Marc Blank
79ff660aa2 Prevent unnecessary database queries in ExchangeService
Change-Id: Idc3cbc272bd96598b7c7a5de644786bddf1ce03e
2010-11-05 20:35:14 -07:00
Andy Stadler
aa1259b4cf Merge "Handle clicks outside of the "checking..." dialog" 2010-11-05 17:00:53 -07:00
Andy Stadler
992b7e7ed3 Handle clicks outside of the "checking..." dialog
* Clicking outside of the dialog actually "cancels" it
* Need to shut down the checker so it doesn't keep trying to
  update it or close it when done.

Bug: 3120019
Change-Id: I5faa3c78b64d2aafc472b03b8086695edaf0b3fd
2010-11-05 15:54:28 -07:00
Makoto Onuki
30ba828784 Make the account dropdown visible again.
Workaround for the framework issue that the app context doesn't
use the right theme.

Also removed the use of obsolete methods.

Bug 3169944

Change-Id: Ic8d3ba2edb9300df549cb902855025815021ff49
2010-11-05 14:06:29 -07:00
Andy Stadler
4535237e3b Merge "Fix NPE in pop3 checkcapabilities" 2010-11-05 16:52:28 +00:00
Makoto Onuki
467eb0cceb Merge "Reverse FLAG_INCLUDE_QUOTED_TEXT" 2010-11-05 16:44:02 +00:00
Andy Stadler
54ab7a27a3 Fix NPE in pop3 checkcapabilities
* This happens if an open fails immediately (error message in the
  initial banner) followed by a checkSettings.
* The fix is to harden checkSettings to force a clean connection
  every time.

Bug: 2170147
Change-Id: If7403bf517477d2b03b21d71caab511fe45e234c
2010-11-04 23:34:26 -07:00
Andrew Stadler
111d67acc5 Merge "Add YMail and RocketMail, tighten security, cleanup" 2010-11-04 21:46:32 -07:00
Andy Stadler
9ce244b2e3 Hide vibrate notification option on no-vibrate devices
* Check for existence of vibrator, hide option if appropriate
* Notifications with vibration are still OK, they are just ignored
* Minor cleanups & renaming

Bug: 2988758
Change-Id: Ia1fd259f57d33a75a54cf1016f66a1c072aba579
2010-11-04 21:13:45 -07:00
Marc Blank
bad09c18d9 Correct drag & drop mechanics; implement multiple selection
* This CL brings drag&drop move in line with the current document
  describing its functionality in the Email app

Bug: 3135124

TODO: Assets and proper creation of the drag thumbnail based on
  those assets
TODO: Review long-press behavior re: press on subject vs sender

Change-Id: I6e1ee1a1f055feb041a0338f2f5c775a88620595
2010-11-04 17:13:55 -07:00
Makoto Onuki
138abe82e6 Make "Send all messages" a menu option
- Now it's a menu command rather than a button.
- Also string changed from "Send outgoing messages".

Bug 3166218

Change-Id: I82f6188365f9f6bc5a6d40fb23d774eebe181445
2010-11-04 16:53:18 -07:00
Makoto Onuki
0e6254223a Reverse FLAG_INCLUDE_QUOTED_TEXT
To make it compatible with old databases.

(Follow-up to Ie7bcca23)

Bug 3162967

Change-Id: Ie3bbb5089900bb9dbd0834adbdd466fa009245f9
2010-11-04 16:30:03 -07:00
Andrew Stadler
34d0de940b Add YMail and RocketMail, tighten security, cleanup
* Add Ymail and RocketMail as generic yahoo-based email providers
* Add SSL to AOL & AIM
* Remove trustallcertificates from mac.com / me.com
* Minor reorganization to group shared providers together

Bug: 2508590
Change-Id: I7e80aaa587609f95c09e4395055bf515ec43e35e
2010-11-04 16:21:37 -07:00
Makoto Onuki
bf678771b7 UI change: MassageCompose
Basic changes for the new UI.  At this point we don't know what the new phone
UI will look like, so I didn't bother trying to preserve the old behavior on
the phone UI.  The changes will affect both the phone UI and the tablet UI.

- Send, Save Draft, and Discard are now action bar commands.
- Add CC/BCC and Add Attachment are now regular buttons.
- Activity title changed to "Compose"
- Some string changes per new wireframe

Further changes (actual layout changes for the latest wireframe) should be made
only for the xlarge layout.

Change-Id: I68c9c37dfdca6736b1e35053e7f196800fcfce2e
2010-11-04 15:22:25 -07:00
Marc Blank
c81bef6720 Drag & Drop "move to folder"
* Drag & Drop "move to folder" preliminary implementation
* Use "drag handle" button to initiate drag
* Use the message list item itself as the drag thumbnail for
  one item; "Move N messages" for multiple (not implemented)
* Disable MailboxList update during drag
* Use ListView itself as drag/drop target

Bug: 3138004
Change-Id: I9243e4f583cf91caa1b9dd04fd64d52e8b28fa30
2010-11-04 08:45:24 -07:00
Makoto Onuki
e4f8111001 Merge "Fix & clean up intent handling" 2010-11-03 16:53:02 -07:00
Marc Blank
5ade775c8f Merge "Send sync start/finish callbacks in pairs" 2010-11-03 16:01:10 -07:00
Andrew Stadler
997a022c9b Enable zooming in MessageView
Bug: 2282390
Change-Id: Ie5be3c4adb8cc3bef5ccf4fccbfefe8a40872b17
2010-11-03 15:31:08 -07:00
Marc Blank
12b398fac3 Send sync start/finish callbacks in pairs
Bug: 3143544
Change-Id: Ifb8c3c4c12e32df6a7d058446a0279c26048e0f3
2010-11-03 11:18:07 -07:00
Andy Stadler
ba4e72a947 Cleanup various IMAP/POP manual account setup defaults
These defaults affect manual setup only.  There should be no changes
observed in automatic setup, and no changes observed in EAS setup.

* user $email instead of $user as default login
* guess "imap." or "pop3." for server name
* propagate the incoming server name to the outgoing server name, and
  replace "imap.", "pop3." or "pop." with "smtp."

Also, fixed a couple of leftover places where we were trimming
passwords (and should not be, since some people insist on having
spaces in their passwords.)

Bug: 2978634
Change-Id: I9b0e345aa9550b5e1cc29aaa22109f03da61af20
2010-11-03 09:31:45 -07:00
Makoto Onuki
7126e5ae53 Fix & clean up intent handling
- Make sure an account shortcut really opens the account by
  adding the FLAG_ACTIVITY_CLEAR_TOP flag to shortcuts

  * Shortcuts have to be re-created for this fix to take effect.

- Remove Welcome.createOpenCombinedInbox/OutboxIntent, which don't work
  with the new combined view.

  * createOpenCombinedInboxIntent() is not used already
  * createOpenCombinedOutboxIntent() is used, but is not final UI, so
    removing it is okay.

- Fix MessageListXL.actionOpenMailbox -- now it really uses the passed
  mailbox ID.

Bug 3144066

Change-Id: I2ee3f84c62a135351c10266c7ca6d5178c3a0ca2
2010-11-02 18:18:43 -07:00
Andrew Stadler
c50f912676 Inhibit "send" when user is a monkey.
While monkey is active, any clicks on "send" will be mapped to "save".
Drafts will pile up, but nothing will get out.

Bug: 2799956
Change-Id: I300d50001b43c8b61062143f9a0ac914aa2deaca
2010-11-02 16:14:19 -07:00
Andrew Stadler
ba0b1bbc8d Implement text zoom for Message View
* Add preference for default text size
* Move saveSettings logic into onPreferenceChange handler
* Per user tests, default setting is large (not "normal") for XL devices.
* Use setting in MessageView's WebView

TODO: Investigate zooming header (to/from/subject/etc) as well.

Bug: 2282390
Change-Id: If32ed3626244b046941a461f974b3dbdb535f592
2010-11-02 14:58:24 -07:00
Marc Blank
278cb8e3d5 Merge "Support EAS in providers.xml files" 2010-11-01 21:14:46 -07:00
Makoto Onuki
3aca79fbec Switch to the Theme.Holo.Light.Extended theme.
Change-Id: Ib620285c6445f7b7500217cfb354ed1de280d861
2010-11-01 17:19:38 -07:00
Andrew Stadler
cd09545b87 Provide runtime switch for GL acceleration
* new checkbox in debug fragment
* saved value in prefs so it's sticky
* each Activity calls a helper to enable/disable per that flag

Change-Id: I1af1ae9f401bc746cc97da00dfb0e06407b79d46
2010-11-01 16:16:27 -07:00
Makoto Onuki
da0d12ca36 Merge "Add null check to investigate an NPE in restoreMessageWithId." 2010-11-01 15:40:26 -07:00
Makoto Onuki
d281726706 Add null check to investigate an NPE in restoreMessageWithId.
We're getting an NPE in restoreMessageWithId(EmailContent.java:670)
called from MessageFileViewFragment.openMessageSync().

However, there're only two things that can be null in this line,
context and context.getContentResolver(), and either one really
can't be null.  Add explicit null checks to investigate what's going
on.

Bug 3134403

Change-Id: I463b039b6afeda32729f7e6a93edfdb9abf12093
2010-11-01 15:29:11 -07:00
Marc Blank
26e01b4ad2 Merge "Delay appearance of "stop" button when loading attachments" 2010-11-01 14:02:01 -07:00
Marc Blank
fdc41d4ffc Delay appearance of "stop" button when loading attachments
Bug: 3082804
Change-Id: Ib8b0fcec36a7303b2094bd0e49645d11aa2ff2db
2010-11-01 13:48:53 -07:00
Makoto Onuki
bbe25adfc8 Fix crashes related to readParcelable
We need to pass the actual class loader.  Passing null makes it use
the boot class loader, which can't find our classes.

Bug 3073304

Change-Id: I1c72c1d352cfc0a730aba1d83eb048a8cfa95b67
2010-11-01 13:47:53 -07:00
Makoto Onuki
730cc6724a Add "Combined view".
- Don't show combined mailboxes with regular mailboxes in the mailbox list.
- Add "Combined view" to the account selector instead.
- "Combined view" has all the combined mailboxes and accounts.
- Renambed these combined boxes.  (e.g. "Combined inbox" -> "Inbox")
- Regular account view still has "Starred" mailbox, but it's actually
  "combined" and not per-account.
- Re-order special mailboxes per latest wireframe.

Bug 3138004

Change-Id: I4c5860c6774b10c55ba0ca599373e51105432cf8
2010-11-01 11:51:51 -07:00
Makoto Onuki
7c09f04810 Merge "Turn on ActionBar on the 1-pane message list" 2010-11-01 10:56:46 -07:00