Commit Graph

5442 Commits

Author SHA1 Message Date
Marc Blank
5d9f9a41b2 am f39645cc: DO NOT MERGE: Work around framework bug related to service start
* commit 'f39645ccef07a272d42b902c1558c5067ca249c3':
  DO NOT MERGE: Work around framework bug related to service start
2011-05-19 10:56:07 -07:00
Makoto Onuki
01bd33f318 Change to Mailbox/MessageListFragment
- MailboxListFragment.Callback.onMailboxSelected is now split into
  two different callbacks, one for regular selection and the
  other for DnD for clarity.
- Added onDragStarted/Ended to MessageListFragment.Callback
- Changed Log to use this

Change-Id: I8861d3b43aa1b5b17c68c53605270e99733599f4
2011-05-19 10:51:12 -07:00
Marc Blank
f39645ccef DO NOT MERGE: Work around framework bug related to service start
Bug: 4450201
Change-Id: Id49fc4859726600b63a63897966860bc8dc57cda
2011-05-19 10:26:58 -07:00
Ben Komalo
b1c5c75abe am 74cf6fdd: (-s ours) am faaf1e60: Merge "DO NOT MERGE - Email support for 7" devices." into honeycomb-mr2
* commit '74cf6fdd0d8f188ae277f04bb9fa7652a3b24574':
  DO NOT MERGE - Email support for 7" devices.
2011-05-19 08:58:39 -07:00
Ben Komalo
74cf6fdd0d am faaf1e60: Merge "DO NOT MERGE - Email support for 7" devices." into honeycomb-mr2
* commit 'faaf1e60f866dc8dce6267d8e2645aab2fd29f06':
  DO NOT MERGE - Email support for 7" devices.
2011-05-18 18:12:46 -07:00
Ben Komalo
faaf1e60f8 Merge "DO NOT MERGE - Email support for 7" devices." into honeycomb-mr2 2011-05-18 18:08:56 -07:00
Makoto Onuki
92c0d91578 Merge "Clean up Two pane" 2011-05-18 15:14:50 -07:00
Makoto Onuki
49de71e3d2 Clean up Two pane
- Remove bunch of outdated TODOs
- Removed the stack for the back navigation for nested folders.
  Instead, Back/Up will always just navigate to the parent mailbox.
- Two-pane UI controller no longer stores IDs by itself.
  Now it always gets these from installed fragments.
- Added UIController.switchAccount(), which is the same as openAccount
  except it's no-op if the account is already selected.
- Other small clean-ups.

Change-Id: Ie14bc4f4b6b2cf6afb69bc97967c25682d4c7c78
2011-05-18 14:55:44 -07:00
Marc Blank
3f9447a0e1 am b4578815: (-s ours) am 4ad68f6a: (-s ours) am c55e2c88: DO NOT MERGE: Fix serious DST issue with non-DST time zones
* commit 'b4578815e2a287f9d975b8beef1e1546db0e5961':
  DO NOT MERGE: Fix serious DST issue with non-DST time zones
2011-05-18 10:25:06 -07:00
Ben Komalo
9f976e29a0 DO NOT MERGE - Email support for 7" devices.
- use XLarge layout for Large as well in most cases.
- use XLarge portrait behavior for landscape and portrait for message
list collapsing
- some minor tweaks to account setup UI as the XLarge one didn't fit
on large devices with the padding it specified

Change-Id: I2a83e7239019b3feadcabe5fae61f0d13a628471
2011-05-18 10:23:22 -07:00
Todd Kennedy
ff72651145 Clean up shortcut picker
First some cleanup before adding new functionality.

Change-Id: I37339bb8967c2136c8361133d38c2f5ad30ae3e2
2011-05-18 09:59:31 -07:00
Eric Fischer
b212ba8e6b am 4e1a917b: (-s ours) am 9576db71: Import revised translations. DO NOT MERGE
* commit '4e1a917b0ba1e065a82af0720ca3231a0c6aa745':
  Import revised translations.  DO NOT MERGE
2011-05-18 09:21:31 -07:00
Marc Blank
b4578815e2 am 4ad68f6a: (-s ours) am c55e2c88: DO NOT MERGE: Fix serious DST issue with non-DST time zones
* commit '4ad68f6a47f744976801596784c98bdd25ab2df5':
  DO NOT MERGE: Fix serious DST issue with non-DST time zones
2011-05-17 17:51:33 -07:00
Marc Blank
4ad68f6a47 am c55e2c88: DO NOT MERGE: Fix serious DST issue with non-DST time zones
* commit 'c55e2c884743bf5dee7de8d0fda69db3510476fd':
  DO NOT MERGE: Fix serious DST issue with non-DST time zones
2011-05-17 17:46:24 -07:00
Eric Fischer
f0ec26e63e Merge "Import revised translations." 2011-05-17 17:18:40 -07:00
Eric Fischer
8d3c2229bc Import revised translations.
Change-Id: Iad3bda4840f37b7c9c30012ffc657440cc9ac991
2011-05-17 16:59:35 -07:00
Makoto Onuki
3909570d26 Merge "Changes for NO_XXX" 2011-05-17 15:00:42 -07:00
Makoto Onuki
b36ac01792 Changes for NO_XXX
- Added Message.NO_MESSAGE
- Renamed PSEUDO_ACCOUNT_ID_NONE to NO_ACCOUNT
- Removed PARENT_KEY_NONE and use NO_MAILBOX instead
- For starters, cleaned up the UI controllers to use them.

Change-Id: I6cfd87ece2fced8e9f7c76d034c4d1dbf9e4db10
2011-05-17 14:36:00 -07:00
Todd Kennedy
18ad1651fa Merge "Fix display of POP3 mailbox" 2011-05-17 14:35:10 -07:00
Todd Kennedy
e07ecb8864 Fix display of POP3 mailbox
When legacy support for mailboxes with a parent key of '0' was removed, the
parent key for POP3 mailboxes was not updated. This forces the parent key
for all POP3 mailboxes to be "no mailbox". If we ever want to support virtual
mailboxes for POP3 accounts, this will need to be adjusted.

Change-Id: I4ae0e386db4bcdaf559b87ca17cbe0d151dea75b
2011-05-17 14:18:40 -07:00
Marc Blank
a30316d0df Merge "Workaround bug in DPM related to initialization of our admin" 2011-05-17 14:13:59 -07:00
Eric Fischer
4e1a917b0b am 9576db71: Import revised translations. DO NOT MERGE
* commit '9576db716b33ad9d27688daf484d70440f5347a0':
  Import revised translations.  DO NOT MERGE
2011-05-17 13:31:53 -07:00
Marc Blank
6d9d71683a Workaround bug in DPM related to initialization of our admin
Bug: 4436285

Change-Id: If6f0ccaa9e1479fae0dbd1853a462eaf7948ccfc
2011-05-17 13:27:02 -07:00
Eric Fischer
9576db716b Import revised translations. DO NOT MERGE
Change-Id: I015a4828ea6576c553ada0ed6774aaa88be025b5
2011-05-17 13:20:23 -07:00
Todd Kennedy
7bf21c7165 Merge "Fix bug where we fail to acknowledge an APPEND" 2011-05-17 11:07:33 -07:00
Todd Kennedy
518fc490b2 Fix bug where we fail to acknowledge an APPEND
After appending a message to a mailbox (i.e. like appending to the 'sent'
mailbox after composing a new message), we would try to determine if the
append was successful by searching for the message. Most servers return an
APPENDUID response with the message's new UID. However, on those that don't
support APPENDUID, we need to perform a SEARCH for the message id. On one
set of these servers, the search would fail if the query string was
surrounded by parenthesis. However, another set of servers will fail if the
query string is not surroudned by parenthesis. So, we now try both ways.

Change-Id: I5a82ad241fb927e28aa5d05376568d5eac266a95
2011-05-17 10:43:46 -07:00
Makoto Onuki
e211b1a32a Merge "Remove stale proguard entries" 2011-05-17 10:09:00 -07:00
Todd Kennedy
b522a2c166 Merge "Fix Store re-using old data" 2011-05-17 08:49:55 -07:00
Todd Kennedy
581e3c2333 Fix Store re-using old data
The key for the Store cache was not adjusting properly for account
changes (such as port changes, etc...). As such, it was possible to
get an invalid store.

Now, there's problem with leaking Account objects if the store account
changes (see bug 4440839). This is "okay" for now since account changes
are fairly uncommon and Account objects are light. However, this should
be fixed at some point.

Change-Id: I4ddcbc3e2759b7b1374d0300706373678dedec94
2011-05-17 08:48:33 -07:00
Makoto Onuki
54c91f00d7 Use IllegalArgumentException, not InvalidParameterException
Because IllegalArgumentException is the standard one.

Change-Id: Ib4d0bfa88a3d4218148a7cb248d9baa2124a72ba
2011-05-16 17:48:46 -07:00
Makoto Onuki
7e1fa63d75 Merge "Clean up fragments" 2011-05-16 17:22:37 -07:00
Makoto Onuki
954f037d8f Clean up fragments
Now that we don't reuse fragments and always use newInstance() to pass
arguments, there's a bunch of unnecessary things in them, such as
clearContent().

Also now MessageListFragment takes an account ID as an argument.

Bug 4346486

Change-Id: I7e05628c481ed56512c2281257239105d40ee1bc
2011-05-16 17:17:20 -07:00
Todd Kennedy
171c3f2273 Some more re-arrangement of code
No real code changes; just moving where code / constants live. Removed
one unused method of Store.

Change-Id: Ie7532381759a568cb23601e1071c8e199b6beb07
2011-05-16 14:47:49 -07:00
Todd Kennedy
ebece4dbdc Make ImapConnect a top-level class
Split out ImapConnection to its own class. This allows us to update ImapStore
without worrying about links between it and the connection.

Also, added a bit more safety to the classes in terms of correctly freeing
resources. Whenever the connection is closed, it now releases all resources.
Additionally, if the connection is ever put back in the pool, any response
data is released.

Change-Id: Ie3bda40d677707a0d6655f57175e58dece539e19
2011-05-16 14:17:58 -07:00
Makoto Onuki
f8414e2efe Remove stale proguard entries
Change-Id: I9b1be6b96341184b4bf9cd96ae4535cdc19819ce
2011-05-16 13:49:26 -07:00
Makoto Onuki
b9c2e0d5e6 Remove the phone activities from manifest
Apparently I forgot to include this in the huge CL...

Change-Id: I4b3e944b328e6b8a3e20427904ba654dab2041ac
2011-05-16 13:29:27 -07:00
Makoto Onuki
4c4e4c3515 Clean up the method to build message list selection.
- Moved the method to EmailCommon.
- Use *_SELECTION for magic mailboxes
  (meaning we now use subqueries for magic mailbox selections, rather than
   building the mailbox ID list by ourselves)

Change-Id: I3ebf6af62fd912fea6faea0f75e05fc61c87af3b
2011-05-16 11:08:05 -07:00
Ben Komalo
e0bb7e7909 Make Mailbox parcelable
Also fix unit tests

Change-Id: I5f64f53b278b7bc27053d831760b155532a14e33
2011-05-13 18:35:08 -07:00
Ben Komalo
53ea83ebf9 Move Mailbox to top level class.
No other changes made.

Change-Id: I3d8f3c521dc0d902be313b25252b4b6a4a96e7ee
2011-05-13 17:42:02 -07:00
Ben Komalo
373c3e1a56 Merge "Put account email as title on phone settings." 2011-05-13 14:41:22 -07:00
The Android Automerger
75080bfd4c merge in gingerbread-release history after reset to gingerbread 2011-05-13 14:27:35 -07:00
Makoto Onuki
bfac9f2e8a Move some of the log constants from Email to Logging
Change-Id: If9f4e4e3adcdef897a0d6a4e153bb446a8b24fdd
2011-05-13 14:24:38 -07:00
Ben Komalo
3955f6794f Put account email as title on phone settings.
This is kind of a convoluted issue; the framework automatically sets the
breadcrumbs on multi pane settings. However, on single pane, it doesn't
pass any of that breadcrumb info on, and just uses an Intent to start
another instance of the activity with a different Fragment.
Unfortunately, nothing in the default codepath sets the title to
correspond with the breadcrumbs (as it would have been in multipane)

Change-Id: I428642771538bdec3bdaba644f7816a1250ae929
2011-05-13 13:56:26 -07:00
Ben Komalo
8c9167027f Merge "Rename AccountSettingsXL -> AccountSettings" 2011-05-13 13:56:20 -07:00
Makoto Onuki
f1554751c7 Merge "Clean up fragment intallation." 2011-05-13 13:52:05 -07:00
Makoto Onuki
1fba8254c5 Clean up fragment intallation.
Change-Id: Ia9c9d713dc921783995a8a50cc8b256b8392c1a7
2011-05-13 13:18:35 -07:00
Todd Kennedy
4790bd6041 Merge "Remove notifyNewMessages() service callback" 2011-05-13 11:26:04 -07:00
Ben Komalo
2866284a6d Rename AccountSettingsXL -> AccountSettings
This activity already supports phone and tablet mode.
Only renames in this change - no other change.

Change-Id: Ieca17137af45e3860812091f69cd4d9b55ddf3ec
2011-05-13 09:58:15 -07:00
Makoto Onuki
82b136bba2 Merge "Adding hdpi search icon" 2011-05-13 09:29:02 -07:00
Todd Kennedy
577ddb7dd7 Remove notifyNewMessages() service callback
Since the notification controller now operates exclusively using database
observers, there's no reason for the exchange service to call the
notifyNewMessages() service API.

Change-Id: Iaa7e2f5eae786162eab23b02b03ce6d1e8a738e9
2011-05-13 09:10:28 -07:00