ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libgui: Change detachNextBuffer to return sp<GB>

Browse Source 
Changes Surface::detachNextBuffer to return an sp<GraphicBuffer>
instead of an ANativeWindowBuffer* to ensure that reference counting
works correctly.

Bug: 20092217
Change-Id: I3979ea6121aaf14845f0554477b778770413581e
(cherry picked from commit 8b2daa3ca29492b181fb67840640d771c4a2b3ac)
This commit is contained in:
Dan Stoza 2015-04-27 11:06:01 -07:00
parent 63a0f42823
commit d9c4971da2
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/gui/Surface.h
View File

@ -179,7 +179,7 @@ public:
virtual int unlockAndPost(); virtual int unlockAndPost();
virtual int connect(int api, const sp<IProducerListener>& listener); virtual int connect(int api, const sp<IProducerListener>& listener);
virtual int detachNextBuffer(ANativeWindowBuffer** outBuffer, virtual int detachNextBuffer(sp<GraphicBuffer>* outBuffer,
sp<Fence>* outFence); sp<Fence>* outFence);
virtual int attachBuffer(ANativeWindowBuffer*); virtual int attachBuffer(ANativeWindowBuffer*);

4
libs/gui/Surface.cpp
View File

@ -651,7 +651,7 @@ int Surface::disconnect(int api) {
return err; return err;
} }
int Surface::detachNextBuffer(ANativeWindowBuffer** outBuffer, int Surface::detachNextBuffer(sp<GraphicBuffer>* outBuffer,
sp<Fence>* outFence) { sp<Fence>* outFence) {
ATRACE_CALL(); ATRACE_CALL();
ALOGV("Surface::detachNextBuffer"); ALOGV("Surface::detachNextBuffer");
@ -670,7 +670,7 @@ int Surface::detachNextBuffer(ANativeWindowBuffer** outBuffer,
return result; return result;
} }
*outBuffer = buffer.get(); *outBuffer = buffer;
if (fence != NULL && fence->isValid()) { if (fence != NULL && fence->isValid()) {
*outFence = fence; *outFence = fence;
} else { } else {