* commit '8e624d4cad45532c09879356f3adaa3b65fdcfc9': Add a BufferItem parameter to onFrameAvailable
This commit is contained in:
commit
6b7a45859e
@ -44,6 +44,7 @@ class BufferItem : public Flattenable<BufferItem> {
|
||||
// The default value of mBuf, used to indicate this doesn't correspond to a slot.
|
||||
enum { INVALID_BUFFER_SLOT = -1 };
|
||||
BufferItem();
|
||||
~BufferItem();
|
||||
operator IGraphicBufferConsumer::BufferItem() const;
|
||||
|
||||
static const char* scalingModeName(uint32_t scalingMode);
|
||||
|
@ -62,7 +62,7 @@ public:
|
||||
public:
|
||||
ProxyConsumerListener(const wp<ConsumerListener>& consumerListener);
|
||||
virtual ~ProxyConsumerListener();
|
||||
virtual void onFrameAvailable();
|
||||
virtual void onFrameAvailable(const android::BufferItem& item);
|
||||
virtual void onBuffersReleased();
|
||||
virtual void onSidebandStreamChanged();
|
||||
private:
|
||||
|
@ -203,6 +203,16 @@ private:
|
||||
// since the previous buffer might have already been acquired.
|
||||
sp<Fence> mLastQueueBufferFence;
|
||||
|
||||
// Take-a-ticket system for ensuring that onFrame* callbacks are called in
|
||||
// the order that frames are queued. While the BufferQueue lock
|
||||
// (mCore->mMutex) is held, a ticket is retained by the producer. After
|
||||
// dropping the BufferQueue lock, the producer must wait on the condition
|
||||
// variable until the current callback ticket matches its retained ticket.
|
||||
Mutex mCallbackMutex;
|
||||
int mNextCallbackTicket; // Protected by mCore->mMutex
|
||||
int mCurrentCallbackTicket; // Protected by mCallbackMutex
|
||||
Condition mCallbackCondition;
|
||||
|
||||
}; // class BufferQueueProducer
|
||||
|
||||
} // namespace android
|
||||
|
@ -46,7 +46,7 @@ public:
|
||||
//
|
||||
// This is called without any lock held and can be called concurrently
|
||||
// by multiple threads.
|
||||
virtual void onFrameAvailable() = 0;
|
||||
virtual void onFrameAvailable(const BufferItem& item) = 0;
|
||||
};
|
||||
|
||||
virtual ~ConsumerBase();
|
||||
@ -106,7 +106,7 @@ protected:
|
||||
// the ConsumerBase implementation must be called from the derived class.
|
||||
// The ConsumerBase version of onSidebandStreamChanged does nothing and can
|
||||
// be overriden by derived classes if they want the notification.
|
||||
virtual void onFrameAvailable();
|
||||
virtual void onFrameAvailable(const BufferItem& item);
|
||||
virtual void onBuffersReleased();
|
||||
virtual void onSidebandStreamChanged();
|
||||
|
||||
|
@ -28,6 +28,8 @@
|
||||
namespace android {
|
||||
// ----------------------------------------------------------------------------
|
||||
|
||||
class BufferItem;
|
||||
|
||||
// ConsumerListener is the interface through which the BufferQueue notifies
|
||||
// the consumer of events that the consumer may wish to react to. Because
|
||||
// the consumer will generally have a mutex that is locked during calls from
|
||||
@ -43,11 +45,24 @@ public:
|
||||
// frame becomes available for consumption. This means that frames that
|
||||
// are queued while in asynchronous mode only trigger the callback if no
|
||||
// previous frames are pending. Frames queued while in synchronous mode
|
||||
// always trigger the callback.
|
||||
// always trigger the callback. The item passed to the callback will contain
|
||||
// all of the information about the queued frame except for its
|
||||
// GraphicBuffer pointer, which will always be null.
|
||||
//
|
||||
// This is called without any lock held and can be called concurrently
|
||||
// by multiple threads.
|
||||
virtual void onFrameAvailable() = 0; /* Asynchronous */
|
||||
virtual void onFrameAvailable(const BufferItem& item) = 0; /* Asynchronous */
|
||||
|
||||
// onFrameReplaced is called from queueBuffer if the frame being queued is
|
||||
// replacing an existing slot in the queue. Any call to queueBuffer that
|
||||
// doesn't call onFrameAvailable will call this callback instead. The item
|
||||
// passed to the callback will contain all of the information about the
|
||||
// queued frame except for its GraphicBuffer pointer, which will always be
|
||||
// null.
|
||||
//
|
||||
// This is called without any lock held and can be called concurrently
|
||||
// by multiple threads.
|
||||
virtual void onFrameReplaced(const BufferItem& item) {} /* Asynchronous */
|
||||
|
||||
// onBuffersReleased is called to notify the buffer consumer that the
|
||||
// BufferQueue has released its references to one or more GraphicBuffers
|
||||
|
@ -74,7 +74,7 @@ private:
|
||||
// can block if there are too many outstanding buffers. If it blocks, it
|
||||
// will resume when onBufferReleasedByOutput releases a buffer back to the
|
||||
// input.
|
||||
virtual void onFrameAvailable();
|
||||
virtual void onFrameAvailable(const BufferItem& item);
|
||||
|
||||
// From IConsumerListener
|
||||
// We don't care about released buffers because we detach each buffer as
|
||||
|
@ -36,6 +36,8 @@ BufferItem::BufferItem() :
|
||||
mCrop.makeInvalid();
|
||||
}
|
||||
|
||||
BufferItem::~BufferItem() {}
|
||||
|
||||
BufferItem::operator IGraphicBufferConsumer::BufferItem() const {
|
||||
IGraphicBufferConsumer::BufferItem bufferItem;
|
||||
bufferItem.mGraphicBuffer = mGraphicBuffer;
|
||||
|
@ -31,10 +31,11 @@ BufferQueue::ProxyConsumerListener::ProxyConsumerListener(
|
||||
|
||||
BufferQueue::ProxyConsumerListener::~ProxyConsumerListener() {}
|
||||
|
||||
void BufferQueue::ProxyConsumerListener::onFrameAvailable() {
|
||||
void BufferQueue::ProxyConsumerListener::onFrameAvailable(
|
||||
const android::BufferItem& item) {
|
||||
sp<ConsumerListener> listener(mConsumerListener.promote());
|
||||
if (listener != NULL) {
|
||||
listener->onFrameAvailable();
|
||||
listener->onFrameAvailable(item);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -39,7 +39,11 @@ BufferQueueProducer::BufferQueueProducer(const sp<BufferQueueCore>& core) :
|
||||
mSlots(core->mSlots),
|
||||
mConsumerName(),
|
||||
mStickyTransform(0),
|
||||
mLastQueueBufferFence(Fence::NO_FENCE) {}
|
||||
mLastQueueBufferFence(Fence::NO_FENCE),
|
||||
mCallbackMutex(),
|
||||
mNextCallbackTicket(0),
|
||||
mCurrentCallbackTicket(0),
|
||||
mCallbackCondition() {}
|
||||
|
||||
BufferQueueProducer::~BufferQueueProducer() {}
|
||||
|
||||
@ -537,7 +541,10 @@ status_t BufferQueueProducer::queueBuffer(int slot,
|
||||
return BAD_VALUE;
|
||||
}
|
||||
|
||||
sp<IConsumerListener> listener;
|
||||
sp<IConsumerListener> frameAvailableListener;
|
||||
sp<IConsumerListener> frameReplacedListener;
|
||||
int callbackTicket = 0;
|
||||
BufferItem item;
|
||||
{ // Autolock scope
|
||||
Mutex::Autolock lock(mCore->mMutex);
|
||||
|
||||
@ -593,7 +600,6 @@ status_t BufferQueueProducer::queueBuffer(int slot,
|
||||
++mCore->mFrameCounter;
|
||||
mSlots[slot].mFrameNumber = mCore->mFrameCounter;
|
||||
|
||||
BufferItem item;
|
||||
item.mAcquireCalled = mSlots[slot].mAcquireCalled;
|
||||
item.mGraphicBuffer = mSlots[slot].mGraphicBuffer;
|
||||
item.mCrop = crop;
|
||||
@ -614,7 +620,7 @@ status_t BufferQueueProducer::queueBuffer(int slot,
|
||||
// When the queue is empty, we can ignore mDequeueBufferCannotBlock
|
||||
// and simply queue this buffer
|
||||
mCore->mQueue.push_back(item);
|
||||
listener = mCore->mConsumerListener;
|
||||
frameAvailableListener = mCore->mConsumerListener;
|
||||
} else {
|
||||
// When the queue is not empty, we need to look at the front buffer
|
||||
// state to see if we need to replace it
|
||||
@ -630,9 +636,10 @@ status_t BufferQueueProducer::queueBuffer(int slot,
|
||||
}
|
||||
// Overwrite the droppable buffer with the incoming one
|
||||
*front = item;
|
||||
frameReplacedListener = mCore->mConsumerListener;
|
||||
} else {
|
||||
mCore->mQueue.push_back(item);
|
||||
listener = mCore->mConsumerListener;
|
||||
frameAvailableListener = mCore->mConsumerListener;
|
||||
}
|
||||
}
|
||||
|
||||
@ -643,6 +650,9 @@ status_t BufferQueueProducer::queueBuffer(int slot,
|
||||
mCore->mTransformHint, mCore->mQueue.size());
|
||||
|
||||
ATRACE_INT(mCore->mConsumerName.string(), mCore->mQueue.size());
|
||||
|
||||
// Take a ticket for the callback functions
|
||||
callbackTicket = mNextCallbackTicket++;
|
||||
} // Autolock scope
|
||||
|
||||
// Wait without lock held
|
||||
@ -654,9 +664,27 @@ status_t BufferQueueProducer::queueBuffer(int slot,
|
||||
mLastQueueBufferFence = fence;
|
||||
}
|
||||
|
||||
// Call back without lock held
|
||||
if (listener != NULL) {
|
||||
listener->onFrameAvailable();
|
||||
// Don't send the GraphicBuffer through the callback, and don't send
|
||||
// the slot number, since the consumer shouldn't need it
|
||||
item.mGraphicBuffer.clear();
|
||||
item.mSlot = BufferItem::INVALID_BUFFER_SLOT;
|
||||
|
||||
// Call back without the main BufferQueue lock held, but with the callback
|
||||
// lock held so we can ensure that callbacks occur in order
|
||||
{
|
||||
Mutex::Autolock lock(mCallbackMutex);
|
||||
while (callbackTicket != mCurrentCallbackTicket) {
|
||||
mCallbackCondition.wait(mCallbackMutex);
|
||||
}
|
||||
|
||||
if (frameAvailableListener != NULL) {
|
||||
frameAvailableListener->onFrameAvailable(item);
|
||||
} else if (frameReplacedListener != NULL) {
|
||||
frameReplacedListener->onFrameReplaced(item);
|
||||
}
|
||||
|
||||
++mCurrentCallbackTicket;
|
||||
mCallbackCondition.broadcast();
|
||||
}
|
||||
|
||||
return NO_ERROR;
|
||||
|
@ -98,7 +98,7 @@ void ConsumerBase::freeBufferLocked(int slotIndex) {
|
||||
mSlots[slotIndex].mFrameNumber = 0;
|
||||
}
|
||||
|
||||
void ConsumerBase::onFrameAvailable() {
|
||||
void ConsumerBase::onFrameAvailable(const BufferItem& item) {
|
||||
CB_LOGV("onFrameAvailable");
|
||||
|
||||
sp<FrameAvailableListener> listener;
|
||||
@ -109,7 +109,7 @@ void ConsumerBase::onFrameAvailable() {
|
||||
|
||||
if (listener != NULL) {
|
||||
CB_LOGV("actually calling onFrameAvailable");
|
||||
listener->onFrameAvailable();
|
||||
listener->onFrameAvailable(item);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -21,6 +21,7 @@
|
||||
#include <binder/Parcel.h>
|
||||
|
||||
#include <gui/IConsumerListener.h>
|
||||
#include <gui/BufferItem.h>
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
namespace android {
|
||||
@ -39,9 +40,10 @@ public:
|
||||
: BpInterface<IConsumerListener>(impl) {
|
||||
}
|
||||
|
||||
virtual void onFrameAvailable() {
|
||||
virtual void onFrameAvailable(const BufferItem& item) {
|
||||
Parcel data, reply;
|
||||
data.writeInterfaceToken(IConsumerListener::getInterfaceDescriptor());
|
||||
data.write(item);
|
||||
remote()->transact(ON_FRAME_AVAILABLE, data, &reply, IBinder::FLAG_ONEWAY);
|
||||
}
|
||||
|
||||
@ -66,18 +68,20 @@ status_t BnConsumerListener::onTransact(
|
||||
uint32_t code, const Parcel& data, Parcel* reply, uint32_t flags)
|
||||
{
|
||||
switch(code) {
|
||||
case ON_FRAME_AVAILABLE:
|
||||
case ON_FRAME_AVAILABLE: {
|
||||
CHECK_INTERFACE(IConsumerListener, data, reply);
|
||||
onFrameAvailable();
|
||||
return NO_ERROR;
|
||||
case ON_BUFFER_RELEASED:
|
||||
BufferItem item;
|
||||
data.read(item);
|
||||
onFrameAvailable(item);
|
||||
return NO_ERROR; }
|
||||
case ON_BUFFER_RELEASED: {
|
||||
CHECK_INTERFACE(IConsumerListener, data, reply);
|
||||
onBuffersReleased();
|
||||
return NO_ERROR;
|
||||
case ON_SIDEBAND_STREAM_CHANGED:
|
||||
return NO_ERROR; }
|
||||
case ON_SIDEBAND_STREAM_CHANGED: {
|
||||
CHECK_INTERFACE(IConsumerListener, data, reply);
|
||||
onSidebandStreamChanged();
|
||||
return NO_ERROR;
|
||||
return NO_ERROR; }
|
||||
}
|
||||
return BBinder::onTransact(code, data, reply, flags);
|
||||
}
|
||||
|
@ -98,7 +98,7 @@ void StreamSplitter::setName(const String8 &name) {
|
||||
mInput->setConsumerName(name);
|
||||
}
|
||||
|
||||
void StreamSplitter::onFrameAvailable() {
|
||||
void StreamSplitter::onFrameAvailable(const BufferItem& /* item */) {
|
||||
ATRACE_CALL();
|
||||
Mutex::Autolock lock(mMutex);
|
||||
|
||||
|
@ -67,7 +67,7 @@ protected:
|
||||
};
|
||||
|
||||
struct DummyConsumer : public BnConsumerListener {
|
||||
virtual void onFrameAvailable() {}
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {}
|
||||
virtual void onBuffersReleased() {}
|
||||
virtual void onSidebandStreamChanged() {}
|
||||
};
|
||||
|
@ -44,7 +44,7 @@ public:
|
||||
mPendingFrames--;
|
||||
}
|
||||
|
||||
virtual void onFrameAvailable() {
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {
|
||||
Mutex::Autolock lock(mMutex);
|
||||
mPendingFrames++;
|
||||
mFrameCondition.signal();
|
||||
|
@ -35,7 +35,7 @@ public:
|
||||
mPendingFrames--;
|
||||
}
|
||||
|
||||
virtual void onFrameAvailable() {
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {
|
||||
Mutex::Autolock lock(mMutex);
|
||||
mPendingFrames++;
|
||||
mCondition.signal();
|
||||
|
@ -65,7 +65,7 @@ const sp<Fence> QUEUE_BUFFER_INPUT_FENCE = Fence::NO_FENCE;
|
||||
}; // namespace anonymous
|
||||
|
||||
struct DummyConsumer : public BnConsumerListener {
|
||||
virtual void onFrameAvailable() {}
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {}
|
||||
virtual void onBuffersReleased() {}
|
||||
virtual void onSidebandStreamChanged() {}
|
||||
};
|
||||
|
@ -46,7 +46,7 @@ protected:
|
||||
};
|
||||
|
||||
struct DummyListener : public BnConsumerListener {
|
||||
virtual void onFrameAvailable() {}
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {}
|
||||
virtual void onBuffersReleased() {}
|
||||
virtual void onSidebandStreamChanged() {}
|
||||
};
|
||||
|
@ -130,7 +130,7 @@ protected:
|
||||
}
|
||||
|
||||
// This should be called by GLConsumer on the producer thread.
|
||||
virtual void onFrameAvailable() {
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {
|
||||
Mutex::Autolock lock(mMutex);
|
||||
ALOGV("+onFrameAvailable");
|
||||
mFrameAvailable = true;
|
||||
|
@ -101,7 +101,7 @@ TEST_F(EGLTest, EGLTerminateSucceedsWithRemainingObjects) {
|
||||
EXPECT_TRUE(eglChooseConfig(mEglDisplay, attrs, &config, 1, &numConfigs));
|
||||
|
||||
struct DummyConsumer : public BnConsumerListener {
|
||||
virtual void onFrameAvailable() {}
|
||||
virtual void onFrameAvailable(const BufferItem& /* item */) {}
|
||||
virtual void onBuffersReleased() {}
|
||||
virtual void onSidebandStreamChanged() {}
|
||||
};
|
||||
|
@ -122,7 +122,7 @@ status_t FramebufferSurface::nextBuffer(sp<GraphicBuffer>& outBuffer, sp<Fence>&
|
||||
}
|
||||
|
||||
// Overrides ConsumerBase::onFrameAvailable(), does not call base class impl.
|
||||
void FramebufferSurface::onFrameAvailable() {
|
||||
void FramebufferSurface::onFrameAvailable(const BufferItem& /* item */) {
|
||||
sp<GraphicBuffer> buf;
|
||||
sp<Fence> acquireFence;
|
||||
status_t err = nextBuffer(buf, acquireFence);
|
||||
|
@ -56,7 +56,7 @@ public:
|
||||
private:
|
||||
virtual ~FramebufferSurface() { }; // this class cannot be overloaded
|
||||
|
||||
virtual void onFrameAvailable();
|
||||
virtual void onFrameAvailable(const BufferItem& item);
|
||||
virtual void freeBufferLocked(int slotIndex);
|
||||
|
||||
virtual void dumpLocked(String8& result, const char* prefix) const;
|
||||
|
@ -159,7 +159,7 @@ void Layer::onLayerDisplayed(const sp<const DisplayDevice>& /* hw */,
|
||||
}
|
||||
}
|
||||
|
||||
void Layer::onFrameAvailable() {
|
||||
void Layer::onFrameAvailable(const BufferItem& /* item */) {
|
||||
android_atomic_inc(&mQueuedFrames);
|
||||
mFlinger->signalLayerUpdate();
|
||||
}
|
||||
|
@ -330,7 +330,7 @@ protected:
|
||||
|
||||
private:
|
||||
// Interface implementation for SurfaceFlingerConsumer::ContentsChangedListener
|
||||
virtual void onFrameAvailable();
|
||||
virtual void onFrameAvailable(const BufferItem& item);
|
||||
virtual void onSidebandStreamChanged();
|
||||
|
||||
void commitTransaction();
|
||||
|
Loading…
Reference in New Issue
Block a user