ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

am 3ed2736c: am b21a4e3b: ConsumerBase: free buffers outside the lock

Browse Source 
* commit '3ed2736c10efb2f18062591e308036837d9725a4':
  ConsumerBase: free buffers outside the lock
This commit is contained in:
Jamie Gennis 2012-12-06 19:00:57 -08:00 committed by Android Git Automerger
commit 05989772d5
1 changed files with 24 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libs/gui/ConsumerBase.cpp
View File

@ -109,6 +109,9 @@ void ConsumerBase::onFrameAvailable() {
}
void ConsumerBase::onBuffersReleased() {
sp<GraphicBuffer> bufRefs[BufferQueue::NUM_BUFFER_SLOTS];
{ // Scope for the lock
Mutex::Autolock lock(mMutex);
CB_LOGV("onBuffersReleased");
@ -122,11 +125,22 @@ void ConsumerBase::onBuffersReleased() {
mBufferQueue->getReleasedBuffers(&mask);
for (int i = 0; i < BufferQueue::NUM_BUFFER_SLOTS; i++) {
if (mask & (1 << i)) {
// Grab a local reference to the buffers so that they don't
// get freed while the lock is held.
bufRefs[i] = mSlots[i].mGraphicBuffer;
freeBufferLocked(i);
}
}
}
// Clear the local buffer references. This would happen automatically
// when the array gets dtor'd, but I'm doing it explicitly for clarity.
for (int i = 0; i < BufferQueue::NUM_BUFFER_SLOTS; i++) {
bufRefs[i].clear();
}
}
void ConsumerBase::abandon() {
CB_LOGV("abandon");
Mutex::Autolock lock(mMutex);