ADHOC
/
replicant-vendor_cmsdk
3
0
Fork 0
Code Issues Pull Requests Releases Activity

Remove public default constructor from CMWeatherManager.RequestStatus [1/2] 

RequestStatus holds only final constants and should not provide
public constructors. This class also should be final.

This patch also fix minor typos on RequestStatus javadoc

Change-Id: I0deb1d6a9b23eed83451dec352bb4c410e2378d6
TICKET: CYNGNOS-2441
This commit is contained in:
Luis Vidal 2016-04-13 17:37:33 -07:00
parent b49885a649
commit ad5e5d019f
3 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/cm_current.txt
View File

@ -1366,8 +1366,7 @@ package cyanogenmod.weather {
method public abstract void onLookupCityRequestCompleted(int, java.util.List<cyanogenmod.weather.WeatherLocation>);
}
public static class CMWeatherManager.RequestStatus {
ctor public CMWeatherManager.RequestStatus();
public static final class CMWeatherManager.RequestStatus {
field public static final int ALREADY_IN_PROGRESS = -3; // 0xfffffffd
field public static final int COMPLETED = 1; // 0x1
field public static final int FAILED = -1; // 0xffffffff

11
sdk/src/java/cyanogenmod/weather/CMWeatherManager.java
View File

@ -57,13 +57,16 @@ public class CMWeatherManager {
/**
* The different request statuses
*/
public static class RequestStatus {
public static final class RequestStatus {
private RequestStatus() {}
/**
* Request Successfully completed
* Request successfully completed
*/
public static final int COMPLETED = 1;
/**
* An error occurred while trying to honor the request.
* An error occurred while trying to honor the request
*/
public static final int FAILED = -1;
/**
@ -71,7 +74,7 @@ public class CMWeatherManager {
*/
public static final int SUBMITTED_TOO_SOON = -2;
/**
* Another request in already in progress
* Another request is already in progress
*/
public static final int ALREADY_IN_PROGRESS = -3;
/**

3
system-api/cm_system-current.txt
View File

@ -1366,8 +1366,7 @@ package cyanogenmod.weather {
method public abstract void onLookupCityRequestCompleted(int, java.util.List<cyanogenmod.weather.WeatherLocation>);
}
public static class CMWeatherManager.RequestStatus {
ctor public CMWeatherManager.RequestStatus();
public static final class CMWeatherManager.RequestStatus {
field public static final int ALREADY_IN_PROGRESS = -3; // 0xfffffffd
field public static final int COMPLETED = 1; // 0x1
field public static final int FAILED = -1; // 0xffffffff