ADHOC/replicant-vendor_cmsdk
3
0
Fork 0
Code Issues Pull Requests Releases Activity

Improve several permission description Strings.

Browse Source 
The MODIFY_NETWORK_SETTINGS and MODIFY_SOUND_SETTINGS permissions were
not descriptive enough. Improve the strings to enumerate exactly what
settings these permissions protect.

Fixes FOR-23.

Change-Id: Idd64738c21d879462a7e7e6c65ceefdc771f1bcd
This commit is contained in:
Matt Garnes 2015-10-14 13:27:08 -07:00
parent fe7a368a69
commit 9e69abb862
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cm/res/AndroidManifest.xml
View File

@ -36,7 +36,7 @@
android:icon="@drawable/ic_launcher_cyanogenmod" android:icon="@drawable/ic_launcher_cyanogenmod"
android:protectionLevel="normal" /> android:protectionLevel="normal" />
<!-- Allows system applications to make changes to a subset of system network settings --> <!-- Allows an app to make changes to the airplane mode and mobile data network settings -->
<permission android:name="cyanogenmod.permission.MODIFY_NETWORK_SETTINGS" <permission android:name="cyanogenmod.permission.MODIFY_NETWORK_SETTINGS"
android:label="@string/permlab_modifyNetworkSettings" android:label="@string/permlab_modifyNetworkSettings"
android:description="@string/permdesc_modifyNetworkSettings" android:description="@string/permdesc_modifyNetworkSettings"
@ -44,7 +44,7 @@
androidprv:allowViaWhitelist="true" androidprv:allowViaWhitelist="true"
android:protectionLevel="system|signature" /> android:protectionLevel="system|signature" />
<!-- Allows system applications to make changes to a subset of system sound settings --> <!-- Allows an app to make changes to the interruption mode sound settings -->
<permission android:name="cyanogenmod.permission.MODIFY_SOUND_SETTINGS" <permission android:name="cyanogenmod.permission.MODIFY_SOUND_SETTINGS"
android:label="@string/permlab_modifySoundSettings" android:label="@string/permlab_modifySoundSettings"
android:description="@string/permdesc_modifySoundSettings" android:description="@string/permdesc_modifySoundSettings"

4
cm/res/res/values/strings.xml
View File

@ -22,10 +22,10 @@
<string name="permdesc_publishCustomTile">Allows an app to publish a quick settings tile.</string> <string name="permdesc_publishCustomTile">Allows an app to publish a quick settings tile.</string>
<string name="permlab_modifyNetworkSettings">change system network settings</string> <string name="permlab_modifyNetworkSettings">change system network settings</string>
<string name="permdesc_modifyNetworkSettings">Allows an app to make changes to a restricted set of system network settings.</string> <string name="permdesc_modifyNetworkSettings">Allows an app to make changes to the airplane mode and mobile data network settings.</string>
<string name="permlab_modifySoundSettings">change system sound settings</string> <string name="permlab_modifySoundSettings">change system sound settings</string>
<string name="permdesc_modifySoundSettings">Allows an app to make changes to a restricted set of system sound settings.</string> <string name="permdesc_modifySoundSettings">Allows an app to make changes to the interruption mode sound settings.</string>
<string name="permlab_bindCustomTileListenerService">bind to a custom tile listener service</string> <string name="permlab_bindCustomTileListenerService">bind to a custom tile listener service</string>
<string name="permdesc_bindCustomTileListenerService">Allows the app to bind to the top-level interface of a custom tile listener service.</string> <string name="permdesc_bindCustomTileListenerService">Allows the app to bind to the top-level interface of a custom tile listener service.</string>