From 2d8ae47d9919f83cdf7244c3eeb34f919d83a33d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Wed, 9 Oct 2019 15:46:52 -0400 Subject: [PATCH] Disable phone number lookup settings during upgrade MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This disables during the upgrade settings that cause private information leaking through phone number lookup feature. Signed-off-by: Joonas Kylmälä Acked-by: Denis 'GNUtoo' Carikli --- .../cmsettings/CMDatabaseHelper.java | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/packages/CMSettingsProvider/src/org/cyanogenmod/cmsettings/CMDatabaseHelper.java b/packages/CMSettingsProvider/src/org/cyanogenmod/cmsettings/CMDatabaseHelper.java index d35f449..1242c1a 100644 --- a/packages/CMSettingsProvider/src/org/cyanogenmod/cmsettings/CMDatabaseHelper.java +++ b/packages/CMSettingsProvider/src/org/cyanogenmod/cmsettings/CMDatabaseHelper.java @@ -46,7 +46,7 @@ public class CMDatabaseHelper extends SQLiteOpenHelper{ private static final boolean LOCAL_LOGV = false; private static final String DATABASE_NAME = "cmsettings.db"; - private static final int DATABASE_VERSION = 6; + private static final int DATABASE_VERSION = 7; public static class CMTableNames { public static final String TABLE_SYSTEM = "system"; @@ -232,6 +232,25 @@ public class CMDatabaseHelper extends SQLiteOpenHelper{ } upgradeVersion = 6; } + + if (upgradeVersion < 7) { + if (mUserHandle == UserHandle.USER_OWNER) { + db.beginTransaction(); + SQLiteStatement stmt = null; + try { + stmt = db.compileStatement("UPDATE system SET value = 0 WHERE name IN (?,?,?);"); + stmt.bindString(1, CMSettings.System.ENABLE_FORWARD_LOOKUP); + stmt.bindString(2, CMSettings.System.ENABLE_PEOPLE_LOOKUP); + stmt.bindString(3, CMSettings.System.ENABLE_REVERSE_LOOKUP); + stmt.execute(); + db.setTransactionSuccessful(); + } finally { + if (stmt != null) stmt.close(); + db.endTransaction(); + } + } + upgradeVersion = 7; + } // *** Remember to update DATABASE_VERSION above! if (upgradeVersion < newVersion) {