From 153bd2287cf5658d8eba9e9179404c223fbb9d51 Mon Sep 17 00:00:00 2001 From: Steve Kondik Date: Tue, 26 Apr 2016 22:31:28 -0700 Subject: [PATCH] livedisplay: Fix another transition issue * If the screen is off during the entire transition period, when we turn the display back on it is not updated with the correct color temperature. * The code here is trying to be Mr. Smarty Pants and avoid extra updates, but it's totally pointless and also broken. There's no ill effects from writing to the hardware when the screen comes on, and updateColorTemperature already has all the other conditionals we need. * Just call updateColorTemperature every time, regardless. The LiveDisplayService ensures the callbacks run on the handler thread and all this crap can be removed. Change-Id: Ib9560e13870a5c6bbe9c5a26fad40f5ec1cefa83 --- .../internal/display/ColorTemperatureController.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/cm/lib/main/java/org/cyanogenmod/platform/internal/display/ColorTemperatureController.java b/cm/lib/main/java/org/cyanogenmod/platform/internal/display/ColorTemperatureController.java index d20c002..3184d71 100644 --- a/cm/lib/main/java/org/cyanogenmod/platform/internal/display/ColorTemperatureController.java +++ b/cm/lib/main/java/org/cyanogenmod/platform/internal/display/ColorTemperatureController.java @@ -96,19 +96,12 @@ public class ColorTemperatureController extends LiveDisplayFeature { @Override protected void onScreenStateChanged() { - // pause/continue transition - if (isTransitioning()) { - if (isScreenOn()) { - mHandler.post(mTransitionRunnable); - } else { - mHandler.removeCallbacks(mTransitionRunnable); - } - } + updateColorTemperature(); } @Override protected void onTwilightUpdated() { - mHandler.post(mTransitionRunnable); + updateColorTemperature(); } @Override