From 716ffa86dc68d72a6eb031a7ed52759b2298d4f3 Mon Sep 17 00:00:00 2001 From: cretin45 Date: Wed, 21 Jan 2015 15:55:03 -0800 Subject: [PATCH] SetupWizard: More refactor to match redlines Change-Id: I74f422ba0c294d5e91aefb9356458c681cc53b37 --- res/anim/slide_left.xml | 13 +- res/anim/slide_right.xml | 13 +- res/drawable/divider.xml | 2 +- res/drawable/reveal.xml | 19 ++ res/layout-land/logo_header.xml | 49 ++++ res/layout-land/setup_welcome_page.xml | 44 +++ res/layout/choose_data_sim_page.xml | 57 ++-- res/layout/header.xml | 4 +- res/layout/header_condensed.xml | 4 +- res/layout/location_settings.xml | 234 ++++++++-------- res/layout/logo_header.xml | 4 +- res/layout/mobile_data_settings.xml | 127 +++++---- res/layout/setup_cyanogen_services.xml | 253 ++++++++++-------- res/layout/setup_datetime_page.xml | 157 ++++++----- res/layout/setup_finalizing.xml | 13 - res/layout/setup_finished_page.xml | 33 ++- res/layout/setup_main.xml | 23 +- res/layout/setup_welcome_page.xml | 40 ++- res/layout/sim_missing_page.xml | 66 +++-- res/values-land/colors.xml | 19 ++ res/values-land/dimens.xml | 2 +- res/values/colors.xml | 5 +- res/values/dimens.xml | 5 +- res/values/strings.xml | 6 +- res/values/styles.xml | 13 +- .../setupwizard/setup/AbstractSetupData.java | 5 - .../setup/CyanogenServicesPage.java | 42 +-- .../setupwizard/setup/FinishPage.java | 66 ++++- .../setup/LocationSettingsPage.java | 5 - .../setupwizard/setup/SetupDataCallbacks.java | 4 - .../setupwizard/setup/SetupPage.java | 21 +- .../setupwizard/setup/WelcomePage.java | 10 +- .../setupwizard/ui/LocalePicker.java | 6 +- .../setupwizard/ui/SetupPageFragment.java | 16 +- .../setupwizard/ui/SetupWizardActivity.java | 44 +-- 35 files changed, 822 insertions(+), 602 deletions(-) create mode 100644 res/drawable/reveal.xml create mode 100644 res/layout-land/logo_header.xml create mode 100644 res/layout-land/setup_welcome_page.xml delete mode 100644 res/layout/setup_finalizing.xml create mode 100644 res/values-land/colors.xml diff --git a/res/anim/slide_left.xml b/res/anim/slide_left.xml index fa15cc7..283638e 100644 --- a/res/anim/slide_left.xml +++ b/res/anim/slide_left.xml @@ -1,8 +1,9 @@ - - + + diff --git a/res/anim/slide_right.xml b/res/anim/slide_right.xml index 849f0c8..49de7e9 100644 --- a/res/anim/slide_right.xml +++ b/res/anim/slide_right.xml @@ -1,8 +1,9 @@ - - + + diff --git a/res/drawable/divider.xml b/res/drawable/divider.xml index fb38c5b..34f43ba 100644 --- a/res/drawable/divider.xml +++ b/res/drawable/divider.xml @@ -16,5 +16,5 @@ --> - + \ No newline at end of file diff --git a/res/drawable/reveal.xml b/res/drawable/reveal.xml new file mode 100644 index 0000000..abcbf19 --- /dev/null +++ b/res/drawable/reveal.xml @@ -0,0 +1,19 @@ + + + + + \ No newline at end of file diff --git a/res/layout-land/logo_header.xml b/res/layout-land/logo_header.xml new file mode 100644 index 0000000..30929e7 --- /dev/null +++ b/res/layout-land/logo_header.xml @@ -0,0 +1,49 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/res/layout-land/setup_welcome_page.xml b/res/layout-land/setup_welcome_page.xml new file mode 100644 index 0000000..a3afa51 --- /dev/null +++ b/res/layout-land/setup_welcome_page.xml @@ -0,0 +1,44 @@ + + + + + + + + + + + + + diff --git a/res/layout/choose_data_sim_page.xml b/res/layout/choose_data_sim_page.xml index 95162d3..67963f2 100644 --- a/res/layout/choose_data_sim_page.xml +++ b/res/layout/choose_data_sim_page.xml @@ -14,31 +14,44 @@ See the License for the specific language governing permissions and limitations under the License. --> - + - + - + - + - - + + + + + + + + + + diff --git a/res/layout/header.xml b/res/layout/header.xml index 2e76a08..396bf3b 100644 --- a/res/layout/header.xml +++ b/res/layout/header.xml @@ -15,8 +15,10 @@ limitations under the License. --> + android:layout_height="@dimen/header_height" + style="@style/Header"> + android:layout_height="@dimen/page_title_height" + style="@style/Header"> - + - + - + - + + + + + + + - + - + - + - + - + - + - + - + - + - + - - - + + + + + diff --git a/res/layout/logo_header.xml b/res/layout/logo_header.xml index 5aa8df4..c8fbaaa 100644 --- a/res/layout/logo_header.xml +++ b/res/layout/logo_header.xml @@ -15,8 +15,10 @@ limitations under the License. --> + android:layout_height="@dimen/logo_header_height" + style="@style/Header"> - + - + - + - + - - - + style="@style/PageContent"> - + - - + - + - - + + + + + + + + + + + + + diff --git a/res/layout/setup_cyanogen_services.xml b/res/layout/setup_cyanogen_services.xml index 2f705ba..801e198 100644 --- a/res/layout/setup_cyanogen_services.xml +++ b/res/layout/setup_cyanogen_services.xml @@ -14,133 +14,152 @@ See the License for the specific language governing permissions and limitations under the License. --> - - - - - - - - - + - + - + - + - - + - + + + + + - + - + - - + - + + - + - - - + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/res/layout/setup_datetime_page.xml b/res/layout/setup_datetime_page.xml index 2622dad..46373f8 100644 --- a/res/layout/setup_datetime_page.xml +++ b/res/layout/setup_datetime_page.xml @@ -14,85 +14,100 @@ See the License for the specific language governing permissions and limitations under the License. --> - + - + - + - + - - - + android:paddingLeft="@dimen/content_margin_left" + android:paddingRight="@dimen/content_margin_right" + style="@style/PageContent"> - - + - + - + - - + - - + + + + + + + + + + + + + + \ No newline at end of file diff --git a/res/layout/setup_finalizing.xml b/res/layout/setup_finalizing.xml deleted file mode 100644 index 60a30d7..0000000 --- a/res/layout/setup_finalizing.xml +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/res/layout/setup_finished_page.xml b/res/layout/setup_finished_page.xml index a641edf..44f0da2 100644 --- a/res/layout/setup_finished_page.xml +++ b/res/layout/setup_finished_page.xml @@ -17,16 +17,31 @@ + android:layout_height="match_parent"> - + - + + + + + + + \ No newline at end of file diff --git a/res/layout/setup_main.xml b/res/layout/setup_main.xml index c29af05..5fb5748 100644 --- a/res/layout/setup_main.xml +++ b/res/layout/setup_main.xml @@ -18,29 +18,14 @@ android:id="@+id/root" android:orientation="vertical" android:layout_width="match_parent" - android:layout_height="match_parent" - style="@style/RootView"> + android:layout_height="match_parent"> - - - - - - - + android:layout_weight="1" + style="@style/PageContainer"/> diff --git a/res/layout/setup_welcome_page.xml b/res/layout/setup_welcome_page.xml index 80bc669..dc2d499 100644 --- a/res/layout/setup_welcome_page.xml +++ b/res/layout/setup_welcome_page.xml @@ -14,19 +14,31 @@ See the License for the specific language governing permissions and limitations under the License. --> - + - + - + + + + + + + diff --git a/res/layout/sim_missing_page.xml b/res/layout/sim_missing_page.xml index 789de85..d69d1c1 100644 --- a/res/layout/sim_missing_page.xml +++ b/res/layout/sim_missing_page.xml @@ -14,36 +14,50 @@ See the License for the specific language governing permissions and limitations under the License. --> - + - + - + - + + + + + + + + + + + + - - diff --git a/res/values-land/colors.xml b/res/values-land/colors.xml new file mode 100644 index 0000000..c18f003 --- /dev/null +++ b/res/values-land/colors.xml @@ -0,0 +1,19 @@ + + + + @color/primary_dark + diff --git a/res/values-land/dimens.xml b/res/values-land/dimens.xml index deac1a4..fb4e588 100644 --- a/res/values-land/dimens.xml +++ b/res/values-land/dimens.xml @@ -15,5 +15,5 @@ limitations under the License. --> - + @dimen/page_title_height diff --git a/res/values/colors.xml b/res/values/colors.xml index 951d28e..89f30c6 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -20,10 +20,11 @@ #e4e7e8 #efefef - #2196f3 - #1481d8 + #00B1E5 + #00A2E5 #009789 #8a000000 #727272 #40000000 + @color/primary diff --git a/res/values/dimens.xml b/res/values/dimens.xml index c0c91e8..d3c34d8 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -15,12 +15,13 @@ limitations under the License. --> - 290dp + 220dp 220dp 56dp 26dp 25dp 11dp + 30dp 26dp 26dp 14dp @@ -31,4 +32,6 @@ 30dp 30dp 15dp + 3sp + 100dp diff --git a/res/values/strings.xml b/res/values/strings.xml index bda7eac..31c0da7 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -49,9 +49,9 @@ Set your time zone and adjust current date and time if needed Location services allows Maps and other apps to gather and use data such as your approximate location. For example, Maps may use your approximate location to locate nearby coffee shops. - Allow apps that have asked your permission to use your location information. This may include your current location and past locations. - Improve location accuracy by allowing apps to use the GPS on your phone. - Use Google\'s location service to help apps determine your location. This means sending annonymous location data to Google, even when no apps are running. + Allow apps that have asked your permission to use your location information. This may include your current location and past locations. + Improve location accuracy by allowing apps to use the GPS on your phone. + Use Google\'s location service to help apps determine your location. This means sending annonymous location data to Google, even when no apps are running. Turn On Mobile Data No service diff --git a/res/values/styles.xml b/res/values/styles.xml index b42d118..36dda1d 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -18,17 +18,15 @@ - -