Go to file
Andrew Stadler dfd53b0e82 Follow-up to MimeMessage efficiency improvements.
I missed a case where message-id should not be set locally, which is
the case where the Mime parser clears all headers *and* does not find
a message-id.  The parsed MimeMessage should accurately reflect this.

In the old code, the local id was created at construction time and then
immediately discarded by the parser (calling headers.clear()).

In the new code, I was generating a message-id any time I couldn't find
one.  Now, when explicitly cleared or removed, I set a boolean to inhibit
automatic generation of a new one.

I also missed the fact that a missing message-id no longer throws an
exception, it simply returns null, and so I changed the code that was
catching that exception to simply check for null.

(Note:  Clearly, modeling of legacy behavior is becoming annoying here;
It would be better to do away with all of the automatic logic, and simply
generate message-id locally when appropriate:  On locally-generated
messages.  I don't want to touch this for the current release, but I left
a note in the code to this effect.)

Bug: 2504774
Change-Id: Ibfcbd2363c7ae39ee6d44e4c3295f88258cb4945
2010-03-10 16:42:49 -08:00
assets auto import from //depot/cupcake/@135843 2009-03-03 19:32:22 -08:00
docs auto import from //depot/cupcake/@135843 2009-03-03 19:32:22 -08:00
images auto import from //depot/cupcake/@135843 2009-03-03 19:32:22 -08:00
res Merge "New look for account switcher." 2010-03-04 17:29:07 -08:00
src Follow-up to MimeMessage efficiency improvements. 2010-03-10 16:42:49 -08:00
tests Follow-up to MimeMessage efficiency improvements. 2010-03-10 16:42:49 -08:00
.classpath Initial Contribution 2008-10-21 07:00:00 -07:00
.project Initial Contribution 2008-10-21 07:00:00 -07:00
Android.mk Set proguard flags 2010-03-02 14:03:08 -08:00
AndroidManifest.xml Continuing work on account migration 2010-03-03 22:19:41 -08:00
CleanSpec.mk Add an empty CleanSpec.mk 2010-03-08 18:05:00 -08:00
MODULE_LICENSE_APACHE2 auto import from //depot/cupcake/@135843 2009-03-03 19:32:22 -08:00
NOTICE auto import from //depot/cupcake/@135843 2009-03-03 19:32:22 -08:00
proguard.flags Set proguard flags 2010-03-02 14:03:08 -08:00
remove-exchange-support.sh Remove exchange readme and update script 2010-02-04 13:09:34 -08:00