Commit Graph

3831 Commits

Author SHA1 Message Date
Makoto Onuki
a44c0349fa Merge "Don't move drafts to trash" 2010-10-20 17:37:42 -07:00
Makoto Onuki
6a2265eff2 Add checkbox to include original text or not.
Added the "Include text" checkbox according to the latest mock.

Before:
- We removed original message when the user pressed X.

Now:
- We save the original message all the way till the draft is sent.
- The "Include text" check state is saved in the db.  (to Message.mFlags)

Bug 3072414

Change-Id: Ie7bcca23bb6a02d676700027b0b6cb94b6627236
2010-10-20 14:21:17 -07:00
Marc Blank
8d70372e0a Merge "Don't duplicate attachments when saving drafts" 2010-10-20 13:20:40 -07:00
Marc Blank
e14aa7dacb Merge "Add account name to temporary sync error UI to help debugging" 2010-10-20 13:05:05 -07:00
Marc Blank
3bdba62f58 Don't duplicate attachments when saving drafts
Bug: 3070196
Change-Id: Ic9dffe57cdc81615e07b1c593fc71085e1281718
2010-10-20 13:03:33 -07:00
Makoto Onuki
33c86101f7 Enable OpenGL acceleration.
Looks like it no longer has obvious bugs.

Change-Id: I48876c62c4ebd5a32bcca8fb7a230c428b4b35f7
2010-10-20 12:31:07 -07:00
Marc Blank
deb51f824e Add account name to temporary sync error UI to help debugging
* At this point, there are a lot of toasts shown that relate to
  sync failures (e.g. "Unable to connect to server").  To help
  find where they're coming from, add the display name of the
  account
* UX folks: Please consider what this UI should be

Change-Id: Id9b76cd22178727bedaf67ad0b7450edff99a791
2010-10-19 15:45:03 -07:00
Marc Blank
a8bb34fd62 Respect the RESPONSE_REQUESTED tag in meeting invite mail
Bug: 2639037
Change-Id: I4bd73f23ba270fa0ead72971b5a79d9db678a8dd
2010-10-19 14:23:54 -07:00
Makoto Onuki
77aabd9519 Don't move drafts to trash
Now deleted drafts are really deleted, rather than getting moved to trash.

Also rewrote the test to avoid creating AsyncTasks on the test thread.
In this case it seems to be running fine, but I've had problems doing this
before.

Bug 3099179

Change-Id: Ice5298bf94312ce764d90aa35c5a6c5262ec5b42
2010-10-19 13:54:05 -07:00
Marc Blank
eb49659423 Prevent MailService from spamming AccountManager during reconcile
* When any Account is modified, MailService gets a content notification and
  runs reconciliation in an AsyncTask.  Reconciliation ends up calling the
  AccountManager, which also runs asynchronously.  The net effect is that,
  especially during unit tests, where we create/destroy accounts rapidly,
  these calls can "back up", ending in a situation in which the worker pool
  for AsyncTask is filled, with a resulting RejectedExecutionException
* We fix this by preventing more than one request for reconciliation to
  be queued at a time
* Added a unit test that thrashes the notification handler

Bug: 2937628
Change-Id: Iaf25806efb46831f31704604360df091752d9525
2010-10-18 14:07:47 -07:00
Marc Blank
07a91c1655 Merge "Fix errors in MockProvider unit tests" 2010-10-18 14:04:10 -07:00
Marc Blank
6af171cae6 Fix errors in MockProvider unit tests
Change-Id: Ibfe6d72547f182332fddf82a842a131f920f5e7f
2010-10-16 21:12:12 -07:00
Kenny Root
6997b65710 am 905fec26: (-s ours) am dd479065: Import revised translations
Merge commit '905fec26373b615c479d784e91a6aa35c9faff8c'

* commit '905fec26373b615c479d784e91a6aa35c9faff8c':
  Import revised translations
2010-10-15 14:08:57 -07:00
Andy Stadler
f8b30b776b am 1e64175c: (-s ours) am 214c6c6c: Fix remote wipe with mobile sync server
Merge commit '1e64175c7a80667f55dfa49f8651a73243f03a65'

* commit '1e64175c7a80667f55dfa49f8651a73243f03a65':
  Fix remote wipe with mobile sync server
2010-10-15 09:44:59 -07:00
Andy Stadler
6fa2d73b97 am 73c1645b: (-s ours) am efcde27b: Use original all-day flag when upsyncing exceptions DO NOT MERGE
Merge commit '73c1645b9052dd52eeca0b4bcf4438e50d0555f9'

* commit '73c1645b9052dd52eeca0b4bcf4438e50d0555f9':
  Use original all-day flag when upsyncing exceptions DO NOT MERGE
2010-10-15 08:32:48 -07:00
Andy Stadler
75d9fc337a am 25cc1ec4: (-s ours) am 9c2baaab: Fix upsync of exceptions in EAS 2.5 (Exchange 2003) DO NOT MERGE
Merge commit '25cc1ec4de9bfcee0e5b02fa2004435ac0090f93'

* commit '25cc1ec4de9bfcee0e5b02fa2004435ac0090f93':
  Fix upsync of exceptions in EAS 2.5 (Exchange 2003)  DO NOT MERGE
2010-10-15 08:32:46 -07:00
Andy Stadler
07d047638f am 0f8cd216: (-s ours) am 419a36ca: Give email its own version# scheme. DO NOT MERGE
Merge commit '0f8cd216977887541c977ebffa67925b1f3652ee'

* commit '0f8cd216977887541c977ebffa67925b1f3652ee':
  Give email its own version# scheme.  DO NOT MERGE
2010-10-15 08:31:48 -07:00
Makoto Onuki
7fdd88e37c Merge "Put the dest mailbox name in the "message moved" toast" 2010-10-14 15:36:37 -07:00
Makoto Onuki
ee7205d100 Put the dest mailbox name in the "message moved" toast
Also removed obsolete todo

Bug 3075984

Change-Id: I10ce9df29c4913c328d2a962151d4a9f2e6e1408
2010-10-14 15:14:46 -07:00
Makoto Onuki
b0ffb3e39a Merge "Don't use negative IDs with ListView" 2010-10-14 14:45:23 -07:00
Makoto Onuki
9b5001a34c Don't use negative IDs with ListView
ListView uses the _id column for some operations, including
onSave/RestoreInstanceState, and if the column contains negative values
they don't work as expected.  The same assumption seems to be in other places
as well, so let's just avoid using negative IDs.

With this CL we now use two different IDs, one for ListView, which will
never be negative, and the other for us, the actual mailbox ID.

Bug 3049315

Change-Id: I263b4895212b5f8bb80c98acaf5c4eccd0bfef55
2010-10-14 14:42:46 -07:00
Kenny Root
905fec2637 am dd479065: Import revised translations
Merge commit 'dd4790651b32f7de741e101341c439f1434a2082' into gingerbread-plus-aosp

* commit 'dd4790651b32f7de741e101341c439f1434a2082':
  Import revised translations
2010-10-14 12:01:03 -07:00
Makoto Onuki
a5fcefd179 Merge "Fix potential crash in MessageViewFragment.openMessageSync" 2010-10-14 10:55:45 -07:00
Kenny Root
dd4790651b Import revised translations
Change-Id: I30d0ddf21979a6ae1c75ee5e601a9a448079b5de
2010-10-14 09:43:56 -07:00
Andy Stadler
1e64175c7a am 214c6c6c: Fix remote wipe with mobile sync server
Merge commit '214c6c6c8173cf90a3e45615a6896a48dc643e68' into gingerbread-plus-aosp

* commit '214c6c6c8173cf90a3e45615a6896a48dc643e68':
  Fix remote wipe with mobile sync server
2010-10-13 16:46:41 -07:00
Andy Stadler
214c6c6c81 Fix remote wipe with mobile sync server
* It appears as if our running multiple sync threads can confuse the
  mobile sync server during a remote wipe (the server expects the next
  client response to be an acknowledgment, whereas it might well be
  a command or response from a different thread)
* To avoid this, we first put the account on security hold and then
  shut down all other sync threads for the account
* After this, we send the acknowledgment and the remote wipe proceeds
  normally.
* NOTE: It's possible that, due to the vagaries of multithreaded
  operation, one of the other syncing threads could still send a non-
  acknowledgment response to the server before our provisioning thread
  gets a chance to send its acknowledgment.  However, since the other
  syncing threads will terminate (and not restart, because of the hold),
  the provision/remote wipe/ack sequence will work on the subsequent
  attempt

Bug: 2844888
Backport From: Ib4ffbbc67b681e69176b6c1d5515fa80c7d1e121

Change-Id: Ie9e944bd39f331c2ddc0f0ba303a3d5684f6f033
2010-10-13 15:39:27 -07:00
Andy Stadler
73c1645b90 am efcde27b: Use original all-day flag when upsyncing exceptions DO NOT MERGE
Merge commit 'efcde27bf74acdd82bb0aad0ad1fd0b767ca5f18' into gingerbread-plus-aosp

* commit 'efcde27bf74acdd82bb0aad0ad1fd0b767ca5f18':
  Use original all-day flag when upsyncing exceptions DO NOT MERGE
2010-10-13 15:09:36 -07:00
Andy Stadler
25cc1ec4de am 9c2baaab: Fix upsync of exceptions in EAS 2.5 (Exchange 2003) DO NOT MERGE
Merge commit '9c2baaabd2feff633db3ed1b782282667e541927' into gingerbread-plus-aosp

* commit '9c2baaabd2feff633db3ed1b782282667e541927':
  Fix upsync of exceptions in EAS 2.5 (Exchange 2003)  DO NOT MERGE
2010-10-13 15:07:48 -07:00
Andy Stadler
efcde27bf7 Use original all-day flag when upsyncing exceptions DO NOT MERGE
Bug: 3087410
Backport of: I4bed0039758e98d4b85054876f192605eb00ee82

Change-Id: Ibc875d58c2f6c5317ce8e4fee97b96c2fd6b2ecf
2010-10-13 15:05:38 -07:00
Andy Stadler
9c2baaabd2 Fix upsync of exceptions in EAS 2.5 (Exchange 2003) DO NOT MERGE
* Apparently, Exchange 2003 doesn't like to see Visibility set in
  Exceptions
* Apparently, Exchange 2003 likes to see Exception Deleted and
  ExceptionStartTime prior to other data
* The word "apparently" is used above to indicate that these
  findings are not part of any specification, but have been
  determined empirically

Bug: 2775885
Backport of: I163f156675f65c494a59d5233b2b6e23b3f1d6a0

Change-Id: I5d32dea5c3903147725b8df87a71e961a4d78c60
2010-10-13 15:02:38 -07:00
Andy Stadler
0f8cd21697 am 419a36ca: Give email its own version# scheme. DO NOT MERGE
Merge commit '419a36ca6e8d0c46875e82c1e8be245b45adbb52' into gingerbread-plus-aosp

* commit '419a36ca6e8d0c46875e82c1e8be245b45adbb52':
  Give email its own version# scheme.  DO NOT MERGE
2010-10-13 14:22:44 -07:00
Marc Blank
9ce8f4d2a3 Use original all-day flag when upsyncing exceptions
Bug: 3087410
Change-Id: I4bed0039758e98d4b85054876f192605eb00ee82
2010-10-13 14:10:36 -07:00
Andy Stadler
419a36ca6e Give email its own version# scheme. DO NOT MERGE
Change-Id: I258ffcf47d243417edadad44714f74247c78b366
2010-10-12 16:39:58 -07:00
Makoto Onuki
09eb977c06 Fix potential crash in MessageViewFragment.openMessageSync
The problem is that ths method is called in a worker thread, so
there's nothing to prevent it from running just after/at the same
time as clearContent() (which sets -1 to mMessageIdToOpen).
If it does, it passes -1 to restoreMessageWithId() and crashes.

Also removed a half-obsolete comment which is a bit too obvious for its length.

Bug 3077387

Change-Id: I736d696046e6d8964a16c80515544c582aca3943
2010-10-12 16:38:40 -07:00
Makoto Onuki
9c293eb65a Show "No messages" when there's no items on message list
Show this when there's no messages, and no "Load more messages" footer.
i.e. Only Outbox, Drafts, and exchange mailboxes can show "No messages".

Also removed an obsolete comment.

Bug 2363624

Change-Id: If483d33cfacb186d0fe54b4f4382333a332be84c
2010-10-12 10:36:17 -07:00
Marc Blank
92f30bedf2 Merge "Fix remote wipe with mobile sync server" 2010-10-11 11:15:12 -07:00
Roy West
0be3fbe11b am 416fdc22: am 0639c6bd: Fix bug 3074186 limit check label to Inbox
Merge commit '416fdc22cadaed61377bf52d80b6052a81497ebf'

* commit '416fdc22cadaed61377bf52d80b6052a81497ebf':
  Fix bug 3074186 limit check label to Inbox
2010-10-11 10:03:34 -07:00
Marc Blank
3afa93c054 Fix remote wipe with mobile sync server
* It appears as if our running multiple sync threads can confuse the
  mobile sync server during a remote wipe (the server expects the next
  client response to be an acknowledgment, whereas it might well be
  a command or response from a different thread)
* To avoid this, we first put the account on security hold and then
  shut down all other sync threads for the account
* After this, we send the acknowledgment and the remote wipe proceeds
  normally.
* NOTE: It's possible that, due to the vagaries of multithreaded
  operation, one of the other syncing threads could still send a non-
  acknowledgment response to the server before our provisioning thread
  gets a chance to send its acknowledgment.  However, since the other
  syncing threads will terminate (and not restart, because of the hold),
  the provision/remote wipe/ack sequence will work on the subsequent
  attempt

Bug: 2844888
Change-Id: Ib4ffbbc67b681e69176b6c1d5515fa80c7d1e121
2010-10-10 16:40:12 -07:00
Daisuke Miyakawa
43f2321d10 Modify code style.
Change-Id: I40eeb738ca2dcc7f21ddbc603b03debde5ac27d3
2010-10-10 15:17:52 -07:00
Daisuke Miyakawa
c8af3175df Merge "Use AccountAuthenticatorResponse properly." 2010-10-10 15:12:48 -07:00
Marc Blank
4f573d26b2 Merge "Fix CalendarSyncAdapterTests" 2010-10-09 16:40:07 -07:00
Marc Blank
5ae9a1b059 Merge "Fix upsync of exceptions in EAS 2.5 (Exchange 2003)" 2010-10-09 16:38:55 -07:00
Roy West
416fdc22ca am 0639c6bd: Fix bug 3074186 limit check label to Inbox
Merge commit '0639c6bd4ed4807bd8cefcca038f81d858aba8af' into gingerbread-plus-aosp

* commit '0639c6bd4ed4807bd8cefcca038f81d858aba8af':
  Fix bug 3074186 limit check label to Inbox
2010-10-09 09:30:28 -07:00
Roy West
0639c6bd4e Fix bug 3074186 limit check label to Inbox
Change-Id: Iec416a2112c98483372694e09f2375c9cf36ac09
2010-10-09 08:53:34 -07:00
Gilles Debunne
c6ce65ed86 am 7df2f6cd: am ba95e58a: New downscaled menu assets
Merge commit '7df2f6cd996faa8568a819eef3e1b6ae6eb60ece'

* commit '7df2f6cd996faa8568a819eef3e1b6ae6eb60ece':
  New downscaled menu assets
2010-10-08 18:28:50 -07:00
Marc Blank
fde172f576 Fix CalendarSyncAdapterTests
Bug: 3077174
Change-Id: Ic0ba851969e852488a72241c8fba9f466c5bc3a6
2010-10-08 17:17:04 -07:00
Marc Blank
a0692b16e1 Fix upsync of exceptions in EAS 2.5 (Exchange 2003)
* Apparently, Exchange 2003 doesn't like to see Visibility set in
  Exceptions
* Apparently, Exchange 2003 likes to see Exception Deleted and
  ExceptionStartTime prior to other data
* The word "apparently" is used above to indicate that these
  findings are not part of any specification, but have been
  determined empirically

Bug: 2775885
Change-Id: I163f156675f65c494a59d5233b2b6e23b3f1d6a0
2010-10-08 16:32:20 -07:00
Marc Blank
30c99e0dc3 Merge "Make sure updatePolicies is always called during provisioning" 2010-10-08 16:27:21 -07:00
Daisuke Miyakawa
9dac94975f Use AccountAuthenticatorResponse properly.
Current implementation ignores callbacks coming from
AccountManager, which should be called everytime
when this Activity finishes its job.

Bug: 3069222
Change-Id: Iea03cf94bdfe8da184e415bf7e759ddeb46ecdd9
2010-10-08 16:16:43 -07:00
Makoto Onuki
6993130a7c Auto-refresh mailbox list
Refresh mailbox list when changing the account, if it's been more than
5 minutes since the last refresh.

Change-Id: I5b1400bb881197e117b8863f850c368c2d1ccbc6
2010-10-08 15:29:38 -07:00