Commit Graph

853 Commits

Author SHA1 Message Date
Marc Blank
418e4f88fa am 6c47a981: Merge change 22873 into eclair
Merge commit '6c47a981845d443f912a33b7a66dff5bf780cf98'

* commit '6c47a981845d443f912a33b7a66dff5bf780cf98':
  Clean up onCreate/onDestroy methods for SyncManager
2009-08-27 09:19:40 -07:00
Android (Google) Code Review
4118beebed Merge change 22654 into eclair
* changes:
  Move some Contacts fields to new CommonDataKinds rows
2009-08-27 09:17:52 -07:00
Android (Google) Code Review
6c47a98184 Merge change 22873 into eclair
* changes:
  Clean up onCreate/onDestroy methods for SyncManager
2009-08-27 09:15:57 -07:00
Andrew Stadler
48971f190a am 2ded414e: Merge change 22840 into eclair
Merge commit '2ded414e99ec6e275865df6cc5d62b4b9c3e01be'

* commit '2ded414e99ec6e275865df6cc5d62b4b9c3e01be':
  Sync "read" and "favorite" back to server.
2009-08-26 23:18:10 -07:00
Android (Google) Code Review
2ded414e99 Merge change 22840 into eclair
* changes:
  Sync "read" and "favorite" back to server.
2009-08-26 23:14:28 -07:00
Andrew Stadler
423206653f Sync "read" and "favorite" back to server.
* Add \FLAGGED support to IMAP (writeback)
* Add code in Controller to kick MessagingController
* Rewrite pending commands system to scan through provider's updated
    messages table and react
* Fix a unit test that I broke
* Cleaned out some of the old PendingCommand support

Addresses the 2nd half (upsync) of bug 1904385

TODO:
Can I add a unit test for IMAP flag writer?

Change-Id: I5a96a695d4f35fca1395506f165b86d9fb19b543
2009-08-26 23:12:02 -07:00
Marc Blank
317a92f51f Clean up onCreate/onDestroy methods for SyncManager
* Put most of onDestroy code into the run method of SyncManager's thread
* Clean up code for updating Mailboxes' SyncKey and interval
* Fixes 2080472

Change-Id: Ie16c851a686142d9fd1d810a942aa786690b1034
2009-08-26 22:09:53 -07:00
Marc Blank
068b541299 am 6c99ea3d: Merge change 22829 into eclair
Merge commit '6c99ea3d02ba1b6b351a4ff4a39eadf90e494349'

* commit '6c99ea3d02ba1b6b351a4ff4a39eadf90e494349':
  Fix #2081145 (Empty subject line imitates magic eight ball)
2009-08-26 16:41:39 -07:00
Android (Google) Code Review
6c99ea3d02 Merge change 22829 into eclair
* changes:
  Fix #2081145 (Empty subject line imitates magic eight ball)
2009-08-26 16:37:56 -07:00
Marc Blank
b01bce9b50 Fix #2081145 (Empty subject line imitates magic eight ball) 2009-08-26 16:37:05 -07:00
Marc Blank
2b1fb26f87 am 7ac828bc: Merge change 22823 into eclair
Merge commit '7ac828bce884c26d7f28486ec49d7f99b81842d3'

* commit '7ac828bce884c26d7f28486ec49d7f99b81842d3':
  Fix bug #2080302
2009-08-26 15:54:29 -07:00
Android (Google) Code Review
7ac828bce8 Merge change 22823 into eclair
* changes:
  Fix bug #2080302
2009-08-26 15:50:26 -07:00
Marc Blank
1851882c8c Fix bug #2080302
* Was trying to retrieve an integer as a boolean in the ContentValues
* The actual Exception (ClassCastException) was buried by ActivityThread
2009-08-26 15:38:30 -07:00
Marc Blank
5cad4ca9d3 am 58299b0b: Merge change 22793 into eclair
Merge commit '58299b0b668a8913f946f48844b8a7cbcbb69963'

* commit '58299b0b668a8913f946f48844b8a7cbcbb69963':
  Handle errors in account creation by AccountManager
2009-08-26 14:35:04 -07:00
Android (Google) Code Review
58299b0b66 Merge change 22793 into eclair
* changes:
  Handle errors in account creation by AccountManager
2009-08-26 14:31:54 -07:00
Mihai Preda
fe1e2356ea am eac52c93: Merge change 22798 into eclair
Merge commit 'eac52c9398327de297e3369409e5f2225d39a08c'

* commit 'eac52c9398327de297e3369409e5f2225d39a08c':
  MessageCompose: bug 2080075 &  2077496.
2009-08-26 14:01:42 -07:00
Android (Google) Code Review
eac52c9398 Merge change 22798 into eclair
* changes:
  MessageCompose: bug 2080075 &  2077496.
2009-08-26 13:57:45 -07:00
Marc Blank
a3c6c6ed29 Handle errors in account creation by AccountManager
* Don't create our EmailProvider Account until we get a confirmation from
  AccountManager that the system Account is created
* Put up an erorr dialog if AccountManager fails for some reason (this is
  what we saw in bug #2072668)
2009-08-26 13:20:23 -07:00
Mihai Preda
ea0fea2558 MessageCompose: bug 2080075 & 2077496.
- fix bug 2080075, reply to message without text body.
- workaround bug 2077496 by temporarilly disabling the address adapter.
- unit test for MessageCompose.buildBodyText()
- use precompiled regex
2009-08-26 21:49:31 +02:00
Andrew Stadler
d37ba18434 am 2ac94a9c: Update Star and Read/Unread from IMAP server
Merge commit '2ac94a9cc254ff0a4c17407eb1bda31d433ef651'

* commit '2ac94a9cc254ff0a4c17407eb1bda31d433ef651':
  Update Star and Read/Unread from IMAP server
2009-08-26 08:52:15 -07:00
Andrew Stadler
2ac94a9cc2 Update Star and Read/Unread from IMAP server
* Set the star and the read/unread states properly when a
    message is downloaded for the first time.
* Update them on already-downloaded messages.

This is download only - not upload
Bug 1904385

Change-Id: Id03a0957677bb39f4a57ed0542eaa8accc36ab48
2009-08-25 22:45:11 -07:00
satok
55e9ebdaa4 am c1edb4a8: Show/Hide/Change appropriate buttons in footer of MessageList.
Merge commit 'c1edb4a80185311072622a93b8a7458bc549de99'

* commit 'c1edb4a80185311072622a93b8a7458bc549de99':
  Show/Hide/Change appropriate buttons in footer of MessageList.
2009-08-25 16:42:26 -07:00
satok
c1edb4a801 Show/Hide/Change appropriate buttons in footer of MessageList.
BUG: 1904403

* Change the text of READ/UNREAD button dynamically according to the state of selection
* Change the text of favorite button dynamically according to the state of selection
2009-08-26 08:38:06 +09:00
Marc Blank
04e3ba8ffd Move some Contacts fields to new CommonDataKinds rows 2009-08-25 15:00:15 -07:00
Andrew Stadler
773488d0c6 am 98c10db5: Clean up menus in MessageList
Merge commit '98c10db5103aca003446b446efa7492b7cd36f34'

* commit '98c10db5103aca003446b446efa7492b7cd36f34':
  Clean up menus in MessageList
2009-08-25 14:22:49 -07:00
Andrew Stadler
98c10db510 Clean up menus in MessageList
* Final list of options while normal mailbox is shown
* New list of options while smart folder is shown
* Correct lists of context options for drafts, outbox, trash, and
    everywhere else (full list)
* Enable reply, reply all, and forward

TODO: needs a better icon for menu->folders

Resolves bug 1904421 items 4a, 4b, 5a
Resolves bug 2078092
2009-08-25 14:11:38 -07:00
satok
9a17d03970 am 67be8472: Update UI of accounts folder list and smart folders
Merge commit '67be84728a05f969ae1306fc1fed21fb1a2a8526'

* commit '67be84728a05f969ae1306fc1fed21fb1a2a8526':
  Update UI of accounts folder list and smart folders
2009-08-25 11:49:35 -07:00
satok
67be84728a Update UI of accounts folder list and smart folders
BUG: 1904417

* Changed the order of menu options
* Made context menu for smart folders
* Added context menu for Accounts
2009-08-26 03:42:49 +09:00
Mihai Preda
98c0c25c4a am 9b27c7fd: MessageView: display inline images. - also display "show pictures" the same as in donut. - inline images don\'t show in attachemnts list.
Merge commit '9b27c7fd903109bb20812da0421ce44676aa0189'

* commit '9b27c7fd903109bb20812da0421ce44676aa0189':
  MessageView: display inline images.
2009-08-25 11:40:59 -07:00
Mihai Preda
9b27c7fd90 MessageView: display inline images.
- also display "show pictures" the same as in donut.
- inline images don't show in attachemnts list.
2009-08-25 20:32:26 +02:00
Marc Blank
e996b7f455 am 68c3c751: Use LED for notification (same parameters as Gmail and GTalk services)
Merge commit '68c3c7518e132bdbfd17a0b122fbe09c08e0acdc'

* commit '68c3c7518e132bdbfd17a0b122fbe09c08e0acdc':
  Use LED for notification (same parameters as Gmail and GTalk services)
2009-08-25 11:11:22 -07:00
Marc Blank
68c3c7518e Use LED for notification (same parameters as Gmail and GTalk services)
* Agreed to by Erick and Prasenjit

Change-Id: I1a0f3642c9b10f981b2feed55762407ed853763d
2009-08-25 11:06:17 -07:00
Andrew Stadler
4af324616e am df86adf8: Finish the code to demand-load partially loaded messages.
Merge commit 'df86adf87328a439347260331592509787020420'

* commit 'df86adf87328a439347260331592509787020420':
  Finish the code to demand-load partially loaded messages.
2009-08-25 10:18:00 -07:00
Andrew Stadler
df86adf873 Finish the code to demand-load partially loaded messages.
This happens in two primary cases:
1.  When a very large POP message was skipped during initial sync
2.  When any message was interrupted during initial sync, e.g. by
    a dropped connection.

Changes:
* Added loadMessageForView and callbacks to Controller (and touched all
    files with Controller listeners)
* Rewrote loadMessageForView in legacy MessagingController to work with
    provider.
* Update flow in MessageView to use loadMessageForView when needed.
* Restored the use of "loading.html" and "empty.html" assets (although
    I think we should replace them with simple layouts & views.)
* Some random cleanup in MessageView

Satisfies bug # 2065563
2009-08-25 10:13:35 -07:00
satok
3e2172b7e2 am 60a04912: Change all context menus
Merge commit '60a04912e0973183c40ac34fb121ab77e471ec39'

* commit '60a04912e0973183c40ac34fb121ab77e471ec39':
  Change all context menus
2009-08-25 07:12:34 -07:00
satok
60a04912e0 Change all context menus
BUG: 2051086

* Add titles to all context menus
* Fix bug that prevented display of context menus in MessageList

TODO: localize special folder names
2009-08-25 22:14:28 +09:00
satok
32f2e388ca am dadba994: Localize special folder names
Merge commit 'dadba9949895696108b31124fc0c6aa1a297ab1c'

* commit 'dadba9949895696108b31124fc0c6aa1a297ab1c':
  Localize special folder names
2009-08-25 01:14:36 -07:00
satok
dadba99498 Localize special folder names
* make utility for looking up icon id for mailbox
* make utility for looking up localized name for mailbox

BUG: 2065586
2009-08-25 16:20:32 +09:00
Marc Blank
c0c477aea7 am aa69a174: Add initial support for uploading new Contacts to Exchange server
Merge commit 'aa69a174774699d452233f8ffece021f9851011e'

* commit 'aa69a174774699d452233f8ffece021f9851011e':
  Add initial support for uploading new Contacts to Exchange server
2009-08-24 21:09:21 -07:00
Marc Blank
aa69a17477 Add initial support for uploading new Contacts to Exchange server
* Refactor the sync adapters to separate out parsing from commit
* Use ContactsProvider to save the SyncKey for contacts
* Fixes #2072664 and #2072456

Change-Id: I1e85c498496e83d9523489636a75f366f7fbd106
2009-08-24 18:45:14 -07:00
Marc Blank
c0010e2f97 am e2e466e3: Null out reference in onDestroy method
Merge commit 'e2e466e315f645d19b592d62dcf573c706175e17'

* commit 'e2e466e315f645d19b592d62dcf573c706175e17':
  Null out reference in onDestroy method
2009-08-24 18:06:50 -07:00
Marc Blank
17f4159fd1 am 137be44d: Merge change 22502 into eclair
Merge commit '137be44d5c2fde2915a2261e2b1670f8c1b86558'

* commit '137be44d5c2fde2915a2261e2b1670f8c1b86558':
  Fix #2074992
2009-08-24 18:06:49 -07:00
Marc Blank
e2e466e315 Null out reference in onDestroy method
Change-Id: Idc3b7c52ae60121756e071ed2468ee1b9496c1c1
2009-08-24 18:01:49 -07:00
Android (Google) Code Review
137be44d5c Merge change 22502 into eclair
* changes:
  Fix #2074992
2009-08-24 17:53:24 -07:00
Andrew Stadler
8df00ac6b9 am c9c5bd56: (-s ours) am 421a4f55: (-s ours) DO NOT MERGE: Rewrite Base64InputStream from Eclair
Merge commit 'c9c5bd5665648950aeb9c05711a733f7cbd1f730'

* commit 'c9c5bd5665648950aeb9c05711a733f7cbd1f730':
  DO NOT MERGE: Rewrite Base64InputStream from Eclair
2009-08-24 17:52:27 -07:00
Andrew Stadler
c9c5bd5665 am 421a4f55: (-s ours) DO NOT MERGE: Rewrite Base64InputStream from Eclair
Merge commit '421a4f5595163b16064049e20e823f45e0fd7ee9' into eclair

* commit '421a4f5595163b16064049e20e823f45e0fd7ee9':
  DO NOT MERGE: Rewrite Base64InputStream from Eclair
2009-08-24 17:48:45 -07:00
Dianne Hackborn
47ac444ff6 am 4bc4fed4: Use new service command processing to avoid leaving the service running.
Merge commit '4bc4fed47bec36b48203ae7dd6cd7e4727cfea70'

* commit '4bc4fed47bec36b48203ae7dd6cd7e4727cfea70':
  Use new service command processing to avoid leaving the service running.
2009-08-24 17:06:01 -07:00
Andrew Stadler
421a4f5595 DO NOT MERGE: Rewrite Base64InputStream from Eclair
Rewrite Base64InputStream to be much more efficient

This was broken in many, many ways but the primary offender was an
object allocation for every 4 bytes of an input stream (imagine what this
did for 900k attachment files).

The new version is completely self-contained, and is optimized for the
most common case of inner loop case of processing 4-bytes-at-a-time.
2009-08-24 16:30:44 -07:00
Dianne Hackborn
4bc4fed47b Use new service command processing to avoid leaving the service running.
The service still needs to schedule an alarm in its onStartCommand() so that
it will run in its next poll interval.

Change-Id: I66228ef573e84a5c7d33bcb07f4772626079b960
2009-08-24 16:29:02 -07:00
Marc Blank
863c6bb04f Fix #2074992
Change-Id: If60aafe60c6327ec62f2a45aae5d750da65a19a8
2009-08-24 15:57:33 -07:00