Commit Graph

336 Commits

Author SHA1 Message Date
Ben Komalo
891da84a25 Misc visual fixes to Email
- dropped in bigger assets for mailbox triangle
- dropped in bigger assets for checkbox for xhdpi
- dropped in proper star asset for message list
- fixed some padding issues for message list item
- remove the color label from "Combined view" in the account drop down

Bug: 5248125
Change-Id: Ic15d98013f2afb42bf55c327654009ef8baa1b78
2011-09-01 16:51:02 -07:00
Ben Komalo
8466f79a06 Asset drop.
- this syncs up the UX repo with the developer repo so that the assets
now match. We should be able to do wholesale drops/diffs from now on.
- lots of changes to widget so that it is (mostly) up to spec now, and
matches the preview

Bug: 5225385
Bug: 5205578
Bug: 4320895
Change-Id: I8ccbadcfc17cdb406599497edc91165809f55d68
2011-08-30 12:57:38 -07:00
Mindy Pereira
cc02d435b2 fix height of compose view fields
fixes bug:5223556 heights of compose view text fields are too tall on phone/ tablet

Change-Id: I1bbf570a66a424cffcabcae6cfdc2b6ca05be4b7
2011-08-29 08:45:47 -07:00
Mindy Pereira
89dd731a90 Update attachment ui to look like Gmail attachment ui; fix from padding.
Fixes Bug:5184434 Compose view doesn't match pixel perfects
Change-Id: I7217eb4a63beedfd0bc00dffe9e0f29a5af6214c
2011-08-19 15:36:23 -07:00
Mindy Pereira
7b41b374cc Style Email compose to look like gmail compose.
Change-Id: I8e1f0e9c4bbbbcd2463473da190bff88f2748905
2011-08-19 11:42:09 -07:00
Mindy Pereira
5b5a9b3f9e Fix alignment of to/cc/bcc fields.
Part of bug:5162602 Alignment of elements in compose screen seems off (master/tot/prime

Change-Id: Ica741328c687b68c8995a1e9fde4d6bb566407ba
2011-08-18 16:17:29 -07:00
Mindy Pereira
475a56fd0a Merge "Change the fonts / sizes of the chips labels to match the rest of the compose activity." 2011-08-18 15:58:37 -07:00
Ben Komalo
2ae341bfa1 Fix messagelistitem logic.
We had two separate "height" values in XML that weren't consistent - one
was used for the coordinates and one was used for the actual item i nthe
adapter. This made things off slightly when the values didn't match
(i.e. on tablet wide mode).

Also fixed an issue with paperclip icon not aligning with date on wide
mode

Bug: 5184169
Change-Id: I1d80bb9c685fdd8216fcaef26bf6ad715eb74c4c
2011-08-18 12:09:39 -07:00
Mindy Pereira
d52ff88e89 Change the fonts / sizes of the chips labels to match the rest of the compose activity.
part of Bug:5162602 Alignment of elements in compose screen seems off (master/tot/prime)

Change-Id: Ie2125df9888198448d1503edc4cccf3537db016c
2011-08-17 16:52:01 -07:00
Ben Komalo
27348c7882 Revert "Make compose landscape(phone) go fullscreen"
This reverts commit 0108aeb5b1.

There are too many issues that crop up in this mode.

Bug: 5121640
Change-Id: I6264a63cada973a7ee327ff4c7e7af5df5a6fdb3
2011-08-17 11:13:07 -07:00
Marc Blank
8fe74e7899 Clean up SSL/TLS option text
* The previous text was confusing and potentially misleading.
* The new text is more standard (i.e. used by common clients)

Bug: 5011919
Change-Id: I645c7105ecb36cf58b6c78f6b5bc76f2a17858a3
2011-08-16 16:43:43 -07:00
Ben Komalo
4b75ac992d Update visuals for new fonts.
- tighten up action bar spinner
- fix up message list senders/padding

Bug: 5159050
Change-Id: I00033d994a23f7fbb81cd72f53b9d66faa7570f9
2011-08-12 15:01:51 -07:00
Mindy Pereira
ce39730da0 Update styling of chips fields.
Fixes b/5122133 replace recipient background with new multiline background

Change-Id: Icbdb1e885526ccbe1bbbb5e332db8532988a749e
2011-08-11 15:56:31 -07:00
Ben Komalo
fbf4b8045b Remove STOPSHIP and unused strings.
Bug: 5142183
Change-Id: I97df43eeb878f352cb09ccda2eafe8c4981b9346
2011-08-10 16:41:07 -07:00
Ben Komalo
d3ced7cce9 Show helpful messages when no accounts configured
Bug: 5145213
Change-Id: I350d59e8afc72d1bad64cf7cf3d44750e8365a99
2011-08-10 15:33:47 -07:00
Ben Komalo
136dedbbd9 Update headers in message view.
- this uses the new gradient/drop shadows
- adds quick contact badge triangle thing
- also puts in contentDescriptions for the reply/all/forward/star
  actions that were lost
- also merges the headers in tablet and phone

Bug: 5144711
Change-Id: Ie2d14c26b7818aa4389731794a15be6c31f4981d
2011-08-10 10:24:24 -07:00
Ben Komalo
2468b54db5 Merge "Fix search styling." 2011-08-09 18:07:00 -07:00
Ben Komalo
06dee204a0 Small fixes to attachments UI
Bug: 5102245
Change-Id: I71ccce885c563454672e18aa62eac4ab3996146e
2011-08-09 15:07:57 -07:00
Ben Komalo
ed494cd6bb Fix search styling.
This eliminates the excessive padding on the left and makes the hint
text behave according to the new spec (since it uses the new action view
expanded mode).

A later CL will actually change the item to use the action view
facilities of the framework (so we don't have to manage our own custom
views).

Bug: 5109953
Change-Id: Ia3e4a1e64e65b3b8bb3e708b31636f4186acfd46
2011-08-08 17:16:47 -07:00
Ben Komalo
c42f09c05d Merge "Make compose landscape(phone) go fullscreen" 2011-08-05 16:26:28 -07:00
Ben Komalo
330b1273af Fix show pictures to not look broken.
- this still needs an asset for the "checkmark" button when showing
"always show pictures" prompt - using a checkbox on state as a
placeholder but it's probably not the best thing for it

Bug: 5037485
Change-Id: Iaa1d0f865bf0c01fde0b0cb37ea1c395345ed582
2011-08-05 10:02:30 -07:00
Ben Komalo
0108aeb5b1 Make compose landscape(phone) go fullscreen
Bug: 5121640
Change-Id: Ib7cc74c2ee494b69c7674d60960df83d6f0d9845
2011-08-04 17:59:03 -07:00
Ben Komalo
6be8cceadd Update sync settings UI to specs
- minor text changes
- use light holo theme
- slight order changes

Bug: 5110452
Change-Id: Icf558ee495860dc97048765d3b8d09d31161dd32
2011-08-03 17:25:10 -07:00
Ben Komalo
f6348449fa Minor conversation header visual cleanups
- fix header bg on tablets
- fix font color in header
- make subject text wrap on phones

Bug: 5110992
Change-Id: I8c58271788f11251906d71073e6e03033c74f38f
2011-08-03 15:45:16 -07:00
Adam Powell
72fb0c8b2f Follow framework API changes
Change-Id: Idda69badd6405fe6ddff1d3f4b8ea06332ac3360
2011-08-02 17:00:11 -07:00
Ben Komalo
263d0ec707 Fix account spinner width.
- make it take up different size on phones and tablets (also landscape
  phone/portrait phone)
- move unread count outside of the spinner area

Bug: 5108972
Bug: 5111250
Change-Id: I2c16bbb52ce53bbf1c8fe08fd78f1a4b4afd4ccf
2011-08-02 15:04:48 -07:00
Ben Komalo
383279a1c5 Update message list item redlines.
- reduces number of "modes" to just two: normal and wide
- consolidate the normal/narrow modes for phone and tablet (as per spec)
  with the only diff on the tablet being side paddings
- fix issue with "white arrow" visual being shown in phone when tapping
  on a message
- make touch computations be resilient to padding values instead of
  assuming that the check/star icons are right at the left/right

Bug: 5103823

Change-Id: I23f967454f7744d9c59256625e302e54a353994a
2011-08-02 14:05:05 -07:00
Mindy Pereira
b83ecdbb9f Merge "make shorter chips views for landscape where we are turning off extract mode." 2011-08-01 11:18:53 -07:00
Ben Komalo
391b9d4abd Search delay fixes.
- adds a loading state to search so the user isn't left with a blank
screen for several seconds
- adds a timeout so that a warning message is shown for results that
take over 10 seconds
- use default loading/no message views in ListFragment so we don't have
to manager our own stuff

Bug: 5014107
Bug: 5037618
Change-Id: I8b03fa0967055989156c7777901affc777c4fae7
2011-07-27 11:37:54 -07:00
Mindy Pereira
2fe624cf47 make shorter chips views for landscape where we are turning off extract mode.
per UX.
Also, uses the chips RecipientEditTextView style as a base
so that it automatically gets styling for no extract mode.
Change-Id: Icc60944880b1d104766faee18f05960dd5089394
2011-07-25 10:06:22 -07:00
Ben Komalo
df4dfa570a Settings/Setup style cleanup.
This is not an attempt to cleanup the code that much - minimal amount of
work was done to reduce the copy/pasting that is rampant in this part of
the codebase.

This basically just does visual fixes to:
- not make the buttons illegibly tiny
- not make the buttons overlap
- make the padding consistent on phones

Bug: 5039509
Bug: 5011325
Change-Id: Id31dee84a54a5dce9644b6f37fb41ac2c2ce89b9
2011-07-22 20:26:00 -07:00
Ben Komalo
72a24f12a2 Misc settings UX fixes.
Bug: 5068602
Change-Id: I02acf3690e98ce747ddb4d3a745ac2fa59948c70
2011-07-22 16:04:10 -07:00
Jorge Lugo
4ca1ca8622 Display message when no quick respones available
When editing quick responses, displays an appropriate
message letting users know that there are no quick responses.
Additionally, the MessageCompose activity will only show "insert quick
responses" when at least one exists.

Bug: 4948180
Change-Id: I1191bd54d6e64f990b6d6830f0837579d7a6918c
2011-07-21 19:06:17 -07:00
Ben Komalo
0413edd626 Remove STOPSHIP
- ensure that the commitAllowingStateLoss is actually not dangerous - we
only had one case I could see where we were actually doing a transaction
from a loader callback and I fixed that just now to not do any
transactions.

Change-Id: I21e11138f70eb2ce953a5ba54119ca46555f465d
2011-07-19 17:28:58 -07:00
Ben Komalo
dfff72f731 Misc attachment code cleanups
Change-Id: I612b3ed1280d4d057834d3d3e67c8ac17c2bafb6
2011-07-19 15:16:45 -07:00
Ben Komalo
776997e62e Update message compose to phone spec
- move cc/attachment to overflow menu
- misc layout fixes

Bug: 5011868
Change-Id: If17a36c9e7f13115828a957163af5969b6f8f93e
2011-07-18 17:08:35 -07:00
Ben Komalo
9f05f72ab3 Fixup settings entry points.
- include settings in menu in message view
- remove "show all mailboxes" from message view
- rename "Account Settings" to "Settings"

Bug: 5039294
Change-Id: Ic2dcbe8fe6e2bd10cc5d790a74c49a7159b59cab
2011-07-17 16:41:55 -07:00
Eric Fischer
1c810c3f09 Import revised translations.
Change-Id: I2b1a26c9ba36fadd7d4351350dd5322f66c30f6c
2011-07-15 16:48:48 -07:00
Jorge Lugo
8e779e627a Accessibility improvements
TalkBack functions properly with MessageList items, as well as
"reply," "reply-all," and "forward" buttons while viewing messages.
It is now also possible to switch accounts using only a dpad
or trackball. Finally, EditText fields in account setup also work
with TalkBack now.

Checkmarks don't work with Talkback, but this I have confirmed and
reported it as frameworks bug.

Change-Id: I7f72682a517eef4fa122241c675026fe7997ac64
2011-07-15 09:08:13 -07:00
Ben Komalo
08f068c9ce Update message header actions for phones.
- This creates a "more" icon in portrait and shows all three actions
(reply/replyall/forward) in landscape.
- also makes the star visible by default (hiding it in EML view)

Change-Id: Iefff7c0717cfda4dc91218b0d490775294c96103
2011-07-14 17:23:21 -07:00
Ben Komalo
9e8da783a8 Fix action bar text styles.
This makes custom styles in landscape,portrait, and tablet mode since
the action bar real estate differs in those modes.

Bug: 5010826
Change-Id: I2bd6bdcf9adc44a4d0084d4b2bfbffb472f03643
2011-07-11 18:29:18 -07:00
Ben Komalo
e05f511a4e Add entry in settings to clear trusted senders
Bug: 5011682
Change-Id: I09a557e4bb0ce3e17f796bcc5693e405f23e8c7e
2011-07-11 12:14:26 -07:00
Makoto Onuki
1ddc2ca4a7 Per-mailbox settings
- Use PreferenceActivity, in the old style, meaning without PreferenceFragment.
- If setting Inbox, change the account settings instead of mailbox settings.
- Use the DialogWhenLarge theme, meaning it's a full-screen avitity on the
  phone and a dialog on the tablet.
- Also fixed the bug that we the menu items that are made invisible by
  UIControllerBase may be made re-visible by the 1-pane controller.

TODO The menu item shouldn't be shown for non-syncable mailboxes.

Change-Id: I02b2faf6f593e1e2eb370217c27801aa58ca7e6c
2011-07-10 12:09:51 -07:00
Ben Komalo
d8ab562d0d Reduce startup time via Welcome.
In the common case, we don't need the "waiting for sync..." message, so
avoid inflation in those cases and just inflate on demand.

Also do a quick drive-by fix for the error message being pushed in way
too much on phones

Change-Id: Ie7a8472194659a52069d1ee21e0a0cb9b6fc91ba
2011-07-06 11:14:04 -04:00
Ben Komalo
ad359c8fdf Quick fixes to unread count
Makes it consistent in the header and dropdown

Change-Id: Iec97678fa8704c6c4cf8c8eb129c94321f34949b
2011-06-30 16:26:02 -07:00
Ben Komalo
9b4f11a4ed Show a search results header.
The count will be wired in and shown in here.

Change-Id: I2f496dcd86d748ee1c17c8e819b65c61c098a8ba
2011-06-27 19:59:23 -07:00
Makoto Onuki
569083fab3 Merge "New account spinner" 2011-06-27 13:22:41 -07:00
Makoto Onuki
4689cb7100 New account spinner
- Don't use the action bar spinner.
  Instead use a custom view to show the current account.
  (It's not a spinner; now we show the dropdown list by ourselves,
  which gives us more detailed control.)

- Also show the current mailbox name/unread count with the account name.

- Removed the mailbox info loader in ABC.
  Instead, now the AccountSelectorAdapter loader loads the current
  account/mailbox name, and the unread count as extras.

- Now ABC.Callback.onMailboxSelected passed an account ID as well
  as a mailbox ID.

- There's new code paths that can cause the "fragment transaction in
  onLoadFinished" exception.  We need to fix this properly, but
  for now we just use commitAllowingStateLoss().

Bug 4948352

Change-Id: I73bb8b7530f8328ca1c86382ac0a54086ad061d7
2011-06-27 13:19:27 -07:00
Ben Komalo
b1f3c2d73f Merge "Improved "show pictures" support." 2011-06-27 10:00:49 -07:00
Makoto Onuki
679ab33ed5 Fix log spew: Attempt to retrieve bag ...
Bug 4949998

Change-Id: I8b6c88b16ad7657c3e5c247c28fc026129cb86f3
2011-06-26 13:21:39 -07:00