Commit Graph

3552 Commits

Author SHA1 Message Date
Jorge Lugo
56593af65a Pre-populate contentDescription for MessageListItems
Always populate the contentDesription rather than only
when dispatchPopulateAccessibilityEvent() is called. Makes
life easier for testing.

Bug: 5129286
Change-Id: Ide897b81ff30708b9d637cebbf8eb63f06084a74
2011-08-09 16:56:21 -07:00
Jorge Lugo
757c73634d Merge "Allow pre-populating of content descriptions when testing" 2011-08-09 14:49:50 -07:00
Jorge Lugo
70a3f21041 Allow pre-populating of content descriptions when testing
Creates isTesting flag in MessageListItem. When set to true,
populates the contentDescription of each message on initialization
rather than on touch.

Bug: 5129286
Change-Id: Ia0df93bf7399859a750a3fa01e5429436b9daf16
2011-08-09 13:16:30 -07:00
Ben Komalo
03bc225d08 Show color chips in account spinner.
Bug: 5011742
Change-Id: I6aa3d24b83ee1378bf30fb8466a52c6787d27277
2011-08-09 11:27:47 -07:00
Ben Komalo
2c4a6855ba Make isInboxList check robust to combined views.
rookie mistake :(

Bug: 5141774
Change-Id: Iafc4907a4717143ccf8251a1fb452e1ff00aa5ff
2011-08-09 10:44:43 -07:00
Ben Komalo
e91ff527ed Update backstack model.
This makes "Inbox" the top level with the mailbox list one level under.
All "up"/"back" navigation is now identical and will take you upwards
towards the inbox before falling off to the launcher.

This uses a kludge and the "backstack" of the activity is not actually
represented now by the mPreviousFragment variable; it just uses tricker
in the onBackPressed()/shouldPopFromBackStack() calls to do the right
thing.

Bug: 5111629
Change-Id: Ide88efc78fe4f40d89b5ab83c480318e81902554
2011-08-08 17:38:21 -07:00
Ben Komalo
ed494cd6bb Fix search styling.
This eliminates the excessive padding on the left and makes the hint
text behave according to the new spec (since it uses the new action view
expanded mode).

A later CL will actually change the item to use the action view
facilities of the framework (so we don't have to manage our own custom
views).

Bug: 5109953
Change-Id: Ia3e4a1e64e65b3b8bb3e708b31636f4186acfd46
2011-08-08 17:16:47 -07:00
Ben Komalo
547cae3c8e Move reply/replyall/forward spinner to actionbar.
Bug: 5126487
Change-Id: I56cd8861d6d616d1c4590f06c6f949cd84e5a42b
2011-08-08 15:17:42 -07:00
Ben Komalo
3fdf92c977 Merge "Move IntentUtils to emailcommon." 2011-08-08 15:15:44 -07:00
Jorge Lugo
cf8a36531f Remove done button from edit quick responses
Removes done button from edit quick resposnses fragment and
centers the "create new" button.

Bug: 5111173
Change-Id: Ia847725e5d3bdc67426f76dd386f2263befe4189
2011-08-08 14:56:47 -07:00
Ben Komalo
0e6a521747 Move IntentUtils to emailcommon.
This is needed so Exchange can fire up Email activities.
No change other than the move.

Bug: 5122497
Change-Id: I6ee3f61654745fafd444314ecf75eb8ae6bbd01d
2011-08-08 14:39:19 -07:00
Ben Komalo
e9dad11e1a Merge "Avoid NPE when subject/snippet are null." 2011-08-08 11:30:38 -07:00
Ben Komalo
86ed3c07a8 Merge "Compose UI fixes" 2011-08-08 11:30:04 -07:00
Ben Komalo
dce6aafe4e Avoid NPE when subject/snippet are null.
There are cases when subject and snippet re null. If the MessageListItem
is not being recycled (i.e. it's the first time), this can be detected
as "no change from the previous state (of being empty)", which doesn't
initialize mText.

Bug: 5129307
Change-Id: I6df910fb365b7e8c1dd298f787d21fbb438830fd
2011-08-07 16:12:35 -07:00
Ben Komalo
03cb4a2135 Merge "Hide sync options and search icon when appropriate" 2011-08-07 15:44:30 -07:00
Ben Komalo
37a7469716 Hide sync options and search icon when appropriate
- hide sync options for mailboxes that aren't actually syncable
- hide search icon for any mailboxes that don't have any server
counterparts

Bug: 5086134
Change-Id: I60d5e5d1225a946464c5ea273c7d4b9299f433e5
2011-08-07 15:40:12 -07:00
Ben Komalo
b86da6b913 Compose UI fixes
- don't show error message if there are chips

Bug: 5126958
Change-Id: I65a22555260b00ded1df49668cde09b03d7f7d90
2011-08-07 15:37:01 -07:00
Ben Komalo
5b4a214240 Merge "Fix SSL certificate selection for exchange." 2011-08-07 15:04:57 -07:00
Ben Komalo
994343b14b Fix SSL certificate selection for exchange.
- Since the Email and Exchange processes do not share UID, we need to
ensure the call to the KeyChain to request the certificate happens in
the Exchange process
- Misc UI fixes so it's not so ugly

Bug: 5117682
Change-Id: If80698850902e0178eb0998493b4cf4b89e2a15c
2011-08-05 11:28:52 -07:00
Ben Komalo
330b1273af Fix show pictures to not look broken.
- this still needs an asset for the "checkmark" button when showing
"always show pictures" prompt - using a checkbox on state as a
placeholder but it's probably not the best thing for it

Bug: 5037485
Change-Id: Iaa1d0f865bf0c01fde0b0cb37ea1c395345ed582
2011-08-05 10:02:30 -07:00
Marc Blank
a08f654a1a Merge "Catch case where provider reports returning null in error" 2011-08-05 09:56:35 -07:00
Marc Blank
577e604df0 Catch case where provider reports returning null in error
* Missed this one

Change-Id: I080bd3b910827336fcfde818564067db5b4ec3cc
2011-08-05 09:50:56 -07:00
Marc Blank
20b511ff68 Handle GB->ICS upgrade of POP3 accounts properly
* Heh.
* We were using the login from the HostAuth in creating the Account
  Manager account, but it should be the email address from the
  Account itself; in IMAP (and usually in POP3) these are the same
* But not for juno.com!
* Updated unit test coming in another CL (tests are broken in a
  strange way, and the bug is FAST-blocker)

Bug: 5110013
Change-Id: Id11799e8b30a0420804f00c2d2f265e44e39c4c0
2011-08-04 19:03:07 -07:00
Ben Komalo
6be8cceadd Update sync settings UI to specs
- minor text changes
- use light holo theme
- slight order changes

Bug: 5110452
Change-Id: Icf558ee495860dc97048765d3b8d09d31161dd32
2011-08-03 17:25:10 -07:00
Marc Blank
4418596f9b Merge "More whack-a-mole in AttachmentDownloadService" 2011-08-03 14:55:26 -07:00
Marc Blank
c74874c4af Merge "Fix NPE in NfcHandler" 2011-08-03 14:54:46 -07:00
Marc Blank
433b0ed9fe More whack-a-mole in AttachmentDownloadService
Bug: 5115008
Change-Id: I6e5236e08331cfd6a9a11868d97bf5caaf68f6fe
2011-08-03 13:28:01 -07:00
Marc Blank
2208f5dce9 Fix NPE in NfcHandler
Bug: 5115848
Change-Id: I8e581aa77363bc1f33eb3267be5c924fba772aae
2011-08-03 12:56:47 -07:00
Ben Komalo
5497cae94c Fix issues with state restoration in messagelist
- immediate issue was the the mIsFirstLoad flag was on the Loader
instead of the list - since the Loader is retained on rotation, we
didn't the initial list setup after rotation leaving the list in an
infinite "loading" state
- second issue was that list scroll state was being handled poorly - it
was always saved and restored needlessly. However, if two subsequent
loads happened prior to a layout, saving the list state actually saved
bad values (the restored state only seems to take effect after layout)
- third issue was the footer mode was being handled poorly as well - it
was always updated, which required re-setting the adapter every time,
which reset the scroll position. This was why we were always trying to
save/restore scroll position.

Overall this should speed up the list loading and data updates in the
list by a bunch.

Bug: 5110000
Change-Id: Id2f6db928c095ae10ee55b40e7e9241d70e0bebe
2011-08-03 11:23:15 -07:00
Ben Komalo
0a12a6636c Merge "Minor visual fixes in message list" 2011-08-03 10:40:36 -07:00
Ben Komalo
2313f48bdc Minor visual fixes in message list
- changed activated font to white
- ensure activated bg is set even for wide (as it shows for a split
  second when you select a message right before the slide animation)
- attempt to make the animation not so abrupt

Bug: 5110992
Change-Id: Ie05e0a6a09afb97155b26d28672d4a2fb79cc563
2011-08-02 15:19:10 -07:00
Ben Komalo
263d0ec707 Fix account spinner width.
- make it take up different size on phones and tablets (also landscape
  phone/portrait phone)
- move unread count outside of the spinner area

Bug: 5108972
Bug: 5111250
Change-Id: I2c16bbb52ce53bbf1c8fe08fd78f1a4b4afd4ccf
2011-08-02 15:04:48 -07:00
Ben Komalo
171d7303c8 Merge "Update message list item redlines." 2011-08-02 14:15:54 -07:00
Ben Komalo
383279a1c5 Update message list item redlines.
- reduces number of "modes" to just two: normal and wide
- consolidate the normal/narrow modes for phone and tablet (as per spec)
  with the only diff on the tablet being side paddings
- fix issue with "white arrow" visual being shown in phone when tapping
  on a message
- make touch computations be resilient to padding values instead of
  assuming that the check/star icons are right at the left/right

Bug: 5103823

Change-Id: I23f967454f7744d9c59256625e302e54a353994a
2011-08-02 14:05:05 -07:00
Marc Blank
36aef9fb74 Add logging to v21->v22 upgrade; small cleanup
Change-Id: I6659998a3ad2490c923061aab5328469c3222e25
2011-08-02 11:51:21 -07:00
Ben Komalo
c1312ff65f Merge "Save IMAP prefix." 2011-08-01 17:45:18 -07:00
Ben Komalo
bcd1339610 Merge "Minor changes to actionbar for message view" 2011-08-01 14:38:56 -07:00
Marc Blank
b6e2bd85a4 Merge "Make "security required" notification ongoing" 2011-08-01 14:20:11 -07:00
Ben Komalo
3baefc2da0 Minor changes to actionbar for message view
- hides the unread count and account name
- makes the subject two lines

Bug: 5103483
Change-Id: Ied537a0c7d8142ecebe49638a814010790433299
2011-08-01 13:58:35 -07:00
Ben Komalo
5125c06cef Save IMAP prefix.
Bug: 4517078
Change-Id: I4f4a1e490abc78088ec8ded4e4627e5da1ac3fd2
2011-08-01 12:56:55 -07:00
Marc Blank
27a04fecfb Fix EmailProvider database upgrades
* Two of the upgrades (v21->v22 and v25->v26) need to be fixed so
  that they don't reference columns that might not exist.
* Oops

Bug: 4439595
Change-Id: I4a8c556be22bb85fb78807416cd1d6b81c6ef118
2011-07-29 21:53:44 -07:00
Ben Komalo
8bdfee9eec Merge "Update assets" 2011-07-29 10:24:38 -07:00
Ben Komalo
d9e8dcae2f Update assets
- updated checkboxes (new ones for sw600dp and phone)
  ones for phone)
- updated stars (new ones for sw600dp and phone)
- added existing cc/bcc icon to menu item
- updated reply/replyall/forward actions to dark themed items (renames
involved)
- update message list backgrounds (new ones for hdpi,xhdpi, renamed
  everything so that there is no message_ or conversation_
  suffixes, also added missing states for some of the selectors)

Change-Id: I1b4f49f206b846566870f5b430e3c6386e621a0c
2011-07-28 14:40:02 -07:00
Marc Blank
1f825aa538 Merge "Catch NPE in AttachmentDownloadService" 2011-07-28 14:22:44 -07:00
Marc Blank
d9b2a8f237 Make "security required" notification ongoing
* While investigating the referenced bug, it was discovered that
  canceling the "security required" notification (with "X", rather
  than the "cancel" option in the dialog) causes the notification
  to be unavailable until a reboot
* This puts the account needing a security update in the position
  of being unsyncable, and might explain the referenced bug (we
  have no confirmation of that step; on the other hand, the tester
  can't now reproduce the problem, so an unusual action like this
  is to be expected)
* The fix consists of making this particular notification "ongoing",
  which prevents the user from dismissing it; arguably, this should
  always have been the case anyway...
* Consider this fix for backport into LTE and MR2 branches

Bug: 5072343
Change-Id: Ia7419236cf9389380d1e079b1a9a6f425015c487
2011-07-28 13:59:16 -07:00
Marc Blank
0306da14e3 Correct recently added EmailProvider logging
Change-Id: Ica61b7bcbe455448a1a261c83defa840ab1abf3e
2011-07-27 21:57:06 -07:00
Ben Komalo
f64fd6fe71 Merge "Search delay fixes." 2011-07-27 20:28:17 -07:00
Marc Blank
7390b18776 Log return of null from query()
* This shouldn't happen, but ... log it just in case

Change-Id: I8b8df3fec84c9dd14ebb222ee665b0712f63f213
2011-07-27 16:48:35 -07:00
Marc Blank
41c63a05eb Catch NPE in AttachmentDownloadService
%$!@#*&%

Bug: 5055519
Change-Id: Ie155c8d0f9931b51613f7d77e4545531bc148964
2011-07-27 15:53:51 -07:00
Ben Komalo
391b9d4abd Search delay fixes.
- adds a loading state to search so the user isn't left with a blank
screen for several seconds
- adds a timeout so that a warning message is shown for results that
take over 10 seconds
- use default loading/no message views in ListFragment so we don't have
to manager our own stuff

Bug: 5014107
Bug: 5037618
Change-Id: I8b03fa0967055989156c7777901affc777c4fae7
2011-07-27 11:37:54 -07:00
Ben Komalo
1340b2f82b Hide irrelevant options in mailboxlist.
Bug: 5080327
Change-Id: Ief9544b9d8a70a16b90f268bca1342b697fc6962
2011-07-26 13:32:05 -07:00
Martijn Coenen
c34e2dcb3d Merge "NFC zero-click sharing for Email." 2011-07-26 11:32:05 -07:00
Marc Blank
1278df63de Merge "Ignore watchdog alarms for stopped service" 2011-07-26 10:22:21 -07:00
Marc Blank
cb2f0a8bb9 Ignore watchdog alarms for stopped service
Bug: 5055519
Change-Id: I35352364f3f2842932ad40e47d70646bb6d42349
2011-07-26 09:59:10 -07:00
Martijn Coenen
e5b15cd3c8 NFC zero-click sharing for Email.
This shares the e-mail address of the currently shown account
over P2P NFC links. Note that the currently set account must
be updated actively, because the callback to create the message
comes from one of the NFC threads, which don't have permissions
to retrieve the account and the correspondig e-mail address.

Change-Id: I12e48a3787d469179e7ca074429106ed24e3a212
2011-07-26 11:45:11 -05:00
Ben Komalo
1f02d123d2 Merge "Fix mailbox finding and unit tests." 2011-07-25 17:15:36 -07:00
Ben Komalo
cb1d65c478 Fix mailbox finding and unit tests.
We seemed to not properly fallback to querying the database if the cache
did not contain a mailbox of a specific type. We may want to consider
caching mailboxes related to PIM data, but for now this is a quick fix.

Also fixes unit tests.

Bug: 5019661
Change-Id: Idcac0a6f15aa7f174890ae586f478fbb8f6e05b7
2011-07-25 16:51:47 -07:00
Mindy Pereira
79198b913f chips: Use view instead of string.
This allows us to get the correctly styled more view.

Change-Id: Ifebea40eb2b0a27a5aba772c628cf95d22445e38
2011-07-25 14:39:17 -07:00
Ben Komalo
50f4fbf2f6 Merge "Add in settings menu in Welcome." 2011-07-25 13:41:48 -07:00
Ben Komalo
74acf8d9de Add in settings menu in Welcome.
This will avoid cases where the user is permanently stuck, if we fail to
error out when a failed sync occurs or for any reason.

Bug: 5032763
Change-Id: Ib82a62add767d13dc844a90e5ea4147d3ada59dd
2011-07-25 13:32:48 -07:00
Mindy Pereira
ec44a47940 chips: the seperator methods are no longer needed.
Check this in after:
https://android-git.corp.google.com/g/#change,123745

Change-Id: I3228251debfd4a81cd2dc16f05636d64533f9c6d
2011-07-25 13:26:58 -07:00
Ben Komalo
30183e536e Merge "Always show from field in compose" 2011-07-22 16:10:24 -07:00
Ben Komalo
72a24f12a2 Misc settings UX fixes.
Bug: 5068602
Change-Id: I02acf3690e98ce747ddb4d3a745ac2fa59948c70
2011-07-22 16:04:10 -07:00
Ben Komalo
2903be7f3e Always show from field in compose
This info used to be shown in the top right of the status bar in GB but
that is no longer there. So before this change there was no way to tell
who you were sending as.

Bug: 5069124
Change-Id: I10d687a5fd221e65ecfc71b61cccf306492e27b8
2011-07-22 15:52:38 -07:00
Ben Komalo
48a3a1c51c Ignore notifications for unloaded messages
Seems like POP envelopes could get into the database and tickle the
NotificationController even before we got the full subject/sender. Just
ignore those things until the basic info is loaded.

Bug: 5061271
Change-Id: Iadfbff8a1615d2644880f5cae3727768f4f9549a
2011-07-22 13:31:47 -07:00
Ben Komalo
ccb70fcad9 Merge "Fix notification issues." 2011-07-22 13:23:42 -07:00
Ben Komalo
23a4b15e08 Fix notification issues.
- use title as ticker text
- also properly play notification sounds on new messages. Before, if you
left a notification unread, and a new message comes in, no sound would
be played. Since fixing that, it introduces another issue where on
initial sync, tons of new messages come in (and the sync could take > 1
min). We throttle them with a 15 second interval. The notification is
always updated to reflect the most up to date information, but sounds
will never be played closer than 15 seconds together.

Bug: 5020191
Bug: 5067059
Change-Id: I5ca474fd3b210ee856035bd78bd72931da80fe40
2011-07-22 12:06:11 -07:00
Ben Komalo
a10d4a8e45 Prevent crash when composing a message on tablets.
We were hiding the cc/bcc menu option, but on tablets that is a visible
button on the UI and not in the menu. whoops.

Bug: 5067057
Change-Id: I10ecaf115b589b9200529f6ea7703428456b8f0f
2011-07-22 10:00:39 -07:00
Ben Komalo
6a902861e9 Merge "Don't touch the cursor in the background" 2011-07-21 20:45:52 -07:00
Ben Komalo
b30d635dd0 Merge "Guard against null items in NotificationController" 2011-07-21 20:35:00 -07:00
Jorge Lugo
a926c32aa2 Merge "Improved shortcut name" 2011-07-21 19:46:44 -07:00
Jorge Lugo
7496b5ba2b Merge "Display message when no quick respones available" 2011-07-21 19:44:31 -07:00
Ben Komalo
5fb6c5d4de Don't touch the cursor in the background
This prevents accessing a potentially closed cursor when doing batch
operations that will inevitable cause the the list to be reloaded (and
cursor to be invalidated) as the first of the messages are
touched

Bug: 5051730
Change-Id: I90328ee02eafe6ad238d8c57e88a3d96259f6547
2011-07-21 19:41:07 -07:00
Jorge Lugo
4ca1ca8622 Display message when no quick respones available
When editing quick responses, displays an appropriate
message letting users know that there are no quick responses.
Additionally, the MessageCompose activity will only show "insert quick
responses" when at least one exists.

Bug: 4948180
Change-Id: I1191bd54d6e64f990b6d6830f0837579d7a6918c
2011-07-21 19:06:17 -07:00
Jorge Lugo
79fab5ae62 Improved shortcut name
Shortcut name is now the name of folder when it's a non-inbox
folder; otherwise it's the account name. Previously was
always account name.

Bug: 4903490
Change-Id: I15b4024d28db6a48464e423db887bdca99132423
2011-07-21 18:39:10 -07:00
Ben Komalo
af5826cc7a Merge "Optimizations to startup." 2011-07-21 17:56:26 -07:00
Ben Komalo
80b817714f Optimizations to startup.
- don't inflate search views - inflate them on demand
- kill some unneeded containers

Bug: 4996847
Change-Id: I7747e194e7c0939ad6416f351096639b283f4899
2011-07-21 17:38:19 -07:00
Ben Komalo
9867d8a160 Merge "Prevent touching closed cursor" 2011-07-21 13:50:51 -07:00
Ben Komalo
87d8ab4bb4 Prevent touching closed cursor
Bug: 4595568
Change-Id: Ic3087dc5f194aa879a3fea9d45fe77a1e285bde0
2011-07-21 13:01:31 -07:00
Ben Komalo
5479f061ab Remove cc/bcc option from menu when used.
Bug: 5055403
Change-Id: I3a349ddf7b5b186bb6daccd7151b8b352cab0050
2011-07-21 12:34:53 -07:00
Ben Komalo
eb9dcfaf18 Guard against null items in NotificationController
If the account is in the process of being deleted, large parts of its
data may be being removed in parallel with notification processing. We
never handled this very well.

Bug: 5058333
Change-Id: Ic588b68438a9c5829e7e3fd5c8d52e21a037b9f4
2011-07-21 12:24:18 -07:00
Ben Komalo
9d0bb2e3a0 Hide attachment size info if unknown.
Bug: 5011871
Change-Id: Ide56b79c036b16a66720228660f3eed76a9c9ba2
2011-07-20 18:19:48 -07:00
Ben Komalo
8d8814ed35 Consider attachments for empty messages
Since we thought the message was empty, tapping on back doesn't save the
draft.

Bug: 5057044
Change-Id: I99d903430b0e0a40dc23eb805cf24961e9ca2301
2011-07-20 17:15:35 -07:00
Ben Komalo
3f0ac78eab Merge "Remove "Move" action on POP." 2011-07-20 15:11:33 -07:00
Ben Komalo
81a153463b Remove "Move" action on POP.
Bug: 5010614
Change-Id: If0a94840e9dc104566ba39d2e3240883dab5bba0
2011-07-20 13:21:06 -07:00
Ben Komalo
7688300055 Fix sync window settings for EAS setup on phones
- the container is the one that should be visible/gone - individual
fields should just be visible
- also do drive by javadoc fixes

Bug: 5052310
Change-Id: I45c4b6b7f94b2b62ac94eeff0ab97bf34c9e117a
2011-07-20 11:27:11 -07:00
Ben Komalo
6496562610 Merge "Prevent search on POP" 2011-07-20 11:06:56 -07:00
Ben Komalo
5aa3d71209 Prevent search on POP
We were hiding the search icon from the actionbar but didn't take into
account the use of a hardware button.

Bug: 5051691
Change-Id: I2e0bfd1d0bb4faa3238e567c02189894db5f6c44
2011-07-20 11:06:28 -07:00
Ben Komalo
1ecfb5311b Remove illegal references to IsolatedContext
This fixes a crash on account deletion, leaving around bad accounts that
were in limbo
Also remove a test for an unsupported operation

Bug: 5051951
Change-Id: Ieebc7f769075614ae1a656cf123d8ce0313e611d
2011-07-20 10:52:47 -07:00
Marc Blank
e12c0522f8 Merge "Remove NotificationService; use Account columns for data storage" 2011-07-19 19:36:57 -07:00
Marc Blank
aca9426581 Remove NotificationService; use Account columns for data storage
Bug: 5023662
Change-Id: I84df3b474dd6320327851003af985144cc16348e
2011-07-19 18:19:59 -07:00
Ben Komalo
c01ce156e8 Minor change to keep same account if possible.
On second thought, it's probably best to stick with the same account if
I can't find a particular folder. This at least is less jarring if the
user has multiple accounts.

Change-Id: Ifd5d631b220e260399681008ac17203f5451c8ff
2011-07-19 18:16:10 -07:00
Ben Komalo
1ef8ec61c9 Misc STOPSHIP cleanups.
Apply the same logic to mailboxnotfound for two pane.
also remove some obsolete callbacks.

Change-Id: I942c2b557fce2601a0e46878cfe4d5ce2cc83850
2011-07-19 17:51:36 -07:00
Ben Komalo
0413edd626 Remove STOPSHIP
- ensure that the commitAllowingStateLoss is actually not dangerous - we
only had one case I could see where we were actually doing a transaction
from a loader callback and I fixed that just now to not do any
transactions.

Change-Id: I21e11138f70eb2ce953a5ba54119ca46555f465d
2011-07-19 17:28:58 -07:00
Ben Komalo
6edddbf714 Merge "Misc attachment code cleanups" 2011-07-19 15:26:45 -07:00
Ben Komalo
dfff72f731 Misc attachment code cleanups
Change-Id: I612b3ed1280d4d057834d3d3e67c8ac17c2bafb6
2011-07-19 15:16:45 -07:00
Marc Blank
c6df1d605f Prevent NPE's in AccountSecurity
* This CL fixes the referenced bug, but it does NOT explain how
  mAccount; best guess is that the process was killed and then
  restarted when the result from DPM was available.
* Assuming this is the case, we remove the background task loading
  mAccount, avoiding a possible race.
* Also, it's not clear why clearNotifications didn't use the
  account id argument; what if there's more than one account that
  uses security?  Filing a bug about this.

Bug: 5048912
Change-Id: I734834337ab6e409d77624e7c7370350de76becb
2011-07-19 14:38:29 -07:00
Marc Blank
d1f03736e6 Merge "Clean up account reconciliation" 2011-07-19 13:25:25 -07:00
Marc Blank
4e4aba9ebc Clean up account reconciliation
* Move AccountReconciler to the Email app (from EmailCommon)
* Ensure that Controller.deleteAccountSync() performs ALL actions
  needed to clean up after an account deletion (delete attachment
  files, reset policies, refresh the UI, etc.)
* Add reconcileAccounts() API to AccountService
* Remove accountDeleted() and restoreAccountsIfNeede() from the
  AccountService API
* Remove unused callback

Bug: 4883073
Bug: 4767084

Change-Id: I43ffaf009db1a6f306bb0f2a74fb4dd3b2c4b966
2011-07-19 10:31:33 -07:00
Jorge Lugo
5ce13dba1f Merge "Preference panel screen titles don't change on rotate" 2011-07-19 09:54:46 -07:00
Ben Komalo
18811dfb45 Add touch slop to message list items
Bug: 5016987
Change-Id: Iddeb9a7bc244d3215a418f0897778b9ddcb3e955
2011-07-18 17:53:45 -07:00
Ben Komalo
776997e62e Update message compose to phone spec
- move cc/attachment to overflow menu
- misc layout fixes

Bug: 5011868
Change-Id: If17a36c9e7f13115828a957163af5969b6f8f93e
2011-07-18 17:08:35 -07:00
Jorge Lugo
ae594dc0ca Preference panel screen titles don't change on rotate
Incoming settings, outgoing settings, exchange settings, and
edit quick response preference panel titles no longer
change to "Account settings" when screen is rotate.

Bug: 5011355
Change-Id: Ibaf68bc836a61777de929623bff2bf2dd4ae0c3b
2011-07-18 15:43:08 -07:00
Marc Blank
ecf8672df2 Merge "Fix NPE in onStartCommand" 2011-07-18 10:18:11 -07:00
Marc Blank
b31b798b46 Merge "Don't allow actions on empty sets" 2011-07-18 09:51:32 -07:00
Marc Blank
b8f672465a Merge "Remove unnecessary EmailAsyncTask" 2011-07-18 09:51:01 -07:00
Marc Blank
90a4811551 Fix NPE in onStartCommand
Bug: 5041436
Change-Id: Ib7462e5c8cb040b7526d9a655c5ab3f41cd159b8
2011-07-18 09:49:52 -07:00
Marc Blank
21cbdd88e1 Merge "Start/stop AttachmentDownloadService as needed" 2011-07-17 18:11:08 -07:00
Marc Blank
b2a8c2ce4c Start/stop AttachmentDownloadService as needed
Bug: 5033646
Change-Id: Ic0e75b28d0d8d5665c3f3ca864a9532fee05df8c
2011-07-17 18:06:20 -07:00
Ben Komalo
e71a19a523 Build default mailboxes for POP3
Bug: 4580535
Change-Id: Ic800eed387d3e9e64e95cce691d13d98b4a48045
2011-07-17 17:48:31 -07:00
Ben Komalo
2126caf076 Merge "Fix NPE in MailboxListFragment" 2011-07-17 17:29:33 -07:00
Ben Komalo
48f4df0911 Merge "Fixup settings entry points." 2011-07-17 17:29:10 -07:00
Ben Komalo
3c4061ae61 Merge "Filter out inbox from recent mailboxes" 2011-07-17 17:28:28 -07:00
Marc Blank
1d0609d386 Don't allow actions on empty sets
* Not sure how this could have happened, except possibly for some
  race condition
* Let's make sure it's impossible

Bug: 5032454
Change-Id: Ibd4de22dc5298fbaaf224cf4286f63bdc50aa7b9
2011-07-17 17:25:38 -07:00
Ben Komalo
9f05f72ab3 Fixup settings entry points.
- include settings in menu in message view
- remove "show all mailboxes" from message view
- rename "Account Settings" to "Settings"

Bug: 5039294
Change-Id: Ic2dcbe8fe6e2bd10cc5d790a74c49a7159b59cab
2011-07-17 16:41:55 -07:00
Ben Komalo
2be03be9b3 Merge "Remove temp code that was causing an NPE" 2011-07-17 16:41:18 -07:00
Ben Komalo
64a6a1f488 Merge "Show proper quick contact mode." 2011-07-17 16:40:37 -07:00
Ben Komalo
6b4a20730f Show proper quick contact mode.
- doesn't repeat the name
- shows status and right icons instead

Bug: 5039507
Change-Id: Id86d84a8ed54032f283454c83212ae962e8fc179
2011-07-17 16:24:18 -07:00
Ben Komalo
0932da35f5 Filter out inbox from recent mailboxes
Bug: 5039553
Change-Id: I9b58e9331028250f9bc3027429d2a6ec418186d6
2011-07-17 16:21:01 -07:00
Ben Komalo
afbba1bcbb Fix NPE in MailboxListFragment
Bug: 5037646
Change-Id: I74420d68398446f602ebe858760d9aaf5f88c107
2011-07-17 16:02:02 -07:00
Marc Blank
3793ec2463 Merge "Handle message sets in a single EmailAsyncTask" 2011-07-17 15:54:34 -07:00
Marc Blank
e2d28a0607 Clear "security needed" notification when releasing holds
* This fixes the issues with erroneous notifications remaining
  active

Bug: 5039388
Change-Id: Ib1cd506e732e34f6368036a131d79270b22d4a4b
2011-07-17 15:46:03 -07:00
Ben Komalo
14ea7d7bbc Merge "Fix possible NPE for messages with no subjects" 2011-07-17 15:03:35 -07:00
Marc Blank
f29221efc9 Remove unnecessary EmailAsyncTask
Change-Id: Ifb13f2f57016191f7ef409aa656bf9cb840f42c9
2011-07-17 12:23:49 -07:00
Marc Blank
b81a31b29b Handle message sets in a single EmailAsyncTask
* This prevents the possibility of RejectedExecutionException when
  selecting large numbers of items

Change-Id: I8f9ba287d69021fdb99b4a8a30cc79755f669b97
2011-07-16 16:11:00 -07:00
Ben Komalo
7f876c0375 Fix possible NPE for messages with no subjects
Bug: 5038097
Change-Id: I0952158017c0d512998f423ecd38722a5b6b8afc
2011-07-15 19:13:22 -07:00
Marc Blank
eb642812bf Merge "Clear account incomplete flag properly; handle unusual flow" 2011-07-15 19:07:17 -07:00
Ben Komalo
2845d72af0 Remove temp code that was causing an NPE
- since listContext can be null, this code was not safe.
we also filter out the search mailbox too, so it's no longer needed.
- don't ask to highlight a mailbox if doing a search
- remove a call in MailboxListFragment that was unconditionally telling
callbacks that something was selected when we started loading - this was
technically lying and if the item isn't in the list that was selected,
nothing should be called (as in the case of search). This was just an
optimization anyways and that callback is invoked later when the mailbox
list load completes.

Bug: 5037629
Change-Id: Id31c6795af9e64fa8682b67de9ab90540ee660df
2011-07-15 18:42:14 -07:00
Ben Komalo
0796b8aa61 Don't save empty drafts.
Note: all unicode sending unit tests are broken due to chip issues. I've
filed a separate bug on that.

Bug: 5012204
Change-Id: I17392f65e5bd8349780b79d9cbe10492d8e7a7d9
2011-07-15 16:47:36 -07:00
Marc Blank
8df9af0df3 Clear account incomplete flag properly; handle unusual flow
* We waited to clear the incomplete flag until security was agreed
  to, but this can lead to accounts left incomplete; we now clear
  the flag as soon as the AccountManager account is created (by
  convention, this is when the EmailProvider account is complete)
* Also, allow onDone() to be called more than once with a saved
  account, leaving cleanly, rather than throwing a runtime
  exception

Bug: 5016792
Change-Id: Ib5fc44ac045a1dd9bd5d63f922c037ed637d5341
2011-07-15 16:23:11 -07:00
Jorge Lugo
1086830bae Merge "Improve accessibility for stars and settings" 2011-07-15 15:21:44 -07:00
Jorge Lugo
fad7378031 Merge "Don't save empty quick responses; show keyboard on phone" 2011-07-15 15:20:48 -07:00
Ben Komalo
cbfbe1db2d Toggle selection on list item on long press
Bug: 5020642
Change-Id: I31498122a4fe41cc81e5dbad5550a5e6620924c4
2011-07-15 14:49:26 -07:00
Jorge Lugo
8e779e627a Accessibility improvements
TalkBack functions properly with MessageList items, as well as
"reply," "reply-all," and "forward" buttons while viewing messages.
It is now also possible to switch accounts using only a dpad
or trackball. Finally, EditText fields in account setup also work
with TalkBack now.

Checkmarks don't work with Talkback, but this I have confirmed and
reported it as frameworks bug.

Change-Id: I7f72682a517eef4fa122241c675026fe7997ac64
2011-07-15 09:08:13 -07:00
Ben Komalo
5e52339306 Merge "Update message header actions for phones." 2011-07-14 17:51:00 -07:00
Ben Komalo
91f1d451a6 Merge "Put "show all folders" in action bar" 2011-07-14 17:49:46 -07:00
Ben Komalo
1917bcbc17 Put "show all folders" in action bar
Change-Id: I4af74342b3b1eae3a94ebf6616280ebf47d14e5f
2011-07-14 17:44:00 -07:00
Ben Komalo
08f068c9ce Update message header actions for phones.
- This creates a "more" icon in portrait and shows all three actions
(reply/replyall/forward) in landscape.
- also makes the star visible by default (hiding it in EML view)

Change-Id: Iefff7c0717cfda4dc91218b0d490775294c96103
2011-07-14 17:23:21 -07:00
Marc Blank
68ce7f3d60 Merge "Send proper parameter to startSync (via EmailService)" 2011-07-14 16:14:19 -07:00
Jorge Lugo
7920f5809c Don't save empty quick responses; show keyboard on phone
While creating or editing a quick response, disables the save
button when the edit text is empty. Also, now shows the keyboard
on the phone as soon as the dialog box pops up to edit/create
a quick response.

Bug: 5011277
Change-Id: I9926d07cae0e527a7c08a4cc556a9569a91d2f33
2011-07-14 14:54:09 -07:00
Ben Komalo
b507ece493 Remove stale STOPSHIPs
Change-Id: I2364e1dbf25b9df20ef9fa9014e19cbbab278a3b
2011-07-14 14:45:36 -07:00
Ben Komalo
83b0f4434c Merge "Fixup recent mailboxes." 2011-07-14 12:41:15 -07:00
Ben Komalo
d6ad9b8c03 Fixup recent mailboxes.
The default recent list should be pre-populated and fall off the list as
normal. The previous implementation showed a default list if there were
no touched mailboxes, but then the default list disappeared as soon as
there was one touched.

Bug: 5020673
Change-Id: Ifad607a9d36feff837ab42d039ce9209f223f345
2011-07-14 12:03:16 -07:00
Jorge Lugo
7667632eb2 Improve accessibility for stars and settings
Adding and removing a star triggers the appropriate accessibility
In incoming/outgoing settings, added EditText contentDescriptions.

Change-Id: Ibab461f1425b3ebf3579ebc1d0b36d1a9a5efdb2
2011-07-14 12:01:02 -07:00
Marc Blank
21913ced32 Send proper parameter to startSync (via EmailService)
Bug: 5014063
Change-Id: If236a02e92adef06f2a9ca3779d08778915ed6e9
2011-07-14 11:59:22 -07:00
Jorge Lugo
b9d835a2bb Merge "Don't display warning message on edit incoming settings" 2011-07-14 11:44:50 -07:00
Jorge Lugo
cf194df05c Don't display warning message on edit incoming settings
On phones, opening "incoming settings" no longer immediately displays
the warning message associated with editing the username field. It now
only displays when the username is focused by the user.

Bug: 4282856
Change-Id: Ic0a74fa91a0f9cff66565372872e182a0eaec779
2011-07-14 11:38:30 -07:00
Marc Blank
53dddf3c55 Fix loss of client updates in IMAP when no connectivity
Bug: 5014965
Change-Id: Id5c6696ea1add598f180e739398ab14f60e382a3
2011-07-14 11:04:05 -07:00
Jorge Lugo
f8dbd95695 Don't show To/Cc/Bcc hint text on tablet
Since tablet already has to/cc/bcc labels, don't show the hint
text -- only do so when labels don't exist.

Bug: 5019806
Change-Id: I039de06e2576688e654fb0504a027cd9b9b67def
2011-07-13 18:54:51 -07:00
Jorge Lugo
abec4e631c Merge "Prevent account flip flopping from compose" 2011-07-13 16:35:50 -07:00
Ben Komalo
47e8548682 Merge "Remove dead code" 2011-07-13 15:09:31 -07:00
Ben Komalo
4de538be2d Prevent account flip flopping from compose
There were two issues:
- the default account ID from the provider wasn't consistent: it was
using a snapshot from the cached data but that simply returns a Map, and
the values aren't guaranteed to be sorted (and indeed I saw that the
order was different on consecutive calls!)
- hitting app up from Compose always just kicked you out to the inbox
for the default account, but it probably should have used the account of
the compose screen, since it can be specified in the Intent

Bug: 5012008
Change-Id: Ic9a753b261e047790453bc1a9417bc0c6d2f87f9
2011-07-13 14:46:50 -07:00
Marc Blank
2a33dde4d1 Delete PIM data, etc. on device admin disable
* We were deleting secured accounts when device admin is disabled,
  but we were not deleting associated data, which means that
  contacts, calendar, and attachment data were left on device

Bug: 5021062
Change-Id: Iabeec2dcd6ef4f52dc52e43d62803e61f7881c0d
2011-07-13 09:17:23 -07:00
Ben Komalo
3cfb3d5077 Remove dead code
Change-Id: I66bec3975b3f028081071b9bbd26206ec369da26
2011-07-12 20:42:16 -07:00
Marc Blank
4c0e5c0d0a Remove unneeded (and harmful) test in MessagesAdapter
* This fixes the case in which messages are being loaded upon
  initial sync, but do NOT appear in the message list (at least
  until leaving and re-entering the app/mailbox)
* The problem was that MessagesAdapter was checking the state
  of the HOLDS_MAIL flag, which might not have been set at the
  time the Inbox was created; it turns out that the check is
  not necessary, so we remove it here

Bug: 5008696
Change-Id: I009ddf7d82d938758b99c855dfd0271596c5248a
2011-07-12 16:49:48 -07:00
Marc Blank
6fc054daa6 Merge "Add support for TrafficStats; use with IMAP/POP3" 2011-07-12 11:42:01 -07:00
Ben Komalo
4e32489c55 Merge "Support SMTP servers not requiring auth" 2011-07-12 11:30:35 -07:00
Marc Blank
190b2fb8a1 Add support for TrafficStats; use with IMAP/POP3
* All IMAP/POP3 functionality uses TrafficStats except for
  attachment loading (subsequenc CL)

Bug: 4988322

Change-Id: I91d826e0f7151a2101b642c868ab8c37e9660332
2011-07-12 11:28:58 -07:00
Daisuke Miyakawa
b4983afcec Merge "Reflect changes in chips library" 2011-07-11 16:53:29 -07:00
Ben Komalo
c456c257aa Fix missing imports from bad eclipse settings
Change-Id: Iebc2faa4cb8b125a5ee8071119daa771c66b54b2
2011-07-11 14:16:13 -07:00
Daisuke Miyakawa
9753d2fde1 Reflect changes in chips library
Must be with Iad5b8444f4b1949666d93ad43a34de057aba560e

Bug: 4996797
Change-Id: I5f83103628c14dd5079515c46c42a6f43d4f194c
2011-07-11 14:14:18 -07:00
Ben Komalo
7a29fb97b1 Misc compose bug fixes.
- empty subjects should still be prepended with "Re:" and "Fwd:" when
replied/forwarded
- the compose body was being vertically centered

Bug: 5008785
Change-Id: I28e4fac8457c4fd18c764daa35d9deea1646474b
2011-07-11 14:07:12 -07:00
Ben Komalo
b03d8088f6 Merge "Filter out Search mailbox from recents." 2011-07-11 13:52:12 -07:00
Ben Komalo
cf7cd933db Filter out Search mailbox from recents.
Bug: 5015109
Change-Id: I4e4982bbedc388529eb2f3a9c06ecac47a0a85f0
2011-07-11 13:07:22 -07:00
Ben Komalo
e05f511a4e Add entry in settings to clear trusted senders
Bug: 5011682
Change-Id: I09a557e4bb0ce3e17f796bcc5693e405f23e8c7e
2011-07-11 12:14:26 -07:00
Ben Komalo
396a425d79 Make search icon appear again.
The CL I just checked in to reduce the invalidateOptionsMenu calls
removes the search icon because it expects the message list to be ready.
Instead of just invalidating the menu a bunch more, just make it so that
the icon is always shown, but we can't actually search if the message
list isn't ready. The time between the icon being shown and the list
being ready should be miniscule.

Change-Id: I5dfe9363cc904833253cf1fceeeb2af2ec389217
2011-07-11 09:44:33 -07:00
Ben Komalo
490708b079 Merge "Prevent wasteful calls to invalidateOptionsMenu" 2011-07-11 09:02:32 -07:00
Ben Komalo
b0a14e4f1a Merge "SmtpSender: Send EHLO that adheres to RFC2821" 2011-07-11 09:01:53 -07:00
Ben Komalo
025d29fd4b Fix some missed account setup flags.
There were two places where account flags were being set on setup: one
was in manual setup when the user selected the account type
(pop/imap/eas), and another was when it was automatically determined
from XML. The two paths were inconsistent and one was setting bits like
SUPPORTS_SEARCH but the other wasn't.

This fixes being able to search in IMAP

Bug: 5011932
Change-Id: I50eada7485aaef4e2a85d25fa7eb9ac7ab03093a
2011-07-10 18:26:15 -07:00
Ben Komalo
6f31573f00 Support SMTP servers not requiring auth
We were unconditionally setting auth credentials even if the checkbox to
require credentials was unchecked. This prevented setup for certain
outgoing servers

Bug: 4291105
Change-Id: I27f94f02b85b097d2c6dbb896254367e8a15415b
2011-07-10 17:58:06 -07:00
Ben Komalo
cac58e590c Merge "Fix notification Intent." 2011-07-10 14:12:48 -07:00
Ben Komalo
e9188307f2 Fix notification Intent.
This changes it so that the message list is shown if there are multiple
unseen messages.

Bug: 5011855
Change-Id: I14cbcfaa32cc5e2b4cb718449c62b8f39b290d4d
2011-07-10 14:02:50 -07:00
Makoto Onuki
7dd70efb5c Merge "Per-mailbox settings" 2011-07-10 12:15:29 -07:00
Makoto Onuki
1ddc2ca4a7 Per-mailbox settings
- Use PreferenceActivity, in the old style, meaning without PreferenceFragment.
- If setting Inbox, change the account settings instead of mailbox settings.
- Use the DialogWhenLarge theme, meaning it's a full-screen avitity on the
  phone and a dialog on the tablet.
- Also fixed the bug that we the menu items that are made invisible by
  UIControllerBase may be made re-visible by the 1-pane controller.

TODO The menu item shouldn't be shown for non-syncable mailboxes.

Change-Id: I02b2faf6f593e1e2eb370217c27801aa58ca7e6c
2011-07-10 12:09:51 -07:00
Makoto Onuki
986a0d91da Merge "Fix bug 4982804 / nested fragment transaction" 2011-07-10 12:03:07 -07:00
Makoto Onuki
2ac164f609 Fix bug 4982804 / nested fragment transaction
Post MessageOrderManager callbacks instead of calling them directly
to break the loop.

Change-Id: I033121f7bdbadf6edd7a0fab87b960b737da820e
2011-07-10 12:00:46 -07:00
Makoto Onuki
3db100da46 Merge "Make nested folders selectable again" 2011-07-10 11:55:00 -07:00
Makoto Onuki
a3ce177fa4 Make nested folders selectable again
Bug 5009065

Change-Id: I58bcb748848592414ec2334951e57693ac24cd39
2011-07-10 11:53:32 -07:00
Ben Komalo
46cdd47e83 Merge "Use the proper server ID for the message." 2011-07-07 14:40:06 -07:00
Ben Komalo
9ec3bcb3b6 Use the proper server ID for the message.
This was accidentally using the server ID of the folder when being
fetched.

Bug: 5002236
Change-Id: Id0df5fb1d18afd8e0cd05157e8033f08dcf084fe
2011-07-07 17:02:28 -04:00
Marc Blank
50a092c3d6 Add IMAP support for the "replied" state in messages
* Handle replied in new messages and updates
* Code added for upsyncing replied state, but the CL for
  setting this state isn't yet submitted

Change-Id: I6f3ff56475d70f686f96ed6a84fae3468f42b1c8
2011-07-07 12:00:07 -07:00
Ben Komalo
7891106a7d Write reply/forward flags on Controller.sendMessage
- also fix some mixups with the actual icon states

Bug: 4947145
Change-Id: Iec1bbfc46ac956a6bf050e4fb162b94ea3c6b316
2011-07-06 18:10:16 -04:00
Ben Komalo
33d6307d4b Prevent wasteful calls to invalidateOptionsMenu
The app is spending a lot of time in startup inflating XML. I suspect a
lot of it is due to the refreshActionBar() calls.

On a normal startup with NO refresh, the action bar was rebuilt 6 times.
If a refresh happens, the refresh callbacks get called in rapid
succession (20+ successive calls is not uncommon), which seemed really
wasteful.

Change-Id: I05feb56ba7fafb109d820328f591526945ca0a5f
2011-07-06 11:19:40 -04:00
Ben Komalo
d8ab562d0d Reduce startup time via Welcome.
In the common case, we don't need the "waiting for sync..." message, so
avoid inflation in those cases and just inflate on demand.

Also do a quick drive-by fix for the error message being pushed in way
too much on phones

Change-Id: Ie7a8472194659a52069d1ee21e0a0cb9b6fc91ba
2011-07-06 11:14:04 -04:00
Jon Starling
ea11bfd6fc SmtpSender: Send EHLO that adheres to RFC2821
Adhere to RFC2821 Sec. 4.1.3 Address Literals should be enclosed by brackets and
prefixed with 'IPv6:' if the sender is an IPv6 host

Original author: Jon Starling

Bug: 4207470
Change-Id: Id327930001188186713e38d1ce8ecc1dad8cfbc0
2011-07-05 12:50:34 -07:00
Ben Komalo
e76962b1b9 Revert "Enable SD card encryption policy when emulated"
This is a manual cherry-pick of c379ebe372
This reverts commit 7fd14be804

The introduction of proper SD cards breaks the invariant that "external"
storage can be encrypted. Unfortunately, this means that accounts with
that policy bit set will have to be removed for now.

Accounts with the security policy set will be forced to go through
security provisioning on the next sync, using the regular mechanisms of
showing a notification with "Security update required", and then having
it fail. :(

Bug: 4466311
Change-Id: I68119b14f8d198779c2073296e228bc6772136ee
2011-07-04 16:16:07 -07:00
Ben Komalo
0268581de2 Merge "Be explicit about disabling drag n drop in search" 2011-07-04 15:59:00 -07:00
Makoto Onuki
96e084e67a Merge "Work around for bug 4674712" 2011-07-01 16:39:46 -07:00
Ben Komalo
1b4b6cf560 Be explicit about disabling drag n drop in search
It was accidentally happening because search doesn't show the mailbox
list, but explicit > implicit.

Change-Id: Ifb8354dbb366f4c8328bef31d4e251166ae6876a
2011-07-01 16:36:44 -07:00
Ben Komalo
ec9e903ce2 Merge "Fix some stale TODO's" 2011-07-01 16:36:35 -07:00
Ben Komalo
fdd99f5486 Merge "Remove some stale stopships and TODO's" 2011-07-01 16:36:29 -07:00
Makoto Onuki
8b72c7eb8d Work around for bug 4674712
Seems like we're getting onItemClick() on header rows, which are
supposed to be disabled.

Change-Id: I03b108c508f46368cc420049eed67438af7a7735
2011-07-01 16:30:33 -07:00
Ben Komalo
130bf263da Remove some stale stopships and TODO's
Change-Id: I3221b3c35c5ffb464756f9de288bf36f560cf8fb
2011-07-01 16:29:21 -07:00
Ben Komalo
4abf58237a Fix some stale TODO's
- also bail search mode if we can't find an account. it probably doesn't
matter _that_ much since the UIController will also bail, but just in
case...

Change-Id: I0b601186362e048de83b53617e529bbada1e8db5
2011-07-01 16:21:31 -07:00
Jorge Lugo
7d243000d4 Merge "Added "replied to" and "forwarded" icons in message list" 2011-07-01 15:05:25 -07:00
Jorge Lugo
e2f6f18396 Added "replied to" and "forwarded" icons in message list
When a message has been replied to or forwarded by the user in
Exchange or IMAP, it now displays the appropriate symbol in the
message list view. (Right now it's just a test image based on the
reply/forward/replyall images until the assets come in.)

Bug: 4313491
Change-Id: I525e55179d62b6ab08df37cb9bfe9fdd9fefb908
2011-07-01 14:43:17 -07:00
Makoto Onuki
6a712721b1 Merge "Fix all NoSuchMethodErrors" 2011-07-01 12:48:02 -07:00
Makoto Onuki
745b33b8ff Fix all NoSuchMethodErrors
Change-Id: I05adf2b99c819d6aa2d3b52c52a8c655d9307337
2011-07-01 12:44:27 -07:00
Makoto Onuki
7107d8e821 Merge "Use parallel executor" 2011-07-01 11:19:04 -07:00
Makoto Onuki
bc2eaadde9 Use parallel executor
We should eventually replace all with EmailAsyncTask, but it's the safest thing
we can do now to avoid regression.

Change-Id: I78bfc4fb2be1dcfadeb7f90092ec7adb35c1d393
2011-07-01 11:04:11 -07:00
Makoto Onuki
1600adab97 Merge "Fix bug 4978035 Precondition failure: Not combined mailbox" 2011-07-01 10:19:46 -07:00
Makoto Onuki
a6212c88e0 Fix bug 4978035 Precondition failure: Not combined mailbox
Also added test.

(For some reason the message count doesn't get set properly on tests...
I'll investigate it when I get around to it...)

Change-Id: I83f3b6f2079da06b2d4973419d2296e6492de1d3
2011-07-01 10:18:13 -07:00
Makoto Onuki
45bfb10464 Merge "Fix bug 4901592 Do not drill-in to inbox by default" 2011-07-01 10:06:55 -07:00
Marc Blank
983fd116b1 Merge "Delete orphaned mailboxes/messages/policies at provider startup" 2011-07-01 09:22:11 -07:00
Marc Blank
2bdf7ee0f0 Delete orphaned mailboxes/messages/policies at provider startup
Bug: 4972132

Change-Id: Icc756a9e28b77de052261903089b040d229e7b5d
2011-07-01 09:21:09 -07:00
Jorge Lugo
c01db92acf Merge "Widget logo opens up mailbox" 2011-06-30 20:46:22 -07:00
Makoto Onuki
9630e31bac Fix bug 4901592 Do not drill-in to inbox by default
If the initial mailbox has child mailboxes, we should show the drilled-in
view by default, EXCEPT if the initial mailbox is inbox, in which case
we want to show the root view.

(And we drill-in if the user taps Inbox.)

Bug 4901592

Change-Id: Idc1462030cf8d971dd4dcbba647ac3a64cab6819
2011-06-30 18:00:11 -07:00
Ben Komalo
6fc2585327 Fix account settings crash.
The check settings fragment could potentially take a while to finish,
and may finish after the activity has shut down. Ensure that the
callbacks don't go through if that happens (usually means the user
backed out before it finished)
Bug: 4689161

Change-Id: Ie8e052f03a8f8f2884c0fe1e334a91c02444f96c
2011-06-30 15:38:34 -07:00
Jorge Lugo
1f59271769 Widget logo opens up mailbox
Pressing the email widget's logo will open up the account's inbox.
Also, composing a new email open the compose window for that
account instead of an arbitrary account as before.

Bug: 3366819
Change-Id: I03c0d6973f5428b2044e755f41fcc6f4da225afa
2011-06-30 15:16:47 -07:00
Ben Komalo
09e7fffb2a Merge "Fix b/4905749 using workaround" 2011-06-30 11:56:05 -07:00
Ben Komalo
85cfc9c0bd Fix b/4905749 using workaround
We suspect the underlying bug is b/4981556 but it is a framework issue
which needs time to fix. Some fragment state is not restored properly
when going through orientation change, so navigation shortly after that
will always crash.

Change-Id: Id6b8714c2aeac5f6bf09e82aea5459bb19d0054d
2011-06-30 11:47:39 -07:00
Makoto Onuki
3aa7fd74f8 Fix bug 4978032 Can't get out of "starred" mailbox
Even with CL the account spinner on the starred mailbox looks still a bit
weird because the spinner turns into the combined mode even if you select
the starred mailbox from a normail account's mailbox list, but at least
you'll be able to get out of the starred mailbox.

Change-Id: I26a256be39f070acece67f4a308a8525a6be1d3b
2011-06-30 09:46:15 -07:00
Ben Komalo
698aa92e6f Fix actionbar for message view
- shows the title of the message in the action bar (visuals not final -
need to extend the width and hide the account name)
- ensures that tapping up/back from a message view from a search result
list doesn't exit search
- ensures that tapping "app up" from a collapsible tablet view doesn't
exist the search unless the left pane is uncollapsed

Change-Id: I2b21a430d12148cf72237060c05312c7a23e2b3b
2011-06-29 19:46:58 -07:00
Makoto Onuki
8de5bda815 Close cursor properly.
Also, don't issue separate query()s for each recent mailbox.

Bug 4977956

Change-Id: I3ccd437a7efd5c3599c4a1952ba091a7b3b815bf
2011-06-29 19:21:14 -07:00
Makoto Onuki
5fbc5025f0 Merge "Remove opener IDs from message view fragment." 2011-06-29 17:58:37 -07:00
Marc Blank
6da2b981da Merge "Oops; fix NPE" 2011-06-29 17:54:53 -07:00
Marc Blank
569785b4f9 Oops; fix NPE
Bug: 4977755

Change-Id: I117eb3a061628ee572f37123631c3da301b5e50b
2011-06-29 17:50:23 -07:00
Makoto Onuki
918860b8e0 Remove opener IDs from message view fragment.
There are needed for the back navigation when a message
is opened from a deep link, but now that we always have a list context
they're not necessary.

Change-Id: Iba2d0b2f31f4539f6e872970b514574347e248c5
2011-06-29 17:32:45 -07:00
Makoto Onuki
87fce70d0f Merge "Newer/older + auto-advance for one-pane" 2011-06-29 17:31:32 -07:00
Makoto Onuki
22d1a794cd Newer/older + auto-advance for one-pane
- Moved MessageOrderManager code from 2-pabe to the base class.
- Most of the code is shared between 1-pane and 2-pane.

- Also fixed the bug where we re-created MessageOrderManager every time
the user taps newer/older, which was the reson the newer/older button
temporarily got disabled when you tapped them.
Before this CL we stopped MOM in uninstallMessageViewFragment, but now that
we don't reuse fragments this means we stops MOM when we remove the current
message view, and re-created a new one when a new message view is created.
Now we stop MOM when the right pane gets hidden (2pane) or when showing
the mailbox/message list (1pane).

- Also removed a now unused callback onMessageShown() from MessageViewFragment.
We used to update MOM on this event, but now we do this in
installMessageViweFramgment().

Bug 4575586

Change-Id: Idc4aba184f318e0c086afc29dcbe42364e2b51b3
2011-06-29 17:29:29 -07:00
Marc Blank
17f7ffae4c Merge "More Store cleanup" 2011-06-29 16:43:01 -07:00
Makoto Onuki
4b39d7ccff Fix for "Unknown uri: .../mailbox/-4
It was caused by the fact that we show the combined starred mailbox
on each account's mailbox list.

Beacuse of this, when you open the starred mailbox on non-combined view,
we pass a normal account ID + the combined starred mailbox ID to the
AccountsLoader, which then thinks that because the account ID is not
ACCOUNT_ID_COMBINED_VIEW the mailbox ID must be of a regular mailbox,
issues a query to get mailbox info, and crashes because the mailbox
is virtual.

- Also fixed the issue that we don't show message count on the account
spinner for combined mailboxes.

bug 4971181

Change-Id: Iaa13b362505b8babc7f7ea8a03ddf5494736dc2d
2011-06-29 16:30:43 -07:00
Marc Blank
0b8e04c84d More Store cleanup
Change-Id: I8f542175b4468c7a320322a57bfdaf19a7320165
2011-06-29 15:22:05 -07:00
Marc Blank
aa46bc3919 Merge "Remove redundant and unused constants" 2011-06-29 14:48:08 -07:00
Marc Blank
6fea021e3d Remove redundant and unused constants
Change-Id: Ie8658f86737880e3127a0a2c3b7f0557dde98b29
2011-06-29 14:30:46 -07:00
Ben Komalo
29c89ad17a Just mark search mailbox as not visible
This way we don't have to explicitly filter it in all the different
places we do selections on mailboxes.

Note that I didn't create an upgrade path for this. The only people with
search mailboxes are probably developers right now, and worst case for
people who experimented, they will just get the search mailbox visible

Change-Id: I9a0bf6df9985418d467a7348ed99a36521641b89
2011-06-29 14:27:27 -07:00
Ben Komalo
659f60f734 Wire through logic for searched mailbox
- update hint based on the mailbox being searched
- ensure that we use the original searched mailbox as the mailbox to
search for subsequent search (i.e. a search while we're viewing search
results) and not the search mailbox

Change-Id: Ic8663272173ce386dcd13fdf0369e918fb895be8
2011-06-29 14:09:14 -07:00
Marc Blank
244d306ebb Remove more useless code
* Strike another blow for sanity!

Change-Id: Id95b441f9577abda66f04113793d6b1c60500ebe
2011-06-29 14:07:25 -07:00
Marc Blank
77160c8c08 Merge "Don't cache ImapFolders" 2011-06-29 13:34:44 -07:00
Marc Blank
2720a818d5 Don't cache ImapFolders
* ImapFolder is currently very unsafe for use by multiple threads,
  causing, among other things, the referenced bug
* Since ImapFolder is very lightweight, there's no particularly good
  reason to be caching them anyway
* Rename isOpenForTest to isOpen

Bug: 4972084
Change-Id: I2bf17b9cfc8549a222e991f3e59abfd00a4d3afd
2011-06-29 13:02:55 -07:00
Marc Blank
ea8034affa Merge "Clean up Store implementation" 2011-06-29 13:01:36 -07:00
Marc Blank
35b0e95ca7 Clean up Store implementation
* Remove unused argument from newInstance/constructor
* Create ServiceStore class, the superclass of ExchangeStore (and,
  eventually, all Stores, until they can go away completely)

Change-Id: Ic5237236c5349ecf006538c58b63c1efe8e4ea61
2011-06-29 12:50:43 -07:00
Ben Komalo
b859a3b61e Filter search mailboxes so they're not visible
Change-Id: I99edcb19ce9e320676dff55f219370730e74239b
2011-06-29 12:06:57 -07:00
Makoto Onuki
488308b354 Merge "Fix the "onPostExecute executed even when cancelled" issue" 2011-06-29 11:19:37 -07:00
Ben Komalo
5d811ecf18 Merge "Re-enable hw acceleration and fix webview cleanup" 2011-06-29 11:14:55 -07:00
Makoto Onuki
50d934360d Fix the "onPostExecute executed even when cancelled" issue
Renamed onPostExecute to onSuccess and made sure it won't called
if a task is cancelled in time.

Also removed isCancelled().  To implement it right we should make sure
that onPostExecute() isn't finished when setting mCancelled, but it's a bit
of a pain to implement right, and we don't really have to use it.

Change-Id: I3a0baf504506ffc4952a5553f7098a8415842fa3
2011-06-29 10:22:38 -07:00
Ben Komalo
a6e15b13ef Re-enable hw acceleration and fix webview cleanup
Bug: 4886133
Change-Id: Ib59e560a6e1ef3eecc15ff0073a3c0f34688835a
2011-06-29 09:55:32 -07:00
Makoto Onuki
4a893e60b4 Switch to EmailAsyncTask
Also remove the isCancelled test in onPostExecute, where it should
never return true.

Change-Id: Ica2b07db22d73769c2ead5f232f4890bd3bb87da
2011-06-29 09:50:52 -07:00
Makoto Onuki
6cf76d94c8 Merge "Fix one-pane navigation/UI bugs" 2011-06-28 17:50:07 -07:00
Ben Komalo
1f6acaf396 Hide footer when we hit the end of a search
Change-Id: Iec082a9f9560819c034f91706229b1efb7303ba2
2011-06-28 17:24:54 -07:00
Ben Komalo
6b256f1fa1 Wire through results count in search header.
Change-Id: I817236d9c3294acb25b62724cc8c99d47df7f354
2011-06-28 17:11:16 -07:00
Makoto Onuki
ecd9c93cfa Fix one-pane navigation/UI bugs
- Back from the starred mailbox now works.
- Combined view now has the "show all folders" in the spinner.
- Null-out the list context when opening the mailbox list.
- Properly restore the list context when popping from the back stack.
- Disable the account spinner dropdown on the mailbox list.
- Hide the little triangle thing at the right bottom corner of the spinner
  when it's not selectable.

Bug 4836064
Bug 4689313

Change-Id: I41d1b6c7024953407b260f5b4b63fbc366e538ca
2011-06-28 16:30:28 -07:00
Marc Blank
06421df25d Merge "Return total number of results from IMAP search" 2011-06-28 14:19:18 -07:00
Marc Blank
5a9c95f94e Return total number of results from IMAP search
Change-Id: I44eb83042774294aa5aaa8f45a46b82dd78b0141
2011-06-28 12:14:25 -07:00
Ben Komalo
2213a79c36 Merge "Prevent monkey crash on attachment load." 2011-06-28 11:32:07 -07:00
Marc Blank
c0a9fa9c68 Fix NPE
Bug: 4969186
Change-Id: I27fbdf7a496ee73caf36a90bf56b91c90133b3b7
2011-06-28 11:05:02 -07:00
Ben Komalo
efbb408dbb Prevent monkey crash on attachment load.
Bug: 4969655
Change-Id: Ie1cbeaab4b9335aa4b0c2c972647072df21fccec
2011-06-28 09:44:48 -07:00
Marc Blank
5d7ff8577d Synchronize access to mailbox type map
Bug: 4967543
Change-Id: I71380d0d2d5664cf92a9b698bfdad516eeb5c80f
2011-06-27 20:23:40 -07:00
Ben Komalo
8935f6d39e Merge "Show a search results header." 2011-06-27 20:02:44 -07:00
Ben Komalo
9b4f11a4ed Show a search results header.
The count will be wired in and shown in here.

Change-Id: I2f496dcd86d748ee1c17c8e819b65c61c098a8ba
2011-06-27 19:59:23 -07:00