Commit Graph

3024 Commits

Author SHA1 Message Date
Paul Westbrook 0c06a7cf99 Fixed mis-located cleanup code
Bug: 8565783
Change-Id: Iab06411cc85cd4958db574ec52eeebb7457c980f
2013-04-10 00:34:04 -07:00
Vikram Aggarwal 6b88a2471f Allow queries in folder URIs
As a result of a previous change, we are appending application version
to the end of the folder name.  This breaks the EmailProvider's
expectation about folder URIs.  So instead of using just
uifolder/<number>, allow for uifolder/<number>?<appversion query>

getPathSegments().get(i) will still return the path segment without
the query, so the folder ID gets resolved correctly.

The previous change:
https://googleplex-android-review.googlesource.com/#/c/281416/

Bug: 8435074 Not able to access Exchange inbox and combined inbox

Change-Id: I7b9ffad9b5510d1a08a29e2a21aacb091d4330a6
2013-04-09 15:08:11 -07:00
Yu Ping Hu 2930476051 Reorder the folders in combined view.
Inbox should go to top.

Change-Id: I90c55952aaa3955adfd6d08a12a568bfb192c730
2013-04-05 16:35:51 -07:00
Paul Westbrook fcddd014da Merge "email: "Exchange Services has stopped" - Rain of Exchange Javacrashes" into jb-ub-mail-ur9 2013-04-05 22:35:37 +00:00
Yu Ping Hu 1389f0ed03 Merge "Add virtual mailbox for all unread messages." into jb-ub-mail-ur9 2013-04-05 22:25:56 +00:00
Emmanuel Berthier 689efab2b1 email: "Exchange Services has stopped" - Rain of Exchange Javacrashes
Cleanup some nasty records containing NULL fields.

Change-Id: Iec5e7e1bebc4beee8fa010c3f9c9ee723fd2cd83
Author: Emmanuel Berthier <emmanuel.berthier@intel.com>
Signed-off-by: Shuo Gao <shuo.gao@intel.com>
Signed-off-by: Bruce Beare <bruce.j.beare@intel.com>
Signed-off-by: Jack Ren <jack.ren@intel.com>
Author-tracking-BZ: 60461

cherry-pick of https://android-review.googlesource.com/#/c/47571/1
2013-04-05 15:22:14 -07:00
Yu Ping Hu c065e72819 Add virtual mailbox for all unread messages.
Also restores the trash icon. I'm not using the "correct"
icon -- it's the menu icon, not a folder icon -- but it
looks correct. Also, the "unread messages" icon is likewise
the menu icon for mark unread.

Bug: 8527132
Bug: 8444885
Change-Id: I7d3bc286f80f130e6f08ff1340a013d81700406e
2013-04-05 14:50:50 -07:00
Paul Westbrook d402c890dc Fixed make POP and Imap more locale safe
Cherry-picks from:
https://android-review.googlesource.com/#/c/42334/
https://android-review.googlesource.com/#/c/42332/

Change-Id: I557c3d8c725cf6dc4f13f227dcec63864ab5db67
2013-04-05 13:57:51 -07:00
Paul Westbrook 9fd03edb83 Merge "avoid cursor leak in email provider" into jb-ub-mail-ur9 2013-04-05 20:49:09 +00:00
Yoohyun.choi 89c74e89e5 avoid cursor leak in email provider
When cursor is done, the cursor must be closed to avoid cursor leak.

cherry-pick of https://android-review.googlesource.com/#/c/52910/
Change-Id: Iaaffed2c4e90dc4b17ae55fcedb242bf890b3dd5
2013-04-05 13:45:56 -07:00
Jack Bates 4fd97a3050 Fix SMTP RFC violation for better interoperability
Space after colon violates RFC 5321 (and RFC 821): "Since it has been a common
source of errors, it is worth noting that spaces are not permitted on either
side of the colon following FROM in the MAIL command or TO in the RCPT command"

Change-Id: Ie5330bf2bd01cd8f734134dadd742cf16df70d7a
Signed-off-by: Jack Bates <jack@nottheoilrig.com>

cherry-pick of https://android-review.googlesource.com/#/c/32640/
2013-04-05 13:42:13 -07:00
Paul Westbrook 391a7fc0e9 Support legacy shortcuts
We need to support shortcuts that were created with previous versions
of Email

Bug: 8530220
Change-Id: I9e2a44b561f5617ffa954af37a9e78a95400f7dc
2013-04-04 02:45:17 -07:00
Yu Ping Hu c5c9c1c69e Restore functionality for uploading new messages.
The code for syncing new messages from client to server
somehow never got moved from Email1 to Email2.

This change also includes minor cleanup on system mailbox
flags.

Bug: 8531552
Change-Id: I1f9396635ba14cb6e641d2bc1b506c6d702f6b2e
2013-04-03 09:32:35 -07:00
Paul Westbrook d1a87bc02d Fix IMAP sync with Arabic language
Email shouldn't rely on the the default locale.
See: http://developer.android.com/reference/java/util/Locale.html#default_locale

Bug: 7138507
Change-Id: Ia2c6eccc6dee011f4e7e7c663a0328d4fd76131b
2013-04-02 11:36:11 -07:00
Yu Ping Hu de4c230f00 Exclude not fully loaded messages from uimessages queries.
Bug: 8370633
Change-Id: I5643454333b490bb1a988efb7b59e20b18fa67f4
2013-04-01 20:08:30 -07:00
Yu Ping Hu 46d6a4a7cb When loading messages, use left join for Message and Body.
Existing inner join means that a Message without an entry
in Body table cannot display correctly, even though this is
a potentially legitimate state.

However, because the MessageCursor for Email doesn't read
flagLoaded at all, this change actually causes another bug:
if you go to a partially loaded message, it will show as
blank with no load indicator. Fixing b/8370633 will mask
this by not letting you get in a situation where partially
loaded messages are shown.

Bug: 8512030
Change-Id: Ie2e365e7e5df3959115ed299d1a7f03aa1d7af79
2013-04-01 18:17:25 -07:00
Yu Ping Hu 3bef153c9c Merge "Improve error logging for mailboxNotification." into jb-ub-mail-ur9 2013-04-02 00:36:48 +00:00
Paul Westbrook 11472650d1 Fix apk attachments
Bug: 7585865
Change-Id: I20191523377d99472e333dece4d727415f97c67a
2013-04-01 17:20:27 -07:00
Paul Westbrook 3767da5d26 Add capabilities for search folder
Bug: 6693452
Change-Id: Ib55fca4f883a699eabdaabf35568bffa055d556f
2013-03-31 12:00:14 -07:00
Yu Ping Hu 7cc82371ec Improve error logging for mailboxNotification.
Change-Id: I5b16ac46ce8cdd6e8f791c9cea7d7ead7e053bdc
2013-03-28 19:10:23 -07:00
Yu Ping Hu c534638b7a Disable notification prefs until folder prefs are loaded.
Bug: 8485354
Change-Id: Id56c2634a16274e9340ad6ecb96661ee8a489d49
2013-03-27 17:40:38 -07:00
Yu Ping Hu 1dd937bf18 Prevent NPE when getting a bad mailbox id.
The mailboxNotification query apparently can return bogus
mailbox ids. This underlying bug still needs fixing.

Bug: 8482721
Change-Id: Icfbd0d986ab32fe878a0dbe09a3276322c75cafe
2013-03-26 15:00:30 -07:00
Paul Westbrook 28a344042d Prevent NPE
Also add additional logging for this case

Bug: 8372753
Change-Id: I87aa9ee46f0ca866745d62d27f4b40913f2e9b97
2013-03-22 18:21:19 -07:00
Yu Ping Hu 861c5c8c9e Guard against potential NPE.
Change-Id: I379da1f478b1b1fd1e488dbeff249cc10e3d48d5
2013-03-21 19:25:14 -07:00
Paul Westbrook 5a3aebbd2d Fix problem with sending attachments in Exchange
The problem was that when the attachment was attempted to be opened
from the Exchange process, it didn't have access to the cached file.
Instead, use a content provider uri to reference the cached file.

Bug: 8400456

Change-Id: I80abd66642e938cf09f73bf0e9bd049aa8d7ba1d
2013-03-21 17:34:19 -07:00
Yu Ping Hu 68a8e21248 Merge "Always create system folders during sync." into jb-ub-mail-ur9 2013-03-21 16:05:03 +00:00
Yu Ping Hu 8a11cb8fd1 Merge "Always show the starred folder." into jb-ub-mail-ur9 2013-03-21 16:04:53 +00:00
Scott Kennedy f16a7612c0 Exclude all inbox labels when we're viewing an inbox
Bug: 8426563
Change-Id: I7707c9ebf9ebcb73be73ef82f5f2212514671bfe
2013-03-20 17:51:59 -07:00
Yu Ping Hu a5a963321d Always show the starred folder.
Bug: 8383232
Change-Id: I8a5fa0dbdd9f4f2000c5b7d3347eb4946af0ae80
2013-03-20 15:34:56 -07:00
Yu Ping Hu 2192bf01e0 Always create system folders during sync.
Change-Id: I8ff6eb4f65d4207d7a2768c5fd837fad8cd47269
2013-03-20 15:23:51 -07:00
Yu Ping Hu 9ae81e2af0 Move system folder string resources to emailcommon.
This permits us to move shared code for looking up system
folder names to emailcommon, which is also in this change.

Also renames emailcommon2 to emailcommon.

This is part of a multi-project submit with
I4a071a07c3e33aaa4ea404eb66a8db1eabc9ef0e and
I5746c0353783f9b29d52d6540472588c6542a6a2.

Bug: 8383232

Change-Id: I6c6eec4f1bcf2abd54c1ed05da1add8d894ee403
2013-03-19 19:45:52 -07:00
Yu Ping Hu 91107a4c56 Remove useless UI notifications in uiUndo.
The uris supplied for these are bogus (lack IDs), and at any
rate the actual undo itself should notify the UI. (That's
currently broken, but not for want of trying, but the point
is that needs to get fixed anyway.)

Bug: 8373349
Change-Id: Id0f4e9fa45f2ece42d07f1f350d841f00270a8d9
2013-03-18 14:41:24 -07:00
Yu Ping Hu d0e7d88f43 Fix undo to use the correct URI.
Bug: 8373349
Change-Id: Ia23b60a1f82be16cb48afe5cf239e1c588b192a1
2013-03-15 19:32:32 -07:00
Yu Ping Hu 3e88d65aa8 Fix inboxes in POP for non-english.
Same as I27b422b4b9a3568c899beda41c96e61eb77c4ad3
but for POP.

Bug: 8393126
Change-Id: Ifa7ef3aa4080ec4c39309f988f041344fc4e8b54
2013-03-14 20:29:10 -07:00
Yu Ping Hu b3b47ef971 Merge ""Fix" Inboxes in non-English languages for IMAP." into jb-ub-mail-ur9 2013-03-15 02:42:29 +00:00
Yu Ping Hu 5187e702d6 "Fix" Inboxes in non-English languages for IMAP.
Without this change, languages where the inbox is not named
"Inbox" will never initialize IMAP accounts correctly.

This change "works" because
LegacyConversions.inferMailboxTypeFromName matches against
server name. Obviously this code's bad and I should feel
bad, but for now this change at least makes the app usable
in other languages and leaves the code in the simplest state
for fixing later.

Bug: 8393126
Change-Id: I27b422b4b9a3568c899beda41c96e61eb77c4ad3
2013-03-15 02:01:22 +00:00
Paul Westbrook 5ed8b266a4 Fix some problems with move message
Make Email respect the accepts moved mail flag

Don't throw an exception when receiving on the
folders_updated column

Bug: 8370675
Change-Id: I92c630577e6f572361bbaf68d8e5d0bfb6204951
2013-03-14 16:06:11 -07:00
Yu Ping Hu 8e2c4056ca Clean up dead code. Should be a no-op for functionality.
Also includes a fix for saving a draft that's already
been saved (used to create a new one).

The following were unused:
- accountIdAddToField
- mailboxIdAddToField
- uisendmail
- uisavedraft
- uiupdatedraft
- uisenddraft

Deleting those also allows us to remove the translation
from the Bundle used by calls to the ContentValues used by
update (since the update paths are now gone).

Change-Id: I87f2875e3272177a128a8ff65541e51b1f2d05fc
2013-03-14 14:40:39 -07:00
Yu Ping Hu a6cd7cbd63 Merge "Fix IMAP send by ensuring system mailboxes exist." into jb-ub-mail-ur9 2013-03-14 17:17:54 +00:00
Yu Ping Hu f7055e2618 Fix IMAP send by ensuring system mailboxes exist.
This is a quick fix to get it working ASAP, I will improve
how system folders are created when handling b/8383232.

Bug: 8307247
Change-Id: I6ea24ea756911c60d4eca69ce65d27dff33850c8
2013-03-14 17:07:00 +00:00
Alice Yang 700fb3c23d Merge "Revert "Change "hide checkboxes" to "show checkboxes""" into jb-ub-mail-ur9 2013-03-13 21:31:30 +00:00
Alice Yang a833b36ec2 Revert "Change "hide checkboxes" to "show checkboxes""
This reverts commit 5742d44917.

Bug 8370186

Change-Id: Ie15b7c30aaba8df8678d15e19dcd38fddea6de13
2013-03-13 14:18:19 -07:00
Paul Westbrook 88c80b775b Load replyall setting
Bug: 8374501
Change-Id: Ibf01a9c27ad05e3d6c1b172a255299d8af3b69ea
2013-03-12 21:28:26 -07:00
Yu Ping Hu 9d91dd8023 Specify correct sync extras for user-requested syncs.
BUG: 8364227
Change-Id: Icfc97c92e5ecc9c2abd83b73cf67a5e10408cede
2013-03-12 12:38:01 -07:00
Paul Westbrook 5a3d863a43 Add support for feedback
Change-Id: I6de8c0117f79c0be05d3db2fc108f8bf61415783
2013-03-08 17:15:00 -08:00
Paul Westbrook 95bb350f38 Fix NPE when adding account with security policy
When adding an Exchange account with a security policy, Email
generates a notification to let the user enable the policy. The
code that generates the notification attemptes to load the folder
as part of the base notification.  Before the account policy has been
configured, it isn't possible to load the folder.  We need to handle
a null folder when generating the notification

Also, imporoved the logging when an exception is thrown from the
PolicyService

Bug: 8341882
Change-Id: I33ff57adc3c130e8318910e352146b8ea56f9a2c
2013-03-07 23:00:47 -08:00
Scott Kennedy 1cea05ac37 Merge "Make widgets work again" into jb-ub-mail-ur9 2013-03-08 01:45:22 +00:00
Yu Ping Hu 6967b6b6bc Merge "When folder is changed, also update conversation list." into jb-ub-mail-ur9 2013-03-07 19:44:50 +00:00
Scott Kennedy dfd2c87740 Make widgets work again
We can't send Folder parcelables to RemoteViews, so let's just send
what we need: two URIs and a String.

Bug: 8330949
Change-Id: Ic3f272e1bae4530cdc7776fd88eeb7bcb1a7dae3
2013-03-07 11:00:43 -08:00
Yu Ping Hu fc0dae9cd7 When folder is changed, also update conversation list.
Also add the folder's total count to the extras for the
conversation list cursor.

BUG: 7480726
Change-Id: I3215fed561deb8430fd6d6c680bdb44ca87cc162
2013-03-06 19:01:41 -08:00