Commit Graph

2265 Commits

Author SHA1 Message Date
Makoto Onuki ab1674a2d6 Cosmetic changes to MessageView
- Don't show the progress icon unless loading from network
- Don't show the content until LoadAttachmentsTask finishes
- Disable the fade-in animation.  It causes some weird positioning issue
  with the GL accelerated webview.
- Use WebView.clearView() to clear its content.
- Use the "normal" layout mode, otherwise WebView won't use its entire
  width
- Don't hide the vertical scrollbar

Bug 3287729
Bug 3225068
Bug 3295761
Bug 3304396

Change-Id: Ic4b8baac99b71dc0da58021849ff7c1dbd6dbe55
2010-12-21 17:57:16 -08:00
Marc Blank 9c4458dcd7 Don't try to show thumbnail for unloaded attachments
Bug: 3292689
Change-Id: I7575cb891f0b46c4a8564b5d2c4907025d91c639
2010-12-21 12:37:40 -08:00
Dianne Hackborn 8b9f2a7284 Update to use new Loader callbacks.
Change-Id: Ib478c2f2314bbae4a380539e22892d85dd9a34b5
2010-12-20 23:14:01 -08:00
Marc Blank d9b251d23b Properly return zero-count cursor from getMatrixCursor
Change-Id: I574528bf56b5a82ecbaab3d3501b26e7afb974ec
2010-12-20 13:58:11 -08:00
Dianne Hackborn 0698f4027f Update to new Loader APIs.
Change-Id: Ic228f7b785f0d902a0188cfe995006b73b8a3c8b
2010-12-20 12:23:13 -08:00
Marc Blank 0fd8ae8808 Pixel perfect Email widget
* Functionally correct and pixel perfect
* All current assets in place

Bug: 3292507
Bug: 3284201
Bug: 3135118
Bug: 3255036
Bug: 3252913

Change-Id: I8fa6752748c74b3a9789a3675da12f6c0c11975f
2010-12-20 11:55:01 -08:00
Makoto Onuki 22fb45817b Merge "Follow-up to the loader API change" 2010-12-17 13:46:23 -08:00
Makoto Onuki 28d6e09575 Follow-up to the loader API change
This should fix the "attempt to re-open an already-closed object" exception
from SQLite.

(destroy()s don't have @Override becuase the base method is now depricated
and will be removed someday.)

Bug 3288666

Change-Id: I4780f6c8d89c7204b266608462c0833ad5af4e5f
2010-12-17 13:36:51 -08:00
Marc Blank 120674a05c Merge "Harden AttachmentDownloadService; fix storage calculation" 2010-12-17 12:00:14 -08:00
Marc Blank edb05ca5ee Harden AttachmentDownloadService; fix storage calculation
Bug: 3292720
Bug: 3286634

Change-Id: I378aac369ee8317c0c41b1f021a3731b81bcb380
2010-12-17 11:28:18 -08:00
Marc Blank 1504ef5fd1 Merge "Remove unused debug flag" 2010-12-17 10:40:13 -08:00
Marc Blank f3ced5b8a5 Merge "Remove unnecessary logging in Utility.attachmentExists" 2010-12-17 10:36:09 -08:00
Marc Blank 54250337a0 Remove unused debug flag
Change-Id: I88ef517a5b4860c30f1eb2a52f15d8f07c823797
2010-12-17 10:34:43 -08:00
Marc Blank f995f680a8 Merge "Throw exception on illegal URI's in EmailProvider operations" 2010-12-17 10:21:44 -08:00
Marc Blank d3fafabd0f Remove unnecessary logging in Utility.attachmentExists
Bug: 3292689
Change-Id: I937ef44b4576634fd870c759a13f3d27255112bd
2010-12-16 20:09:41 -08:00
Marc Blank e6a22dff39 Throw exception on illegal URI's in EmailProvider operations
Change-Id: I6354c03e7cead81df3764b7d0bd1be0e90271664
2010-12-16 17:12:42 -08:00
Andy Stadler 5b393bfece Merge "Show attachment download progress/status properly" 2010-12-16 15:30:12 -08:00
Andy Stadler 6624909533 Show attachment download progress/status properly
Bug: 3291532
Change-Id: I3ceab8a67095190898273b9ccd5a1016218edcb2
2010-12-16 15:09:03 -08:00
Dianne Hackborn 80769cefb3 Prepare for some changes to LoaderManager/Loader.
Sorry it is a bit ugly, it is to allow this change to be
checked in prior to the first stage of the framework change
without breaking the build.

Change-Id: I1828579019ac0325d19c070a4c62cd79549e7d51
2010-12-16 13:20:39 -08:00
Makoto Onuki 303816534d Don't show app name on action bar
Need to hide the action bar title when showing account spinner.

Change-Id: Id85fa91f1b89fbd9d2a92bd2d175121176b8a2f0
2010-12-16 11:32:28 -08:00
Makoto Onuki a9939ab165 Merge "Disable "upgrade accounts" for now." 2010-12-16 11:09:06 -08:00
Marc Blank 4970392341 Synchronize properly with ContentCache; document synchronization
Bug: 3291682
Change-Id: I69c4a3b2ee62a41e6488b63deeb975e510a3f554
2010-12-16 10:39:08 -08:00
Andy Stadler e6214d1f87 Merge "Restrict download/display to "attachment" and "inline"" 2010-12-15 18:06:59 -08:00
Makoto Onuki b358da3344 Disable "upgrade accounts" for now.
This will not be necessary on tablet.

Bug 3122020

Change-Id: Ifff59a11ccf628fdb5b6d007a7a6591db10153ce
2010-12-15 16:22:04 -08:00
Makoto Onuki 2a63ac55e9 Merge "Add null checks to investigate bug 3275738" 2010-12-15 15:42:19 -08:00
Makoto Onuki ebf0f18cba Add null checks to investigate bug 3275738
Change-Id: I55f83336c5059b7ea6234b9451c60c4c062fdb06
2010-12-15 15:38:27 -08:00
Andy Stadler 014e31a62c Merge "Use generic contact icon for notifications & messages" 2010-12-15 15:27:07 -08:00
Andy Stadler c1c3b6f21e Use generic contact icon for notifications & messages
* Copies the icon from contacts
* Used whenever the sender doesn't have a local photo
* Used in notifications and in messageview

Bug: 3282187 (notification)
Bug: 3285156 (memory leak from the placeholder graphic)
Change-Id: I528cae20355aa8cce7be37b26f32aa90e092708b
2010-12-15 15:26:30 -08:00
Marc Blank f7660220a8 Merge "Enable cache logging for debugging (w/ STOPSHIP)" 2010-12-15 14:07:53 -08:00
Marc Blank 74596b3799 Enable cache logging for debugging (w/ STOPSHIP)
Change-Id: I97493430f2aedcb070bc6d1789e47b562394eeb3
2010-12-15 14:06:54 -08:00
Andy Stadler e3a17f1438 Restrict download/display to "attachment" and "inline"
* Check content-disposition and restrict to these two types
* Add unit test
* Reformatting collectParts (code style cleanup)

Bug: 3242502
Change-Id: I5dcbdda5d4788502113771f4fd1b5fff834a402d
2010-12-15 11:36:02 -08:00
Andy Stadler 884589fddb Merge "Only show attachments UI for downloadable attachments" 2010-12-14 20:27:15 -08:00
Andy Stadler 05340736da Only show attachments UI for downloadable attachments
Bug: 3286678
Change-Id: Ied64674cbfaef95228d5d3d8c99e5f5989b8a3c0
2010-12-14 20:19:52 -08:00
Makoto Onuki 00d10299b5 Merge "Store application context to avoid activity leak." 2010-12-14 17:30:15 -08:00
Makoto Onuki e1b4d2cd4a Store application context to avoid activity leak.
Bug 3285156

Change-Id: I579cf628d178cabf999fc7cd63765298d2082944
2010-12-14 17:14:35 -08:00
Marc Blank ef2261fa00 Merge "Fix placement of invite icon in narrow mode" 2010-12-14 16:52:02 -08:00
Marc Blank de39190bc1 Fix placement of invite icon in narrow mode
Bug: 3285416
Change-Id: I36a78eb486a45b780663a8fb24ee092b964ba1b0
2010-12-14 16:31:24 -08:00
Andy Stadler 8ec0dcfe0d Fix NPE on rotation
* onAttach is called fairly early when rotating, so it needs to do
  very little.
* or in this case, defer some work until onResume

Bug: 3170922
Change-Id: Ie760125c5f32b293f8ba1753f2993de0d7439b56
2010-12-14 11:53:41 -08:00
Makoto Onuki 9afd6bc59f Merge "Fix unit tests" 2010-12-13 16:45:50 -08:00
Andy Stadler f4b855c9bf Merge "Turn down email logging to shippable levels." 2010-12-13 16:40:19 -08:00
Andy Stadler fd5a5f14ea Turn down email logging to shippable levels.
Change-Id: I8426743aebef2329c8958926d7b29abe1309feb0
2010-12-13 16:32:02 -08:00
Makoto Onuki c849936a36 Fix unit tests
- Now ProviderContextSetupHelper.getProviderContext() invalidates DB cache

* MailboxAccountLoaderTestCase
- Save hostauth properly
- (ProviderContextSetupHelper invalidates cache before each test)

Bug 3280911

* SmtpSenderUnitTests
- Use ProviderContextSetupHelper to create isolated context,
  which now also invalidates DB cache

Bug 3280913

* MailboxFinderTest
- When kicking Controller.Result methods directly from tests,
  call the raw callback, rather than the one wrapped with
  ControllerResultUiThreadWrapper, to make it synchronous.

Bug 3280898

* MessageViewTest
- Disable testOpenMessage()
  This test doesn't work because it sets up test data in an isolated
  context but the activity/fragment don't see them because they
  use the real context.
  I have no idea why it worked before... Maybe because there were
  accounts/mailbox/message with the same ID in the DB by chance.

Bug 3280905

Change-Id: I6beb08c58fff102e90bebd2c35f70820268b9e62
2010-12-13 16:29:57 -08:00
Marc Blank 0f27b78669 Merge "Implement prefetch of IMAP/EAS attachments" 2010-12-13 15:33:13 -08:00
Marc Blank 75a873be84 Implement prefetch of IMAP/EAS attachments
* Load attachments in the background for IMAP/EAS messages
* Download an attachment from account X if:
  1) 25% of total storage free
  2) Attachments for X use < 1/N of 25% of total storage, where N is
     the number of AccountManager accounts
* Add accountKey to Attachment table for performance

Change-Id: I913aa710f34f48fcc4210ddf77393ab38323fe59
2010-12-13 15:32:57 -08:00
Marc Blank 06a2f4a3b1 New message list formatting per pixel perfects
* Need icon assets (attachment, meeting, star on/off, and
  checkbox on/off)

Change-Id: I6780fb354584ce5ea398b555a8485cf600617586
2010-12-13 15:32:05 -08:00
Andy Stadler f946ff0019 Fixed issues that cause rotation to NPE
* Add the checker fragment (instead of replacing)
* Don't refresh progress/error dialogs until onResume (a bit later)
* Don't recreate terminal error dialogs that were automatically
  regenerated by the fragment manager.

Bug: 3020074
Change-Id: Ia2947965b758f6846c62ac394ce51da2432523ee
2010-12-13 13:58:40 -08:00
Makoto Onuki 23d6d9cf24 Merge "Controller.Result callbacks should all have accountId" 2010-12-13 10:50:18 -08:00
Makoto Onuki aef9515ee7 Controller.Result callbacks should all have accountId
- Added accountId to loadAttachmentCallback/loadMessageForViewCallback

- Cleaned up LegacyListener/MessagingListener.
  Removed the constructors which take messageId and attachmentId, which
  are used to bridge loadAttachmentProgress, which the callsite doesn't know
  these IDs.  The inconsistency (only loadAttachmentProgress() uses the member
  messageId) doesn't look too good, so extracted this into a separate class,
  MessageRetrievalListenerBridge.

Change-Id: I46303e50df2b0e1fe8616e7c9cef632ac14f23aa
2010-12-10 18:11:44 -08:00
Marc Blank 8b818ea568 Delete attachment files when wiping Email data
Bug: 3276145

Change-Id: I8fd48a7b2c312929e9a4caf3682dadd610c997e9
2010-12-10 15:30:25 -08:00
Andy Stadler 3dedc8b191 Defragment AccountSetupBasics
* This was an early attempt at fragmentation
* But it turned out that no fragment was needed here - it is
  not shared or reused in any way.
* Precursor to doing final layouts for the activity.
* Tested working:
    Automatic provider lookup
    Manual
    POP/IMAP and EAS flow modes (from accounts & sync)
    Force account creation intent
    Provider note
    Duplicate account detection

Change-Id: I434edd4b152391d36e70440873932db3ec1a1c99
2010-12-09 11:05:34 -08:00