Commit Graph

6210 Commits

Author SHA1 Message Date
Ben Komalo
6edddbf714 Merge "Misc attachment code cleanups" 2011-07-19 15:26:45 -07:00
Ben Komalo
dfff72f731 Misc attachment code cleanups
Change-Id: I612b3ed1280d4d057834d3d3e67c8ac17c2bafb6
2011-07-19 15:16:45 -07:00
Marc Blank
c6df1d605f Prevent NPE's in AccountSecurity
* This CL fixes the referenced bug, but it does NOT explain how
  mAccount; best guess is that the process was killed and then
  restarted when the result from DPM was available.
* Assuming this is the case, we remove the background task loading
  mAccount, avoiding a possible race.
* Also, it's not clear why clearNotifications didn't use the
  account id argument; what if there's more than one account that
  uses security?  Filing a bug about this.

Bug: 5048912
Change-Id: I734834337ab6e409d77624e7c7370350de76becb
2011-07-19 14:38:29 -07:00
Marc Blank
d1f03736e6 Merge "Clean up account reconciliation" 2011-07-19 13:25:25 -07:00
Marc Blank
4e4aba9ebc Clean up account reconciliation
* Move AccountReconciler to the Email app (from EmailCommon)
* Ensure that Controller.deleteAccountSync() performs ALL actions
  needed to clean up after an account deletion (delete attachment
  files, reset policies, refresh the UI, etc.)
* Add reconcileAccounts() API to AccountService
* Remove accountDeleted() and restoreAccountsIfNeede() from the
  AccountService API
* Remove unused callback

Bug: 4883073
Bug: 4767084

Change-Id: I43ffaf009db1a6f306bb0f2a74fb4dd3b2c4b966
2011-07-19 10:31:33 -07:00
Jorge Lugo
5ce13dba1f Merge "Preference panel screen titles don't change on rotate" 2011-07-19 09:54:46 -07:00
The Android Automerger
e1a3ae63e6 merge in ics-release history after reset to master 2011-07-19 06:47:07 -07:00
Ben Komalo
18811dfb45 Add touch slop to message list items
Bug: 5016987
Change-Id: Iddeb9a7bc244d3215a418f0897778b9ddcb3e955
2011-07-18 17:53:45 -07:00
Ben Komalo
776997e62e Update message compose to phone spec
- move cc/attachment to overflow menu
- misc layout fixes

Bug: 5011868
Change-Id: If17a36c9e7f13115828a957163af5969b6f8f93e
2011-07-18 17:08:35 -07:00
Jorge Lugo
ae594dc0ca Preference panel screen titles don't change on rotate
Incoming settings, outgoing settings, exchange settings, and
edit quick response preference panel titles no longer
change to "Account settings" when screen is rotate.

Bug: 5011355
Change-Id: Ibaf68bc836a61777de929623bff2bf2dd4ae0c3b
2011-07-18 15:43:08 -07:00
Ben Komalo
23b4ce58d4 Make min widget size 3x2
Bug: 5034371
Change-Id: If3350fcdff83dae9243edfcf651bef7b45fe85a8
2011-07-18 15:14:59 -07:00
Marc Blank
ecf8672df2 Merge "Fix NPE in onStartCommand" 2011-07-18 10:18:11 -07:00
Marc Blank
b31b798b46 Merge "Don't allow actions on empty sets" 2011-07-18 09:51:32 -07:00
Marc Blank
b8f672465a Merge "Remove unnecessary EmailAsyncTask" 2011-07-18 09:51:01 -07:00
Marc Blank
90a4811551 Fix NPE in onStartCommand
Bug: 5041436
Change-Id: Ib7462e5c8cb040b7526d9a655c5ab3f41cd159b8
2011-07-18 09:49:52 -07:00
The Android Automerger
1c1ab4bd2d merge in ics-release history after reset to master 2011-07-18 06:43:09 -07:00
Marc Blank
21cbdd88e1 Merge "Start/stop AttachmentDownloadService as needed" 2011-07-17 18:11:08 -07:00
Marc Blank
b2a8c2ce4c Start/stop AttachmentDownloadService as needed
Bug: 5033646
Change-Id: Ic0e75b28d0d8d5665c3f3ca864a9532fee05df8c
2011-07-17 18:06:20 -07:00
Ben Komalo
e71a19a523 Build default mailboxes for POP3
Bug: 4580535
Change-Id: Ic800eed387d3e9e64e95cce691d13d98b4a48045
2011-07-17 17:48:31 -07:00
Ben Komalo
2126caf076 Merge "Fix NPE in MailboxListFragment" 2011-07-17 17:29:33 -07:00
Ben Komalo
48f4df0911 Merge "Fixup settings entry points." 2011-07-17 17:29:10 -07:00
Ben Komalo
3c4061ae61 Merge "Filter out inbox from recent mailboxes" 2011-07-17 17:28:28 -07:00
Marc Blank
1d0609d386 Don't allow actions on empty sets
* Not sure how this could have happened, except possibly for some
  race condition
* Let's make sure it's impossible

Bug: 5032454
Change-Id: Ibd4de22dc5298fbaaf224cf4286f63bdc50aa7b9
2011-07-17 17:25:38 -07:00
Ben Komalo
9f05f72ab3 Fixup settings entry points.
- include settings in menu in message view
- remove "show all mailboxes" from message view
- rename "Account Settings" to "Settings"

Bug: 5039294
Change-Id: Ic2dcbe8fe6e2bd10cc5d790a74c49a7159b59cab
2011-07-17 16:41:55 -07:00
Ben Komalo
2be03be9b3 Merge "Remove temp code that was causing an NPE" 2011-07-17 16:41:18 -07:00
Ben Komalo
64a6a1f488 Merge "Show proper quick contact mode." 2011-07-17 16:40:37 -07:00
Ben Komalo
6b4a20730f Show proper quick contact mode.
- doesn't repeat the name
- shows status and right icons instead

Bug: 5039507
Change-Id: Id86d84a8ed54032f283454c83212ae962e8fc179
2011-07-17 16:24:18 -07:00
Ben Komalo
0932da35f5 Filter out inbox from recent mailboxes
Bug: 5039553
Change-Id: I9b58e9331028250f9bc3027429d2a6ec418186d6
2011-07-17 16:21:01 -07:00
Ben Komalo
afbba1bcbb Fix NPE in MailboxListFragment
Bug: 5037646
Change-Id: I74420d68398446f602ebe858760d9aaf5f88c107
2011-07-17 16:02:02 -07:00
Marc Blank
3793ec2463 Merge "Handle message sets in a single EmailAsyncTask" 2011-07-17 15:54:34 -07:00
Marc Blank
e2d28a0607 Clear "security needed" notification when releasing holds
* This fixes the issues with erroneous notifications remaining
  active

Bug: 5039388
Change-Id: Ib1cd506e732e34f6368036a131d79270b22d4a4b
2011-07-17 15:46:03 -07:00
Ben Komalo
14ea7d7bbc Merge "Fix possible NPE for messages with no subjects" 2011-07-17 15:03:35 -07:00
Marc Blank
f29221efc9 Remove unnecessary EmailAsyncTask
Change-Id: Ifb13f2f57016191f7ef409aa656bf9cb840f42c9
2011-07-17 12:23:49 -07:00
The Android Automerger
ce4d99a496 merge in ics-release history after reset to master 2011-07-17 12:19:18 -07:00
Marc Blank
b81a31b29b Handle message sets in a single EmailAsyncTask
* This prevents the possibility of RejectedExecutionException when
  selecting large numbers of items

Change-Id: I8f9ba287d69021fdb99b4a8a30cc79755f669b97
2011-07-16 16:11:00 -07:00
Ben Komalo
7f876c0375 Fix possible NPE for messages with no subjects
Bug: 5038097
Change-Id: I0952158017c0d512998f423ecd38722a5b6b8afc
2011-07-15 19:13:22 -07:00
Marc Blank
eb642812bf Merge "Clear account incomplete flag properly; handle unusual flow" 2011-07-15 19:07:17 -07:00
Ben Komalo
2845d72af0 Remove temp code that was causing an NPE
- since listContext can be null, this code was not safe.
we also filter out the search mailbox too, so it's no longer needed.
- don't ask to highlight a mailbox if doing a search
- remove a call in MailboxListFragment that was unconditionally telling
callbacks that something was selected when we started loading - this was
technically lying and if the item isn't in the list that was selected,
nothing should be called (as in the case of search). This was just an
optimization anyways and that callback is invoked later when the mailbox
list load completes.

Bug: 5037629
Change-Id: Id31c6795af9e64fa8682b67de9ab90540ee660df
2011-07-15 18:42:14 -07:00
Ben Komalo
1bc763964e Merge "Don't save empty drafts." 2011-07-15 18:14:58 -07:00
Eric Fischer
9c3741640b Merge "Import revised translations." 2011-07-15 17:03:01 -07:00
Eric Fischer
1c810c3f09 Import revised translations.
Change-Id: I2b1a26c9ba36fadd7d4351350dd5322f66c30f6c
2011-07-15 16:48:48 -07:00
Ben Komalo
0796b8aa61 Don't save empty drafts.
Note: all unicode sending unit tests are broken due to chip issues. I've
filed a separate bug on that.

Bug: 5012204
Change-Id: I17392f65e5bd8349780b79d9cbe10492d8e7a7d9
2011-07-15 16:47:36 -07:00
Marc Blank
8df9af0df3 Clear account incomplete flag properly; handle unusual flow
* We waited to clear the incomplete flag until security was agreed
  to, but this can lead to accounts left incomplete; we now clear
  the flag as soon as the AccountManager account is created (by
  convention, this is when the EmailProvider account is complete)
* Also, allow onDone() to be called more than once with a saved
  account, leaving cleanly, rather than throwing a runtime
  exception

Bug: 5016792
Change-Id: Ib5fc44ac045a1dd9bd5d63f922c037ed637d5341
2011-07-15 16:23:11 -07:00
Jorge Lugo
1086830bae Merge "Improve accessibility for stars and settings" 2011-07-15 15:21:44 -07:00
Jorge Lugo
fad7378031 Merge "Don't save empty quick responses; show keyboard on phone" 2011-07-15 15:20:48 -07:00
Ben Komalo
b87e021b02 Merge "Toggle selection on list item on long press" 2011-07-15 15:16:10 -07:00
Ben Komalo
ffe1b29061 Merge "Fix UI issue with expanding details." 2011-07-15 15:15:26 -07:00
Ben Komalo
cbfbe1db2d Toggle selection on list item on long press
Bug: 5020642
Change-Id: I31498122a4fe41cc81e5dbad5550a5e6620924c4
2011-07-15 14:49:26 -07:00
Jorge Lugo
8e779e627a Accessibility improvements
TalkBack functions properly with MessageList items, as well as
"reply," "reply-all," and "forward" buttons while viewing messages.
It is now also possible to switch accounts using only a dpad
or trackball. Finally, EditText fields in account setup also work
with TalkBack now.

Checkmarks don't work with Talkback, but this I have confirmed and
reported it as frameworks bug.

Change-Id: I7f72682a517eef4fa122241c675026fe7997ac64
2011-07-15 09:08:13 -07:00
The Android Automerger
9c8703fd46 merge in ics-release history after reset to master 2011-07-15 06:45:19 -07:00