Commit Graph

1056 Commits

Author SHA1 Message Date
Marc Blank
5ebdc0efeb Fix "reloadFolderList" service call in SyncManager
* Fixes #2118439

Change-Id: Iee75c5902940fb7f38f19717306708809fa06dd5
2009-09-16 14:27:39 -07:00
Andrew Stadler
092d35c98d Fix NumberFormatException in POP3 message sync
* Write unit test to replicate failure(s) in POP3 use of parseInt.  All
    calls to parseInt must be guarded by try/catch NumberFormatException.
* Fix the failures

Bug # 2115586
2009-09-16 12:20:38 -07:00
Andrew Stadler
0c4dc85190 Harden against crashes caused by account deletes
The basic failure mode is to delete an account while it is being
synced or some other background activity.  The fixes in this CL will
harden against this, but it will not be a perfect solution; That
will require shutting down all sync, which is difficult in the current
too-many-threads implementation.

Primary bug# 2112564
2009-09-16 10:58:54 -07:00
Android (Google) Code Review
fc7dfddf19 Merge change 25130 into eclair
* changes:
  Support StructuredName.DISPLAY_NAME for Exchange contacts
2009-09-15 23:12:24 -04:00
Android (Google) Code Review
2aa3e92fe3 Merge change 25041 into eclair
* changes:
  show message list selection
2009-09-15 21:56:59 -04:00
satok
5569ec9c9d show message list selection
BUG: 2117057

* add styles for items in MessageListView
* reduce color diff of Read/Unread
2009-09-16 10:55:28 +09:00
Marc Blank
ac37c5c15a Change Exchange username validation to exclude bare backslash
* Fixes #2121422

Change-Id: Id55dfa365b83d725926e3e7dcd7b646256863aa1
2009-09-15 18:05:16 -07:00
Andrew Stadler
da8836a76c Give warnings if dupe account created:
* Check for existing accounts with matching servername + username
* Show a dialog and block account creation
* Triggers in three cases:
  * After input of an auto-setup account (e.g. Gmail or AOL)
  * After input of manual setup (incoming) parameters
  * After changing incoming parameters of *any* existing account
* Made some notes in EmailContent regarding fields in HostAuth that we
    are not actually using.
* Added HostAuth unit tests

Primarily fixes bug # 1964449
Bonus fix for bug # 1594408

Change-Id: I49310faf6654280582e0ab3d3e40f2701bfcd21d
2009-09-15 16:33:44 -07:00
Android (Google) Code Review
f2147b1834 Merge change 25159 into eclair
* changes:
  Fix EAS sending (#2122221)
2009-09-15 19:23:40 -04:00
Marc Blank
a84a0e9a0d Fix EAS sending (#2122221)
Change-Id: I92ea4b1a77d96bf7992ea34026a2c5d30f33c317
2009-09-15 16:20:34 -07:00
Android (Google) Code Review
c21d326ef0 Merge change 25145 into eclair
* changes:
  Disable testResolveInlineImage
2009-09-15 19:03:06 -04:00
Andrew Stadler
1761234fc6 Disable testResolveInlineImage
This test depends on LocalStore and is thus deprecated.

It very much needs to be be rewritten and reestablished.

Bug # 2121424
2009-09-15 15:55:23 -07:00
Marc Blank
2d5691cac1 Support bcc in Exchange (Fixes #2117849)
* Must send the bcc header for EAS

Change-Id: I38d119beed334c6bb23a09b87375804f8c03ea76
2009-09-15 15:18:46 -07:00
Marc Blank
71177c5375 Support StructuredName.DISPLAY_NAME for Exchange contacts
* Fixes #2115514

Change-Id: Iac348c4ecac3bf8f895c32fff7077bc36d385bc9
2009-09-15 14:34:03 -07:00
Marc Blank
ffc681a4da Handle the case of no body being present (happens in unit tests)
* Fixes #2121403
2009-09-15 13:08:55 -07:00
Android (Google) Code Review
3bef610196 Merge change 24991 into eclair
* changes:
  change to use the new CALLER_IS_SYNCADAPTER flag
2009-09-15 15:26:50 -04:00
satok
0cc0e70941 Rename adding/removing star strings
BUG: 2116258
2009-09-15 16:05:14 +09:00
satok
d2174733b1 Auto-sync of stale mailboxes
BUG: 2050116
- auto sync onResume
- add mNonPushMode
-- mNonPushMode is updated in SetFooterTask
2009-09-15 14:38:13 +09:00
Android (Google) Code Review
043dba5e1b Merge change 24672 into eclair
* changes:
  Enable long press Open on Accounts screen
2009-09-15 00:42:21 -04:00
Fred Quintana
977cd2f58a change to use the new CALLER_IS_SYNCADAPTER flag 2009-09-14 17:37:18 -07:00
Marc Blank
1d98989222 Implement SmartReply/SmartForward for EAS; fixes #2098779
* SmartForward and SmartReply are EAS commands that automatically
  include the original message and, if a forward, all original
  attachments, regardless of whether they've been downloaded to
  the device
* Both commands improve battery life by sending less data; greatly
  so for SmartForward if there are attachments

Change-Id: I12432cd5275a3b54e9a80d5cd59da437c4a086cc
2009-09-14 15:47:38 -07:00
Marc Blank
42c130dcf1 Fix bug in which EAS mail won't ever get sent (#2118279)
Change-Id: Iedd80269bafd39a3536527ebe8902b4999eff41e
2009-09-14 11:03:18 -07:00
Marc Blank
e59c8725c5 Make sure SyncManager keeps running in various edge cases
* Have Welcome start the service (in case the app has been reloaded)
* Have SyncManager.ping start the service if there's no instance of
  SyncManager

Change-Id: I8bed2843a3e065d2db29fad67dfb0bb3a5d0ff5e
2009-09-14 08:50:50 -07:00
Android (Google) Code Review
d609094182 Merge change 24849 into eclair
* changes:
  Improve the checkMailbox loop query to get only the appropriate boxes
2009-09-14 10:06:44 -04:00
Android (Google) Code Review
bba6d443f5 Merge change 24858 into eclair
* changes:
  Don't wait longer than 10s for ping boxes to be ready
2009-09-14 01:53:36 -04:00
Marc Blank
4f9d5cf8f8 Don't wait longer than 10s for ping boxes to be ready
* Do a short ping in this case, which at least will allow the device
  to sleep while waiting
* Addresses #2116749

Change-Id: I9e70feaeef1361e1d66652dc66b92f6ee14751bf
2009-09-13 22:52:36 -07:00
Android (Google) Code Review
403a45e736 Merge change 24844 into eclair
* changes:
  Reimplement reply/forward to use mTextReply/mHtmlReply
2009-09-14 01:32:10 -04:00
Marc Blank
f2dded3a2f Reimplement reply/forward to use mTextReply/mHtmlReply
* Move creation of final reply/forward text (i.e. new text plus
  the original) to Rfc822Output, where it belongs.
* Prepares the way for use of SmartForward/SmartReply in
  Exchange and replying w/ multipart/alternative in SMTP
* Moved test from MessageCompose to new Rfc822OutputTests, and note
  that new tests should be added (this is not a regression; there
  were never enough tests here)

Change-Id: Ibefb842f47cc9223714856d99b8d4f55b55f49e3
2009-09-13 22:28:38 -07:00
Marc Blank
60c7502b67 Change exchange setup screen per #2025029
Change-Id: Ib94713857902e336984b847f70c96e04826b9b74
2009-09-13 21:55:10 -07:00
Marc Blank
c7897acf56 Fix NPE when adding note rows to Contacts
Change-Id: I51574db9abc45b55f8a7c19d493fdc47bc24b11b
2009-09-13 12:04:59 -07:00
Marc Blank
fa1ad355a1 Improve the checkMailbox loop query to get only the appropriate boxes
* Boxes must 1) be from an EAS account and 2) have a syncInterval that
  is not "never"

Change-Id: I5efbdc527063b2ee3373bc763b625eadfed67c4a
2009-09-13 12:04:06 -07:00
Marc Blank
f50c6d1faf Don't sync "trash" folder in Exchange
Change-Id: I6a1dc2a8ae5936bb7428d82e48ddbf114500051a
2009-09-12 16:47:07 -07:00
Android (Google) Code Review
492228bdc4 Merge change 24815 into eclair
* changes:
  Don't sync if the "Sync Contacts" checkbox isn't set
2009-09-12 14:51:28 -04:00
Marc Blank
411334d4e5 Fix broken test cases
Change-Id: Ib2d019662d358a20b4d62992529bfdf398e4661b
2009-09-11 23:00:39 -07:00
Android (Google) Code Review
95bc6a6ad9 Merge change 24755 into eclair
* changes:
  Allow download of contact w/ no name; don't accept empty note
2009-09-11 21:42:21 -04:00
Marc Blank
9679d4cf64 Don't sync if the "Sync Contacts" checkbox isn't set
Change-Id: I606f6c384fa34283ccee1eeaac90123347846f28
2009-09-11 18:34:06 -07:00
Marc Blank
e13ff84df7 Fix leaked intent receiver by using onStartCommand in SyncManager
Change-Id: I914c597aede6904a11a5d3119b3f7097e65b2fba
2009-09-11 16:52:07 -07:00
Marc Blank
3a0fb3b14e Allow download of contact w/ no name; don't accept empty note
Change-Id: I90058ee6c92853a3765138ca433abd7f62b60c0a
2009-09-11 13:50:45 -07:00
Android (Google) Code Review
2bab07c71e Merge change 24722 into eclair
* changes:
  Fix connection failure retry behavior; don't try syncing w/o connectivity
2009-09-11 16:09:43 -04:00
Marc Blank
a918672f4c Fix connection failure retry behavior; don't try syncing w/o connectivity
* Also remove some logging and correct some erroneous logging
* Fix the backoff behavior on IOException

Change-Id: I5fb5a0bf73eaa681eb7b9c305c838e78e7ba88ab
2009-09-11 12:59:35 -07:00
Marc Blank
3c7f0d4c00 Make exchange contact category names visible; also their members
Change-Id: Icaf7c2828db4fda7323b3ec3a6c9cd783ae80c9a
2009-09-11 08:56:34 -07:00
Marc Blank
86ada729c2 Check for null data before writing contact rows to server
Change-Id: Ib7016c43b2655e1753680c511f30cad8f4a1acce
2009-09-11 07:56:03 -07:00
satok
9486e1c1d3 Enable long press Open on Accounts screen
BUG: 2083565

Fix the button name
2009-09-11 17:59:16 +09:00
Andrew Stadler
be60dfdee7 Update MessageListView to fit punchcut's design
BUG:1904421

* update READ/UNREAD indications
** don't change color chip
** change background color
* Change Date
* Change the position of attachement icon
* Change menu icon for folder
2009-09-10 17:27:21 -07:00
Android (Google) Code Review
51b635f2d2 Merge change 24518 into eclair
* changes:
  Fix spinny position in the title bar
2009-09-10 20:17:47 -04:00
Andrew Stadler
f9ab857a55 Implement delete-from-trash
* Edit Controller.deleteMessage() to handle both cases
* Refactored to start from processPendingActionsSynchronous() and
    dispatch to series of smaller methods to handle deletes vs. updates
    and the details of the various specific operations.
* Added processPendingDeletesSynchronous() which looks for delete-from-
    trash and does the right thing locally and/or remotely.

Fixes bug # 1811026
2009-09-10 16:03:34 -07:00
Android (Google) Code Review
6c6d7e3a26 Merge change 24601 into eclair
* changes:
  Fix sync-crashing bug in exchange contact groups
2009-09-10 18:55:20 -04:00
Marc Blank
058df979c8 Fix sync-crashing bug in exchange contact groups
Change-Id: I40335dcbba9653778d8376b26ae9c2455c34d0ee
2009-09-10 15:53:37 -07:00
Andrew Stadler
6c21942ec4 Implement move-to-trash for IMAP and POP3.
* Define new message-loaded state "FLAG_LOADED_DELETED" (used only for
   POP3, which needs to write sentinel messages that are not displayed.)
* Also renamed the other flags to make the naming more consistent.
* Tweak MessageList query generation to inhibit display of deleted
    message sentinels, and MessagingController won't try to resync them.
* Clean up implementation of Controller.deleteMessage()
* Add support for move to trash to MessagingController.  This operates
    in three primary modes:
  * POP3 local delete (no server-side interaction)
  * POP3 server delete
  * IMAP server delete (and copy to IMAP trash mailbox)
* Add missing implementation in provider to delete all of the attachments
    for a given message
* Fix progress reporting in activities (the test for error vs. progress
    was inverted, which caused progress indicators to keep spinning
    after errors.)
* Fix broken account settings UI (POP3 delete policy was not persisting)

Addresses bug 2097409

TODO delete from trash / empty trash

Change-Id: I00188e6dc2093823106e009f35b68c760227c9e6
2009-09-10 12:44:05 -07:00
Marc Blank
c522cfa770 Change ping loop wait from 10s to 1s to reduce WakeLock use
* There is a better way of implementing this, which I'll write up in
  Buganizer, but this will help our battery life testing

Change-Id: I2583f0cb9c62b38aee64166138385d7b14855832
2009-09-10 12:26:26 -07:00