Commit Graph

1209 Commits

Author SHA1 Message Date
Android (Google) Code Review
25920f67e6 Merge change I7a3482fd into eclair
* changes:
  Handle IMAP empty bodies more safely
2009-10-07 17:48:47 -04:00
Eric Fischer
ed5ce78dfd am 1cd5e5f0: Merge change I0aba41f9 into eclair
Merge commit '1cd5e5f03cc2f707ddfd46d439e6991db7454ab8' into eclair-plus-aosp

* commit '1cd5e5f03cc2f707ddfd46d439e6991db7454ab8':
  Import revised translations.   DO NOT MERGE
2009-10-07 12:08:30 -07:00
Fred Quintana
59259f72fb am 2c79efd8: Merge change I303304ab into eclair
Merge commit '2c79efd82736c4fd9a8351130b9410e9fb23f7f7' into eclair-plus-aosp

* commit '2c79efd82736c4fd9a8351130b9410e9fb23f7f7':
  changes from Sync Manager API Review: bug 2164262
2009-10-07 12:01:07 -07:00
Marc Blank
2ff5384fbf am e1b5e857: Merge change I2b0e3b10 into eclair
Merge commit 'e1b5e8574c86e4dcc184f1b3a4db352c9a631d99' into eclair-plus-aosp

* commit 'e1b5e8574c86e4dcc184f1b3a4db352c9a631d99':
  Help with another push inconsistency edge case (#2131432)
2009-10-07 12:00:58 -07:00
Andrew Stadler
24f568cdd2 am eb7752bf: Fix back-to-back message-id bugs
Merge commit 'eb7752bf695b2a93854e0bb89ddbbc2236bb9aea' into eclair-plus-aosp

* commit 'eb7752bf695b2a93854e0bb89ddbbc2236bb9aea':
  Fix back-to-back message-id bugs
2009-10-07 11:56:35 -07:00
Mihai Preda
50ce2430c1 am 85d718cb: MessageCompose: quote plain-text body if available, otherwise quote HTML body.
Merge commit '85d718cb0735de9069673fbf9834fa64459c2178' into eclair-plus-aosp

* commit '85d718cb0735de9069673fbf9834fa64459c2178':
  MessageCompose: quote plain-text body if available, otherwise quote HTML body.
2009-10-07 11:56:31 -07:00
Mihai Preda
f816c50ef8 am 1ef86a50: MessageView: scroll to (0,0) on message change.
Merge commit '1ef86a50f8f6bf09cb031359c1d7cf0902c4a441' into eclair-plus-aosp

* commit '1ef86a50f8f6bf09cb031359c1d7cf0902c4a441':
  MessageView: scroll to (0,0) on message change.
2009-10-07 11:51:58 -07:00
satok
4795cd8dc6 am d493ba25: Merge change Ie90b74aa into eclair
Merge commit 'd493ba257a1632a8de578e06a7df7ed311227887' into eclair-plus-aosp

* commit 'd493ba257a1632a8de578e06a7df7ed311227887':
  Avoid NPE at onRefresh in MessageList
2009-10-07 11:50:43 -07:00
Marc Blank
c4ab10526d am 8647be09: Merge change Id1c0bc24 into eclair
Merge commit '8647be095a75a25df98487d6e908a94f2d6fb076' into eclair-plus-aosp

* commit '8647be095a75a25df98487d6e908a94f2d6fb076':
  Correct issue with mail change parsing (fixes #2165649)
2009-10-07 11:47:53 -07:00
Fred Quintana
8cc764c184 am 794b7e92: account manager api review changes
Merge commit '794b7e9258db816aa7097779f20e99878e412eda' into eclair-plus-aosp

* commit '794b7e9258db816aa7097779f20e99878e412eda':
  account manager api review changes
2009-10-07 11:45:47 -07:00
Marc Blank
da894344f0 am 888ea64f: Merge change I26bb7b8b into eclair
Merge commit '888ea64f86e518de18806ef85bc7c16ba29f72f6' into eclair-plus-aosp

* commit '888ea64f86e518de18806ef85bc7c16ba29f72f6':
  Handle change from push to other intervals properly (#2165032)
2009-10-07 11:45:35 -07:00
Marc Blank
d3a46145f2 am 65aae18d: Merge change Iaf15ead1 into eclair
Merge commit '65aae18de30be842537d15f7b535243e96071c75' into eclair-plus-aosp

* commit '65aae18de30be842537d15f7b535243e96071c75':
  Add patent disclaimer to appropriate directories (#2079270)
2009-10-07 11:45:26 -07:00
Marc Blank
3b2159d988 am c9e05f16: Merge change I13229d84 into eclair
Merge commit 'c9e05f16b278967f929d18798d3f9d254096b01d' into eclair-plus-aosp

* commit 'c9e05f16b278967f929d18798d3f9d254096b01d':
  Change logging command to help debug Moto issue (#2165649)
2009-10-07 11:44:36 -07:00
Andrew Stadler
b6756688b1 Handle IMAP empty bodies more safely
Some IMAP servers return NIL if you BODY.PEEK[TEXT] a messsage with
no body, instead of the more canonical {0}CRLF.  Instead of messing with the
parser to deal with that, it makes more sense not to try and fetch empty
bodies.  So there are three changes:

* Don't fetch parts when size = 0
* Don't append "null" when there is null body text
* Slight change to attachment handling so size is reported >0
* Unit tests on some of the related lower-level protocol stuff

Bug http://b/issue?id=2160387

Change-Id: Ifb8fb0ed5ce7297908e1ae8d5a02dda5975c4a3c
2009-10-07 11:42:27 -07:00
Mihai Preda
a437e92853 am ba7decd8: Merge change I1197ac76 into eclair
Merge commit 'ba7decd89de39d3ed8d27e8e0e48ad517b435190' into eclair-plus-aosp

* commit 'ba7decd89de39d3ed8d27e8e0e48ad517b435190':
  MessageCompose: allow sending email when started through external intent.
2009-10-07 11:41:40 -07:00
Marc Blank
23a52ff65f am bb7a6c54: Merge change Icb449407 into eclair
Merge commit 'bb7a6c5463f7f9fea372079e3afd44cec79b12e5' into eclair-plus-aosp

* commit 'bb7a6c5463f7f9fea372079e3afd44cec79b12e5':
  Fix push failure edge case (#2161999)
2009-10-07 11:39:22 -07:00
Android (Google) Code Review
1cd5e5f03c Merge change I0aba41f9 into eclair
* changes:
  Import revised translations.   DO NOT MERGE
2009-10-07 14:36:57 -04:00
Eric Fischer
022b6f83b5 am 2787f001: Import revised translations. DO NOT MERGE
Merge commit '2787f001fb4b0341cc9949bffde62075b7c68b39' into eclair-plus-aosp

* commit '2787f001fb4b0341cc9949bffde62075b7c68b39':
  Import revised translations.  DO NOT MERGE
2009-10-07 11:35:26 -07:00
Marc Blank
ef80f8eaec am 1eb0af5d: Fix NPE issue w/ Contacts sync (#2160417)
Merge commit '1eb0af5d80514d03acca7ce040a8c01230f3c47e' into eclair-plus-aosp

* commit '1eb0af5d80514d03acca7ce040a8c01230f3c47e':
  Fix NPE issue w/ Contacts sync (#2160417)
2009-10-07 11:33:31 -07:00
Android (Google) Code Review
2c79efd827 Merge change I303304ab into eclair
* changes:
  changes from Sync Manager API Review: bug 2164262
2009-10-07 01:49:02 -04:00
Fred Quintana
84c975033d changes from Sync Manager API Review: bug 2164262 2009-10-06 17:19:32 -07:00
Android (Google) Code Review
e1b5e8574c Merge change I2b0e3b10 into eclair
* changes:
  Help with another push inconsistency edge case (#2131432)
2009-10-06 20:16:52 -04:00
Eric Fischer
0aba41f98b Import revised translations. DO NOT MERGE
Approver: jerryw
2009-10-06 16:52:58 -07:00
Andrew Stadler
eb7752bf69 Fix back-to-back message-id bugs
* MessageCompose now adds message-id to new messages (it was previously
    done on its behalf by MimeMessage).
* LegacyConversions.updateMessageFields() now handles missing message-id
    without error.
* Unit tests for the LegacyConversions change

These two issues were combining with a failure of comcast's SMTP server
to insert message-id headers, to prevent delivery of a message between
any two comcast accounts using this client.

Bug # http://b/issue?id=2161478
2009-10-06 14:20:09 -07:00
Marc Blank
ffef9d9fe8 Help with another push inconsistency edge case (#2131432)
* If we are forced to abort a "ping" due to a watchdog alarm, we should
  handle this as a ping failure (which potentially changes the heartbeat)
  rather than a garden variety IOException.
* This prevents the additional overhead of connection error backoffs,
  which would only tend to increase the time needed to recover from the
  error.
* In one case reported by Moto, this appears to be the behavior of a WiFi
  router with NAT timeout.  This fix will cause maximum delay for pushed
  mail to be reduced in most cases.

Change-Id: I2b0e3b10d82762d20f63cac3ac4638a03f13f842
2009-10-06 13:46:09 -07:00
Mihai Preda
85d718cb07 MessageCompose: quote plain-text body if available, otherwise quote HTML body.
Bug 2082852.
2009-10-06 16:50:54 +02:00
Mihai Preda
1ef86a50f8 MessageView: scroll to (0,0) on message change.
Bug 2156934.
2009-10-06 16:36:44 +02:00
Android (Google) Code Review
d493ba257a Merge change Ie90b74aa into eclair
* changes:
  Avoid NPE at onRefresh in MessageList
2009-10-05 22:31:42 -04:00
Android (Google) Code Review
8647be095a Merge change Id1c0bc24 into eclair
* changes:
  Correct issue with mail change parsing (fixes #2165649)
2009-10-05 16:59:07 -04:00
Marc Blank
d0848056f1 Correct issue with mail change parsing (fixes #2165649)
* Older parsing code that didn't take into account the fact that
  'flag' is a structured data item
* Requires Dr. No approval for Eclair_Sholes

Change-Id: Id1c0bc24e784b19c598d2b852975e135abebbdb0
2009-10-05 13:58:19 -07:00
Fred Quintana
794b7e9258 account manager api review changes 2009-10-05 11:29:01 -07:00
Android (Google) Code Review
888ea64f86 Merge change I26bb7b8b into eclair
* changes:
  Handle change from push to other intervals properly (#2165032)
2009-10-05 14:07:09 -04:00
Marc Blank
86765f3463 Handle change from push to other intervals properly (#2165032)
* Make sure eas account mailbox is also changed to the new sync interval

Change-Id: I26bb7b8b740c09f4c2cf848c33c9b642b9776fcc
2009-10-05 11:05:37 -07:00
Android (Google) Code Review
65aae18de3 Merge change Iaf15ead1 into eclair
* changes:
  Add patent disclaimer to appropriate directories (#2079270)
2009-10-05 14:02:45 -04:00
Marc Blank
c5563407dd Add patent disclaimer to appropriate directories (#2079270)
Change-Id: Iaf15ead1df560633f9d1b7e915ac846bb6789bf2
2009-10-05 11:01:30 -07:00
satok
e90b74aa04 Avoid NPE at onRefresh in MessageList
BUG: 2161449
2009-10-05 15:53:57 +09:00
Android (Google) Code Review
c9e05f16b2 Merge change I13229d84 into eclair
* changes:
  Change logging command to help debug Moto issue (#2165649)
2009-10-05 00:09:01 -04:00
Marc Blank
b3e449edf9 Change logging command to help debug Moto issue (#2165649)
* It has been reported that messages for a particular user are not
  staying in sync re: deletions via PC
* This hasn't been reported elsewhere
* The new logging command logs the subject of deleted messages which
  will help track down the problem
* I have also requested, and expect to receive, an account on the
  Moto server in question to try to replicate the issue

Requesting Dr. No approval for this important change to user logging
code.

Change-Id: I13229d843ef828b54f3514bdded5a7561a87989a
2009-10-04 19:56:19 -07:00
Android (Google) Code Review
ba7decd89d Merge change I1197ac76 into eclair
* changes:
  MessageCompose: allow sending email when started through external intent.
2009-10-02 19:26:53 -04:00
Android (Google) Code Review
bb7a6c5463 Merge change Icb449407 into eclair
* changes:
  Fix push failure edge case (#2161999)
2009-10-02 14:36:12 -04:00
Marc Blank
36842abe9f Fix push failure edge case (#2161999)
* Unsafe (potentially stale) data was being written to the Mailbox table near
  the end of each sync.  It would effectively undo changes made to the
  Mailbox in other threads that occurred while the Mailbox was syncing.
* In this particular case, changes to sync interval (push/ping/timed)
  were being overwritten, which could cause push to get lost for as
  long as 30 minutes (the pingLoop timeout when there aren't any
  pingable mailboxes)
* Watchdog alarm was being set to wrong time (typo)
* Add extra user logging in case there are additional cases of push
* Only set sync status and time on successful sync
* Move ping error check into pingParser to avoid unnecessary sync

Change-Id: Icb4494078480ada39b7494b3abf380fb08858406
2009-10-02 11:09:08 -07:00
Mihai Preda
1197ac7692 MessageCompose: allow sending email when started through external intent.
Bug: 2161199.
2009-10-02 15:53:28 +02:00
Eric Fischer
2787f001fb Import revised translations. DO NOT MERGE
Approver: jerryw
2009-10-01 16:58:49 -07:00
Marc Blank
1eb0af5d80 Fix NPE issue w/ Contacts sync (#2160417)
* Oversight in late-night submission; simple fix

Change-Id: I0c3ebd4b23c1e913d74e153b3692b3ce8e3c0220
2009-10-01 14:31:24 -07:00
Mihai Preda
ab4fe15476 am 2d34c669: MessageView: scroll webview to (0,0) on message change.
Merge commit '2d34c669c10ec5aec70ec53fe7582feba8166394' into eclair-plus-aosp

* commit '2d34c669c10ec5aec70ec53fe7582feba8166394':
  MessageView: scroll webview to (0,0) on message change.
2009-10-01 06:47:24 -07:00
Mihai Preda
2d34c669c1 MessageView: scroll webview to (0,0) on message change.
Bug 2156934.
2009-10-01 13:21:59 +02:00
Andrew Stadler
2fbfe0b3a1 am f9ccc0ba: Plumb send-message status callbacks from service
Merge commit 'f9ccc0ba88e00c4175f6720aca07876d50b9f22f' into eclair-plus-aosp

* commit 'f9ccc0ba88e00c4175f6720aca07876d50b9f22f':
  Plumb send-message status callbacks from service
2009-10-01 03:22:28 -07:00
Andrew Stadler
f9ccc0ba88 Plumb send-message status callbacks from service
* Make sure service callbacks are installed
* Route from service sent-message callback to controller results

This sends the callback information back to listeners who care about
sent messages.  Note, due to impedance mismatch between the service
and the controller, this should not be used for much more than an
indication that outbox status has changed.

Bug # 2158497

Change-Id: I8d013d97ef53dcca85216f9b8c027ba3917c1e85
2009-10-01 03:12:40 -07:00
Andrew Stadler
f47ee2cfd6 am 3ea49f21: Merge change Ic3cbc51d into eclair
Merge commit '3ea49f215135f0c57456de399f2ea7ad7cb7f17a' into eclair-plus-aosp

* commit '3ea49f215135f0c57456de399f2ea7ad7cb7f17a':
  Cleanup delete handling issues in POP3
2009-10-01 02:04:52 -07:00
Android (Google) Code Review
3ea49f2151 Merge change Ic3cbc51d into eclair
* changes:
  Cleanup delete handling issues in POP3
2009-10-01 04:59:06 -04:00