Commit Graph

4304 Commits

Author SHA1 Message Date
Makoto Onuki
52d0966b86 Fix divider style for message compose
Bug 3335145

Change-Id: I45aed96d6452d2cbffab543c654e9733baa81879
2011-01-10 18:23:22 -08:00
Makoto Onuki
5fed5c8a59 Don't show "Stop" for loaded attachments
There's a case where we show both the "stop" and "view" buttons at the same
time.

Bug 3138021

Change-Id: Ib12f5dc1e522a04b1cc175626d084ed8bc5c8065
2011-01-10 16:28:38 -08:00
Makoto Onuki
84c4ec4aef Merge "Remove STOPSHIPs" into honeycomb 2011-01-10 16:03:16 -08:00
Makoto Onuki
a826d3fb03 Pixel perfect: Message view
Still waiting for a few missing assets, but it's done other than that.

The divider change is already merged; new layouts all use the framework style.

It's basically all layout changes, except for:
- Now the recepient address line has "Show details", which shows a dialog with
  all to/cc/bcc addresses with the timestamp.
- Now invite response buttons are checkboxes.
  (But the basic behavior doesn't change -- once you check a response,
  the message will be gone, so you can't change the response later.)

Copied message_header_bg from gmail manuall.  It'll look silly without it.

Bug 3138021
Bug 3307021

Change-Id: I6f7eb91d6104c3143a5c58b0c4c6c19929cea477
2011-01-10 15:51:32 -08:00
Todd Kennedy
07f5f60b8f Implement proper drag-n-drop
Still some tweaks to be done, but, we're real close to what it should
look like.

Bug 3322756
Change-Id: I8549ab59677a344e8f259c88bed950169d7381a8
2011-01-10 15:23:40 -08:00
Makoto Onuki
42c6881494 Remove STOPSHIPs
Bug 3335094
Bug 3335069

Change-Id: I307a762a83ca7fa94cf62f1d80f32a2b3f30b27a
2011-01-10 14:36:17 -08:00
Todd Kennedy
285fac8554 Replace private divider with framework divider
The framework defines ?android:attr/dividerHorizontal. Instead of defining our
own divider by specifying some arbitrary RGB colour, utilize the framework's
divider.

bug 3335145

Change-Id: I64dd30a5a73b0884f82f6a2b9fbbd88c6782e0db
2011-01-10 13:16:10 -08:00
Marc Blank
26cf5639e0 Remove STOPSHIP from WidgetProvider
Bug: 3335070
Change-Id: I838d5eeb795759da30946fbdb00fa3f0e4dbdb12
2011-01-10 11:33:21 -08:00
Marc Blank
75396e175d Merge "Remove STOPSHIP from AttachmentDownloadService" into honeycomb 2011-01-10 11:29:42 -08:00
Marc Blank
cec50e08ea Merge "Remove STOPSHIP from providers.xml" into honeycomb 2011-01-10 11:28:18 -08:00
Andy Stadler
0b63258999 Merge "Near-final layout tweaks to setup screens" into honeycomb 2011-01-10 11:00:45 -08:00
Andy Stadler
a7b781b5dd Near-final layout tweaks to setup screens
* Dimensions, Colors, Paddings, Text styles, etc.
* Update AccountSetupBasics, AccountSetupAccountType,
    AccountSetupOptions, and AccountSetupNames
* Extracted shared layouts in AccountSetupOptions & AccountSetupNames
* Leave behind STOPSHIP entries for:
  - button positioning (primarily vertical)
  - colors of text & dividers
* Will do incoming, outgoing, exchange in a separate CL (because they
  are shared with settings)

Bug: 3335093
Bug: 3188940
Change-Id: Idf727e3b2b6a0293d6d41bf29f1c0c48d746ab7c
2011-01-10 00:42:26 -08:00
Marc Blank
33799ad2d0 Remove STOPSHIP from AttachmentDownloadService
Bug: 3335071
Change-Id: Ia6a8e2e7378510db234c4ec5164cb5ef39c529d7
2011-01-09 18:30:24 -08:00
Marc Blank
fb4bc09428 Remove STOPSHIP from providers.xml
Bug: 3335087
Change-Id: Id7172370ecdaf61e6ff08ca50e618bab3d2597de
2011-01-09 18:28:35 -08:00
Marc Blank
d9d120bfe4 Merge "Fix issues w/ security-related account data deletion" into honeycomb 2011-01-09 18:25:53 -08:00
Marc Blank
69af769688 Fix issues w/ security-related account data deletion
* Stop running syncs
* Delete all EmailProvider data except the account itself (with
  cleared sync key) and the account mailbox (necessary for syncing
  to sync after security hold is lifted

Bug: 3245779
Bug: 3253952
Change-Id: Idc208ef5ed85808b085ebab9c26a428fb0451e34
2011-01-09 18:24:35 -08:00
Brett Chabot
85985b5db3 Merge "Use new public API to protect force account creation." into honeycomb 2011-01-09 16:35:51 -08:00
Andy Stadler
a8ef07fabc Cleanup STOPSHIPs in strings.xml
* cleaned out old placeholders
* moved a bunch of unused strings into placeholders
* moved three strings into active status.

Bug: 3335092
Change-Id: Ibb0690f7cc9ddd1b8f7f337964faff6471be880c
2011-01-09 16:16:08 -08:00
Brett Chabot
ea4c564261 Use new public API to protect force account creation.
Check value of ActivityManager.isRunningInTestHarness() before allowing force
account creation, instead of ActivityManager.isUserAMonkey().

Bug 3329873

Change-Id: I5028eef9caced2cacc9c187dfd746865939fdedd
2011-01-09 15:25:52 -08:00
Andy Stadler
7271bbef13 Remove a couple of STOPSHIP notes
* Restore ActionBar based progress in phone UX
* Removed unused debugging method

Change-Id: Ia36847d27fe9c9fa121a29f1e6a65bd3da0c3ffc
2011-01-09 14:19:35 -08:00
Dianne Hackborn
0e50c33ec7 Merge "Remove use of old methods." into honeycomb 2011-01-08 14:23:54 -08:00
Dianne Hackborn
6c7075fb86 Remove use of old methods.
Change-Id: Ibc686a39cb2c481e6cd57b1d6029979cfd9f5b71
2011-01-08 13:08:04 -08:00
Christopher Tate
b50872abd0 Rename drag "thumbnail" to the drag "shadow"
No functional changes; just a rename of the relevant class/method/parameters.

Change-Id: I80c0297d0ccbf1bb30196fb919ae68194e18d732
2011-01-07 16:31:05 -08:00
Marc Blank
d6ce2998f7 Merge "Fix widget view switching with > 1 account" into honeycomb 2011-01-07 16:01:49 -08:00
Todd Kennedy
5bd42764c7 Merge "New icons from designer git" into honeycomb 2011-01-07 15:30:05 -08:00
Makoto Onuki
f6cb1b002e Merge "Don't pass ACCOUNT_ID_COMBINED_VIEW to message compose." into honeycomb 2011-01-07 15:11:54 -08:00
Makoto Onuki
f29ce4d37b Don't pass ACCOUNT_ID_COMBINED_VIEW to message compose.
If you do so, MessageCompose won't be able to restore an account, so it'll
use null account...

Bug 3324472

Change-Id: Ic0e615b31e21246e41f6f2c709a8422bef230040
2011-01-07 14:57:05 -08:00
Todd Kennedy
cd49800f78 Merge "Remove unused icons" into honeycomb 2011-01-07 14:20:55 -08:00
Todd Kennedy
0fc4902a5a use official holo icon for mark message read
Change-Id: I3f2c8ce096ecd0eff7ec7719f7f99f7f8dc497a0
2011-01-07 14:14:19 -08:00
Todd Kennedy
f41756f8be New icons from designer git
Change-Id: I9ae2f596fdd5b43c8784eb425a6cb73ba4afe75c
2011-01-07 14:13:11 -08:00
Todd Kennedy
b59cd9d406 Remove unused icons
Icons reported as unused by running the script "findUnusedAssets". This
script checks for any reference to a drawable in all XML and Java files.

Some _holo_light icons are removed as they are no longer in the designer
git and should not be used.

Change-Id: Ie42d13394d6d81d35fcb48f8f76c6abd4cb09ee4
2011-01-07 14:01:27 -08:00
Andy Stadler
4b311dcdd4 Merge "Move account edit save settings off UI thread" into honeycomb 2011-01-07 13:34:41 -08:00
Andy Stadler
6e71978ec3 Move account edit save settings off UI thread
* Caught by StrictMode
* The fix prevents ANR
* Removed vestigial cruft from the saveSettingsAfterEdit() implementations

Bug: 3133633
Change-Id: Id41fb74269a2b72cc17121e33684b459d3eec869
2011-01-07 13:33:07 -08:00
Marc Blank
dc3f9f4d69 Fix widget view switching with > 1 account
* Add test case for view switching

Bug: 3329906
Change-Id: I738bad118d7d7a8d2839fbd2a9fdc00af2af3153
2011-01-07 13:20:48 -08:00
Eric Fischer
8eaa1522d9 Merge "Import some unabbreviated translations for large screens." into honeycomb 2011-01-07 12:59:34 -08:00
Makoto Onuki
1dde2253cb Merge "PPing message view: use proper text size." into honeycomb 2011-01-07 12:47:44 -08:00
Eric Fischer
fe687c8c69 Import some unabbreviated translations for large screens.
Change-Id: I7f16a7e5f2a0065496eee63a03716d17337e7222
2011-01-06 17:46:00 -08:00
Makoto Onuki
21a0c17986 PPing message view: use proper text size.
Also use the same date/time format as gmail to show the date part properly.

Bug 3138021

Change-Id: I24e45895de5330cd670a674f56eca5ccadcee9b5
2011-01-06 16:40:29 -08:00
Makoto Onuki
7523930d39 Pixel perfect: message compose
Layout & action bar icons.  Now I think it's close enough.

Bug 3138037

Change-Id: I0802f34ac23980e0faf8a0daffc016a012816d81
2011-01-06 15:01:29 -08:00
Todd Kennedy
5faff6c76a Merge "Use new holo light icons" into honeycomb 2011-01-06 13:58:18 -08:00
Todd Kennedy
64ac7a6cc8 Use new holo light icons
Use the new icons where appropriate. This is not a complete change as there are
still some icons missing.

Change-Id: I51d1458749343ddfc6456dc2a9853b8bc2540e26
2011-01-06 13:42:20 -08:00
Andy Stadler
29d79adf4b Fix cursor leaks when canceling AsyncTask
We discovered that AsyncTask.cancel() doesn't quite perform as expected;
In particular, if you call cancel() during a particularly slow background
worker, the result is discarded and onPostExecute() is never called.  If
the result is an open cursor, then we "leak" by not closing it.

For AccountFolderList, which has a multi-step doInBackground():
1.  Check for isCancelled() during the long doInBackground() which will
    reduce the number of discarded cursors in the first place.
2.  Check for isCancelled() at the end of the long doInBackground() and
    if true, close the result cursors and return null.
3.  In the existing isCancelled() code in onPostExecute(), close the
    cursors.

For other AsyncTasks (with simpler configurations):
1.  Check for isCancelled() at the end of doInBackground() and if true,
    close the just-opened cursor and return null.

See also Change-Id: Ie63a3197af563baa8bb0fe6f1ef9423e281cbf4c
Bug: 3088870

Change-Id: I51b11bb5b23f209f8b61962500a063040484fd24
2011-01-06 13:35:57 -08:00
Andy Stadler
201a24f51e Harden MailService against half-created accounts
* Add simple sanity checks to scanned accounts, skip over if bad
* Fix existing unit tests and add new unit test for this change
* Also fixed minor bug in EmailContent that was never triggered in
  production code (only discovered it via a unit test).
* Also fixed minor bug in an existing unit test

Bug: 2937595
Change-Id: Id60bbb5d8bd923db043d46891c7f89d7debb0a11
2011-01-06 12:53:40 -08:00
Marc Blank
2f1a7e8d0a Fix typo in CL 87363
Change-Id: I7a52a2a5e93dd6ccde8b040ffb7b1d224f026ce7
2011-01-05 20:35:46 -08:00
Makoto Onuki
ce9df41fc1 Merge "Pixel perfect: mailbox list" 2011-01-05 17:40:51 -08:00
Makoto Onuki
33d7399d8d Merge "action bar: make current mailbox closer to gmail" 2011-01-05 17:37:45 -08:00
Marc Blank
2b3ac66f9f Merge "Move onStartCommand processing to worker thread" 2011-01-05 17:36:55 -08:00
Marc Blank
08065b2669 Merge "Limit user mailboxes for EAS (to 1000, for now)" 2011-01-05 17:35:36 -08:00
Makoto Onuki
e9818160e1 action bar: make current mailbox closer to gmail
Still not pp, but the current one looks too ugly.  Let's change it.

Bug 3137891

Change-Id: I2e036d23b2ec99bb63fe300a5c2ade72b192f81a
2011-01-05 17:29:48 -08:00
Makoto Onuki
0187c3e203 Merge "Message list item: Use "activated" background" 2011-01-05 16:42:03 -08:00