Commit Graph

46 Commits

Author SHA1 Message Date
Makoto Onuki
b3c3f1afc6 Pixel pefect: account spinner.
The expanded account spinner is completed, but the collapsed view
needs some more work.  (That'll probably be a rather large CL, so I'll
finish it in a separate CL.)

Bug 3434135

Change-Id: Ia732e6b57b8c0d3e1609c3134b26411539ab6a18
2011-02-23 13:59:11 -08:00
Todd Kennedy
3f60e9312b Add "info" button to the attachment view
Whenever we remove the "load" and "view" buttons, we should add an "info"
button; where we will inform the user as to why we are preventing her from
seeing the attachment.

bug 3338997

Change-Id: Ic243f1542dec55f5b256eeb67ade50aa90e42009
2011-02-22 08:20:54 -08:00
Andy Stadler
1758bc3c85 Merge "Remove STOPSHIPs." into honeycomb 2011-01-26 21:47:12 -08:00
Makoto Onuki
eee1139ba6 Remove STOPSHIPs.
Bug 3396430

Change-Id: I31fe78793fbb92712b7077219178df68f5d0aa3d
2011-01-26 18:15:51 -08:00
Todd Kennedy
a7f49a7c0b Update icons with latest drop from UI
Change-Id: Ic23f1bee28c8aef1974225f9c03edc92c845f8c7
2011-01-26 17:43:03 -08:00
Makoto Onuki
c850485269 Remove STOPSHIPs
action_bar_current_mailbox: We'll ship with the current design.
colors.xml: Obsolete STOPSHIP.

Bug 3335095

Change-Id: Ic45ef3d0cafb55761b720e1e74c0633012f87e98
2011-01-25 16:37:40 -08:00
Makoto Onuki
b6acba0e7b Expand Reply/Forward/etc buttons for easier tap
Bug 3372927

Change-Id: I9a6e01c43b4c534b5e6c5c697062313d610c44e6
2011-01-20 14:42:48 -08:00
Makoto Onuki
8ac207f298 Compose: Make the EditTexts easy to focus on
- Now tapping these To/Cc/Bcc/Subject labels moves the focus to
  the corresponding edittext.
- Tapping the bottom part of the screen moves the focus to the
  main EditText.
- Also use paddings instead of margins for the main EditText, to
  expand the hitarea.

Bug 3366831
Bug 3367100

Change-Id: I9b5d18dcc9d7802bfcbd0160befcb008c784d9f7
2011-01-19 13:36:21 -08:00
Makoto Onuki
3407d9683e Merge "Pixelperfect: message compose" into honeycomb 2011-01-18 11:09:02 -08:00
Andy Stadler
946239e8a0 Add per-account preference for bkgnd attachments
* Add flag to Account record
* Add checkbox to Account Settings (IMAP & EAS)
* Add checkbox to Account Setup (IMAP & EAS)
* Add flag to backup/restore logic
* Update Account & AccountSetupOptions unit tests

Bug: 3360873
Change-Id: I0c407776ede4110f33716644f6f027938f21130a
2011-01-18 10:53:37 -08:00
Makoto Onuki
9fd050e162 Pixelperfect: message compose
- Use the fixed margin in portrait, as opposed to the fixed width we use
  in landscape.
- Add 16 dip bottom margin for both landscape and portrait.

Bug 3335094

Change-Id: I082380048256aeef67673ed1b961af279fe2e702
2011-01-18 10:45:06 -08:00
Makoto Onuki
9c4989d2c0 Use explicit height for attachment progressbar
The default progressbar height has changed and our layout now seems to be
a bit off.

Bug 3138021

Change-Id: I4f0d9323d4804f5bbde90035f90cdcee9c653a92
2011-01-12 11:52:46 -08:00
Andy Stadler
3c7c8c9ef6 Finish incoming/outgoing/exchange layouts
* Standard values for overall layout & padding
* Standard button positioning
* Move all fragment padding to containers so setup/settings
  can be adjusted individually.
* Remove unnecessary banners in settings fragments

Bug: 3188940
Bug: 3188951
Change-Id: I9567988b388a8cf80f9d583be865091478b2404c
2011-01-12 00:40:34 -08:00
Andy Stadler
056d562d09 Final button spacing & colors for account setup
Removes all STOPSHIP notes for account setup.

Bug: 3335093
Bug: 3188940
Change-Id: I68f906f71cf2404fe626caac97ddf0dd789f6a64
2011-01-11 22:53:55 -08:00
Makoto Onuki
f7b8bc1ed7 Show newer/older in landscape as well, below message list
Now the button area is owned by the 3-pane layout, rather than the message view
fragment.

Bug 3327153

Change-Id: I9c262086c5a001cfe6e81b788c27d05d490c9830
2011-01-11 16:02:19 -08:00
Makoto Onuki
b6171541b6 Pixel perfect: newer/older buttons
We haven't gotten all dimensions yet, but this is what I inferred from
the latest redlines.

Also fixed a margin above the message area on message view.
(Keep the margin even if there's no tabs.)

Bug 3138021

Change-Id: Iafff578f499737674ec10206b75566377cf2383b
2011-01-11 12:31:51 -08:00
Makoto Onuki
a826d3fb03 Pixel perfect: Message view
Still waiting for a few missing assets, but it's done other than that.

The divider change is already merged; new layouts all use the framework style.

It's basically all layout changes, except for:
- Now the recepient address line has "Show details", which shows a dialog with
  all to/cc/bcc addresses with the timestamp.
- Now invite response buttons are checkboxes.
  (But the basic behavior doesn't change -- once you check a response,
  the message will be gone, so you can't change the response later.)

Copied message_header_bg from gmail manuall.  It'll look silly without it.

Bug 3138021
Bug 3307021

Change-Id: I6f7eb91d6104c3143a5c58b0c4c6c19929cea477
2011-01-10 15:51:32 -08:00
Todd Kennedy
285fac8554 Replace private divider with framework divider
The framework defines ?android:attr/dividerHorizontal. Instead of defining our
own divider by specifying some arbitrary RGB colour, utilize the framework's
divider.

bug 3335145

Change-Id: I64dd30a5a73b0884f82f6a2b9fbbd88c6782e0db
2011-01-10 13:16:10 -08:00
Andy Stadler
a7b781b5dd Near-final layout tweaks to setup screens
* Dimensions, Colors, Paddings, Text styles, etc.
* Update AccountSetupBasics, AccountSetupAccountType,
    AccountSetupOptions, and AccountSetupNames
* Extracted shared layouts in AccountSetupOptions & AccountSetupNames
* Leave behind STOPSHIP entries for:
  - button positioning (primarily vertical)
  - colors of text & dividers
* Will do incoming, outgoing, exchange in a separate CL (because they
  are shared with settings)

Bug: 3335093
Bug: 3188940
Change-Id: Idf727e3b2b6a0293d6d41bf29f1c0c48d746ab7c
2011-01-10 00:42:26 -08:00
Makoto Onuki
1dde2253cb Merge "PPing message view: use proper text size." into honeycomb 2011-01-07 12:47:44 -08:00
Makoto Onuki
21a0c17986 PPing message view: use proper text size.
Also use the same date/time format as gmail to show the date part properly.

Bug 3138021

Change-Id: I24e45895de5330cd670a674f56eca5ccadcee9b5
2011-01-06 16:40:29 -08:00
Makoto Onuki
7523930d39 Pixel perfect: message compose
Layout & action bar icons.  Now I think it's close enough.

Bug 3138037

Change-Id: I0802f34ac23980e0faf8a0daffc016a012816d81
2011-01-06 15:01:29 -08:00
Todd Kennedy
64ac7a6cc8 Use new holo light icons
Use the new icons where appropriate. This is not a complete change as there are
still some icons missing.

Change-Id: I51d1458749343ddfc6456dc2a9853b8bc2540e26
2011-01-06 13:42:20 -08:00
Makoto Onuki
e9818160e1 action bar: make current mailbox closer to gmail
Still not pp, but the current one looks too ugly.  Let's change it.

Bug 3137891

Change-Id: I2e036d23b2ec99bb63fe300a5c2ade72b192f81a
2011-01-05 17:29:48 -08:00
Makoto Onuki
4aa8d1850d Make reply/forward/etc buttons selectable with keyboard
Reply, reply-all, forward, star, and the quick contact badge are now clickable
with the keyboard.

Bug 3292854

Change-Id: Ieeb9f50c9e63f251cafb23255dd3f923b2501849
2010-12-16 16:45:38 -08:00
Andy Stadler
3dedc8b191 Defragment AccountSetupBasics
* This was an early attempt at fragmentation
* But it turned out that no fragment was needed here - it is
  not shared or reused in any way.
* Precursor to doing final layouts for the activity.
* Tested working:
    Automatic provider lookup
    Manual
    POP/IMAP and EAS flow modes (from accounts & sync)
    Force account creation intent
    Provider note
    Duplicate account detection

Change-Id: I434edd4b152391d36e70440873932db3ec1a1c99
2010-12-09 11:05:34 -08:00
Makoto Onuki
4d02297f4a MessageView: Show progress icon while loading
To avoid flicker.

Bug 3225088

Change-Id: Ic5faea4e6fc810aa751b9f0b9d04537e5dc29970
2010-12-07 14:36:09 -08:00
Makoto Onuki
2ac95b550d Message view: Use system tab style
Bug 3138021

Change-Id: I18ec66966e984a4f2b9e330d0ef14dbca5cce5e3
2010-12-06 16:51:01 -08:00
Andy Stadler
112ed496f8 Update server settings to current look
* For each of incoming, outgoing, exchange fragment, create a "settings
  mode" which slightly alters the layout for use in AccountSettingsXL.
  * Build a settings mode wrapper layout around the basic fragment
  * Add new constructor to set "settings mode" and select layout
  * Add wiring for cancel/next buttons in the fragment
* AccountSettingsXL configures each fragment in its settings mode
* Remove old actionbar "Next" options (no longer needed)

TODO: Pixel perfect adjustments, colors, fonts, etc.

Bug: 3188951
Change-Id: Iba26281b214333db301dd40d6c016b6c5a932c2d
2010-12-02 21:45:04 -08:00
Makoto Onuki
46e60b51e2 Merge "Fix & cleanup on EML viewer (MessageFileView)" 2010-11-23 12:18:28 -08:00
Makoto Onuki
f23474a40d Revive inputType and imeOptions for address and subject fields
Also removed an unnecessary android:text.

Bug 3222325

Change-Id: Iba49ee85569d7707a0927f44f363dbc9c6cc7c8a
2010-11-23 12:17:26 -08:00
Makoto Onuki
0d6eea970d Merge "Change "id" to "android:id"" 2010-11-23 11:44:18 -08:00
Andy Stadler
1f3e117951 Fix rotation problems in setup/settings
* Fix incomplete tracking of mLoaded flag
* Defer validation on automatic reload of fields (on rotation)
  until reconstruction completes and we're ready to do validation.
* (For Incoming only) Split loadSettings into configure and reload phases;
  We need to configure the UI every time we restart, but we don't want
  to reload & overwrite user-entered values on rotation.
* (For Exchange only) Properly show/hide trust certificates options on
  rotation, and show/hide divider too.

Bug: 3170922
Change-Id: If3de30ee2d4d5668b29698af73f545510692777e
2010-11-22 19:02:16 -08:00
Makoto Onuki
7aff75446d Change "id" to "android:id"
Simply changing them broke the layout.  I couldn't really figure out how to
get the same layout, so ended up using LinearLayouts.

Also removed message_compose_divider, which didn't really add any value
to its parent, horizontalDivider.

Bug 3216086

Change-Id: If29b344e4dc63902d1cc7d5bebdacb9a245ce8d1
2010-11-22 17:40:54 -08:00
Makoto Onuki
b715ea1d76 Fix & cleanup on EML viewer (MessageFileView)
- Fix the XL layout: Don't refer to "GONE" views in RelativeLayout.
- Don't always (re-)load message on onResume().
  This will make it lose all state (e.g. webview's zoom level) when coming
  back from other activities.
- Change the default visibility of some views so that it'll look okay
  while loading the message.
- Remove the use of obsolete fragment APIs.
- And some other minor cleanups...

Bug 3221066

Change-Id: I475bc229f4ea9e0e480f528389f5180e1d63fcd6
2010-11-22 17:02:48 -08:00
Makoto Onuki
f108837c1d Show current mailbox name and unread count on action bar.
- Show them when the mailbox list is hidden
- Data flow:
  MailboxListFragment ->(Callback)-> MessageListXL ->
  MessageListXLFragmentManager, which controls the action bar.
  (I'm not too happy with this flow, but we can at least avoid
  issuing yet another query to get these data.)

Also related:
- On the combined view, show the unread count for account rows

Bug 3137891

Change-Id: I37fa1258d946329905bbbc0da905928bcf2f4cb1
2010-11-19 13:55:49 -08:00
Makoto Onuki
6ffdecfbbb Merge "Add XL layout for message view" 2010-11-17 15:21:06 -08:00
Makoto Onuki
8e8e371260 Add XL layout for message view
- Added the xl layout
- Cleaned up the existing one

Bug 3138021

Change-Id: Ic6ab5e38c10ac12ffeeb6b12319d1e192ac2a40c
2010-11-17 15:19:00 -08:00
Marc Blank
937ea4fc87 Initial rewrite of MessageListItem for XL
* Drawing all done by MessageListItem, based on view width
* Completely functional, layout tweaks required

TODO: Consider caching drawing values for performance

Bug: 3137994

Change-Id: Ie3de79357bfe976b2fcebdedb71dea011252b445
2010-11-17 12:23:03 -08:00
Andy Stadler
e6c6587b04 Create XL layouts for incoming, outgoing, exchange
* Create XL fragments (will be shared w/settings)
* Create XL landscape activities
* Create XL portrait activities
* Placeholders left for integration with settings - remove in settings CL
* Quick fixes (non shipping) for phone UX
* Update existing portait next/prev buttons per new wireframes

Bug: 3188940
Change-Id: Ied6e7fd1e968fd6db57607a68dabf7e00ba78ee6
2010-11-16 16:40:34 -08:00
Makoto Onuki
15f46cc715 XL layout for message compose
The layout is not final, but it's closer to the wireframe.
- All dimensions and colors are not final.  I just made them up.
- The "+cc/bcc" and "add attachment" buttons are in the wrong position.

I'll wait for the pixel perfect before addressing them.

Bug 3138037

Change-Id: I72fc7557c28e72df08a3751c3c93acfb35749d68
2010-11-16 11:28:58 -08:00
Andy Stadler
7fd78d8d61 Create XL layouts for AccountSetupOptions
* Landscape and portrait layouts
* Quick fixes to phone UX (not shippable)
* Added some CHAR_LIMIT values

Bug: 3188940
Change-Id: I093d5a6dcde2da96c173b5878900114802aead3e
2010-11-15 18:37:56 -08:00
Andy Stadler
27c70e3322 Preliminary XL version of Account Type screen
* Add new account type layout for XL devices

Bug: 3188940
Change-Id: I12ebe60075971fa14c7c55be65dccc0b7602f566
2010-11-14 21:37:41 -08:00
Marc Blank
bad09c18d9 Correct drag & drop mechanics; implement multiple selection
* This CL brings drag&drop move in line with the current document
  describing its functionality in the Email app

Bug: 3135124

TODO: Assets and proper creation of the drag thumbnail based on
  those assets
TODO: Review long-press behavior re: press on subject vs sender

Change-Id: I6e1ee1a1f055feb041a0338f2f5c775a88620595
2010-11-04 17:13:55 -07:00
Marc Blank
c81bef6720 Drag & Drop "move to folder"
* Drag & Drop "move to folder" preliminary implementation
* Use "drag handle" button to initiate drag
* Use the message list item itself as the drag thumbnail for
  one item; "Move N messages" for multiple (not implemented)
* Disable MailboxList update during drag
* Use ListView itself as drag/drop target

Bug: 3138004
Change-Id: I9243e4f583cf91caa1b9dd04fd64d52e8b28fa30
2010-11-04 08:45:24 -07:00
Makoto Onuki
60c6dc4711 Sparse message list item layout for XL
- Tested on N1 as well
- Also fixes bug 2546662 -- show both invitation & attachment icons

Change-Id: Ic2f42370be32a0beb43f9018cefdce86028e8189
2010-10-07 10:17:58 -07:00