Commit Graph

304 Commits

Author SHA1 Message Date
Ben Komalo
1eb80b23fb New waiting for sync layout.
Bug: 5161231
Change-Id: I7b547982c923067e32154b38f61eea0a3be10553
2011-08-25 12:53:38 -07:00
Ben Komalo
781fa387b0 Update asset for "always show" checkmark
Bug: 5184494
Change-Id: I6bae14002d1bfaf661da95ca2b96a0af03a449cc
2011-08-24 12:42:29 -07:00
Ben Komalo
32bed4bb8e Fix unit tests.
- make attachment download service injectable
- fix assertions for account manager account checks
- update message compose ID's so they're consistent on tablet/phone

Bug: 5198343
Change-Id: I9976f5b9e5590dd61fb0a62937d3f9203fefe236
2011-08-24 10:24:42 -07:00
Mindy Pereira
89dd731a90 Update attachment ui to look like Gmail attachment ui; fix from padding.
Fixes Bug:5184434 Compose view doesn't match pixel perfects
Change-Id: I7217eb4a63beedfd0bc00dffe9e0f29a5af6214c
2011-08-19 15:36:23 -07:00
Mindy Pereira
7b41b374cc Style Email compose to look like gmail compose.
Change-Id: I8e1f0e9c4bbbbcd2463473da190bff88f2748905
2011-08-19 11:42:09 -07:00
Ben Komalo
2ae341bfa1 Fix messagelistitem logic.
We had two separate "height" values in XML that weren't consistent - one
was used for the coordinates and one was used for the actual item i nthe
adapter. This made things off slightly when the values didn't match
(i.e. on tablet wide mode).

Also fixed an issue with paperclip icon not aligning with date on wide
mode

Bug: 5184169
Change-Id: I1d80bb9c685fdd8216fcaef26bf6ad715eb74c4c
2011-08-18 12:09:39 -07:00
Ben Komalo
5ef235193b Merge "Minimal changes to make invite UI less broken" 2011-08-16 16:00:16 -07:00
Mindy Pereira
5e88869393 Merge "We must have unique id's in order for the state to be saved automatically by the widget." 2011-08-15 18:28:05 -07:00
Mindy Pereira
ac9975e745 We must have unique id's in order for the state to be saved automatically by the widget.
Also turned off extract mode for subject/ body as we already
did this in gmail at request of ux.
Fixes b/5161118 TO field drops all entry chips on rotation

Change-Id: Iada93bbf7ee457801340167aa1086b03b87b4268
2011-08-15 18:24:43 -07:00
Ben Komalo
22cc33158d Use proper style for account spinner
- also removes the "Accounts" header as requested by UX
- also tightens up width on tablets a little.

Bug: 5160847
Change-Id: Ie8da1f9d2ec0e53421a435897fc9bb50991a20b6
2011-08-15 12:22:54 -07:00
Ben Komalo
285b6bb303 Minimal changes to make invite UI less broken
- tweaked padding for 7" portrait tablets (required copying tablet
layout to two spots so that the 10" portrait tablets still work
normally)
- removed checkboxes on phones and toyed with fonts

Bug: 5165210
Bug: 5156282
Change-Id: Idd3a1c53dc32fefc14854b08a0a9eaebeb5d2f44
2011-08-15 11:59:51 -07:00
Ben Komalo
4b75ac992d Update visuals for new fonts.
- tighten up action bar spinner
- fix up message list senders/padding

Bug: 5159050
Change-Id: I00033d994a23f7fbb81cd72f53b9d66faa7570f9
2011-08-12 15:01:51 -07:00
Ben Komalo
6f96c779cf Hide presence icon when unknown.
- the "offline" icon isn't much use for a lot of our (non-gmail) users
anyways and it takes precious real estate in the header

Bug: 5147565
Change-Id: Iea3df0c1c3756ff749e50ce46a7437488dc169e7
2011-08-11 18:04:39 -07:00
Ben Komalo
7c98d35990 Merge "Prevent infinite resizes in webview" 2011-08-11 17:58:20 -07:00
Ben Komalo
bd0d2a899e Prevent infinite resizes in webview
Bug: 2349275
Change-Id: Iea502beafcc232105486dfdd5a2d93229313bc45
2011-08-11 16:45:49 -07:00
Mindy Pereira
c165092ea2 Merge "Update styling of chips fields." 2011-08-11 15:58:45 -07:00
Mindy Pereira
ce39730da0 Update styling of chips fields.
Fixes b/5122133 replace recipient background with new multiline background

Change-Id: Icbdb1e885526ccbe1bbbb5e332db8532988a749e
2011-08-11 15:56:31 -07:00
Ben Komalo
90a3f1e08b Ensure message actions aren't available for EML
Bug: 5150912
Change-Id: I189eeed903d1af9b9da42b27acb91dd3e836c357
2011-08-11 14:12:48 -07:00
Ben Komalo
7aa58cf8b2 Move lonely "Next" button to the right
Bug: 5148247
Change-Id: I6cf918be3a6786a29d8dd43b0fd48795623cab73
2011-08-10 14:10:15 -07:00
Ben Komalo
136dedbbd9 Update headers in message view.
- this uses the new gradient/drop shadows
- adds quick contact badge triangle thing
- also puts in contentDescriptions for the reply/all/forward/star
  actions that were lost
- also merges the headers in tablet and phone

Bug: 5144711
Change-Id: Ie2d14c26b7818aa4389731794a15be6c31f4981d
2011-08-10 10:24:24 -07:00
Ben Komalo
2468b54db5 Merge "Fix search styling." 2011-08-09 18:07:00 -07:00
Ben Komalo
06dee204a0 Small fixes to attachments UI
Bug: 5102245
Change-Id: I71ccce885c563454672e18aa62eac4ab3996146e
2011-08-09 15:07:57 -07:00
Ben Komalo
03bc225d08 Show color chips in account spinner.
Bug: 5011742
Change-Id: I6aa3d24b83ee1378bf30fb8466a52c6787d27277
2011-08-09 11:27:47 -07:00
Ben Komalo
ed494cd6bb Fix search styling.
This eliminates the excessive padding on the left and makes the hint
text behave according to the new spec (since it uses the new action view
expanded mode).

A later CL will actually change the item to use the action view
facilities of the framework (so we don't have to manage our own custom
views).

Bug: 5109953
Change-Id: Ia3e4a1e64e65b3b8bb3e708b31636f4186acfd46
2011-08-08 17:16:47 -07:00
Ben Komalo
547cae3c8e Move reply/replyall/forward spinner to actionbar.
Bug: 5126487
Change-Id: I56cd8861d6d616d1c4590f06c6f949cd84e5a42b
2011-08-08 15:17:42 -07:00
Jorge Lugo
cf8a36531f Remove done button from edit quick responses
Removes done button from edit quick resposnses fragment and
centers the "create new" button.

Bug: 5111173
Change-Id: Ia847725e5d3bdc67426f76dd386f2263befe4189
2011-08-08 14:56:47 -07:00
Ben Komalo
5b4a214240 Merge "Fix SSL certificate selection for exchange." 2011-08-07 15:04:57 -07:00
Ben Komalo
994343b14b Fix SSL certificate selection for exchange.
- Since the Email and Exchange processes do not share UID, we need to
ensure the call to the KeyChain to request the certificate happens in
the Exchange process
- Misc UI fixes so it's not so ugly

Bug: 5117682
Change-Id: If80698850902e0178eb0998493b4cf4b89e2a15c
2011-08-05 11:28:52 -07:00
Ben Komalo
330b1273af Fix show pictures to not look broken.
- this still needs an asset for the "checkmark" button when showing
"always show pictures" prompt - using a checkbox on state as a
placeholder but it's probably not the best thing for it

Bug: 5037485
Change-Id: Iaa1d0f865bf0c01fde0b0cb37ea1c395345ed582
2011-08-05 10:02:30 -07:00
Ben Komalo
f6348449fa Minor conversation header visual cleanups
- fix header bg on tablets
- fix font color in header
- make subject text wrap on phones

Bug: 5110992
Change-Id: I8c58271788f11251906d71073e6e03033c74f38f
2011-08-03 15:45:16 -07:00
Ben Komalo
0632f52c3c Fix spinner style.
- use proper theme attribute instead of hardcoded style

Bug: 5115264
Change-Id: Ieb0be8093a0a99655877389353ede4ed8d921262
2011-08-03 10:38:31 -07:00
Ben Komalo
263d0ec707 Fix account spinner width.
- make it take up different size on phones and tablets (also landscape
  phone/portrait phone)
- move unread count outside of the spinner area

Bug: 5108972
Bug: 5111250
Change-Id: I2c16bbb52ce53bbf1c8fe08fd78f1a4b4afd4ccf
2011-08-02 15:04:48 -07:00
Ben Komalo
383279a1c5 Update message list item redlines.
- reduces number of "modes" to just two: normal and wide
- consolidate the normal/narrow modes for phone and tablet (as per spec)
  with the only diff on the tablet being side paddings
- fix issue with "white arrow" visual being shown in phone when tapping
  on a message
- make touch computations be resilient to padding values instead of
  assuming that the check/star icons are right at the left/right

Bug: 5103823

Change-Id: I23f967454f7744d9c59256625e302e54a353994a
2011-08-02 14:05:05 -07:00
Ben Komalo
d9e8dcae2f Update assets
- updated checkboxes (new ones for sw600dp and phone)
  ones for phone)
- updated stars (new ones for sw600dp and phone)
- added existing cc/bcc icon to menu item
- updated reply/replyall/forward actions to dark themed items (renames
involved)
- update message list backgrounds (new ones for hdpi,xhdpi, renamed
  everything so that there is no message_ or conversation_
  suffixes, also added missing states for some of the selectors)

Change-Id: I1b4f49f206b846566870f5b430e3c6386e621a0c
2011-07-28 14:40:02 -07:00
Ben Komalo
391b9d4abd Search delay fixes.
- adds a loading state to search so the user isn't left with a blank
screen for several seconds
- adds a timeout so that a warning message is shown for results that
take over 10 seconds
- use default loading/no message views in ListFragment so we don't have
to manager our own stuff

Bug: 5014107
Bug: 5037618
Change-Id: I8b03fa0967055989156c7777901affc777c4fae7
2011-07-27 11:37:54 -07:00
Ben Komalo
df4dfa570a Settings/Setup style cleanup.
This is not an attempt to cleanup the code that much - minimal amount of
work was done to reduce the copy/pasting that is rampant in this part of
the codebase.

This basically just does visual fixes to:
- not make the buttons illegibly tiny
- not make the buttons overlap
- make the padding consistent on phones

Bug: 5039509
Bug: 5011325
Change-Id: Id31dee84a54a5dce9644b6f37fb41ac2c2ce89b9
2011-07-22 20:26:00 -07:00
Ben Komalo
2903be7f3e Always show from field in compose
This info used to be shown in the top right of the status bar in GB but
that is no longer there. So before this change there was no way to tell
who you were sending as.

Bug: 5069124
Change-Id: I10d687a5fd221e65ecfc71b61cccf306492e27b8
2011-07-22 15:52:38 -07:00
Jorge Lugo
7496b5ba2b Merge "Display message when no quick respones available" 2011-07-21 19:44:31 -07:00
Jorge Lugo
4ca1ca8622 Display message when no quick respones available
When editing quick responses, displays an appropriate
message letting users know that there are no quick responses.
Additionally, the MessageCompose activity will only show "insert quick
responses" when at least one exists.

Bug: 4948180
Change-Id: I1191bd54d6e64f990b6d6830f0837579d7a6918c
2011-07-21 19:06:17 -07:00
Ben Komalo
80b817714f Optimizations to startup.
- don't inflate search views - inflate them on demand
- kill some unneeded containers

Bug: 4996847
Change-Id: I7747e194e7c0939ad6416f351096639b283f4899
2011-07-21 17:38:19 -07:00
Ben Komalo
7688300055 Fix sync window settings for EAS setup on phones
- the container is the one that should be visible/gone - individual
fields should just be visible
- also do drive by javadoc fixes

Bug: 5052310
Change-Id: I45c4b6b7f94b2b62ac94eeff0ab97bf34c9e117a
2011-07-20 11:27:11 -07:00
Ben Komalo
dfff72f731 Misc attachment code cleanups
Change-Id: I612b3ed1280d4d057834d3d3e67c8ac17c2bafb6
2011-07-19 15:16:45 -07:00
Ben Komalo
776997e62e Update message compose to phone spec
- move cc/attachment to overflow menu
- misc layout fixes

Bug: 5011868
Change-Id: If17a36c9e7f13115828a957163af5969b6f8f93e
2011-07-18 17:08:35 -07:00
Jorge Lugo
1086830bae Merge "Improve accessibility for stars and settings" 2011-07-15 15:21:44 -07:00
Ben Komalo
ffe1b29061 Merge "Fix UI issue with expanding details." 2011-07-15 15:15:26 -07:00
Jorge Lugo
8e779e627a Accessibility improvements
TalkBack functions properly with MessageList items, as well as
"reply," "reply-all," and "forward" buttons while viewing messages.
It is now also possible to switch accounts using only a dpad
or trackball. Finally, EditText fields in account setup also work
with TalkBack now.

Checkmarks don't work with Talkback, but this I have confirmed and
reported it as frameworks bug.

Change-Id: I7f72682a517eef4fa122241c675026fe7997ac64
2011-07-15 09:08:13 -07:00
Ben Komalo
08f068c9ce Update message header actions for phones.
- This creates a "more" icon in portrait and shows all three actions
(reply/replyall/forward) in landscape.
- also makes the star visible by default (hiding it in EML view)

Change-Id: Iefff7c0717cfda4dc91218b0d490775294c96103
2011-07-14 17:23:21 -07:00
Jorge Lugo
7667632eb2 Improve accessibility for stars and settings
Adding and removing a star triggers the appropriate accessibility
In incoming/outgoing settings, added EditText contentDescriptions.

Change-Id: Ibab461f1425b3ebf3579ebc1d0b36d1a9a5efdb2
2011-07-14 12:01:02 -07:00
Ben Komalo
17501fc0ca Fix UI issue with expanding details.
- the show/hide details icon no longer jumps
- the expanded details now doesn't take up the entire screen on tablets

Bug: 5009046
Change-Id: If7f3451e28ba09928cc9b8aa156779f076948979
2011-07-12 17:20:13 -07:00
Ben Komalo
9e8da783a8 Fix action bar text styles.
This makes custom styles in landscape,portrait, and tablet mode since
the action bar real estate differs in those modes.

Bug: 5010826
Change-Id: I2bd6bdcf9adc44a4d0084d4b2bfbffb472f03643
2011-07-11 18:29:18 -07:00