Commit Graph

2633 Commits

Author SHA1 Message Date
Marc Blank
9edec6478c am de302226: Always check serverId AND calendarId in queries
Merge commit 'de3022268982d1ef7e81ef563c6b3a87faa9b002' into froyo-plus-aosp

* commit 'de3022268982d1ef7e81ef563c6b3a87faa9b002':
  Always check serverId AND calendarId in queries
2010-04-12 16:49:15 -07:00
Marc Blank
de30222689 Always check serverId AND calendarId in queries
* With multiple accounts, serverId's are not guaranteed to be unique
  (indeed, they rarely are)
* There were two queries in CalendarSyncAdapter that checked only
  serverId and this has caused the referenced bug PLUS others that
  would have turned up later on
* This is a critical fix

Bug: 2589815
Change-Id: I49bc6cb5bb4708f4bf4ca60a891ff78f0b25e989
2010-04-12 16:37:50 -07:00
Marc Blank
61ea18298e am c388bf66: am b5253606: Merge "Sync description with exceptions" into froyo
Merge commit 'c388bf66775e7979a1fd372964ef9ee7908e3b0d' into kraken

* commit 'c388bf66775e7979a1fd372964ef9ee7908e3b0d':
  Sync description with exceptions
2010-04-12 15:57:53 -07:00
Marc Blank
c388bf6677 am b5253606: Merge "Sync description with exceptions" into froyo
Merge commit 'b5253606eeeae86938f04415553aac9f3f22daaa' into froyo-plus-aosp

* commit 'b5253606eeeae86938f04415553aac9f3f22daaa':
  Sync description with exceptions
2010-04-12 15:55:35 -07:00
Marc Blank
b5253606ee Merge "Sync description with exceptions" into froyo 2010-04-12 15:53:50 -07:00
Marc Blank
d1c1b505f4 am 95c071bc: am 1e3f86df: Merge "Increase timeouts for Exchange sync; prevent early upload sync" into froyo
Merge commit '95c071bc6322a0ddd0491099b57ec8224d894f2f' into kraken

* commit '95c071bc6322a0ddd0491099b57ec8224d894f2f':
  Increase timeouts for Exchange sync; prevent early upload sync
2010-04-12 14:50:19 -07:00
Marc Blank
95c071bc63 am 1e3f86df: Merge "Increase timeouts for Exchange sync; prevent early upload sync" into froyo
Merge commit '1e3f86dfd4b3db7bd91893a84584589dc778f52c' into froyo-plus-aosp

* commit '1e3f86dfd4b3db7bd91893a84584589dc778f52c':
  Increase timeouts for Exchange sync; prevent early upload sync
2010-04-12 14:46:06 -07:00
Marc Blank
1e3f86dfd4 Merge "Increase timeouts for Exchange sync; prevent early upload sync" into froyo 2010-04-12 14:42:44 -07:00
Marc Blank
e3df9f95ea Sync description with exceptions
* We weren't sending up the event description with exceptions, so
  changes to description were being lost on upload
* Move the code uploading description so that it happens with
  exceptions as well as top-level events

Bug: 2590020
Change-Id: Ifab556bed68671f3ee8cab02b657adbd8ba9c50c
2010-04-12 14:22:11 -07:00
Marc Blank
2e22263777 Increase timeouts for Exchange sync; prevent early upload sync
* It's reported that 50% of third party users have issues syncing
  Calendar in Exchange
* In testing, it was determined that the server takes > 30 seconds
  to respond to a sync request initially, which is beyond our timeout
  limit
* Also, I found that the system SyncManager was trying to trigger an
  upload sync at the same time (i.e. before the sync session was
  established with the server)
* There are four changes here:
  1) Prevent upload syncs while the sync key is null or "0" ("0"
     is the initial state)
  2) Increase timeout for connection; at worst, this will
     cause a short extra delay in syncs with a bad connection, but this
     will be unnoticable to users
  3) Increase the read timeout for initial sync to twice that of
     regular syncs (the initial sync always seems to take longer)
  3) Reduce the lookback for calendar to two weeks (from one month);
     this is a better default anyway, and it probably reduces the server
     and client load a great deal
* Empirically, this solves the bug for a known completely repeatable
  case.

Bug: 2569162
Change-Id: I36b1c3e1e0b65f50d42e05f1830fed912191651f
2010-04-12 13:59:04 -07:00
Makoto Onuki
9c88c1ff3c am b0690302: am 1fe0aa19: Merge "Set CLEAR_WHEN_TASK_RESET flag when launching Calendar" into froyo
Merge commit 'b0690302bfc486ae76002179de11df0537090c30' into kraken

* commit 'b0690302bfc486ae76002179de11df0537090c30':
  Set CLEAR_WHEN_TASK_RESET flag when launching Calendar
2010-04-12 13:31:43 -07:00
Makoto Onuki
b0690302bf am 1fe0aa19: Merge "Set CLEAR_WHEN_TASK_RESET flag when launching Calendar" into froyo
Merge commit '1fe0aa19bf9a64dff0fb0965d29f930303208f73' into froyo-plus-aosp

* commit '1fe0aa19bf9a64dff0fb0965d29f930303208f73':
  Set CLEAR_WHEN_TASK_RESET flag when launching Calendar
2010-04-12 13:30:06 -07:00
Makoto Onuki
1fe0aa19bf Merge "Set CLEAR_WHEN_TASK_RESET flag when launching Calendar" into froyo 2010-04-12 13:27:15 -07:00
Makoto Onuki
f793cd93b9 Set CLEAR_WHEN_TASK_RESET flag when launching Calendar
and Contacts, so that when you relaunch Email from Home, you always see
the Email app, not Calendar/Contacts.

Note as stated in the corresponding bug, this CL itself won't fix the issue,
because CLEAR_WHEN_TASK_RESET will be lost when Contacts/Calendar apps handle
the intent.
There's a feature request against the framework (bug 2586404) which should fix
this losing flag problem.

Bug 2584792

Change-Id: I34ac3707b99926fc07529ea2229f2a6b3c4f93e4
2010-04-12 13:09:56 -07:00
Andrew Stadler
ead786d9b5 am ef01261a: am 9cc6f46b: Merge "Try TOP even on POP servers that fail to report CAPA" into froyo
Merge commit 'ef01261a8909ea3fe3e40b06cc537e0032d47898' into kraken

* commit 'ef01261a8909ea3fe3e40b06cc537e0032d47898':
  Try TOP even on POP servers that fail to report CAPA
2010-04-12 11:33:04 -07:00
Andrew Stadler
ef01261a89 am 9cc6f46b: Merge "Try TOP even on POP servers that fail to report CAPA" into froyo
Merge commit '9cc6f46b05cdb1678b0ef73daf268c5728e96208' into froyo-plus-aosp

* commit '9cc6f46b05cdb1678b0ef73daf268c5728e96208':
  Try TOP even on POP servers that fail to report CAPA
2010-04-12 11:31:04 -07:00
Andrew Stadler
9cc6f46b05 Merge "Try TOP even on POP servers that fail to report CAPA" into froyo 2010-04-12 11:27:25 -07:00
Andrew Stadler
645fc28301 Try TOP even on POP servers that fail to report CAPA
* Ignore the results of CAPA and always try TOP
* If TOP returns -ERR simply fall back to (bad old slow) RETR
* Unit tests for positive & failure cases

Bug: 2588432
Change-Id: Ife4b551217de1025e14efc46074f16ef4ae99c6f
2010-04-12 10:56:55 -07:00
Marc Blank
8f76feabe2 am ab99976d: am c3aa3182: Send email to organizer if attendee deletes event/exception
Merge commit 'ab99976d18de5b2ac57d26808296ba5d966cea8d' into kraken

* commit 'ab99976d18de5b2ac57d26808296ba5d966cea8d':
  Send email to organizer if attendee deletes event/exception
2010-04-12 10:29:34 -07:00
Marc Blank
ab99976d18 am c3aa3182: Send email to organizer if attendee deletes event/exception
Merge commit 'c3aa31820003bd62a863dc28d699cebdbcead228' into froyo-plus-aosp

* commit 'c3aa31820003bd62a863dc28d699cebdbcead228':
  Send email to organizer if attendee deletes event/exception
2010-04-12 10:26:22 -07:00
Marc Blank
c3aa318200 Send email to organizer if attendee deletes event/exception
* There are two cases, event and exception and both are fixed in this CL

Bug: 2587775
Change-Id: Id325c4877a77074ca6edd4d7fbeb54971d4cf984
2010-04-12 10:12:46 -07:00
Marc Blank
f362d0357c am dc0f9ee7: am 536a3655: Merge "Always add changed exceptions to the upload list" into froyo
Merge commit 'dc0f9ee7ed36947414b37bb8d303f6ca0b768a8a' into kraken

* commit 'dc0f9ee7ed36947414b37bb8d303f6ca0b768a8a':
  Always add changed exceptions to the upload list
2010-04-12 10:04:19 -07:00
Marc Blank
dc0f9ee7ed am 536a3655: Merge "Always add changed exceptions to the upload list" into froyo
Merge commit '536a36555b2a03eb852e2e54afedca7281f67f91' into froyo-plus-aosp

* commit '536a36555b2a03eb852e2e54afedca7281f67f91':
  Always add changed exceptions to the upload list
2010-04-12 10:00:48 -07:00
Marc Blank
536a36555b Merge "Always add changed exceptions to the upload list" into froyo 2010-04-12 09:57:57 -07:00
Marc Blank
c5c5bf7da7 Always add changed exceptions to the upload list
* We were adding deleted exceptions to the "deleted" list; this is bad,
  because the exception then gets deleted from the database after the
  sync.  The symptom is that the deleted exception reappears on the
  calendar.

Bug: 2587837
Change-Id: If497f82ba0b2b817d1cef6165ded23d19876528f
2010-04-11 15:33:39 -07:00
Marc Blank
4b07f049b3 am 605433f7: am 3b19278a: Only allow the account mailbox to attempt provisioning
Merge commit '605433f78dfacc6c634c6313832c9e1f475bcd99' into kraken

* commit '605433f78dfacc6c634c6313832c9e1f475bcd99':
  Only allow the account mailbox to attempt provisioning
2010-04-11 11:58:53 -07:00
Marc Blank
605433f78d am 3b19278a: Only allow the account mailbox to attempt provisioning
Merge commit '3b19278a24ec6f1062d3c5e38580fe9fb20326cf' into froyo-plus-aosp

* commit '3b19278a24ec6f1062d3c5e38580fe9fb20326cf':
  Only allow the account mailbox to attempt provisioning
2010-04-11 11:55:37 -07:00
Marc Blank
65ff1aeb60 am 6155bc2b: am 6a4eae5f: Fix upload of multi-day all day events
Merge commit '6155bc2b10316b5257692b2e4c540c24f5f49836' into kraken

* commit '6155bc2b10316b5257692b2e4c540c24f5f49836':
  Fix upload of multi-day all day events
2010-04-11 09:49:06 -07:00
Marc Blank
3b19278a24 Only allow the account mailbox to attempt provisioning
* We were allowing all sync services to attempt provisioning, but this
  could potentially lead to a race condition in which two different
  policy keys are created on the server (this is speculative)
* Change to allow only the account mailbox to attempt provisioning
* Log policy keys when verbose exchange logging is enabled
* We'll see if this solves the referenced bug

Bug: 2569162
Change-Id: I36c60098a4866882a8f9f4c288da54ea378d9aee
2010-04-11 09:45:49 -07:00
Marc Blank
6155bc2b10 am 6a4eae5f: Fix upload of multi-day all day events
Merge commit '6a4eae5f4104599cddfea67705cc4d594ee7d47f' into froyo-plus-aosp

* commit '6a4eae5f4104599cddfea67705cc4d594ee7d47f':
  Fix upload of multi-day all day events
2010-04-11 09:45:01 -07:00
Marc Blank
6a4eae5f41 Fix upload of multi-day all day events
* We were assuming a single day for all-day events
* Use the actual end date
* Make sure we send date/time back to server in local TZ
* Also fixes #2500863

Bug: 2578776
Change-Id: I58767a574248935b9840ce93e634a24e54abe62f
2010-04-10 18:03:39 -07:00
Andrew Stadler
459199c93d am ddc5dd3f: am 80bd83fd: Upsync appropriate organizer name/email
Merge commit 'ddc5dd3fe0cde3e03a053e1d2b6a06822a4b30b7' into kraken

* commit 'ddc5dd3fe0cde3e03a053e1d2b6a06822a4b30b7':
  Upsync appropriate organizer name/email
2010-04-10 17:42:59 -07:00
Andrew Stadler
ddc5dd3fe0 am 80bd83fd: Upsync appropriate organizer name/email
Merge commit '80bd83fd8550ed1b58c26241aab6830d66289b5e' into froyo-plus-aosp

* commit '80bd83fd8550ed1b58c26241aab6830d66289b5e':
  Upsync appropriate organizer name/email
2010-04-10 17:40:31 -07:00
Andrew Stadler
80bd83fd85 Upsync appropriate organizer name/email
* We need to send name & email for Exchange 2007
* For Exchange 2003, only name & email if the event is new

Bug: 2586661
Change-Id: Ia35c2c7a645a3d20b7031e9a43b8b5044a40f005
2010-04-10 17:35:34 -07:00
Andrew Stadler
e588bec8c9 am 13cc0023: am 06699c0d: Send meeting status with all upsynced changes
Merge commit '13cc00239e958647312b26deae7e62e3c4b27fdf' into kraken

* commit '13cc00239e958647312b26deae7e62e3c4b27fdf':
  Send meeting status with all upsynced changes
2010-04-10 17:31:18 -07:00
Andrew Stadler
13cc00239e am 06699c0d: Send meeting status with all upsynced changes
Merge commit '06699c0d911ad71d5964c68e182745f5c4144569' into froyo-plus-aosp

* commit '06699c0d911ad71d5964c68e182745f5c4144569':
  Send meeting status with all upsynced changes
2010-04-10 17:28:53 -07:00
Andy Stadler
51c864d56c am 6445efb6: am 7d32ec27: Merge "Check for active device admin before each ping loop" into froyo
Merge commit '6445efb6497348f4fc0b2c7ca5c78634626dfa3f' into kraken

* commit '6445efb6497348f4fc0b2c7ca5c78634626dfa3f':
  Check for active device admin before each ping loop
2010-04-10 17:26:43 -07:00
Andy Stadler
4929b7fdaa am 66473998: am 69757c66: Merge "Synchronize getAccountById on sAccountList" into froyo
Merge commit '66473998027f5d93c652653f58dc4ea73e462a55' into kraken

* commit '66473998027f5d93c652653f58dc4ea73e462a55':
  Synchronize getAccountById on sAccountList
2010-04-10 17:26:41 -07:00
Marc Blank
114dfb269d am 7ac1a975: am 0cd9cbf0: Add organizer to Attendees before handling exceptions
Merge commit '7ac1a975c470f1a41e589e2a223467bf564fafc9' into kraken

* commit '7ac1a975c470f1a41e589e2a223467bf564fafc9':
  Add organizer to Attendees before handling exceptions
2010-04-10 17:26:38 -07:00
Andrew Stadler
06699c0d91 Send meeting status with all upsynced changes
* Meeting status differentiates between appointments and meetings,
  which is important in Outlook and OWA
* Fix older, completely incorrect code for upsyncing categories

Bug: 2586071
Change-Id: I277252ef2c31e5b8ec7ceda69c229f5fd100ecdb
2010-04-10 17:24:23 -07:00
Andy Stadler
6445efb649 am 7d32ec27: Merge "Check for active device admin before each ping loop" into froyo
Merge commit '7d32ec27ec7f17238d0f5c373acc502053e59647' into froyo-plus-aosp

* commit '7d32ec27ec7f17238d0f5c373acc502053e59647':
  Check for active device admin before each ping loop
2010-04-10 17:23:23 -07:00
Andy Stadler
6647399802 am 69757c66: Merge "Synchronize getAccountById on sAccountList" into froyo
Merge commit '69757c6670b8b6fbeea6da1d9690002e0f7b9293' into froyo-plus-aosp

* commit '69757c6670b8b6fbeea6da1d9690002e0f7b9293':
  Synchronize getAccountById on sAccountList
2010-04-10 17:21:57 -07:00
Marc Blank
7ac1a975c4 am 0cd9cbf0: Add organizer to Attendees before handling exceptions
Merge commit '0cd9cbf08817b18b4221efa15388f5a144ebfab4' into froyo-plus-aosp

* commit '0cd9cbf08817b18b4221efa15388f5a144ebfab4':
  Add organizer to Attendees before handling exceptions
2010-04-10 17:21:54 -07:00
Andy Stadler
7d32ec27ec Merge "Check for active device admin before each ping loop" into froyo 2010-04-10 17:18:35 -07:00
Andy Stadler
69757c6670 Merge "Synchronize getAccountById on sAccountList" into froyo 2010-04-10 17:17:56 -07:00
Marc Blank
2769c06b3d Check for active device admin before each ping loop
* Accounts that require security need to check that the Email app
  is still an active device admin from time to time
* Add a check for this before each run of the ping loop

Bug: 2583282
Change-Id: I1491821b7d0c1a341b1fe7ef1002c8b21aed12c2
2010-04-10 16:59:15 -07:00
Marc Blank
ff958286f1 am c89e3462: am 232b2dd9: Merge "Handle exception deletion properly" into froyo
Merge commit 'c89e34624492e43fb8d403e0321df648248d9fcc' into kraken

* commit 'c89e34624492e43fb8d403e0321df648248d9fcc':
  Handle exception deletion properly
2010-04-10 11:41:54 -07:00
Makoto Onuki
bd9444b0c2 am aab0d339: am 17a18d64: Merge "Fix NPE caused by I34451000" into froyo
Merge commit 'aab0d339da9605339695c85da2bc81cdc2d6bb08' into kraken

* commit 'aab0d339da9605339695c85da2bc81cdc2d6bb08':
  Fix NPE caused by I34451000
2010-04-10 11:41:52 -07:00
Marc Blank
c89e346244 am 232b2dd9: Merge "Handle exception deletion properly" into froyo
Merge commit '232b2dd9dcce647e49e770ec9b4e6a3a564008d2' into froyo-plus-aosp

* commit '232b2dd9dcce647e49e770ec9b4e6a3a564008d2':
  Handle exception deletion properly
2010-04-10 11:38:07 -07:00
Makoto Onuki
aab0d339da am 17a18d64: Merge "Fix NPE caused by I34451000" into froyo
Merge commit '17a18d644af54b98087f3ec7a9b1e6d55e604e67' into froyo-plus-aosp

* commit '17a18d644af54b98087f3ec7a9b1e6d55e604e67':
  Fix NPE caused by I34451000
2010-04-10 11:38:05 -07:00