Commit Graph

2586 Commits

Author SHA1 Message Date
Ben Komalo
28e496daef Respect system font size in message list.
- This makes dimensions according to scaled font sizes, and also resets
the activity properly (invalidating drawing caches) when that font size
happens.

Bug: 5287961
Change-Id: I04cf117b027befd6a065edeadf95187f62fffc8a
2011-10-13 15:54:14 -07:00
Ben Komalo
7d1324a6df Merge "Keeps track of "last account used"" 2011-10-13 10:21:06 -07:00
Ben Komalo
513486cfb5 Fix per account starred mailboxes.
We always switched to combined view when we tapped "Starred" in a
mailbox list. This was confusing since tapping to show the mailbox list
will take you to the mailbox list for the combined view, even if there's
only one account on the device! Other confusing things happened like
showing coloured account chips, even if there's only one account.

This fixes it so that we pass the account ID when building the
selection. Lots of wiring to make it happen, but very little change
overall.

Bug: 5388326
Change-Id: I1fe52f211cceca0c1b26581e200f3c7adcd0734a
2011-10-12 19:44:39 -07:00
Ben Komalo
47bf70cf7b Keeps track of "last account used"
This only applies for the main EmailActivity. The compose window still
uses the user-visible setting for "Default account" as the default
account when handling intents like "mailto:" links.

In the future, we should probably just remove that setting, now that we
remember the last account in the reading-email case.

Bug: 4460450
Change-Id: I4b3e7c9e13b7e89320891346383780cd670492ae
2011-10-12 17:16:19 -07:00
Marc Blank
160bbc8288 Merge "Don't show "mailbox not found" toast on "back"" 2011-10-11 12:59:22 -07:00
Marc Blank
d9cdd88702 Don't show "mailbox not found" toast on "back"
* We'll only show this on a first load of the
  MessageListFragment

Bug: 5396997
Change-Id: I9a93bfd6e2c31d1ed8f75f1ec486da060712dffd
2011-10-11 12:04:11 -07:00
Ben Komalo
c35c4b14c9 Fix persistent "empty name" error.
We were never clearing the error state when typing in a field that
needed to be non-empty.

Bug: 5422268
Change-Id: Iabe8c6f6c348b4210695c3eeff98e79e60f83d08
2011-10-07 18:03:16 -07:00
Ben Komalo
6e8e49d5f7 Merge "Ensure proper mailbox is highlighted." 2011-10-07 11:12:26 -07:00
Ben Komalo
ce4ebc52a6 Ensure proper mailbox is highlighted.
Bug: 5424565
Change-Id: I1436568aa1c7d7d2becce27ee068d88deb217496
2011-10-06 17:31:59 -07:00
Ben Komalo
f9b566c109 Fix message list pressed state color
Also do some cleanup - we were creating a background task for opening a
message, when in the common case we don't need to hit disk for any
reason. This was also an issue since the async opening of the message
caused the list item to go into an "active" state, changing its colour
(this problem still exists in starred view now, though)

Bug: 5222509
Change-Id: Ie94109df42406fd6eec1e1255bb0827626ba0628
2011-10-06 16:35:04 -07:00
Marc Blank
cd75eef4de Merge "Handle possible NPE in MessageListItem" 2011-10-04 13:41:08 -07:00
Marc Blank
bcf5d5825f Handle possible NPE in MessageListItem
* I don't know how the timestamp can be zero for a message, but we
  shouldn't crash, and it's late for adding new localizable text

Bug: 5410814
Change-Id: Idf1c8b0d4c0b7e0e2b2466643ea52e5244d1bb5f
2011-10-04 13:36:47 -07:00
Ben Komalo
1c4b62a0ed Merge "Always update adapter's cursor." 2011-10-03 17:15:11 -07:00
Marc Blank
35d92429af Merge "Enforce "auto-sync app data" setting for POP3/IMAP" 2011-10-03 14:21:04 -07:00
Ben Komalo
5aedd25869 Always update adapter's cursor.
In cases where the account gets removed, we accidentally hold a stale
cursor. This leaves a ticking bomb, which generally explodes when the
list tries to save state.

Bug: 5367199
Change-Id: Ibcd0c281c9668778f7d1d2abba472ffff8b22879
2011-10-03 13:53:24 -07:00
Marc Blank
faf9ecc992 Enforce "auto-sync app data" setting for POP3/IMAP
* We were using the deprecated ConnectivityManager for this; we should now be
  using the setting in ContentResolver
* Also, remove broadcast receiver code that is no longer relevant

Bug: 5405352
Change-Id: I985a95071aea92d235a2708925f775b817ba2328
2011-10-03 13:05:24 -07:00
Ben Komalo
d75ac0d357 Don't touch views in the background.
Bug: 5404366
Change-Id: I8aca89c032db41aaf95d3a94dc8047fbacbd47a9
2011-10-03 12:58:58 -07:00
Ben Komalo
b19a76c452 Don't show move to dialog until data is ready.
The data is usually really quick, but it's enough to cause it to flicker
if we set it with an empty adapter first.

Bug: 5087874
Change-Id: I2fc37751edcaa8ffeee144b85417b48e94b4ba4f
2011-09-29 13:50:32 -07:00
Ben Komalo
0dc7886f47 Merge "Make draft loading happen on serial executor" 2011-09-29 11:57:12 -07:00
Ben Komalo
fb83cef9ad Hide attachment progress bar on complete.
Also fix up styles to (mostly) match mocks and be consistent
with Gmail

Bug: 5205957
Change-Id: Iea7e9706464a8050255a7be78fca471cb7f9f6cf
2011-09-28 17:41:30 -07:00
Ben Komalo
8f56f41a07 Merge "Prefill account names." 2011-09-28 14:52:08 -07:00
Ben Komalo
b3a72b51dd Prefill account names.
- default to e-mail address for account description
- try to use the phone's profile info for the user name

Bug: 5369190
Change-Id: I01cb567f31999bce79426eee58de8fbbc09e344d
2011-09-28 14:43:08 -07:00
Marc Blank
c82c1caf01 Include external storage in remote wipe
* Apparently, this is required via Microsoft specifications, though
  there had been an earlier decision not to do this

Bug: 5384246
Change-Id: I05b6c2d21d3b295ad696f26a7a13cba6f1974e83
2011-09-28 09:41:44 -07:00
Ben Komalo
5fc0aa79f6 Make draft loading happen on serial executor
This fixes an issue where it loads drafts too quickly on orientation
change (and a previous save has not completed). The save was explicitly
put on the serial executor for this reason, but the load task was
missed. whoops.

Bug: 5361711
Change-Id: Ic764e15deb7cd8b88fa4f87e7cbdf435d7d79c80
2011-09-26 18:22:19 -07:00
Ben Komalo
112f39692c Merge "Fix "always show pictures"" 2011-09-26 15:59:03 -07:00
Ben Komalo
3432bdb757 Fix focus behavior in setup screens.
- properly put actionNext on most fields
- make sure actionDone doesn't do funky things with focus so that a
non-editable field gets focus. we may want to consider not making this
focusable in the future.

Bug: 5367827
Change-Id: I4e7bb13801d96a4f1e6fd02a2d43713200738b18
2011-09-26 15:49:01 -07:00
Ben Komalo
5bcb32a0d3 Fix "always show pictures"
- stopped using the confusing checkmark
- consolidated tablet/phone view - removed some needless views

Bug: 5224399
Change-Id: I944459881f04bf1103db98bb15a597bdfcc07cd9
2011-09-26 15:47:09 -07:00
Mindy Pereira
92922ea4a4 Provide an empty constructor for orientation changes.
Fixes bug:5369868 Email crash while changing orientation when there is a security exception pop-up

Change-Id: I8fc530c994d5015cb76039d2f309d98ed2c3761f
2011-09-26 11:16:39 -07:00
Marc Blank
b9b6ce1d36 Don't show -1 as a search result count
* We'll show zero in this case

Bug: 5361745
Change-Id: Id969fa9895520382de11a47a302792d3431e451c
2011-09-23 11:19:47 -07:00
Ben Komalo
0c56eedae5 Merge "Try to avoid cases when we flicker "No messages"" 2011-09-21 17:19:16 -07:00
Ben Komalo
075817ff68 Try to avoid cases when we flicker "No messages"
Bug: 5205196
Change-Id: Ide4b9ebc02c294ee3c031cc0b69ecba32877e2eb
2011-09-21 15:03:41 -07:00
Ben Komalo
8506afff28 Avoid building/rebuilding the action tabs.
Doing this on a tab callback confuses the action bar rendering.

Bug: 5288508
Change-Id: Ifbba2c2a30f5def04ec36ea2395c0d6da2bdf00d
2011-09-21 13:06:40 -07:00
Marc Blank
2fa301710f Fix oopsie on startup with no accounts
Bug: 5208939
Change-Id: Ia001dcacdb1dd014bdc480432d1eb7cbf7f56454
2011-09-20 17:36:17 -07:00
Ben Komalo
d6bd622299 Merge "Prevent flicker in opening Email." 2011-09-20 13:50:15 -07:00
Ben Komalo
002a1802ca Prevent flicker in opening Email.
Welcome had some assumptions that some things had to be done
asynchronously, such as checking inbox status.
This can now be done on the UI thread and so transition into Email can
be done immediately in onCreate, except if there's reconciliating to
be done

Bug: 4599569
Change-Id: Iaaac21e73c985c60e1b7974fb0429948b35968e4
2011-09-19 16:50:07 -07:00
Ben Komalo
51dc9593bb UI improvements to cert selection
Bug: 5286334
Change-Id: I2c6184740364ae60f9df81119c11479e142f63c3
2011-09-16 11:14:10 -07:00
Ben Komalo
3415be2078 Merge "Minor cleanups to message list item rendering." 2011-09-15 17:56:19 -07:00
Ben Komalo
ba0008b669 Minor cleanups to message list item rendering.
- cached font colors
- cached date layouts
- remove unneeded text size sets
- change layout flow to be using standard layout mechanisms

Bug: 5186135
Change-Id: I9c6a659ef50b9e37a51e2463fe2bdf01974291b7
2011-09-15 15:53:01 -07:00
Marc Blank
a49da87191 Handle internal push states when showing sync interval
* We turn them into "push", which is the external representation
  of those states (ping and push/hold)

Bug: 5327559
Change-Id: I843f37e4619f1c33cdafbf8a3a6a39abb8e8834c
2011-09-15 14:23:24 -07:00
Ben Komalo
7683a43117 Prevent NPE in check settings fragment.
Bug: 5324512
Change-Id: I9366eb33c5acfe079c023ee4bc8c2026cde46ae9
2011-09-15 10:56:34 -07:00
Marc Blank
5602ba92a0 Merge "Allow multiple wildcards in providers.xml; add hotmail domains" 2011-09-14 17:06:22 -07:00
Marc Blank
1b65e834c3 Allow multiple wildcards in providers.xml; add hotmail domains
* Change handling of the providers.xml file to allow asterisk
  as a placeholder for an individual domain name part
  (the previous behavior was a very greedy wildcard)
* Add hotmail aliases using the new scheme
* Update unit tests

Bug: 5318329
Change-Id: I73a0dfcb956830b18c5460a1b3ddfc58459d08c9
2011-09-14 16:59:02 -07:00
Michael Chan
bfbf0dd853 Add setting for ReplyAll
Also show/hide the right icon and item in overflow menu depending on setting

Bug: 5298445
Change-Id: I950025cab0aeb57d18769b137eeca418d581c5f9
2011-09-14 16:00:56 -07:00
Ben Komalo
2c57e7036d Fix upgrade code.
In HC MR2 we introduced a column for a parentKey, but AFAICT, did not
use it. It was populated with a null value. The first upgrade code in
ICS assumed it was '0' which failed to upgrade it properly.

This prevents IMAP accounts from being broken when upgrading from GB ->
ICS.

Bug: 5252620
Change-Id: I000253b7c02ac1706710bdb21a820293f09cbea5
2011-09-13 17:18:34 -07:00
Ben Komalo
715ee4ec4c Wire a custom error code for cert errors
This addesses UX's #1 concern about the UX flow for servers that require
certs - users don't know what to do after an error, so they want to kick
them into the certificate selection flow.

Bug: 5280071
Change-Id: I566707b9e680b3ef0b4c0cc8a07a8ad2c825ecaa
2011-09-13 14:08:44 -07:00
Ben Komalo
afdec1caf1 Tweak message header actions.
Once again, I missed an asset in the drop, since there is actually a
sepcialized one for the message view.

Also, use styles to fill out the entire height to the header to make the
touch targets bigger, as consistent with Gmail.

Bug: 5290357
Change-Id: I6754b3ef986dbf57c7c68bc595cf54cc9d76123a
2011-09-12 12:39:30 -07:00
Ben Komalo
891da84a25 Misc visual fixes to Email
- dropped in bigger assets for mailbox triangle
- dropped in bigger assets for checkbox for xhdpi
- dropped in proper star asset for message list
- fixed some padding issues for message list item
- remove the color label from "Combined view" in the account drop down

Bug: 5248125
Change-Id: Ic15d98013f2afb42bf55c327654009ef8baa1b78
2011-09-01 16:51:02 -07:00
Ben Komalo
cbaaa85aba Merge "increase MessageListItem touchslop" 2011-09-01 11:07:08 -07:00
Ben Komalo
2076fa7a3b increase MessageListItem touchslop
Bug: 5237832
Change-Id: Ic651cb23b25041195a226a301b9111c5e8d831ec
2011-08-31 14:06:41 -07:00
Ben Komalo
c3249d8f34 Ensure we can pan around in two directions.
This introduces a ScrollView that doesn't "lock" scrolling in one
direction, which makes it really difficult to view messages on a phone.

Bug: 5039459
Change-Id: I75e6824952c843140844873bec77af55b194f776
2011-08-31 14:03:29 -07:00