Commit Graph

6050 Commits

Author SHA1 Message Date
Ben Komalo
2be03be9b3 Merge "Remove temp code that was causing an NPE" 2011-07-17 16:41:18 -07:00
Ben Komalo
64a6a1f488 Merge "Show proper quick contact mode." 2011-07-17 16:40:37 -07:00
Ben Komalo
6b4a20730f Show proper quick contact mode.
- doesn't repeat the name
- shows status and right icons instead

Bug: 5039507
Change-Id: Id86d84a8ed54032f283454c83212ae962e8fc179
2011-07-17 16:24:18 -07:00
Ben Komalo
0932da35f5 Filter out inbox from recent mailboxes
Bug: 5039553
Change-Id: I9b58e9331028250f9bc3027429d2a6ec418186d6
2011-07-17 16:21:01 -07:00
Ben Komalo
afbba1bcbb Fix NPE in MailboxListFragment
Bug: 5037646
Change-Id: I74420d68398446f602ebe858760d9aaf5f88c107
2011-07-17 16:02:02 -07:00
Marc Blank
3793ec2463 Merge "Handle message sets in a single EmailAsyncTask" 2011-07-17 15:54:34 -07:00
Marc Blank
e2d28a0607 Clear "security needed" notification when releasing holds
* This fixes the issues with erroneous notifications remaining
  active

Bug: 5039388
Change-Id: Ib1cd506e732e34f6368036a131d79270b22d4a4b
2011-07-17 15:46:03 -07:00
Ben Komalo
14ea7d7bbc Merge "Fix possible NPE for messages with no subjects" 2011-07-17 15:03:35 -07:00
Marc Blank
f29221efc9 Remove unnecessary EmailAsyncTask
Change-Id: Ifb13f2f57016191f7ef409aa656bf9cb840f42c9
2011-07-17 12:23:49 -07:00
Marc Blank
b81a31b29b Handle message sets in a single EmailAsyncTask
* This prevents the possibility of RejectedExecutionException when
  selecting large numbers of items

Change-Id: I8f9ba287d69021fdb99b4a8a30cc79755f669b97
2011-07-16 16:11:00 -07:00
Ben Komalo
7f876c0375 Fix possible NPE for messages with no subjects
Bug: 5038097
Change-Id: I0952158017c0d512998f423ecd38722a5b6b8afc
2011-07-15 19:13:22 -07:00
Marc Blank
eb642812bf Merge "Clear account incomplete flag properly; handle unusual flow" 2011-07-15 19:07:17 -07:00
Ben Komalo
2845d72af0 Remove temp code that was causing an NPE
- since listContext can be null, this code was not safe.
we also filter out the search mailbox too, so it's no longer needed.
- don't ask to highlight a mailbox if doing a search
- remove a call in MailboxListFragment that was unconditionally telling
callbacks that something was selected when we started loading - this was
technically lying and if the item isn't in the list that was selected,
nothing should be called (as in the case of search). This was just an
optimization anyways and that callback is invoked later when the mailbox
list load completes.

Bug: 5037629
Change-Id: Id31c6795af9e64fa8682b67de9ab90540ee660df
2011-07-15 18:42:14 -07:00
Ben Komalo
1bc763964e Merge "Don't save empty drafts." 2011-07-15 18:14:58 -07:00
Eric Fischer
9c3741640b Merge "Import revised translations." 2011-07-15 17:03:01 -07:00
Eric Fischer
1c810c3f09 Import revised translations.
Change-Id: I2b1a26c9ba36fadd7d4351350dd5322f66c30f6c
2011-07-15 16:48:48 -07:00
Ben Komalo
0796b8aa61 Don't save empty drafts.
Note: all unicode sending unit tests are broken due to chip issues. I've
filed a separate bug on that.

Bug: 5012204
Change-Id: I17392f65e5bd8349780b79d9cbe10492d8e7a7d9
2011-07-15 16:47:36 -07:00
Marc Blank
8df9af0df3 Clear account incomplete flag properly; handle unusual flow
* We waited to clear the incomplete flag until security was agreed
  to, but this can lead to accounts left incomplete; we now clear
  the flag as soon as the AccountManager account is created (by
  convention, this is when the EmailProvider account is complete)
* Also, allow onDone() to be called more than once with a saved
  account, leaving cleanly, rather than throwing a runtime
  exception

Bug: 5016792
Change-Id: Ib5fc44ac045a1dd9bd5d63f922c037ed637d5341
2011-07-15 16:23:11 -07:00
Jorge Lugo
1086830bae Merge "Improve accessibility for stars and settings" 2011-07-15 15:21:44 -07:00
Jorge Lugo
fad7378031 Merge "Don't save empty quick responses; show keyboard on phone" 2011-07-15 15:20:48 -07:00
Ben Komalo
b87e021b02 Merge "Toggle selection on list item on long press" 2011-07-15 15:16:10 -07:00
Ben Komalo
ffe1b29061 Merge "Fix UI issue with expanding details." 2011-07-15 15:15:26 -07:00
Ben Komalo
cbfbe1db2d Toggle selection on list item on long press
Bug: 5020642
Change-Id: I31498122a4fe41cc81e5dbad5550a5e6620924c4
2011-07-15 14:49:26 -07:00
Jorge Lugo
8e779e627a Accessibility improvements
TalkBack functions properly with MessageList items, as well as
"reply," "reply-all," and "forward" buttons while viewing messages.
It is now also possible to switch accounts using only a dpad
or trackball. Finally, EditText fields in account setup also work
with TalkBack now.

Checkmarks don't work with Talkback, but this I have confirmed and
reported it as frameworks bug.

Change-Id: I7f72682a517eef4fa122241c675026fe7997ac64
2011-07-15 09:08:13 -07:00
Ben Komalo
5e52339306 Merge "Update message header actions for phones." 2011-07-14 17:51:00 -07:00
Ben Komalo
91f1d451a6 Merge "Put "show all folders" in action bar" 2011-07-14 17:49:46 -07:00
Ben Komalo
1917bcbc17 Put "show all folders" in action bar
Change-Id: I4af74342b3b1eae3a94ebf6616280ebf47d14e5f
2011-07-14 17:44:00 -07:00
Ben Komalo
08f068c9ce Update message header actions for phones.
- This creates a "more" icon in portrait and shows all three actions
(reply/replyall/forward) in landscape.
- also makes the star visible by default (hiding it in EML view)

Change-Id: Iefff7c0717cfda4dc91218b0d490775294c96103
2011-07-14 17:23:21 -07:00
Marc Blank
68ce7f3d60 Merge "Send proper parameter to startSync (via EmailService)" 2011-07-14 16:14:19 -07:00
Jorge Lugo
7920f5809c Don't save empty quick responses; show keyboard on phone
While creating or editing a quick response, disables the save
button when the edit text is empty. Also, now shows the keyboard
on the phone as soon as the dialog box pops up to edit/create
a quick response.

Bug: 5011277
Change-Id: I9926d07cae0e527a7c08a4cc556a9569a91d2f33
2011-07-14 14:54:09 -07:00
Ben Komalo
b507ece493 Remove stale STOPSHIPs
Change-Id: I2364e1dbf25b9df20ef9fa9014e19cbbab278a3b
2011-07-14 14:45:36 -07:00
Ben Komalo
83b0f4434c Merge "Fixup recent mailboxes." 2011-07-14 12:41:15 -07:00
Ben Komalo
d6ad9b8c03 Fixup recent mailboxes.
The default recent list should be pre-populated and fall off the list as
normal. The previous implementation showed a default list if there were
no touched mailboxes, but then the default list disappeared as soon as
there was one touched.

Bug: 5020673
Change-Id: Ifad607a9d36feff837ab42d039ce9209f223f345
2011-07-14 12:03:16 -07:00
Jorge Lugo
7667632eb2 Improve accessibility for stars and settings
Adding and removing a star triggers the appropriate accessibility
In incoming/outgoing settings, added EditText contentDescriptions.

Change-Id: Ibab461f1425b3ebf3579ebc1d0b36d1a9a5efdb2
2011-07-14 12:01:02 -07:00
Marc Blank
21913ced32 Send proper parameter to startSync (via EmailService)
Bug: 5014063
Change-Id: If236a02e92adef06f2a9ca3779d08778915ed6e9
2011-07-14 11:59:22 -07:00
Jorge Lugo
b9d835a2bb Merge "Don't display warning message on edit incoming settings" 2011-07-14 11:44:50 -07:00
Jorge Lugo
cf194df05c Don't display warning message on edit incoming settings
On phones, opening "incoming settings" no longer immediately displays
the warning message associated with editing the username field. It now
only displays when the username is focused by the user.

Bug: 4282856
Change-Id: Ic0a74fa91a0f9cff66565372872e182a0eaec779
2011-07-14 11:38:30 -07:00
Marc Blank
53dddf3c55 Fix loss of client updates in IMAP when no connectivity
Bug: 5014965
Change-Id: Id5c6696ea1add598f180e739398ab14f60e382a3
2011-07-14 11:04:05 -07:00
Jorge Lugo
89010fe39f Merge "Don't show To/Cc/Bcc hint text on tablet" 2011-07-13 19:52:38 -07:00
Jorge Lugo
f8dbd95695 Don't show To/Cc/Bcc hint text on tablet
Since tablet already has to/cc/bcc labels, don't show the hint
text -- only do so when labels don't exist.

Bug: 5019806
Change-Id: I039de06e2576688e654fb0504a027cd9b9b67def
2011-07-13 18:54:51 -07:00
Ben Komalo
acd985efb4 update one more test for default account changes
Change-Id: I36344a9c0a29d718ec9dd3d51d9abfbc435252f0
2011-07-13 17:10:16 -07:00
Ben Komalo
04bd9aa8b3 Merge "Unit test updates for default account changes" 2011-07-13 16:47:27 -07:00
Jorge Lugo
abec4e631c Merge "Prevent account flip flopping from compose" 2011-07-13 16:35:50 -07:00
Ben Komalo
52e66110d8 Unit test updates for default account changes
Change-Id: Id619de198a84d1da43068a90474ed76ece9a30b5
2011-07-13 15:16:55 -07:00
Ben Komalo
47e8548682 Merge "Remove dead code" 2011-07-13 15:09:31 -07:00
Ben Komalo
4de538be2d Prevent account flip flopping from compose
There were two issues:
- the default account ID from the provider wasn't consistent: it was
using a snapshot from the cached data but that simply returns a Map, and
the values aren't guaranteed to be sorted (and indeed I saw that the
order was different on consecutive calls!)
- hitting app up from Compose always just kicked you out to the inbox
for the default account, but it probably should have used the account of
the compose screen, since it can be specified in the Intent

Bug: 5012008
Change-Id: Ic9a753b261e047790453bc1a9417bc0c6d2f87f9
2011-07-13 14:46:50 -07:00
Marc Blank
2a33dde4d1 Delete PIM data, etc. on device admin disable
* We were deleting secured accounts when device admin is disabled,
  but we were not deleting associated data, which means that
  contacts, calendar, and attachment data were left on device

Bug: 5021062
Change-Id: Iabeec2dcd6ef4f52dc52e43d62803e61f7881c0d
2011-07-13 09:17:23 -07:00
Ben Komalo
3cfb3d5077 Remove dead code
Change-Id: I66bec3975b3f028081071b9bbd26206ec369da26
2011-07-12 20:42:16 -07:00
Ben Komalo
17501fc0ca Fix UI issue with expanding details.
- the show/hide details icon no longer jumps
- the expanded details now doesn't take up the entire screen on tablets

Bug: 5009046
Change-Id: If7f3451e28ba09928cc9b8aa156779f076948979
2011-07-12 17:20:13 -07:00
Marc Blank
4c0e5c0d0a Remove unneeded (and harmful) test in MessagesAdapter
* This fixes the case in which messages are being loaded upon
  initial sync, but do NOT appear in the message list (at least
  until leaving and re-entering the app/mailbox)
* The problem was that MessagesAdapter was checking the state
  of the HOLDS_MAIL flag, which might not have been set at the
  time the Inbox was created; it turns out that the check is
  not necessary, so we remove it here

Bug: 5008696
Change-Id: I009ddf7d82d938758b99c855dfd0271596c5248a
2011-07-12 16:49:48 -07:00