Commit Graph

2270 Commits

Author SHA1 Message Date
Marc Blank
1c1bd6a3eb Fix typo in debug code
Change-Id: Iffb3effa3fd659be3df3208bb587fea83bc9116e
2010-12-29 20:51:16 -08:00
Marc Blank
268597f68d Remove "Heartbeat" logging
Change-Id: Ib15451a9204a40b4bd74c55a348d732c8f43604a
2010-12-28 12:24:07 -08:00
Marc Blank
c041c799f3 Merge "Fix synchronization issue w/ closing CachedCursor" 2010-12-27 23:38:19 -08:00
Marc Blank
788408dee4 Fix synchronization issue w/ closing CachedCursor
Bug: 3306031

Change-Id: I3000cf92c27e93b2df94799492fb9960a3d795dc
2010-12-26 11:45:30 -08:00
Andy Stadler
926e7369d1 Remove UI thread disk access from AccountSetupNames
* Remove unneeded DB read in onCreate (add runtime checks for problems)
* Move more exit/commit work to existing AsyncTask
* Add lockout of next & back keys while processing

Bug: 2792509 (probably others)
Change-Id: I0db030a1f1df94ba721510b5112519f260f5c0f9
2010-12-25 23:16:10 -08:00
Andy Stadler
4f6a507d9b Merge "Fix ANR's in AccountSetupOptions" 2010-12-24 21:53:36 -08:00
Andy Stadler
ec9398e7c6 Fix ANR's in AccountSetupOptions
* Move all db ops off UI thread
* Reorder methods in typical progression (they were random)

Bug: 3134660
Bug: 3134677
Change-Id: Idd4f411e937336bbd09bcc03d9ad036d22dc5e19
2010-12-23 16:38:52 -08:00
Makoto Onuki
adbb6f8bc4 Log cursor/adapter class name and such when detecting a crash
Also log where the cursor was closed, if it is.

To investigate bug 3308465 and bug 3305706

Change-Id: I2b0fd9ea14757b6cf7597cd7162686d050d43fe9
2010-12-23 16:15:44 -08:00
Andy Stadler
2959a7e073 Fix ANRs from Email.setServicesEnabled()
* Create sync & async versions
* Rename all callsites so sync is very apparent
* Fix callsites appropriately
* Clean up interaction between reconciler and setServicesEnabled

Bug: 3133770
Bug: 3134677
Change-Id: Iefbc7814d9aa390baea6345e450e2a4768bf0a9a
2010-12-23 13:19:55 -08:00
Andy Stadler
6aec257fe7 Merge "Fix NPE when changing server settings w/security dialog" 2010-12-23 11:08:50 -08:00
Andy Stadler
c4c3a71f9f Merge "Async code for read/unread and starred" 2010-12-23 11:01:42 -08:00
Makoto Onuki
948bcad901 Merge "Use swapCursor(null) instead of changeCursor(null)" 2010-12-23 10:15:05 -08:00
Andy Stadler
3b1cccf234 Async code for read/unread and starred
* Move each worker into async (combining common code)
* Update unit tests to match
* Make the message->account->controller lookups more efficient

Bug: 3134653
Change-Id: Icc82998a5d8eb07c7ebc7edbd28cd9308378d866
2010-12-23 09:55:16 -08:00
Andy Stadler
d8f1d8f2ff Fix NPE when changing server settings w/security dialog
Bug: 3302453
Change-Id: I8adb5166598b72f9eb4a26bbe47afc756e764159
2010-12-22 19:01:08 -08:00
Andy Stadler
8d22e85e45 Reduce/eliminate DB access in server settings
* Create shared async worker to check for duplicate accounts
* Use it in AccountSetupIncomingFragment
* Use it in AccountSetupExchangeFragment
* Debounce proceed/next button because work is now async
* Also, upgrade leftover old-style code in AccountSetupOutgoingFragment

Bug: 3134666
Change-Id: I5c24a6546d1ab66aedc5c4ac826ddf4f1ff53446
2010-12-22 18:57:27 -08:00
Makoto Onuki
e0f28d7853 Use swapCursor(null) instead of changeCursor(null)
The later closes the old cursor while the former doesn't.
LoaderManager takes care of closing cursors, so no need to close
cursors by ourselves.

Change-Id: Ib652e6877dcfc1fea51ffc862254eaeed451cdfa
2010-12-22 17:35:44 -08:00
Andy Stadler
6ebaa90847 Reduce/eliminate UI thread access in MailService
* Make most calls to AccountBackupRestore return immediately w/o DB access
* Move most workers in MailService into async runnables
* Remove account restore / null check from ACTION_SEND_PENDING_EMAIL
* Strengthened unit test on Mailbox.findMailboxOfType() because after
  removing the account check (above), sendPendingMessages depends on
  findMailboxOfType() returning -1 on a missing account.
* Clean up a bunch of warnings (no longer use deprecated Config.LOGD)

Bug: 3133763  (and probably others)
Change-Id: Id39707bca7a8ebf5000f84d542013411ff0f422e
2010-12-22 16:34:48 -08:00
Andy Stadler
9f7e3982ad Reduce UI thread disk access in account settings
This change is in top-level settings for a given account:
* Call saveSettings async on UI changes, instead of synch at onDestroy()
* In loadSettings, get default account id async

Also sprinkled in some TODOs for future whack-a-mole fixes.

Bug: 3133639

Change-Id: I5216c78d28b35fe47e43b48ad0db3a3e57b25004
2010-12-22 13:55:42 -08:00
Marc Blank
84dfef9085 Merge "Put individual account inboxes in widget rotation" 2010-12-22 13:46:11 -08:00
Makoto Onuki
22b33a5a4a Show stacktrace when failing to load message body
Change-Id: Ie6b2dda6fa32982e48e052f5f8fe2c699ebc8a01
2010-12-22 12:53:05 -08:00
Marc Blank
66b6b95646 Put individual account inboxes in widget rotation
Change-Id: If1fddc107d9934849bbf273a67dd1db9c2063d99
2010-12-22 12:49:15 -08:00
Makoto Onuki
ab1674a2d6 Cosmetic changes to MessageView
- Don't show the progress icon unless loading from network
- Don't show the content until LoadAttachmentsTask finishes
- Disable the fade-in animation.  It causes some weird positioning issue
  with the GL accelerated webview.
- Use WebView.clearView() to clear its content.
- Use the "normal" layout mode, otherwise WebView won't use its entire
  width
- Don't hide the vertical scrollbar

Bug 3287729
Bug 3225068
Bug 3295761
Bug 3304396

Change-Id: Ic4b8baac99b71dc0da58021849ff7c1dbd6dbe55
2010-12-21 17:57:16 -08:00
Marc Blank
9c4458dcd7 Don't try to show thumbnail for unloaded attachments
Bug: 3292689
Change-Id: I7575cb891f0b46c4a8564b5d2c4907025d91c639
2010-12-21 12:37:40 -08:00
Dianne Hackborn
8b9f2a7284 Update to use new Loader callbacks.
Change-Id: Ib478c2f2314bbae4a380539e22892d85dd9a34b5
2010-12-20 23:14:01 -08:00
Marc Blank
d9b251d23b Properly return zero-count cursor from getMatrixCursor
Change-Id: I574528bf56b5a82ecbaab3d3501b26e7afb974ec
2010-12-20 13:58:11 -08:00
Dianne Hackborn
0698f4027f Update to new Loader APIs.
Change-Id: Ic228f7b785f0d902a0188cfe995006b73b8a3c8b
2010-12-20 12:23:13 -08:00
Marc Blank
0fd8ae8808 Pixel perfect Email widget
* Functionally correct and pixel perfect
* All current assets in place

Bug: 3292507
Bug: 3284201
Bug: 3135118
Bug: 3255036
Bug: 3252913

Change-Id: I8fa6752748c74b3a9789a3675da12f6c0c11975f
2010-12-20 11:55:01 -08:00
Makoto Onuki
22fb45817b Merge "Follow-up to the loader API change" 2010-12-17 13:46:23 -08:00
Makoto Onuki
28d6e09575 Follow-up to the loader API change
This should fix the "attempt to re-open an already-closed object" exception
from SQLite.

(destroy()s don't have @Override becuase the base method is now depricated
and will be removed someday.)

Bug 3288666

Change-Id: I4780f6c8d89c7204b266608462c0833ad5af4e5f
2010-12-17 13:36:51 -08:00
Marc Blank
120674a05c Merge "Harden AttachmentDownloadService; fix storage calculation" 2010-12-17 12:00:14 -08:00
Marc Blank
edb05ca5ee Harden AttachmentDownloadService; fix storage calculation
Bug: 3292720
Bug: 3286634

Change-Id: I378aac369ee8317c0c41b1f021a3731b81bcb380
2010-12-17 11:28:18 -08:00
Marc Blank
1504ef5fd1 Merge "Remove unused debug flag" 2010-12-17 10:40:13 -08:00
Marc Blank
f3ced5b8a5 Merge "Remove unnecessary logging in Utility.attachmentExists" 2010-12-17 10:36:09 -08:00
Marc Blank
54250337a0 Remove unused debug flag
Change-Id: I88ef517a5b4860c30f1eb2a52f15d8f07c823797
2010-12-17 10:34:43 -08:00
Marc Blank
f995f680a8 Merge "Throw exception on illegal URI's in EmailProvider operations" 2010-12-17 10:21:44 -08:00
Marc Blank
d3fafabd0f Remove unnecessary logging in Utility.attachmentExists
Bug: 3292689
Change-Id: I937ef44b4576634fd870c759a13f3d27255112bd
2010-12-16 20:09:41 -08:00
Marc Blank
e6a22dff39 Throw exception on illegal URI's in EmailProvider operations
Change-Id: I6354c03e7cead81df3764b7d0bd1be0e90271664
2010-12-16 17:12:42 -08:00
Andy Stadler
5b393bfece Merge "Show attachment download progress/status properly" 2010-12-16 15:30:12 -08:00
Andy Stadler
6624909533 Show attachment download progress/status properly
Bug: 3291532
Change-Id: I3ceab8a67095190898273b9ccd5a1016218edcb2
2010-12-16 15:09:03 -08:00
Dianne Hackborn
80769cefb3 Prepare for some changes to LoaderManager/Loader.
Sorry it is a bit ugly, it is to allow this change to be
checked in prior to the first stage of the framework change
without breaking the build.

Change-Id: I1828579019ac0325d19c070a4c62cd79549e7d51
2010-12-16 13:20:39 -08:00
Makoto Onuki
303816534d Don't show app name on action bar
Need to hide the action bar title when showing account spinner.

Change-Id: Id85fa91f1b89fbd9d2a92bd2d175121176b8a2f0
2010-12-16 11:32:28 -08:00
Makoto Onuki
a9939ab165 Merge "Disable "upgrade accounts" for now." 2010-12-16 11:09:06 -08:00
Marc Blank
4970392341 Synchronize properly with ContentCache; document synchronization
Bug: 3291682
Change-Id: I69c4a3b2ee62a41e6488b63deeb975e510a3f554
2010-12-16 10:39:08 -08:00
Andy Stadler
e6214d1f87 Merge "Restrict download/display to "attachment" and "inline"" 2010-12-15 18:06:59 -08:00
Makoto Onuki
b358da3344 Disable "upgrade accounts" for now.
This will not be necessary on tablet.

Bug 3122020

Change-Id: Ifff59a11ccf628fdb5b6d007a7a6591db10153ce
2010-12-15 16:22:04 -08:00
Makoto Onuki
2a63ac55e9 Merge "Add null checks to investigate bug 3275738" 2010-12-15 15:42:19 -08:00
Makoto Onuki
ebf0f18cba Add null checks to investigate bug 3275738
Change-Id: I55f83336c5059b7ea6234b9451c60c4c062fdb06
2010-12-15 15:38:27 -08:00
Andy Stadler
014e31a62c Merge "Use generic contact icon for notifications & messages" 2010-12-15 15:27:07 -08:00
Andy Stadler
c1c3b6f21e Use generic contact icon for notifications & messages
* Copies the icon from contacts
* Used whenever the sender doesn't have a local photo
* Used in notifications and in messageview

Bug: 3282187 (notification)
Bug: 3285156 (memory leak from the placeholder graphic)
Change-Id: I528cae20355aa8cce7be37b26f32aa90e092708b
2010-12-15 15:26:30 -08:00
Marc Blank
f7660220a8 Merge "Enable cache logging for debugging (w/ STOPSHIP)" 2010-12-15 14:07:53 -08:00