Commit Graph

2147 Commits

Author SHA1 Message Date
Makoto Onuki
17d07ecdf7 Hide selection mode when message list is not visible.
...without clearing the selection.

Message list can be hidden on portrait.

Bug 3228718

Change-Id: Idc9eb3416e151ac0c2b851824fcee10b346d51c5
2010-11-30 14:54:04 -08:00
Andy Stadler
e29189e3ee Cleanups to Controller & AttachmentProvider
* New method in AttachmentProvider to delete all attachments for an
  account, and unit test it.
* New method in Controller to delete all synced data for an account,
  and unit test it.
* Fixed existing problem with Controller unit tests (needed cache clear)
* Fixed existing problems in Controller (mContext vs. mProviderContext)

Bug: 3197935
Change-Id: I79c6a03c21f18d37eeb8158cd1c2af0e0a6e9d2e
2010-11-30 12:11:36 -08:00
Marc Blank
3bbc690600 Add watchdog to AttachmentDownloadService
* Detect attachment downloads that have stalled and restart them
* Catch a couple of cases in which we weren't sending callbacks

Bug: 3122242

Change-Id: Id2bfd3b26182004b301cf8665f4feb6e62b98b73
2010-11-30 10:16:05 -08:00
Makoto Onuki
2201b38fe3 Add error message UI
Show an error message in a yellow bar at the top of the activity.

Bug 3230116

Change-Id: I45dad233c1ab52de365c8caedb4eeff29aefac65
2010-11-29 16:07:38 -08:00
Makoto Onuki
2d648f4cec Merge "Make "mark unread" close current message" 2010-11-29 16:07:09 -08:00
Marc Blank
d14f93f2b4 Merge "Make sure we send callbacks for UI requested syncs" 2010-11-29 16:04:55 -08:00
Andy Stadler
2148d9b2e6 Merge "Move "Add Account" to ActionBar" 2010-11-29 15:18:17 -08:00
Andy Stadler
97874770fc Move "Add Account" to ActionBar
Not currently enabling/disabling properly, filing a framework bug.

Bug: 3188951
Change-Id: I9c8900187048f548411a23c2a1b0208c79fc0a24
2010-11-29 15:00:37 -08:00
Makoto Onuki
f3d43641c9 Make "mark unread" close current message
- XLFragmentManager.selectMailbox() used to hide the message view
  when it's visible, but not anymore.  Made goBackToMailbox() itself
  hide it instead.

- Also made onMarkAsUnread() not call the unread callback, which was
  already done in onMarkMessageAsRead().

Bug 3214538

Change-Id: I52fb8bb745cdaa517624a9aeec074122f10aac4a
2010-11-29 14:46:27 -08:00
Marc Blank
1b6623b092 Make sure we send callbacks for UI requested syncs
* In the case in which a sync was requested during an already-running
  sync, we weren't passing the request information into the service

Bug: 3143544
Change-Id: I098161830844f604e4aa5b9c067491d2777d78c3
2010-11-29 11:32:04 -08:00
Makoto Onuki
36cf701784 New back behavior
The home icon on action bar and the system back key work slightly differently
on portrait.

home: full-screen message view -> mailbox list + message list
back: full-screen message view -> expanded message list
      -> mailbox list + message list

Bug 3228524

Change-Id: I9bb598315ee829c6a8300a35d194a29c7a26291f
2010-11-24 14:42:27 -08:00
Makoto Onuki
54513ed740 Merge "pixel-almost-perfect: mailbox list" 2010-11-24 13:47:04 -08:00
Makoto Onuki
9d6d5b3091 pixel-almost-perfect: mailbox list
Bug 3137965

Change-Id: Ic5aa3327ddbd456024e1938b74c7da0452b682f5
2010-11-24 13:40:58 -08:00
Andy Stadler
0cefe81b47 Merge "Update visual style shortcut picker and make it async" 2010-11-24 11:20:06 -08:00
Makoto Onuki
2e1c3eaaf1 Merge "Don't show color chips when there's only one account" 2010-11-24 10:48:10 -08:00
Makoto Onuki
e2201949ba Don't show color chips when there's only one account
Bug 3225322

Change-Id: Idb299f54dc6f746e7d451a7a04fb971a432a869a
2010-11-24 10:47:04 -08:00
Andy Stadler
d87f81e901 Update visual style shortcut picker and make it async
* Use dialog when in XL screen size
* Show different strings in launcher and in dialog/activity title
* Add cancel button to picker
* Move accounts query to AsyncTask
* Remove obsolete AccountsAdapter

Bug: 3093928
Change-Id: Ief771482c6db684c434c21cf92844c37a927d34a
2010-11-23 22:54:49 -08:00
Makoto Onuki
e47c12dba8 Merge "Don't show account dropdown when there's only 1 account." 2010-11-23 17:31:43 -08:00
Makoto Onuki
08e1f2f782 Don't show account dropdown when there's only 1 account.
Bug 3225851

Change-Id: I7b411f8047e3b26cfe53f17c46c3e2611fb8ae9d
2010-11-23 17:23:36 -08:00
Marc Blank
2eaa910a65 Merge "Handle upsync of EAS contact "group" (category) rename/delete" 2010-11-23 15:10:20 -08:00
Marc Blank
fb3c389a14 Handle upsync of EAS contact "group" (category) rename/delete
Bug: 3211907
Change-Id: I7bec90dae7c223b4bd0d0f366d18cac37e53fbcc
2010-11-23 15:07:48 -08:00
Makoto Onuki
5b81690de1 Show color chips for combined view.
Show color chips for account rows and message items on the combined view.

Moved hard-coded color values to resource.

Bug 3138001

Change-Id: Ib93fb9d6e9592ebd0c297f83c3dee2358a80508f
2010-11-23 13:03:06 -08:00
Makoto Onuki
46e60b51e2 Merge "Fix & cleanup on EML viewer (MessageFileView)" 2010-11-23 12:18:28 -08:00
Andy Stadler
4091ffe94f Merge "Move application icon to mipmap-* directories" 2010-11-23 12:16:00 -08:00
Andy Stadler
5c4c0ab456 Move application icon to mipmap-* directories
Change-Id: Idc5df7046d0fa64ffbfce2869dffb4fe0fd144a0
2010-11-23 12:06:44 -08:00
Marc Blank
70188b71aa Merge "Fix deadlock in ContentCache" 2010-11-23 11:51:04 -08:00
Marc Blank
5835dceced Fix deadlock in ContentCache
* The situation is that putCursor() is called from a reading thread
  while invalidate() is called from a writing thread
* putCursor() must not hold the monitor lock on ContentCache while
  moving the underlying cursor to position 0

Bug: 3224203
Change-Id: I35b798dccf245c761dc79c39ced4fc8c0cfb9d78
2010-11-23 11:19:26 -08:00
Makoto Onuki
a6998d39fa Merge "Implement screen transition animation." 2010-11-23 10:18:25 -08:00
Makoto Onuki
d2dac0fd6c Implement screen transition animation.
Bug 3137919

Change-Id: I077768bffb1eb246fdaa7d2def30c7b132566d69
2010-11-23 10:17:54 -08:00
Andy Stadler
1f3e117951 Fix rotation problems in setup/settings
* Fix incomplete tracking of mLoaded flag
* Defer validation on automatic reload of fields (on rotation)
  until reconstruction completes and we're ready to do validation.
* (For Incoming only) Split loadSettings into configure and reload phases;
  We need to configure the UI every time we restart, but we don't want
  to reload & overwrite user-entered values on rotation.
* (For Exchange only) Properly show/hide trust certificates options on
  rotation, and show/hide divider too.

Bug: 3170922
Change-Id: If3de30ee2d4d5668b29698af73f545510692777e
2010-11-22 19:02:16 -08:00
Marc Blank
c0604d9648 Merge "Don't layout with 0 width if we've got a real width" 2010-11-22 18:05:34 -08:00
Marc Blank
d98b42e767 Merge "Remove unnecessary MessageObserver" 2010-11-22 17:45:45 -08:00
Marc Blank
4238524d6f Remove unnecessary MessageObserver
* We used this to ensure that messages placed in the Outbox would
  trigger a sync, but this is already handled by a call to
  startSync on the Outbox

Change-Id: I90e1b56dd437bbb9e3341bbe4b1ae8245aede891
2010-11-22 17:45:12 -08:00
Marc Blank
452b347729 Don't layout with 0 width if we've got a real width
Bug: 3221168
Change-Id: I85562cad4afe7ce494cdb4cd348cad23c6103936
2010-11-22 17:43:11 -08:00
Makoto Onuki
b715ea1d76 Fix & cleanup on EML viewer (MessageFileView)
- Fix the XL layout: Don't refer to "GONE" views in RelativeLayout.
- Don't always (re-)load message on onResume().
  This will make it lose all state (e.g. webview's zoom level) when coming
  back from other activities.
- Change the default visibility of some views so that it'll look okay
  while loading the message.
- Remove the use of obsolete fragment APIs.
- And some other minor cleanups...

Bug 3221066

Change-Id: I475bc229f4ea9e0e480f528389f5180e1d63fcd6
2010-11-22 17:02:48 -08:00
Makoto Onuki
c8e623b31e Merge "Fix NPE in MessageViewFragment" 2010-11-22 15:21:07 -08:00
Makoto Onuki
deda053f7c Fix NPE in MessageViewFragment
Call clearContent() in onDestroy(), instead of cancelAllTasks().
(This is what I thought I was doing.)

Calling clearContent() tells the BG thread that the activity has already
been destroyed, and prevents them from loading a message.

Also as a precaution, don't load a message if getActivity() returns null,
which means the activity has already been destroyed.

Bug 3134403

Change-Id: I0d591e0dd147f73e70b0c027dc8037482197f7b4
2010-11-22 14:29:29 -08:00
Marc Blank
51f5cd7c16 Merge "Use consumeContent() to ensure release of HttpClient resources" 2010-11-22 11:56:05 -08:00
Makoto Onuki
79c5d35c13 Merge "Correctly set intent to new message notification" 2010-11-22 11:46:01 -08:00
Marc Blank
7f35dd8da7 Use consumeContent() to ensure release of HttpClient resources
Bug: 3197531

Change-Id: I7376b438edb05411950249bbf34cffa3ad8cb5a7
2010-11-22 11:45:01 -08:00
Makoto Onuki
8d3ef1d01e Correctly set intent to new message notification
Bug 3219763

Change-Id: I7826e762713228ee4ca1ca1d57b4d7603df81a66
2010-11-22 11:36:17 -08:00
Marc Blank
7c90fa014d Merge "Implement password expiration for EAS" 2010-11-22 11:18:10 -08:00
Marc Blank
cf3fb71bc6 Implement password expiration for EAS
* Hoist wipe() method from AbstractSyncParser to AbstractSyncAdapter
* Add deleteAccountPIMData(accountId) to the EmailService API
* Implement deleteAccountPIMData for EAS

Change-Id: I1037cde25fc2b24419f399446cfa0906dc0174d1
2010-11-22 11:17:00 -08:00
Makoto Onuki
9cb0ad3cd6 Merge "Don't reset message view when becoming active again." 2010-11-22 10:42:18 -08:00
Joe Onorato
2e578032d0 Use new notification API to get the new features.
Change-Id: I47a6c46ebb7999663ec16f049c99c418f4333213
2010-11-21 16:26:33 -08:00
Makoto Onuki
4c9e1a3fde Don't reset message view when becoming active again.
- We used to (re-)load the content on every onStart(),
  which is called too when coming back from other actibities.
  So if you go home and come back with the task switcher,
  all state get reset, including webview zoom/pan and the current tab.

- Introduce a new flag, mLoadWhenResumed, to tell if we really need to
  load a message.

Also:
- Start loading a message in onResume() rather than onStart()
  to keep it consistent with other fragments.

Bug 3215269

Change-Id: I1cc6e12c3cc3c08065da3696603a3247f341469a
2010-11-19 15:12:54 -08:00
Makoto Onuki
00fb407689 Merge "Show current mailbox name and unread count on action bar." 2010-11-19 13:56:36 -08:00
Makoto Onuki
f108837c1d Show current mailbox name and unread count on action bar.
- Show them when the mailbox list is hidden
- Data flow:
  MailboxListFragment ->(Callback)-> MessageListXL ->
  MessageListXLFragmentManager, which controls the action bar.
  (I'm not too happy with this flow, but we can at least avoid
  issuing yet another query to get these data.)

Also related:
- On the combined view, show the unread count for account rows

Bug 3137891

Change-Id: I37fa1258d946329905bbbc0da905928bcf2f4cb1
2010-11-19 13:55:49 -08:00
Makoto Onuki
9f04fdc555 Make home icon on action bar clickable
- Make the home icon on action bar clickable, and show the back arrow with it.
- When clicked, it'll navigate you back to the main screen.

Bug 3138037

Change-Id: Ice783e6b594347bd73b94e71d29a61ad4f5ef972
2010-11-18 16:54:00 -08:00
Andy Stadler
6143d026c0 Re-enable activity progress indicator
Bug: 3137891
Change-Id: Iea65b69dd376fd0026cd53680b901805a07fa101
2010-11-17 23:19:36 -08:00