Commit Graph

6001 Commits

Author SHA1 Message Date
Ben Komalo
23a4b15e08 Fix notification issues.
- use title as ticker text
- also properly play notification sounds on new messages. Before, if you
left a notification unread, and a new message comes in, no sound would
be played. Since fixing that, it introduces another issue where on
initial sync, tons of new messages come in (and the sync could take > 1
min). We throttle them with a 15 second interval. The notification is
always updated to reflect the most up to date information, but sounds
will never be played closer than 15 seconds together.

Bug: 5020191
Bug: 5067059
Change-Id: I5ca474fd3b210ee856035bd78bd72931da80fe40
2011-07-22 12:06:11 -07:00
Ben Komalo
a10d4a8e45 Prevent crash when composing a message on tablets.
We were hiding the cc/bcc menu option, but on tablets that is a visible
button on the UI and not in the menu. whoops.

Bug: 5067057
Change-Id: I10ecaf115b589b9200529f6ea7703428456b8f0f
2011-07-22 10:00:39 -07:00
Ben Komalo
6a902861e9 Merge "Don't touch the cursor in the background" 2011-07-21 20:45:52 -07:00
Ben Komalo
b30d635dd0 Merge "Guard against null items in NotificationController" 2011-07-21 20:35:00 -07:00
Jorge Lugo
a926c32aa2 Merge "Improved shortcut name" 2011-07-21 19:46:44 -07:00
Jorge Lugo
7496b5ba2b Merge "Display message when no quick respones available" 2011-07-21 19:44:31 -07:00
Ben Komalo
5fb6c5d4de Don't touch the cursor in the background
This prevents accessing a potentially closed cursor when doing batch
operations that will inevitable cause the the list to be reloaded (and
cursor to be invalidated) as the first of the messages are
touched

Bug: 5051730
Change-Id: I90328ee02eafe6ad238d8c57e88a3d96259f6547
2011-07-21 19:41:07 -07:00
Jorge Lugo
4ca1ca8622 Display message when no quick respones available
When editing quick responses, displays an appropriate
message letting users know that there are no quick responses.
Additionally, the MessageCompose activity will only show "insert quick
responses" when at least one exists.

Bug: 4948180
Change-Id: I1191bd54d6e64f990b6d6830f0837579d7a6918c
2011-07-21 19:06:17 -07:00
Jorge Lugo
79fab5ae62 Improved shortcut name
Shortcut name is now the name of folder when it's a non-inbox
folder; otherwise it's the account name. Previously was
always account name.

Bug: 4903490
Change-Id: I15b4024d28db6a48464e423db887bdca99132423
2011-07-21 18:39:10 -07:00
Ben Komalo
af5826cc7a Merge "Optimizations to startup." 2011-07-21 17:56:26 -07:00
Ben Komalo
80b817714f Optimizations to startup.
- don't inflate search views - inflate them on demand
- kill some unneeded containers

Bug: 4996847
Change-Id: I7747e194e7c0939ad6416f351096639b283f4899
2011-07-21 17:38:19 -07:00
Ben Komalo
9867d8a160 Merge "Prevent touching closed cursor" 2011-07-21 13:50:51 -07:00
Ben Komalo
87d8ab4bb4 Prevent touching closed cursor
Bug: 4595568
Change-Id: Ic3087dc5f194aa879a3fea9d45fe77a1e285bde0
2011-07-21 13:01:31 -07:00
Ben Komalo
5479f061ab Remove cc/bcc option from menu when used.
Bug: 5055403
Change-Id: I3a349ddf7b5b186bb6daccd7151b8b352cab0050
2011-07-21 12:34:53 -07:00
Ben Komalo
eb9dcfaf18 Guard against null items in NotificationController
If the account is in the process of being deleted, large parts of its
data may be being removed in parallel with notification processing. We
never handled this very well.

Bug: 5058333
Change-Id: Ic588b68438a9c5829e7e3fd5c8d52e21a037b9f4
2011-07-21 12:24:18 -07:00
Ben Komalo
9d0bb2e3a0 Hide attachment size info if unknown.
Bug: 5011871
Change-Id: Ide56b79c036b16a66720228660f3eed76a9c9ba2
2011-07-20 18:19:48 -07:00
Ben Komalo
8d8814ed35 Consider attachments for empty messages
Since we thought the message was empty, tapping on back doesn't save the
draft.

Bug: 5057044
Change-Id: I99d903430b0e0a40dc23eb805cf24961e9ca2301
2011-07-20 17:15:35 -07:00
Ben Komalo
b7b0b04f50 Swap order of search<->show all labels on phone
Change-Id: I21473495261b9671cfbadf3c9b7eeaf4f0d1d319
2011-07-20 15:17:39 -07:00
Ben Komalo
3f0ac78eab Merge "Remove "Move" action on POP." 2011-07-20 15:11:33 -07:00
Ben Komalo
81a153463b Remove "Move" action on POP.
Bug: 5010614
Change-Id: If0a94840e9dc104566ba39d2e3240883dab5bba0
2011-07-20 13:21:06 -07:00
Ben Komalo
7688300055 Fix sync window settings for EAS setup on phones
- the container is the one that should be visible/gone - individual
fields should just be visible
- also do drive by javadoc fixes

Bug: 5052310
Change-Id: I45c4b6b7f94b2b62ac94eeff0ab97bf34c9e117a
2011-07-20 11:27:11 -07:00
Ben Komalo
6496562610 Merge "Prevent search on POP" 2011-07-20 11:06:56 -07:00
Ben Komalo
5aa3d71209 Prevent search on POP
We were hiding the search icon from the actionbar but didn't take into
account the use of a hardware button.

Bug: 5051691
Change-Id: I2e0bfd1d0bb4faa3238e567c02189894db5f6c44
2011-07-20 11:06:28 -07:00
Ben Komalo
1ecfb5311b Remove illegal references to IsolatedContext
This fixes a crash on account deletion, leaving around bad accounts that
were in limbo
Also remove a test for an unsupported operation

Bug: 5051951
Change-Id: Ieebc7f769075614ae1a656cf123d8ce0313e611d
2011-07-20 10:52:47 -07:00
Marc Blank
e12c0522f8 Merge "Remove NotificationService; use Account columns for data storage" 2011-07-19 19:36:57 -07:00
Marc Blank
aca9426581 Remove NotificationService; use Account columns for data storage
Bug: 5023662
Change-Id: I84df3b474dd6320327851003af985144cc16348e
2011-07-19 18:19:59 -07:00
Ben Komalo
c01ce156e8 Minor change to keep same account if possible.
On second thought, it's probably best to stick with the same account if
I can't find a particular folder. This at least is less jarring if the
user has multiple accounts.

Change-Id: Ifd5d631b220e260399681008ac17203f5451c8ff
2011-07-19 18:16:10 -07:00
Ben Komalo
1ef8ec61c9 Misc STOPSHIP cleanups.
Apply the same logic to mailboxnotfound for two pane.
also remove some obsolete callbacks.

Change-Id: I942c2b557fce2601a0e46878cfe4d5ce2cc83850
2011-07-19 17:51:36 -07:00
Ben Komalo
0413edd626 Remove STOPSHIP
- ensure that the commitAllowingStateLoss is actually not dangerous - we
only had one case I could see where we were actually doing a transaction
from a loader callback and I fixed that just now to not do any
transactions.

Change-Id: I21e11138f70eb2ce953a5ba54119ca46555f465d
2011-07-19 17:28:58 -07:00
Ben Komalo
6edddbf714 Merge "Misc attachment code cleanups" 2011-07-19 15:26:45 -07:00
Ben Komalo
dfff72f731 Misc attachment code cleanups
Change-Id: I612b3ed1280d4d057834d3d3e67c8ac17c2bafb6
2011-07-19 15:16:45 -07:00
Marc Blank
c6df1d605f Prevent NPE's in AccountSecurity
* This CL fixes the referenced bug, but it does NOT explain how
  mAccount; best guess is that the process was killed and then
  restarted when the result from DPM was available.
* Assuming this is the case, we remove the background task loading
  mAccount, avoiding a possible race.
* Also, it's not clear why clearNotifications didn't use the
  account id argument; what if there's more than one account that
  uses security?  Filing a bug about this.

Bug: 5048912
Change-Id: I734834337ab6e409d77624e7c7370350de76becb
2011-07-19 14:38:29 -07:00
Marc Blank
d1f03736e6 Merge "Clean up account reconciliation" 2011-07-19 13:25:25 -07:00
Marc Blank
4e4aba9ebc Clean up account reconciliation
* Move AccountReconciler to the Email app (from EmailCommon)
* Ensure that Controller.deleteAccountSync() performs ALL actions
  needed to clean up after an account deletion (delete attachment
  files, reset policies, refresh the UI, etc.)
* Add reconcileAccounts() API to AccountService
* Remove accountDeleted() and restoreAccountsIfNeede() from the
  AccountService API
* Remove unused callback

Bug: 4883073
Bug: 4767084

Change-Id: I43ffaf009db1a6f306bb0f2a74fb4dd3b2c4b966
2011-07-19 10:31:33 -07:00
Jorge Lugo
5ce13dba1f Merge "Preference panel screen titles don't change on rotate" 2011-07-19 09:54:46 -07:00
Ben Komalo
18811dfb45 Add touch slop to message list items
Bug: 5016987
Change-Id: Iddeb9a7bc244d3215a418f0897778b9ddcb3e955
2011-07-18 17:53:45 -07:00
Ben Komalo
776997e62e Update message compose to phone spec
- move cc/attachment to overflow menu
- misc layout fixes

Bug: 5011868
Change-Id: If17a36c9e7f13115828a957163af5969b6f8f93e
2011-07-18 17:08:35 -07:00
Jorge Lugo
ae594dc0ca Preference panel screen titles don't change on rotate
Incoming settings, outgoing settings, exchange settings, and
edit quick response preference panel titles no longer
change to "Account settings" when screen is rotate.

Bug: 5011355
Change-Id: Ibaf68bc836a61777de929623bff2bf2dd4ae0c3b
2011-07-18 15:43:08 -07:00
Ben Komalo
23b4ce58d4 Make min widget size 3x2
Bug: 5034371
Change-Id: If3350fcdff83dae9243edfcf651bef7b45fe85a8
2011-07-18 15:14:59 -07:00
Marc Blank
ecf8672df2 Merge "Fix NPE in onStartCommand" 2011-07-18 10:18:11 -07:00
Marc Blank
b31b798b46 Merge "Don't allow actions on empty sets" 2011-07-18 09:51:32 -07:00
Marc Blank
b8f672465a Merge "Remove unnecessary EmailAsyncTask" 2011-07-18 09:51:01 -07:00
Marc Blank
90a4811551 Fix NPE in onStartCommand
Bug: 5041436
Change-Id: Ib7462e5c8cb040b7526d9a655c5ab3f41cd159b8
2011-07-18 09:49:52 -07:00
Marc Blank
21cbdd88e1 Merge "Start/stop AttachmentDownloadService as needed" 2011-07-17 18:11:08 -07:00
Marc Blank
b2a8c2ce4c Start/stop AttachmentDownloadService as needed
Bug: 5033646
Change-Id: Ic0e75b28d0d8d5665c3f3ca864a9532fee05df8c
2011-07-17 18:06:20 -07:00
Ben Komalo
e71a19a523 Build default mailboxes for POP3
Bug: 4580535
Change-Id: Ic800eed387d3e9e64e95cce691d13d98b4a48045
2011-07-17 17:48:31 -07:00
Ben Komalo
2126caf076 Merge "Fix NPE in MailboxListFragment" 2011-07-17 17:29:33 -07:00
Ben Komalo
48f4df0911 Merge "Fixup settings entry points." 2011-07-17 17:29:10 -07:00
Ben Komalo
3c4061ae61 Merge "Filter out inbox from recent mailboxes" 2011-07-17 17:28:28 -07:00
Marc Blank
1d0609d386 Don't allow actions on empty sets
* Not sure how this could have happened, except possibly for some
  race condition
* Let's make sure it's impossible

Bug: 5032454
Change-Id: Ibd4de22dc5298fbaaf224cf4286f63bdc50aa7b9
2011-07-17 17:25:38 -07:00