Commit Graph

5589 Commits

Author SHA1 Message Date
Makoto Onuki
c3e6507293 Merge "Remove obsolete documents" 2011-06-10 11:46:33 -07:00
Makoto Onuki
4d95d0d19b Remove obsolete documents
Change-Id: I07920ddb3db128a82f5bb9d904881b9d3d2f7abb
2011-06-10 11:20:45 -07:00
Todd Kennedy
e1fe562e26 Merge "Don't include sourc mailbox in the move-to dialog" 2011-06-10 10:21:11 -07:00
Todd Kennedy
0f747de9a7 Don't include sourc mailbox in the move-to dialog
When moving messages using the move-to dialog, exclude the source folder from
the list of valid targets.

bug 4585929

Change-Id: Id02c05f38d1623f0c059d84e50ee1b51a1cdec1a
2011-06-10 10:20:31 -07:00
Marc Blank
541e98a4e4 Merge "Remove storeUri's except during auto-setup" 2011-06-09 15:21:13 -07:00
Todd Kennedy
8c921f91a4 Merge "Add recent header if there are zero recent items" 2011-06-09 15:16:27 -07:00
Todd Kennedy
0ec545048a Add recent header if there are zero recent items
For the one pane view, it's possible that an account has zero items in the
recent list (this is only possible for accounts that do not have neither
a "drafts" nor a "sent" folder). In such situations, we will still want to
have some header to distinguish between the accounts and the "show all
folders" item.

Change-Id: Ic5d6368b88ba4a28904c3b78a6489d06345a901e
2011-06-09 14:58:07 -07:00
Marc Blank
85e4c101b0 Remove storeUri's except during auto-setup
* Remove per-store limitations
* Use constants for VISIBLE_WINDOW, rather than having the
  potential for differences between Stores

Change-Id: Idd5e0874bba6e3390e4f093bcb03f4b1bb399c11
2011-06-09 13:34:43 -07:00
Ben Komalo
0a5ed251f5 am 8e8372d7: am c05084c8: Update Email version for 3.2 release.
* commit '8e8372d733e1cc85977a458d979443937b7c8f46':
  Update Email version for 3.2 release.
2011-06-09 11:54:07 -07:00
Todd Kennedy
e1e63d4387 Merge "Set proper default values for new mailboxes" 2011-06-09 11:46:26 -07:00
Ben Komalo
5757e60bc7 Merge "Guard against invalid selections in spinner" 2011-06-09 11:43:40 -07:00
Todd Kennedy
9d2dae6750 Set proper default values for new mailboxes
When creating mailboxes (specifically 'drafts' or 'sent'), we need to ensure
that its default values for flags & server key are set correctly. In most
cases this is "okay" because the mailbox will be created on the server and
the values for these fields will be reset. However, in cases where system
mailboxes cannot be created on the sever (for example, the 'drafts' folder
on any POP3 account or an IMAP gmail account), these default values do not
get updated and we are unable to view the contents of these mailboxes.

bug 4356871

Change-Id: I9e6a394145f471b555c5827d5114bca243dbc37c
2011-06-09 11:39:14 -07:00
Ben Komalo
479fdf03aa Guard against invalid selections in spinner
This is a stop gap fix for b/4584196
There was a race condition in which the actionbar callback happened
prior to the fragments being ready, and so any callbacks on a mailbox
would explode (and the spinner mistakenly thought the header was a
        mailbox)

Change-Id: Id0a24d252472faf97088175b5c413ef554dc3b76
2011-06-09 11:38:11 -07:00
Todd Kennedy
348b2f9f11 test uid search w/ and w/o parens
some imap servers will not work if the uid command contains parenthesis, while
other imap servers will not work unless the uid command contains parethesis. we
need to verify that we send both formats.

bug 4526165

Change-Id: I04a31f06a0f0fa0f03777a22b23281af574cd549
2011-06-09 10:38:44 -07:00
Todd Kennedy
7984aa60a0 Add new field to mailbox test
there's a new field in the mailbox class that was causing a unit test failure.

bug 4552358

Change-Id: Id17a99b55248cdc9e4c5ea455506f72e52687599
2011-06-09 10:14:52 -07:00
Todd Kennedy
b4f6404cd1 ignore state loss during fragment transaction
We don't need to worry about state loss here. If the fragment state is already
saved, the loader will re-fire when the fragment resumes and we'll proceed to
mailbox selection / account list as expected.

Also; only add the account selection fragment to the back stack if there is
more than one account.

bug 4558901

Change-Id: I38290fa378ac80ef5a5c8cf25c38b6e820715366
2011-06-09 09:52:11 -07:00
Todd Kennedy
964c0caf74 Merge "Don't display count for items with invalid IDs" 2011-06-08 16:44:20 -07:00
Todd Kennedy
a26fe0f150 Don't display count for items with invalid IDs
Change-Id: Id82b0a96a718f27d51d205b066a282444d6bd939
2011-06-08 16:43:37 -07:00
Makoto Onuki
3b91d0ce0f Merge "Use fragment transition animation for 1pane." 2011-06-08 16:24:02 -07:00
Todd Kennedy
7986cf6737 Merge "Fix where recent mailboxes are displayed" 2011-06-08 15:47:49 -07:00
Makoto Onuki
519b488123 Use fragment transition animation for 1pane.
Change-Id: I5f62abf87580876c75c8578da1d4a46cb92bce94
2011-06-08 15:34:41 -07:00
Makoto Onuki
3e343286d7 Merge "Back navigation on 1 pane" 2011-06-08 14:46:59 -07:00
Makoto Onuki
e06e122441 Back navigation on 1 pane
- Allow going back from the message view to the message list with restoring
  all the state on the message list. (batch selection and scroll position)

- Also make "back" work for the message list <-> mailbox list navigation,
  but only 1 level at most.
  (Only the system back key works for this; the action bar home icon will
   not.)

- As discussed offline, it uses our custum "back stack" (which can hold
  at most 1 fragment) using the new fragment APIs, attach and detach.

- Removed commitFragmentTransaction() from the base class, as now there's
  nothing really in common between the two UI controllers in terms of how
  they use the fragment transaction.

Change-Id: Id626ce99beb1f4dceb999dc04bf7d3e5d57a8198
2011-06-08 14:45:57 -07:00
Todd Kennedy
85bd26e210 Fix where recent mailboxes are displayed
For the non two pane devices, we only show the recent mailbox list in the
account spinner (and not on the mailbox list fragment).
For two pane devices, we only show the recent mailbox list in the mailbox
list fragment (and not on the account spinner)

Change-Id: I1094626532ad6d6548ef441929d94546c97304a3
2011-06-08 14:21:00 -07:00
Ben Komalo
f5df2df28a Merge "Introduce scheme name escaping in SSLUtils." 2011-06-08 13:34:39 -07:00
Ben Komalo
724c3a81cd Introduce scheme name escaping in SSLUtils.
Change-Id: I73f19e7d40d0b19dfd41cfaf7db0879ef2e3a3ea
2011-06-08 13:33:38 -07:00
Todd Kennedy
3161f1a3f2 Merge "Lock cache puts while running tests" 2011-06-08 13:01:39 -07:00
Todd Kennedy
78849fd388 Lock cache puts while running tests
Change-Id: I04c88ee70f9d72252fd1c5114d560a28fcee1b56
2011-06-08 11:51:55 -07:00
Ben Komalo
8e8372d733 am c05084c8: Update Email version for 3.2 release.
* commit 'c05084c884eef066b7eb7b2b8eec9ad447df1b23':
  Update Email version for 3.2 release.
2011-06-08 11:30:01 -07:00
Ben Komalo
c05084c884 Update Email version for 3.2 release.
Change-Id: I7480c15fcfbc91c34aa042fe936ff08964d7add7
2011-06-07 21:22:07 -07:00
Ben Komalo
313586c8eb Introduce client cert alias for HostAuth.
Some email servers require client certificates to be presented to
establish an SSL connection. While this certificate will be maintained
by the system key store, we need to store the "alias" of the certificate
stored in that system store.

Wiring up to use the actual alias will be done in future CL's. It is
currently unused.

Change-Id: I8d1290151342daea9ceb0df8a4088405b44faa81
2011-06-07 18:48:23 -07:00
Makoto Onuki
4431a74be5 Merge "Message list: Hide CAB when in back stack." 2011-06-07 18:46:59 -07:00
Makoto Onuki
ab2dba417a Message list: Hide CAB when in back stack.
Because isViewCreated() is used by updateSelectionMode() which is called from
onDestroyView(), we can't use getView() to determine if the CAB should be
shown.

Change-Id: I8d868998031115800766000fb0128f1d1d3541cd
2011-06-07 18:23:47 -07:00
Todd Kennedy
32d45f6669 Merge "update account spinner properly" 2011-06-07 17:52:32 -07:00
Ben Komalo
261ea5125b am 1c53a128: (-s ours) am c379ebe3: DO NOT MERGE Revert "Enable SD card encryption policy when emulated"
* commit '1c53a1287f1f6b9448b24931a313ffd21120bdc9':
  DO NOT MERGE Revert "Enable SD card encryption policy when emulated"
2011-06-07 17:17:31 -07:00
Todd Kennedy
7305cf5c8e update account spinner properly
Fixes two issues:
1. if a recent folder was selected from the spinner, the user could not
re-select it (even if they navigated to another mailbox using the mailbox
list) unless they manually selected another element in the spinner
2. the recent item "show all folders" did not set the associated account
position, so, when selecting that item, the spinner was not showing the
correct view.

Change-Id: I469f9f28aebd36a348534def28a4c476c0df366d
2011-06-07 17:12:34 -07:00
Todd Kennedy
dc6928d798 Add recent mailboxes to the mailbox list
Change-Id: I84ee9d0da43ccac4d10e5122f57583c4b39cf65d
2011-06-07 16:40:12 -07:00
Todd Kennedy
1b404f4fff Collapse MailboxAdapter & MailboxFragmentAdapter
MFA was the only subclass of MA and the abstraction no longer made sense.
Collapse the two into a single adapter class.

Change-Id: I32c6f027bc37f3da08626f743c3f494e5f48c3f0
2011-06-07 14:34:16 -07:00
Todd Kennedy
96e44859cf Merge "Always add "recent" header for one pane view" 2011-06-07 14:23:50 -07:00
Makoto Onuki
f329665e10 Merge "Remove "Show all folders" menu item." 2011-06-07 14:18:05 -07:00
Makoto Onuki
f1097ba7e9 Merge "Revive message view specific menu options" 2011-06-07 14:17:18 -07:00
Makoto Onuki
ed14960af5 Merge "New method to see whether 1-pane or 2-pane UI..." 2011-06-07 14:06:57 -07:00
Makoto Onuki
c6bb2ab553 Revive message view specific menu options
Revive the delete, move, mark unread options

This was lost during the refactoring.

Bug 4483764

Change-Id: Ic8d79f926aac303b3ff7477019cd05c29d614627
2011-06-07 14:00:43 -07:00
Makoto Onuki
101f929b3c Remove "Show all folders" menu item.
Now the account spinner has this.

Change-Id: I95e771e512f6c70ea9ddd8084c29a2f99b4cd758
2011-06-07 13:50:44 -07:00
Makoto Onuki
347ae23b69 New method to see whether 1-pane or 2-pane UI...
should be used.

From now on, UiUtilities.useTwoPane() should be used to see which UI
should be used.

You can pass the DEBUG_PANE_MODE extra when launching Welcome
to force which UI mode to use.  (See the comment inside Welcome.)

Change-Id: Iefa3737e4979eb55f7986a9033ff9c6266d32f52
2011-06-07 13:41:42 -07:00
Todd Kennedy
132307281d Always add "recent" header for one pane view
The one pane view will always have something in the recent list (either the
default recent list or the "all folders" item).

Change-Id: Ic264b59dc25504a8ce75bea6efae53a0d5dede87
2011-06-07 13:28:01 -07:00
Todd Kennedy
da3d04ea31 Add ability to create headers in the mailbox list
Change-Id: I9d1054056db7b6ac993570adcc4adc4cc6699e9c
2011-06-07 12:01:35 -07:00
Makoto Onuki
ab40c98821 More work on fragment install/uninstall.
- Now we "uninstall" a fragment in Fragment.onDestroyView.
  i.e. a fragment transaction is actually executed.
- Maintain our own "about to be removed" fragment list to avoid
  double removal of a fragment.

Change-Id: I61328e0a09a7af00cbb0e6ba10a2d39c11b5c3dc
2011-06-07 11:13:37 -07:00
Makoto Onuki
cb530b4e91 Merge "Use the CursorWithExtras pattern for the message list." 2011-06-07 11:12:31 -07:00
Todd Kennedy
99c1da2642 Merge "Implement account spinner recent list for one pane" 2011-06-07 10:44:12 -07:00