ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

am 4e619a2d: am 2b2b3448: Handle inactivity timeout > maximum allowed properly

Browse Source 
Merge commit '4e619a2d5051811262496e48ec99a0e916822d44' into gingerbread-plus-aosp

* commit '4e619a2d5051811262496e48ec99a0e916822d44':
  Handle inactivity timeout > maximum allowed properly
This commit is contained in:
Marc Blank 2010-08-02 20:43:50 -07:00 committed by Android Git Automerger
commit fbf501fefd
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/email/SecurityPolicy.java
View File

@ -461,9 +461,6 @@ public class SecurityPolicy {
if (passwordMode < PASSWORD_MODE_NONE || passwordMode > PASSWORD_MODE_STRONG) { if (passwordMode < PASSWORD_MODE_NONE || passwordMode > PASSWORD_MODE_STRONG) {
throw new IllegalArgumentException("password mode"); throw new IllegalArgumentException("password mode");
} }
if (maxScreenLockTime > SCREEN_LOCK_TIME_MAX) {
throw new IllegalArgumentException("screen lock time");
}
// This value can be reduced (which actually increases security) if necessary // This value can be reduced (which actually increases security) if necessary
if (maxPasswordFails > PASSWORD_MAX_FAILS_MAX) { if (maxPasswordFails > PASSWORD_MAX_FAILS_MAX) {
maxPasswordFails = PASSWORD_MAX_FAILS_MAX; maxPasswordFails = PASSWORD_MAX_FAILS_MAX;

17
tests/src/com/android/email/SecurityPolicyTests.java
View File

@ -33,7 +33,10 @@ import android.test.suitebuilder.annotation.SmallTest;
/** /**
* This is a series of unit tests for backup/restore of the SecurityPolicy class. * This is a series of unit tests for backup/restore of the SecurityPolicy class.
*/ *
* You can run this entire test case with:
* runtest -c com.android.email.SecurityPolicyTests email
*/
@MediumTest @MediumTest
public class SecurityPolicyTests extends ProviderTestCase2<EmailProvider> { public class SecurityPolicyTests extends ProviderTestCase2<EmailProvider> {
@ -101,12 +104,12 @@ public class SecurityPolicyTests extends ProviderTestCase2<EmailProvider> {
fail("Illegal password mode allowed"); fail("Illegal password mode allowed");
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
} }
try { PolicySet ps = new PolicySet(0, PolicySet.PASSWORD_MODE_NONE, 0,
new PolicySet(0, PolicySet.PASSWORD_MODE_NONE, 0, PolicySet.SCREEN_LOCK_TIME_MAX + 1, false);
PolicySet.SCREEN_LOCK_TIME_MAX + 1, false); assertEquals(PolicySet.SCREEN_LOCK_TIME_MAX, ps.getMaxScreenLockTime());
fail("Too-long screen lock time allowed"); ps = new PolicySet(0, PolicySet.PASSWORD_MODE_NONE,
} catch (IllegalArgumentException e) { PolicySet.PASSWORD_MAX_FAILS_MAX + 1, 0, false);
} assertEquals(PolicySet.PASSWORD_MAX_FAILS_MAX, ps.getMaxPasswordFails());
} }
/** /**