From 391b9d4abd935cf19e530972544946889b932fb6 Mon Sep 17 00:00:00 2001 From: Ben Komalo Date: Wed, 27 Jul 2011 11:24:59 -0700 Subject: [PATCH] Search delay fixes. - adds a loading state to search so the user isn't left with a blank screen for several seconds - adds a timeout so that a warning message is shown for results that take over 10 seconds - use default loading/no message views in ListFragment so we don't have to manager our own stuff Bug: 5014107 Bug: 5037618 Change-Id: I8b03fa0967055989156c7777901affc777c4fae7 --- res/layout/message_list_fragment.xml | 15 ++-- res/layout/message_list_warning.xml | 54 +++++++++++++++ res/values/strings.xml | 8 +++ .../email/activity/MessageListFragment.java | 69 ++++++++++++++----- 4 files changed, 120 insertions(+), 26 deletions(-) create mode 100644 res/layout/message_list_warning.xml diff --git a/res/layout/message_list_fragment.xml b/res/layout/message_list_fragment.xml index a3ada0226..97363abc9 100644 --- a/res/layout/message_list_fragment.xml +++ b/res/layout/message_list_fragment.xml @@ -24,16 +24,8 @@ android:layout_width="match_parent" android:layout_height="match_parent" > - + + + + + diff --git a/res/layout/message_list_warning.xml b/res/layout/message_list_warning.xml new file mode 100644 index 000000000..80b865d7b --- /dev/null +++ b/res/layout/message_list_warning.xml @@ -0,0 +1,54 @@ + + + + + + + + + + + + + diff --git a/res/values/strings.xml b/res/values/strings.xml index 629bb0e79..2ec7e97cf 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1215,6 +1215,14 @@ save attachment. Search results for \"%1$s\" + + Waiting for results + + + Some servers may take a long time. + Folders diff --git a/src/com/android/email/activity/MessageListFragment.java b/src/com/android/email/activity/MessageListFragment.java index 859fcb5ba..8571bc314 100644 --- a/src/com/android/email/activity/MessageListFragment.java +++ b/src/com/android/email/activity/MessageListFragment.java @@ -102,11 +102,12 @@ public class MessageListFragment extends ListFragment private Callback mCallback = EmptyCallback.INSTANCE; private boolean mIsViewCreated; + private View mListPanel; private View mListFooterView; private TextView mListFooterText; private View mListFooterProgress; - private View mNoMessagesPanel; private ViewGroup mSearchHeader; + private ViewGroup mWarningContainer; private TextView mSearchHeaderText; private TextView mSearchHeaderCount; @@ -335,7 +336,6 @@ public class MessageListFragment extends ListFragment mRefreshManager = RefreshManager.getInstance(mActivity); mListAdapter = new MessagesAdapter(mActivity, this); - setListAdapter(mListAdapter); } @Override @@ -346,8 +346,8 @@ public class MessageListFragment extends ListFragment } // Use a custom layout, which includes the original layout with "send messages" panel. View root = inflater.inflate(R.layout.message_list_fragment,null); - mNoMessagesPanel = UiUtilities.getView(root, R.id.no_messages_panel); mIsViewCreated = true; + mListPanel = UiUtilities.getView(root, R.id.list_panel); return root; } @@ -392,6 +392,7 @@ public class MessageListFragment extends ListFragment mListFooterView = getActivity().getLayoutInflater().inflate( R.layout.message_list_item_footer, lv, false); + setEmptyText(getString(R.string.message_list_no_messages)); if (savedInstanceState != null) { // Fragment doesn't have this method. Call it manually. @@ -543,10 +544,6 @@ public class MessageListFragment extends ListFragment } } - /* package */MessagesAdapter getAdapterForTest() { - return mListAdapter; - } - /** * @return true if the mailbox is refreshable. false otherwise, or unknown yet. */ @@ -1144,11 +1141,6 @@ public class MessageListFragment extends ListFragment && (mMailbox == null || mMailbox.canHaveMessagesMoved()); } - private void showNoMessageText(boolean visible) { - mNoMessagesPanel.setVisibility(visible ? View.VISIBLE : View.GONE); - getListView().setVisibility(visible ? View.GONE : View.VISIBLE); - } - /** * Adjusts message notification depending upon the state of the fragment and the currently * viewed mailbox. If the fragment is resumed, notifications for the current mailbox may @@ -1176,7 +1168,6 @@ public class MessageListFragment extends ListFragment Log.d(Logging.LOG_TAG, this + " startLoading"); } // Clear the list. (ListFragment will show the "Loading" animation) - showNoMessageText(false); showSendCommand(false); updateSearchHeader(null); @@ -1185,6 +1176,26 @@ public class MessageListFragment extends ListFragment lm.initLoader(LOADER_ID_MESSAGES_LOADER, null, new MessagesLoaderCallback()); } + /** Timeout to show a warning, since some IMAP searches could take a long time. */ + private final int SEARCH_WARNING_DELAY_MS = 10000; + + private void onSearchLoadTimeout() { + // Search is taking too long. Show an error message. + ViewGroup root = (ViewGroup) getView(); + Activity host = getActivity(); + if (root != null && host != null) { + mListPanel.setVisibility(View.GONE); + mWarningContainer = (ViewGroup) LayoutInflater.from(host).inflate( + R.layout.message_list_warning, root, false); + TextView title = UiUtilities.getView(mWarningContainer, R.id.message_title); + TextView message = UiUtilities.getView(mWarningContainer, R.id.message_warning); + title.setText(R.string.search_slow_warning_title); + message.setText(R.string.search_slow_warning_message); + root.addView(mWarningContainer); + } + + } + /** * Loader callbacks for message list. */ @@ -1198,6 +1209,29 @@ public class MessageListFragment extends ListFragment Log.d(Logging.LOG_TAG, MessageListFragment.this + " onCreateLoader(messages) listContext=" + listContext); } + + if (mListContext.isSearch()) { + final MessageListContext searchInfo = mListContext; + + // Search results are not primed with local data, and so will usually be slow. + // In some cases, they could take a long time to return, so we need to be robust. + setListShownNoAnimation(false); + Utility.getMainThreadHandler().postDelayed(new Runnable() { + @Override + public void run() { + if (mListContext != searchInfo) { + // Different list is being shown now. + return; + } + if (!mIsFirstLoad) { + // Something already returned. No need to do anything. + return; + } + onSearchLoadTimeout(); + } + }, SEARCH_WARNING_DELAY_MS); + } + mIsFirstLoad = true; return MessagesAdapter.createLoader(getActivity(), listContext); } @@ -1258,8 +1292,6 @@ public class MessageListFragment extends ListFragment autoRefreshStaleMailbox(); addFooterView(); updateSelectionMode(); - showNoMessageText((cursor.getCount() == 0) - && (getListContext().isSearch() || (mListFooterMode == LIST_FOOTER_MODE_NONE))); // We want to make visible the selection only for the first load. // Re-load caused by content changed events shouldn't scroll the list. @@ -1269,7 +1301,12 @@ public class MessageListFragment extends ListFragment // "post processing" seems to reset the scroll position. lv.onRestoreInstanceState(listState); - // Clear this for next reload triggered by content changed events. + if (mIsFirstLoad) { + setListShownNoAnimation(true); + UiUtilities.setVisibilitySafe(mWarningContainer, View.GONE); + mListPanel.setVisibility(View.VISIBLE); + setListAdapter(mListAdapter); + } mIsFirstLoad = false; }