ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add additional analytics regarding our SSLSockets

Browse Source 
b/18104622
There were some suggestions for additional info to log.
Now we also log the protocol being used, along with the
cipher suite, and whether or not we are accepting all
certificates (i.e. whether or not we are verifying
hostnames.)

Change-Id: Iad1fa4d2867d4a27830d54cc7fafcd0d32e0b23b
This commit is contained in:
Martin Hibdon 2014-10-24 13:53:14 -07:00
parent 21dc44d235
commit f0bbcd85ea
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
provider_src/com/android/email/mail/transport/MailTransport.java
View File

@ -122,10 +122,13 @@ public class MailTransport {
if (canTrySslSecurity() && !canTrustAllCertificates()) {
verifyHostname(mSocket, getHost());
}
Analytics.getInstance().sendEvent("socket_certificates",
"open", Boolean.toString(canTrustAllCertificates()), 0);
if (mSocket instanceof SSLSocket) {
final SSLSocket sslSocket = (SSLSocket) mSocket;
if (sslSocket.getSession() != null) {
Analytics.getInstance().sendEvent("cipher_suite", "open",
Analytics.getInstance().sendEvent("cipher_suite",
sslSocket.getSession().getProtocol(),
sslSocket.getSession().getCipherSuite(), 0);
}
}
@ -167,9 +170,12 @@ public class MailTransport {
mIn = new BufferedInputStream(mSocket.getInputStream(), 1024);
mOut = new BufferedOutputStream(mSocket.getOutputStream(), 512);
Analytics.getInstance().sendEvent("socket_certificates",
"reopenTls", Boolean.toString(canTrustAllCertificates()), 0);
final SSLSocket sslSocket = (SSLSocket) mSocket;
if (sslSocket.getSession() != null) {
Analytics.getInstance().sendEvent("cipher_suite", "reopenTls",
Analytics.getInstance().sendEvent("cipher_suite",
sslSocket.getSession().getProtocol(),
sslSocket.getSession().getCipherSuite(), 0);
}
} catch (SSLException e) {