ADHOC
/
replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

2pane: Show/hide fragments *before* animation starts 

To fix "IllegalStateException: Can not perform this action after
onSaveInstanceState".

Bug 4522010

Change-Id: I640fab0d51b02467f2f91d0d33091e1daac356fd
This commit is contained in:
Makoto Onuki 2011-06-27 13:02:37 -07:00
parent 569083fab3
commit d538d4bce1
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/com/android/email/activity/ThreePaneLayout.java
View File

@ -41,6 +41,8 @@ import android.widget.LinearLayout;
* See {@link #isPaneCollapsible()} for details on the two modes.
*
* TODO Unit tests, when UX is settled.
*
* TODO onVisiblePanesChanged() should be called *AFTER* the animation, not before.
*/
public class ThreePaneLayout extends LinearLayout implements View.OnClickListener {
private static final boolean ANIMATION_DEBUG = false; // DON'T SUBMIT WITH true
@ -555,6 +557,18 @@ public class ThreePaneLayout extends LinearLayout implements View.OnClickListene
for (View v : mViewsVisible) {
v.setVisibility(View.VISIBLE);
}
// TODO These things, making invisible views and calling the visible pane changed
// callback, should really be done in onAnimationEnd.
// However, because we may want to initiate a fragment transaction in the callback but
// by the time animation is done, the activity may be stopped (by user's HOME press),
// it's not easy to get right. For now, we just do this before the animation.
for (View v : mViewsInvisible) {
v.setVisibility(View.INVISIBLE);
}
for (View v : mViewsGone) {
v.setVisibility(View.GONE);
}
mCallback.onVisiblePanesChanged(mPreviousVisiblePanes);
}
@ -575,13 +589,6 @@ public class ThreePaneLayout extends LinearLayout implements View.OnClickListene
return; // But they shouldn't be hidden when cancelled.
}
log("end");
for (View v : mViewsInvisible) {
v.setVisibility(View.INVISIBLE);
}
for (View v : mViewsGone) {
v.setVisibility(View.GONE);
}
mCallback.onVisiblePanesChanged(mPreviousVisiblePanes);
}
}