From ae980cd685a867b3fecfd38c876fd18d98b7c86b Mon Sep 17 00:00:00 2001 From: Tony Mantler Date: Mon, 17 Mar 2014 16:45:47 -0700 Subject: [PATCH] Account setup flow: Move button and headline handling into fragments b/13508015 Change-Id: I9f7a09467fbee5a57985f36eaa47c2cc7b9d4086 --- .../account_setup_buttons.xml | 1 + .../account_setup_template.xml} | 44 ++++----- .../account_setup_basics_fragment.xml | 0 .../account_setup_incoming_fragment.xml | 0 .../account_setup_options_fragment.xml | 0 .../account_setup_outgoing_fragment.xml | 0 .../account_setup_template.xml} | 11 ++- .../account_setup_type_fragment.xml | 0 .../account_type.xml | 0 .../authentication_view.xml | 0 res/layout/account_credentials.xml | 22 +---- res/layout/account_credentials_fragment.xml | 37 +++++++ ...ntainer.xml => account_setup_activity.xml} | 15 ++- .../account_setup_credentials_fragment.xml | 11 +-- ...t_setup.xml => account_setup_template.xml} | 5 +- .../activity/setup/AccountCredentials.java | 31 ++---- .../setup/AccountServerBaseFragment.java | 21 ++-- .../email/activity/setup/AccountSettings.java | 2 +- .../setup/AccountSetupBasicsFragment.java | 9 +- .../AccountSetupCredentialsFragment.java | 52 +++++++--- .../activity/setup/AccountSetupFinal.java | 98 +++---------------- .../activity/setup/AccountSetupFragment.java | 78 ++++++++++++++- .../setup/AccountSetupIncomingFragment.java | 13 ++- .../setup/AccountSetupNamesFragment.java | 34 ++++--- .../setup/AccountSetupOptionsFragment.java | 4 +- .../setup/AccountSetupOutgoingFragment.java | 12 ++- .../setup/AccountSetupTypeFragment.java | 5 +- 27 files changed, 267 insertions(+), 238 deletions(-) rename res/{layout-sw600dp-land => layout-w1000dp}/account_setup_buttons.xml (97%) rename res/{layout-sw600dp-land/account_setup.xml => layout-w1000dp/account_setup_template.xml} (61%) rename res/{layout-sw600dp => layout-w600dp}/account_setup_basics_fragment.xml (100%) rename res/{layout-sw600dp => layout-w600dp}/account_setup_incoming_fragment.xml (100%) rename res/{layout-sw600dp => layout-w600dp}/account_setup_options_fragment.xml (100%) rename res/{layout-sw600dp => layout-w600dp}/account_setup_outgoing_fragment.xml (100%) rename res/{layout-sw600dp-port/account_setup.xml => layout-w600dp/account_setup_template.xml} (87%) rename res/{layout-sw600dp => layout-w600dp}/account_setup_type_fragment.xml (100%) rename res/{layout-sw600dp => layout-w600dp}/account_type.xml (100%) rename res/{layout-sw600dp => layout-w600dp}/authentication_view.xml (100%) create mode 100644 res/layout/account_credentials_fragment.xml rename res/layout/{account_setup_fragment_container.xml => account_setup_activity.xml} (61%) rename res/layout/{account_setup.xml => account_setup_template.xml} (91%) diff --git a/res/layout-sw600dp-land/account_setup_buttons.xml b/res/layout-w1000dp/account_setup_buttons.xml similarity index 97% rename from res/layout-sw600dp-land/account_setup_buttons.xml rename to res/layout-w1000dp/account_setup_buttons.xml index 22c638f9b..24b47c689 100644 --- a/res/layout-sw600dp-land/account_setup_buttons.xml +++ b/res/layout-w1000dp/account_setup_buttons.xml @@ -16,6 +16,7 @@ + - - + - + android:paddingRight="@dimen/setup_padding_right" + > - - - - - - + - - - + android:id="@+id/setup_fragment_content"/> + + + + + + diff --git a/res/layout-sw600dp/account_setup_basics_fragment.xml b/res/layout-w600dp/account_setup_basics_fragment.xml similarity index 100% rename from res/layout-sw600dp/account_setup_basics_fragment.xml rename to res/layout-w600dp/account_setup_basics_fragment.xml diff --git a/res/layout-sw600dp/account_setup_incoming_fragment.xml b/res/layout-w600dp/account_setup_incoming_fragment.xml similarity index 100% rename from res/layout-sw600dp/account_setup_incoming_fragment.xml rename to res/layout-w600dp/account_setup_incoming_fragment.xml diff --git a/res/layout-sw600dp/account_setup_options_fragment.xml b/res/layout-w600dp/account_setup_options_fragment.xml similarity index 100% rename from res/layout-sw600dp/account_setup_options_fragment.xml rename to res/layout-w600dp/account_setup_options_fragment.xml diff --git a/res/layout-sw600dp/account_setup_outgoing_fragment.xml b/res/layout-w600dp/account_setup_outgoing_fragment.xml similarity index 100% rename from res/layout-sw600dp/account_setup_outgoing_fragment.xml rename to res/layout-w600dp/account_setup_outgoing_fragment.xml diff --git a/res/layout-sw600dp-port/account_setup.xml b/res/layout-w600dp/account_setup_template.xml similarity index 87% rename from res/layout-sw600dp-port/account_setup.xml rename to res/layout-w600dp/account_setup_template.xml index 9f564ecb0..275b4d718 100644 --- a/res/layout-sw600dp-port/account_setup.xml +++ b/res/layout-w600dp/account_setup_template.xml @@ -47,11 +47,14 @@ android:background="@color/account_setup_divider_color" /> - + + android:layout_width="match_parent" + android:layout_height="0dp" + android:layout_weight="1"/> diff --git a/res/layout-sw600dp/account_setup_type_fragment.xml b/res/layout-w600dp/account_setup_type_fragment.xml similarity index 100% rename from res/layout-sw600dp/account_setup_type_fragment.xml rename to res/layout-w600dp/account_setup_type_fragment.xml diff --git a/res/layout-sw600dp/account_type.xml b/res/layout-w600dp/account_type.xml similarity index 100% rename from res/layout-sw600dp/account_type.xml rename to res/layout-w600dp/account_type.xml diff --git a/res/layout-sw600dp/authentication_view.xml b/res/layout-w600dp/authentication_view.xml similarity index 100% rename from res/layout-sw600dp/authentication_view.xml rename to res/layout-w600dp/authentication_view.xml diff --git a/res/layout/account_credentials.xml b/res/layout/account_credentials.xml index 0aa053576..2f891e2aa 100644 --- a/res/layout/account_credentials.xml +++ b/res/layout/account_credentials.xml @@ -14,24 +14,8 @@ limitations under the License. --> - - - - - - - - - + android:layout_height="match_parent" /> diff --git a/res/layout/account_credentials_fragment.xml b/res/layout/account_credentials_fragment.xml new file mode 100644 index 000000000..0aa053576 --- /dev/null +++ b/res/layout/account_credentials_fragment.xml @@ -0,0 +1,37 @@ + + + + + + + + + + + + diff --git a/res/layout/account_setup_fragment_container.xml b/res/layout/account_setup_activity.xml similarity index 61% rename from res/layout/account_setup_fragment_container.xml rename to res/layout/account_setup_activity.xml index ba0af41cf..799d4a805 100644 --- a/res/layout/account_setup_fragment_container.xml +++ b/res/layout/account_setup_activity.xml @@ -14,13 +14,10 @@ limitations under the License. --> - - - + diff --git a/res/layout/account_setup_credentials_fragment.xml b/res/layout/account_setup_credentials_fragment.xml index 0003ff17c..c45ed1098 100644 --- a/res/layout/account_setup_credentials_fragment.xml +++ b/res/layout/account_setup_credentials_fragment.xml @@ -63,7 +63,7 @@ android:orientation="vertical" android:visibility="gone">