ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix bugs related to orientation change in MessageCompose

Browse Source 
* Save reference to LoadMessageTask and cancel it in onDestroy
* Check whether we've already processed the source message
  before calling processSourceMessage
* Fixes #2097361 (Duplicate addresses in reply/reply all)
* Fixes NPE (not in Buganizer) related to fast orientation changes
  due to duplicated background task

Change-Id: Ib8115e29c9d88db1be009df4f549f925db8a1c19
This commit is contained in:
Marc Blank 2009-09-20 12:35:24 -07:00
parent 8d5004a6eb
commit a740e29357
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/com/android/email/activity/MessageCompose.java
View File

@ -137,6 +137,7 @@ public class MessageCompose extends Activity implements OnClickListener, OnFocus
private boolean mDraftNeedsSaving; private boolean mDraftNeedsSaving;
private AsyncTask mLoadAttachmentsTask; private AsyncTask mLoadAttachmentsTask;
private AsyncTask mSaveMessageTask; private AsyncTask mSaveMessageTask;
private AsyncTask mLoadMessageTask;
private Handler mHandler = new Handler() { private Handler mHandler = new Handler() {
@Override @Override
@ -267,7 +268,7 @@ public class MessageCompose extends Activity implements OnClickListener, OnFocus
// Otherwise, handle the internal cases (Message Composer invoked from within app) // Otherwise, handle the internal cases (Message Composer invoked from within app)
long messageId = intent.getLongExtra(EXTRA_MESSAGE_ID, -1); long messageId = intent.getLongExtra(EXTRA_MESSAGE_ID, -1);
if (messageId != -1) { if (messageId != -1) {
new LoadMessageTask().execute(messageId); mLoadMessageTask = new LoadMessageTask().execute(messageId);
} else { } else {
setAccount(intent); setAccount(intent);
} }
@ -331,6 +332,8 @@ public class MessageCompose extends Activity implements OnClickListener, OnFocus
mQuotedText = null; mQuotedText = null;
cancelTask(mLoadAttachmentsTask); cancelTask(mLoadAttachmentsTask);
mLoadAttachmentsTask = null; mLoadAttachmentsTask = null;
cancelTask(mLoadMessageTask);
mLoadMessageTask = null;
// don't cancel mSaveMessageTask, let it do its job to the end. // don't cancel mSaveMessageTask, let it do its job to the end.
// cancelTask(mSaveMessageTask); // cancelTask(mSaveMessageTask);
} }
@ -517,7 +520,10 @@ public class MessageCompose extends Activity implements OnClickListener, OnFocus
} }
mAccount = account; mAccount = account;
processSourceMessage(message, mAccount); // Make sure we only do this once (otherwise we'll duplicate addresses!)
if (!mSourceMessageProcessed) {
processSourceMessage(message, mAccount);
}
} }
} }