ADHOC
/
replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't rely on Activity to set the context for ops 

The Fragment can get detached from the activity prior to performing an
operation, so for now, use the context reference that the fragment has
instead.

In the long run, we should avoid referencing the application context,
but a restructuring of ActivityHelper may help instead.

Bug: 4332451
Change-Id: Ieabff8ec0cc363f7d2eebd3ed47c230df9959886
This commit is contained in:
Ben Komalo 2011-04-22 15:42:37 -04:00
parent 23b441a5c8
commit a6e6b9969a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/email/activity/MessageViewFragment.java
View File

@ -415,7 +415,7 @@ public class MessageViewFragment extends MessageViewFragmentBase
private void onDelete() {
mCallback.onBeforeMessageDelete();
ActivityHelper.deleteMessage(getActivity(), mCurrentMessageId);
ActivityHelper.deleteMessage(mContext, mCurrentMessageId);
}
private void onMarkAsUnread() {

2
src/com/android/email/activity/MessageViewFragmentBase.java
View File

@ -100,7 +100,7 @@ public abstract class MessageViewFragmentBase extends Fragment implements View.O
private static final String BUNDLE_KEY_CURRENT_TAB = "MessageViewFragmentBase.currentTab";
private static final String BUNDLE_KEY_PICTURE_LOADED = "MessageViewFragmentBase.pictureLoaded";
private static final int PHOTO_LOADER_ID = 1;
private Context mContext;
protected Context mContext;
// Regex that matches start of img tag. '<(?i)img\s+'.
private static final Pattern IMG_TAG_START_REGEX = Pattern.compile("<(?i)img\\s+");