Workaround for improper timeout for Ping commands

* We're seeing our ping timeouts complete after 30 seconds (although
  set to 5-17 minutes), due to the fact that our reused sockets are
  not having their timeouts reset (i.e. they use the original value
  of 30 seconds from when the socket was first created)
* Until the underlying issue is resolved, we'll avoid reusing
  sockets for Ping commands

Bug: 3241899
Change-Id: I90b53c0d28b866a91507efafacbb3c4c0df2324c
This commit is contained in:
Marc Blank 2010-12-02 12:08:58 -08:00
parent 9585018647
commit 9166aa46da
1 changed files with 6 additions and 1 deletions

View File

@ -1309,7 +1309,12 @@ public class EasSyncService extends AbstractSyncService {
HttpConnectionParams.setConnectionTimeout(params, CONNECTION_TIMEOUT);
HttpConnectionParams.setSoTimeout(params, timeout);
HttpConnectionParams.setSocketBufferSize(params, 8192);
HttpClient client = new DefaultHttpClient(getClientConnectionManager(), params);
//HttpClient client = new DefaultHttpClient(getClientConnectionManager(), params);
// STOPSHIP Replace this line with the previous, commented-out line
// The underlying problem (socket timeout is not being updated for reused, pooled
// connections) needs to be fixed prior to ship
HttpClient client = new DefaultHttpClient(
timeout == COMMAND_TIMEOUT ? getClientConnectionManager() : null, params);
return client;
}